This PR was merged into the 4.0 branch.
Discussion
----------
Make KernelInterface docblock more fit for bundle-less environment
| Q | A
| ------------- | ---
| Branch? | 4.0
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #26457
| License | MIT
| Doc PR | -
Commits
-------
e8df759f21 Make KernelInterface docblock more fit for bundle-less environment
This PR was squashed before being merged into the 4.1-dev branch (closes#26398).
Discussion
----------
[WebProfilerBundle] Display the missing translation panel by default
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Display the "Missing Translations" panel by default ... except if there are no missing translations.
Commits
-------
15fe686a58 [WebProfilerBundle] Display the missing translation panel by default
This PR was merged into the 4.1-dev branch.
Discussion
----------
[Security] AuthenticationUtils::getLastUsername() return type inconsistency
Always return `string`, never `null` according to the `@return` annotation tag.
| Q | A
| ------------- | ---
| Branch? | 2.8
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Alternatively, string return might be nullable:
```php
return null === $session ? null : $session->get(Security::LAST_USERNAME);
```
Is test needed for this change?
Commits
-------
743692c3fd AuthenticationUtils::getLastUsername()` now always returns a string.
This PR was submitted for the 2.7 branch but it was merged into the 4.1-dev branch instead (closes#26439).
Discussion
----------
[Console] [DX] Fix command description/help display
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/26376
| License | MIT
| Doc PR | none
Hi,
Here is a fix for the issue https://github.com/symfony/symfony/issues/26376
I only patch the text descriptor, should I do it for others?
(I do not think so as the main and default one is text)
Thanks
Commits
-------
9ca6d62f6c Fix command description display
This PR was squashed before being merged into the 4.1-dev branch (closes#26467).
Discussion
----------
Add UsernameNotFoundException declaration to refreshUser().
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | maybe
| New feature? | maybe
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Symfony\Component\Security\Core\User\UserProviderInterface::refreshUser() does not declare that implementations may throw a UsernameNotFoundException, although a) it makes sense, as the user could have been deleted since the last load, and b) the ContextListener already handles the UsernameNotFoundException. So it looks like someone thought of this, but simply forgot the annotation.
Unsure if this is a bugfix or a feature, but as it doesn't change executed code, master should be soon enough.
Commits
-------
f7a0c46338 Add UsernameNotFoundException declaration to refreshUser().
* 2.7:
Php Inspections (EA Ultimate): address some of one-time used local variables
[Intl] Load locale aliases to support alias fallbacks
[CssSelector] Fix CSS identifiers parsing - they can start with dash
This PR was merged into the 2.7 branch.
Discussion
----------
[minor] SCA with Php Inspections (EA Ultimate)
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n.a
Addressed some cases with one-time used local variables and repetitive calls.
Commits
-------
f16d99ecfa Php Inspections (EA Ultimate): address some of one-time used local variables
This PR was merged into the 4.1-dev branch.
Discussion
----------
reword some deprecation messages
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
86fe18116c reword some deprecation messages
This PR was squashed before being merged into the 2.7 branch (closes#26452).
Discussion
----------
[Intl] Load locale aliases to support alias fallbacks
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #21457
| License | MIT
| Doc PR | -
For example, `zh_TW` is an alias to `zh_Hant_TW`. Without aliases,` zh_TW` would fall back to `zh` (which is incorrect). With aliases loaded, `zh_TW` will fall back properly to `zh_Hant_TW`.
Judging by git history this has never worked.
```php
\Locale::setDefault('zh'); dump(Intl::getRegionBundle()->getCountryName('AD'));
\Locale::setDefault('zh_TW'); dump(Intl::getRegionBundle()->getCountryName('AD'));
\Locale::setDefault('zh_Hant_TW'); dump(Intl::getRegionBundle()->getCountryName('AD'));
```
Before:
```
"安道尔"
"安道尔"
"安道爾"
```
After:
```
"安道尔"
"安道爾"
"安道爾"
```
All tests are passing, including those from the `intl-data` group.
Commits
-------
1debf79430 [Intl] Load locale aliases to support alias fallbacks
This PR was merged into the 2.7 branch.
Discussion
----------
[CssSelector] Fix CSS identifiers parsing - they can start with dash
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Vendor prefixes use `-` (dash) at the start of CSS identifiers.
Commits
-------
16e86bc0c0 [CssSelector] Fix CSS identifiers parsing - they can start with dash
This PR was merged into the 3.4 branch.
Discussion
----------
[SecurityBundle] Make extra character non mandatory in regex
The extra character was introduced in 5f9471e, and breaks the testsuite
in native php 7.2.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
44b4fc8 [SecurityBundle] Make extra character non mandatory in regex
* 4.0:
fix the handling of timestamp in the MongoDBSessionHandler
Improve the documentation of `Finder::exclude()`
[DI] Skip resource tracking if disabled
[WebProfilerBundle] fix wrong variable for profiler counting ajax requests
This PR was merged into the 4.1-dev branch.
Discussion
----------
Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)"
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This reverts commit 136408937b, reversing
changes made to e043478ba5.
As discussed in #24763 and #26344
This doens't revert the possibility to use prepared command lines. They just won't be *portable* anymore, unless special care is taken by "userland".
Ie the placeholders need to be shell-dependent: use eg `echo "$FOO"` on *nix (the double quotes *are* important), and `echo !FOO!` on Windows (no double quotes there).
Commits
-------
6a98bfa8d7 Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)"
