This PR was merged into the 4.4 branch.
Discussion
----------
[Serializer] Fix EncoderInterface::encode() return type
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N.A.
| License | MIT
| Doc PR | N.A.
I might have missed something (in that case, please let me know), but I believe that `EncoderInterface::encode()` will and should always return a `string`. This makes more sense because `DecoderInterface::decode()` only accepts a string as input.
Commits
-------
ae6f054cc1 Fix EncoderInterface::encode() return type
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Lock] Prevent store exception break combined store
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#39470 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
Handle exception to preserve expected behavior - one or multiple stores could be unreachable in a moment and combined store will handle this according to strategy.
Commits
-------
0daff35bae [Lock] Prevent store exception break combined store
* 5.2:
Fix enabled key for ratelimiter config
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
Remove void return type from test methods
[Notifier] Remove void return type from test methods
[Notifier][Telegram] Remove void return type from test methods
[Notifier][Esendex] Remove void return type from test methods
[Notifier][Sendinblue] Remove void return type from test methods
[Notifier][GoogleChat] Remove void return type from test methods
[Notifier] Move ext-json below php requirement to stay consistent
* 5.1:
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
Remove void return type from test methods
[Notifier] Remove void return type from test methods
* 4.4:
Use more explicit variable name
Fix wrong comment about SES region
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
[Mailer] [Amazon] Fix @param annotation
[Mailer] Rename testsuites
Remove void return type from test methods
This PR was merged into the 4.4 branch.
Discussion
----------
Fix wrong comment about SES region
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This list is wrong (or maybe no more exact). And maintain such list does not make sens in code.
https://docs.aws.amazon.com/general/latest/gr/ses.html
Commits
-------
759774750e Fix wrong comment about SES region
This PR was merged into the 4.4 branch.
Discussion
----------
Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
94f823fd4a Remove void return type from test methods
This PR was merged into the 5.1 branch.
Discussion
----------
Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
This PR follows #39459
cc @nicolas-grekas
Commits
-------
6e6c3ba1a0 Remove void return type from test methods
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] [Sendgrid] Use $scheme variable to stay consistent
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
Its used like this in all other mailer bridges
Commits
-------
1a40d7c75a [Mailer] [Sendgrid] Use $scheme variable to stay consistent
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Telegram] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
e48fcdcd34 [Notifier][Telegram] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Esendex] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
6c185d19ad [Notifier][Esendex] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [Sendinblue] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
15f523e6ad [Notifier][Sendinblue] Remove void return type from test methods
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] [GoogleChat] Remove void return type from test methods
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
cc @nicolas-grekas
Commits
-------
de2bf6d98a [Notifier][GoogleChat] Remove void return type from test methods
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Messenger] Added more descriptive exception message when handling of a message failed
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no (more of a patch thing)
| New feature? | no
| Deprecations? | no
| License | MIT
I use Symfony Messenger extensively and I run into the `HandlerFailedException` from time to time. What bothers me is that the exception doesn't carry the name of the message that failed right there in the exception message.
Here is an example from Sentry:
![image](https://user-images.githubusercontent.com/2412177/101757346-572eda00-3ad7-11eb-9f57-6ba2b043594d.png)
As you can see I get the error message, but I have to look through all my messages (in different bundles etc) to find the sinner.
This PR adds the message name directly to the exception message.
Commits
-------
d985ca9a6e [Messenger] Added more descriptive exception message when handling of a message failed
This PR was merged into the 5.1 branch.
Discussion
----------
[Notifier] Streamline README files
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | --
| License | MIT
| Doc PR | --
This should be considered a bug fix as it does not touches any PHP file.
I will continue the work for `5.2` branch after the merge
Commits
-------
dfddc899ce [Notifier] Streamline README files
This PR was merged into the 4.4 branch.
Discussion
----------
Fix licence
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Backport of #39435 for 4.4 (the file has been renamed and the git history trapped me)
Commits
-------
6d7893cdaa Fix licence
This PR was merged into the 5.1 branch.
Discussion
----------
Fix CS in Changelogs in 5.1
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
4557e4d55d Fix CS in Changelogs
This PR was squashed before being merged into the 5.1 branch.
Discussion
----------
[Notifier] [Free Mobile] Rename method to match other bridges
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
All other bridges use `create*` instead of `init*`
Commits
-------
f53ae7c40a [Notifier] [Free Mobile] Rename method to match other bridges
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] fix setting "read_timeout" when using Redis
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Being inspired by #39431
Commits
-------
7acca31e66 [Cache] fix setting "read_timeout" when using Redis
Both classes have an optional argument `$readTimeout` that can be set during
initialization for `\RedisSentinel` and during `connect`/`pconnect`
respectively.
* 5.1:
[Notifier] [Twilio] Fix tests
[Cache] Prevent notice on case matching metadata trick
[Notifier][Slack] Remove :void from test methods
[Notifier] Remove @internal annotation from notifier transports
[Notifier][Twilio] Add tests
[Notifier][Free Mobile] Tests
[DI] The default index method wasn't used if the "index_by" attribute is missing
This PR was merged into the 5.2 branch.
Discussion
----------
[Serializer][Validator] Mention annotation loaders handle PHP8 attributes
| Q | A
| ------------- | ---
| Branch? | 5.2 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
Just a small note for the ones reading docblocks first and expecting to find a PhpAttributeLoader or whatever: the annotation loaders handle both doctrine annotations & PHP 8 attributes.
The route loader already mentions this.
Commits
-------
3cbe758df3 [Serializer][Validator] Mention annotation loaders handle PHP8 attributes
This PR was merged into the 5.2 branch.
Discussion
----------
[HttpClient] Fix content swallowed by AsyncClient initializer
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I'm not sure if it should be fixed in RetryableHttpClient or AsycClient.
The issue is: when the Strategy needs the body to take a decision BUT decide to NOT retry the request, the content is "lost"
In fact, when the first chunk is yield, the AsyncResponse's initializer is stopped, and nothing consume the remaining chunks. Moreover, because the `passthru` were disabled before yielding the first chunk in RetryableHttpClient, the callback is never called again to yield the remaining content.
Commits
-------
d324271691 Fix content swallowed by AsyncClient initializer
On saving an array of one element with a int key of strlen 10
it matches the first conditions of the trick used to save metadata.
> Notice: Trying to access array offset on value of type int
Casting it to string fixes it.
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Messenger] Use "warning" instead of "error" log level for RecoverableException
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
When one throw a `RecoverableExceptionInterface`, one knows somethings
wrong occurs, so if an `error` should be emmited, it's in place where the
exception is thrown.
And, by extension, if nothing really wrong occurs (like a random network
error), one may want to retry the message **without** any errors.
That's why in this PR, if an exception of type `RecoverableExceptionInterface`
is thrown, it uses `warning` insteand of `error` log level. So
everything stay under the radar.
Commits
-------
a885ba844d [Messenger] Use "warning" intead of "error" log level for RecoverableException
This PR was merged into the 5.1 branch.
Discussion
----------
[Notifier] Remove @internal annotation from notifier transports
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
All other transports does not have the `@internal` annotation, so I think we can safely remove it.
I consider this a bugfix, as this does not break BC.
cc @fabpot
Commits
-------
d75f50d3a7 [Notifier] Remove @internal annotation from notifier transports
* 5.2:
[PhpUnitBridge] CS fix
[Notifier] Only use sprintf instead of sprintf and string concat
[PhpUnitBridge] Fix PHP 5.5 compatibility
Fix exception thrown by Form when converting UUID
[Notifier] Remove trailing argument in tests
[Serializer] Make fabbot happy with 5.2 tests CS
Add missing param annotation abouts $fileLinkFormat
[HttpClient] Use decoration instead of class replacement for mock factory
[Form] Fixed StringUtil::trim() to trim ZERO WIDTH SPACE (U+200B) and SOFT HYPHEN (U+00AD)
23412 Stop treating multiline resources as globs
* 5.1:
[PhpUnitBridge] CS fix
[Notifier] Only use sprintf instead of sprintf and string concat
[PhpUnitBridge] Fix PHP 5.5 compatibility
Add missing param annotation abouts $fileLinkFormat
[Form] Fixed StringUtil::trim() to trim ZERO WIDTH SPACE (U+200B) and SOFT HYPHEN (U+00AD)
23412 Stop treating multiline resources as globs