Commit Graph

52595 Commits

Author SHA1 Message Date
Fabien Potencier
8dfd31d975 Merge branch '5.2' into 5.x
* 5.2:
  [Notifier] Fix parsing Dsn with empty user/password
  Remove void return type from test methods
  [Notifier] [Discord] Use private const and mb_strlen()
  [Notifier] Set message id on SentMessage
  [Notifier] Fix toString when optional parameter is not set
  [Notifier] Use assertSame()
2020-12-18 08:28:30 +01:00
Fabien Potencier
d0da49d201 Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] Fix parsing Dsn with empty user/password
  Remove void return type from test methods
  [Notifier] Use assertSame()
2020-12-18 08:27:35 +01:00
Fabien Potencier
24334cb837 bug #39538 [Notifier] Fix parsing Dsn with empty user/password (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Fix parsing Dsn with empty user/password

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Same like https://github.com/symfony/symfony/pull/39531, but for Notifier component.

I backported the DsnTest from `5.2` to `5.1`

Commits
-------

a80409af25 [Notifier] Fix parsing Dsn with empty user/password
2020-12-18 08:25:35 +01:00
Oskar Stark
a80409af25 [Notifier] Fix parsing Dsn with empty user/password 2020-12-18 08:25:29 +01:00
Fabien Potencier
32ad72fbf8 minor #39542 Remove void return type from test methods (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

Remove void return type from test methods

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

cc @nicolas-grekas

Same like #39541 but for `5.1`

Commits
-------

78da70615b Remove void return type from test methods
2020-12-18 08:17:09 +01:00
Oskar Stark
78da70615b Remove void return type from test methods 2020-12-18 07:28:27 +01:00
Wouter de Jong
98f4c054d1 minor #39537 [Notifier] Iqsms bridge fix README.md (alexandrbarabolia)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Iqsms bridge fix README.md

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| License       | MIT

Sorry, bug I make a typo in file README.md. Please accept this pr and fix this problem.

Commits
-------

9513ea8caa fix README.md
2020-12-17 22:15:17 +01:00
Oleksandr Barabolia
9513ea8caa fix README.md 2020-12-17 20:28:25 +02:00
Fabien Potencier
e533bd34a8 feature #39096 [Notifier] add iqsms bridge (alexandrbarabolia)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] add iqsms bridge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/14555
Hi,

I've created integration to notifier to support russian sms operator - [iqsms](https://iqsms.ru)

Can you grab this code and make as symfony/iqsms-notifier?

This PR includes changes in notifier and framework-bundle to support smsapi transport as well as other included in notifier component.

Could someone integrate this into notifier component?

Commits
-------

bf94bcb1f6 [Notifier] add iqsms bridge
2020-12-17 17:52:45 +01:00
Oleksandr Barabolia
bf94bcb1f6 [Notifier] add iqsms bridge 2020-12-17 17:52:39 +01:00
Fabien Potencier
6ead4a273e bug #39492 [Notifier] [Discord] Use private const and mb_strlen() (OskarStark)
This PR was squashed before being merged into the 5.2 branch.

Discussion
----------

[Notifier] [Discord] Use private const and mb_strlen()

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

like proposed by @nicolas-grekas in https://github.com/symfony/symfony/pull/39444/files#r542288432

Commits
-------

165c87247d [Notifier] [Discord] Use private const and mb_strlen()
2020-12-17 17:31:33 +01:00
Oskar Stark
165c87247d [Notifier] [Discord] Use private const and mb_strlen() 2020-12-17 17:31:25 +01:00
Fabien Potencier
756bab4241 bug #39522 [Notifier] Set message id on SentMessage (OskarStark)
This PR was squashed before being merged into the 5.2 branch.

Discussion
----------

[Notifier] Set message id on SentMessage

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

@ismail1432 what do you think?

Commits
-------

9dd09e632d [Notifier] Set message id on SentMessage
2020-12-17 17:30:10 +01:00
Oskar Stark
9dd09e632d [Notifier] Set message id on SentMessage 2020-12-17 17:30:01 +01:00
Fabien Potencier
cf08a502ac bug #39532 [Notifier] Fix toString when optional parameter is not set (OskarStark)
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] Fix toString when optional parameter is not set

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

e61363c1f2 [Notifier] Fix toString when optional parameter is not set
2020-12-17 17:28:54 +01:00
Maxime Steinhausser
928594ee18 feature #39493 [Notifier] Introduce LengthException (OskarStark)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Introduce LengthException

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Follows https://github.com/symfony/symfony/pull/39444/files#r542298086

Commits
-------

437cad7c2b [Notifier] Introduce LengthException
2020-12-17 16:16:20 +01:00
Oskar Stark
e61363c1f2 [Notifier] Fix toString when optional parameter is not set 2020-12-17 11:46:37 +01:00
Nicolas Grekas
7617506f28 Merge branch '5.2' into 5.x
* 5.2:
  [Notifier] CS fix
  [VarDumper] dont hide any nodes until JS is proven to work
2020-12-17 09:59:57 +01:00
Nicolas Grekas
29d62dfa86 [Notifier] CS fix 2020-12-17 09:59:31 +01:00
Nicolas Grekas
bc6550ec67 minor #39526 [Notifier] Use assertSame() (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Use assertSame()

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

4a1976b4ef [Notifier] Use assertSame()
2020-12-17 09:34:41 +01:00
Oskar Stark
4a1976b4ef [Notifier] Use assertSame() 2020-12-17 09:34:34 +01:00
Nicolas Grekas
3741b064df bug #39525 [VarDumper] dont hide any nodes until JS is proven to work (nicolas-grekas)
This PR was merged into the 5.2 branch.

Discussion
----------

[VarDumper] dont hide any nodes until JS is proven to work

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39394
| License       | MIT
| Doc PR        | -

Replaces #39523

Commits
-------

42ad1ece92 [VarDumper] dont hide any nodes until JS is proven to work
2020-12-17 09:32:53 +01:00
Nicolas Grekas
42ad1ece92 [VarDumper] dont hide any nodes until JS is proven to work 2020-12-16 18:02:19 +01:00
Oskar Stark
437cad7c2b [Notifier] Introduce LengthException 2020-12-16 12:16:51 +01:00
Alexander M. Turek
75323bd68d Merge branch '5.2' into 5.x
* 5.2:
  [Notifier] Improve tests (5.1)
  [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE
  [Notifier] Fix wrong package name
  [Notifier] Fix wrong package names
  Add missing symfony/deprecation-contracts requirement
  [Notifier] [Free Mobile] Could not use custom host in DSN
  Add missing symfony/deprecation-contracts requirement
2020-12-16 09:40:19 +01:00
Alexander M. Turek
904b05a0de Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] Improve tests (5.1)
  [Notifier] Fix wrong package names
  [Notifier] [Free Mobile] Could not use custom host in DSN
2020-12-16 08:59:53 +01:00
Alexander M. Turek
40672e1748 minor #39509 [Notifier] Improve tests (5.1) (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Improve tests (5.1)

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Please review commit by commit

Commits
-------

5773a46677 [Notifier] Improve tests (5.1)
2020-12-16 08:45:27 +01:00
Oskar Stark
5773a46677 [Notifier] Improve tests (5.1) 2020-12-16 08:45:20 +01:00
Alexander M. Turek
6112be33d2 bug #39498 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE (guillaume-sainthillier)
This PR was squashed before being merged into the 5.2 branch.

Discussion
----------

[DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39468
| License       | MIT
| Doc PR        | -

Rebased PR #39469
Fixes #39468 related to Doctrine Form Type Guesser with DateImmutable type

Commits
-------

238d318e34 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE
2020-12-16 08:43:23 +01:00
Guillaume Sainthillier
238d318e34 [DoctrineBridge] Guess correct form types for DATE_IMMUTABLE and DATETIME_IMMUTABLE 2020-12-16 08:43:10 +01:00
Fabien Potencier
77960f86a9 bug #39510 [Notifier]  [Free Mobile] Could not use custom host in DSN (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier]  [Free Mobile] Could not use custom host in DSN

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

While working on #39509 I discovered, that you cannot set a custom host through the DSN string itself, only by calling `setHost()` method in the transport, which is only possible by **not** using the factory....

I changed it the way all other bridges work. I don't add a testcase for the port, because non of the others have that test.
I plan to implement it in #39495

As this is a bugfix I created an extra PR.

Cheers

EDIT:

Also the host is not allowed to contain `https://` otherwise calling `__toString()` will result in: `freemobile://https://......`

Commits
-------

63350cc19b [Notifier] [Free Mobile] Could not use custom host in DSN
2020-12-15 18:16:25 +01:00
Fabien Potencier
9613b41efa bug #39515 [Notifier] Fix wrong package name (OskarStark)
This PR was merged into the 5.2 branch.

Discussion
----------

[Notifier] Fix wrong package name

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Same like https://github.com/symfony/symfony/pull/39514 but for `5.2`

Commits
-------

f345ecd966 [Notifier] Fix wrong package name
2020-12-15 14:02:02 +01:00
Fabien Potencier
1a98df5342 bug #39514 [Notifier] Fix wrong package names (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] Fix wrong package names

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

344437286a [Notifier] Fix wrong package names
2020-12-15 14:01:00 +01:00
Oskar Stark
f345ecd966 [Notifier] Fix wrong package name 2020-12-15 13:50:14 +01:00
Oskar Stark
344437286a [Notifier] Fix wrong package names 2020-12-15 13:48:34 +01:00
Fabien Potencier
a4033bb580 bug #39503 Add missing symfony/deprecation-contracts requirement - 5.x (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

Add missing symfony/deprecation-contracts requirement - 5.x

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

same PR than #39494 for branch 5.x

Commits
-------

00d11735d6 Add missing symfony/deprecation-contracts requirement
2020-12-15 13:31:28 +01:00
Fabien Potencier
8399f9c6e1 bug #39502 Add missing symfony/deprecation-contracts requirement - 5.2 (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

Add missing symfony/deprecation-contracts requirement - 5.2

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

same PR than #39494 for branch 5.2

Commits
-------

bdf8744c2a Add missing symfony/deprecation-contracts requirement
2020-12-15 13:30:33 +01:00
Fabien Potencier
c766e59924 feature #39484 [FrameworkBundle] Allow env variables in json_manifest_path (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[FrameworkBundle] Allow env variables in `json_manifest_path`

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Fix #39264
| License       | MIT
| Doc PR        | -

the parameter `framework.assets.json_manifest_path` does not allow env variable when value is remote.
This PR adds a new `DynamicJsonManifestVersionStrategy` to fix that.

Commits
-------

4e4a81c346 Allow env variables in `json_manifest_path`
2020-12-15 13:21:53 +01:00
Jérémy Derussé
bdf8744c2a
Add missing symfony/deprecation-contracts requirement 2020-12-15 12:53:10 +01:00
Jérémy Derussé
862b19982a
Merge branch '5.1' into 5.2
* 5.1:
  Add missing symfony/deprecation-contracts requirement
2020-12-15 12:52:46 +01:00
Alexander M. Turek
defb90b030 bug #39494 Add missing symfony/deprecation-contracts requirement (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

Add missing symfony/deprecation-contracts requirement

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

We should require the `symfony/deprecation-contracts` package in components that call `trigger_deprecated`.

Commits
-------

5ae2364c7e Add missing symfony/deprecation-contracts requirement
2020-12-15 12:05:57 +01:00
Oskar Stark
63350cc19b [Notifier] [Free Mobile] Could not use custom host in DSN 2020-12-15 11:50:27 +01:00
Robin Chalas
c8c7fd5d25 Merge branch '5.2' into 5.x
* 5.2:
  [Uid] Fix tests namespace
  Fix cache:clear with buildDir
2020-12-15 10:13:08 +01:00
Robin Chalas
302b80768a Merge branch '5.1' into 5.2
* 5.1:
  [Uid] Fix tests namespace
2020-12-15 10:12:47 +01:00
Robin Chalas
a7fd98bee8 bug #39360 [FrameworkBundler] Fix cache:clear with buildDir (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

[FrameworkBundler] Fix cache:clear with buildDir

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39232
| License       | MIT
| Doc PR        |

Since #36515 there are 2 caches dir `cacheDir` and `buildDir`. For BC reason both points to the same folders, but when app don't use the same folder, many thing are broken:
This PR fixes several issues introduces by the above PR:
- some files are persisted in the wrong folder (`App_KernelDevDebugContainerDeprecations.log`, `App_KernelDevDebugContainer.xml`)
- LoggerDataCollector looks into cache_dir, while `Compiler.log` is written in build_dir and `Deprecations.log` were written in cache_dir before this PR
- the logic that mirror cacheDir into buildDir at the end of CacheClearCommand does not make sens when `cache_dir` and `build_dir` are not identical.
- Files generated in cacheDir are trashed at the end of CacheWarming (initial issue)

Commits
-------

ea68966e91 Fix cache:clear with buildDir
2020-12-15 10:04:49 +01:00
Alexander M. Turek
3a3b2498fd minor #39508 [Uid] Fix tests namespace (fancyweb)
This PR was merged into the 5.1 branch.

Discussion
----------

[Uid] Fix tests namespace

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | -

Commits
-------

cd11ef67dc [Uid] Fix tests namespace
2020-12-15 01:19:30 +01:00
Alexander M. Turek
4145914482 [PhpUnitBridge] Remove linter. 2020-12-15 00:14:20 +01:00
Alexander M. Turek
138b273056 Merge branch '5.2' into 5.x
* 5.2:
  [Notifier] Rework/streamline bridges (5.1)
  [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
  Stop using deprecated trait
  [PhpUnitBridge] Lint files with PHP 5.5
2020-12-15 00:08:52 +01:00
Thomas Calvet
cd11ef67dc [Uid] Fix tests namespace 2020-12-15 00:03:24 +01:00
Alexander M. Turek
6caf916083 Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] Rework/streamline bridges (5.1)
  [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
  Stop using deprecated trait
  [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 23:27:17 +01:00