This PR was submitted for the master branch but it was merged into the 3.4 branch instead.
Discussion
----------
[Finder] Fixed docs
minor docblock fix
Commits
-------
e7d0787a4d [Finder] Fixed docs
This PR was merged into the 3.4 branch.
Discussion
----------
Adjust pull request template for 5.1
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Now that 5.0-RC1 has been released (btw: 🎉👏🍾 ), I assume that new features should go to master again.
Commits
-------
c194fffaef Adjust pull request template for 5.0 branchout
This PR was squashed before being merged into the 3.4 branch (closes#34422).
Discussion
----------
Update HttpKernel.php
phpstan-symfony (0.11.6) level 5
Parameter #2 $values of method Symfony\Component\HttpFoundation\HeaderBag::set() expects array|string, int given.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", if any -->
| License | MIT
| Doc PR |
Commits
-------
7b7f966711 Update HttpKernel.php
This PR was merged into the 3.4 branch.
Discussion
----------
Add conflict rule for Monolog 2
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #27857, symfony/monolog-bundle#300
| License | MIT
| Doc PR | N/A
Depending on the monorepo has been best practice in Symfony 3 and is discouraged but still possible in Symfony 4. If the Symfony Standard Edition was used to bootstrap the application, Monolog is installed as dependency of the MonologBundle. Thus, if we released a MonologBundle that indicates compatibility with Monolog 2, those application would be bumped to Version 2 although MonologBridge 3.4 is not ready for it. The goal is to prevent this from happening.
This PR adds a conflict rule for Monolog 2 to the 3.4 branch. Assuming this gets merged before the next Symfony releases (3.4.30, 4.2.11, 4.3.3), my plan would be to bump MonologBundle's dependencies like this:
```diff
"require": {
- "monolog/monolog": "~1.22",
- "symfony/monolog-bridge": "~3.4|~4.0"
+ "monolog/monolog": "~1.22|~2.0",
+ "symfony/monolog-bridge": "^3.4.30|~4.2.11|^4.3.3|^5.0"
}
```
If I'm not mistaken, this should remove any possible combination of Symfony 3/4 and Monolog 2.
Projects depending on individual packages instead of the monorepo should be safe already because MonologBridge 3.x/4.x locks Monolog at version 1.
Commits
-------
d53b91a45a Add conflict rule for Monolog 2.
This PR was merged into the 3.4 branch.
Discussion
----------
[HttpFoundation] Allow redirecting to URLs that contain a semicolon
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
URLs that contain a semicolon cannot be redirected to at least in MS Edge and IE10.
Take the following example...
```
# https://ad.doubleclick.net/ddm/clk/450721234;254801234;l
// After redirect...
# https://ad.doubleclick.net/ddm/clk/450721234
```
Wrapping the URL in single quotes fixes the issue ([related reading](https://www.w3.org/TR/WCAG20-TECHS/H76.html))
Commits
-------
bd0637ebe4 [HttpFoundation] Allow redirecting to URLs that contain a semicolon
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.
Discussion
----------
[HttpFoundation] Fix MySQL column type definition.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? |no
| Deprecations? | no
| Tickets | Fix#34409
| License | MIT
| Doc PR | symfony/symfony-docs#12641
Fix wrong MySQL column type definition causing Numeric value out of range exception.
Commits
-------
51c5f69274 Fix MySQL column type definition.
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.
Discussion
----------
Link the right file depending on the new version
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix url doc upgrading to 4.x
| License | MIT
Link the right file depending on the new version
Commits
-------
7e38d83ad0 Link the right file depending on the new version
This PR was merged into the 3.4 branch.
Discussion
----------
[Finder] Allow ssh2 stream wrapper for sftp
Same fix as #28604 but for the ssh2.sftp wrapper.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#28604 maybe
| License | MIT
| Doc PR |
Without this patch, we can't use the finder with ssh2.sftp connections.
```php
$connection = \ssh2_connect('host', 22);
\ssh2_auth_password($connection, 'user', 'pass');
$sftp = \ssh2_sftp($connection);
$path = "ssh2.sftp://".intval($sftp)."/";
$finder = new Finder();
foreach ($finder->in($path)->files() as $directory) {
dump(file_get_contents($directory));
}
```
Without the patch:
> RecursiveDirectoryIterator::__construct(ssh2.sftp://838): failed to open dir: operation failed
Commits
-------
e6c9d77b63 [Finder] Allow ssh2 stream wrapper for sftp
This PR was merged into the 3.4 branch.
Discussion
----------
[WebProfilerBundle] Require symfony/twig-bundle
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Starting from a fresh 3.4 I did `composer require symfony/web-profiler-bundle --dev` but it fails on post install cache clear because 8a68d2d358/src/Symfony/Bundle/WebProfilerBundle/Resources/config/profiler.xml (L13) needs the `twig` service that is declared in the `TwigBundle`.
`symfony/twig-bundle` is already a hard depency of the `WebProfilerBundle` on 4.3+ (cf cac37caa7d).
Commits
-------
78dad79fec [WebProfilerBundle] Require symfony/twig-bundle
This PR was merged into the 3.4 branch.
Discussion
----------
Allow returning null from NormalizerInterface::normalize
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes?
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Looking at the code, it seems that a normalizer might be called with a `null` value for `$data`, and thus it's only sensible that it be allowed to return `null` too:
7064ff35f2/src/Symfony/Component/Serializer/Serializer.php (L141-L148)
Updating the phpdoc to match.
Commits
-------
1c8edc55ad Allow returning null from NormalizerInterface::normalize
This PR was merged into the 3.4 branch.
Discussion
----------
[Routing] revert the return type for UrlGeneratorInterface::generate to remove null
…to remove null
| Q | A
| ------------- | ---
| Branch? | 3.4 (only)
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
Bit of a casualty of commit tennis this:
A change to add `null` here as an option for how `UrlGeneratorInterface::generate()` (rather than the concrete `UrlGenerator`) was merged in https://github.com/symfony/symfony/pull/28321, but then [reverted](90494c20cc) for the reason [that this could be seen as a BC break](https://github.com/symfony/symfony/pull/28321#issuecomment-418540080), as the `null` return had not previously been documented (and is still not as part of the interface method docs).
However, in a subsequent change (https://github.com/symfony/symfony/pull/33252) with a wider scope, this doc change was added _back_ in order to reflect the underlying implementation as a result of a PHPStorm plugin complaining. There's no indication though of what a `null` return here though would mean, and for the same reason as the first revert (that this should be seen as a BC break), I'd like to submit this to be reverted for the 3.4 branch. (In 4.4 the `null` has already been removed.)
Having the interface indicating that this method can return `null` necessitates introducing a lot of actually redundant null checks in code that is covered by static analysis tools such as PHPStan.
Commits
-------
9f853f324f [Routing] revert the return type for UrlGeneratorInterface::generate to remove null
This PR was squashed before being merged into the 3.4 branch (closes#34135).
Discussion
----------
[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | Fix#30166
| License | MIT
Ref #30166
Commits
-------
022cf67f19 [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
This PR was merged into the 3.4 branch.
Discussion
----------
[FrameworkBundle] Avoid using of kernel after shutdown in KernelTestCase
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix #...
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
I had sadly something like this in my codebase:
```php
if (!static::$kernel) {
static::bootKernel();
}
```
As the $kernel is never set again to null a old $kernel was still there. I would not only set the $container also the $kernel variable to null. ~~As this could be a BC Break I'm targeting master~~.
Commits
-------
49b58ed45e Avoid using of kernel after shutdown
This PR was submitted for the master branch but it was merged into the 3.4 branch instead.
Discussion
----------
[DependencyInjection] Fix broken references in tests
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? |no
| Deprications? | no
| License | MIT
Commits
-------
bd1ead251c [DependencyInjection] Fix broken references in tests
