Commit Graph

35998 Commits

Author SHA1 Message Date
Fabien Potencier d65c43ba84 feature #26372 Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)" (nicolas-grekas)
This PR was merged into the 4.1-dev branch.

Discussion
----------

Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This reverts commit 136408937b, reversing
changes made to e043478ba5.

As discussed in #24763 and #26344

This doens't revert the possibility to use prepared command lines. They just won't be *portable* anymore, unless special care is taken by "userland".
Ie the placeholders need to be shell-dependent: use eg `echo "$FOO"` on *nix (the double quotes *are* important), and `echo !FOO!` on Windows (no double quotes there).

Commits
-------

6a98bfa8d7 Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)"
2018-03-05 08:20:17 -08:00
Fabien Potencier fc1b1dd0ed bug #26393 [DI] Skip resource tracking if disabled (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

 [DI] Skip resource tracking if disabled

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26388
| License       | MIT
| Doc PR        | n/a

Commits
-------

0b748fac95 [DI] Skip resource tracking if disabled
2018-03-05 08:14:30 -08:00
Fabien Potencier 7a9929f9d6 minor #26410 [WebProfilerBundle] Made the translation profiler panel more compact (javiereguiluz)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[WebProfilerBundle] Made the translation profiler panel more compact

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

### Before

![before](https://user-images.githubusercontent.com/73419/36983246-2201e208-2092-11e8-897b-a31862a9a745.png)

### After

![after](https://user-images.githubusercontent.com/73419/36983252-26ac3df8-2092-11e8-81f4-44384cef8851.png)

Commits
-------

21ee76c0ad Made the translation profiler panel more compact
2018-03-05 08:09:39 -08:00
Christophe Coevoet 1819c8dc51 bug #26403 fix the handling of timestamp in the MongoDBSessionHandler (hjanuschka)
This PR was submitted for the master branch but it was squashed and merged into the 4.0 branch instead (closes #26403).

Discussion
----------

fix the handling of timestamp in the MongoDBSessionHandler

| Q             | A
| ------------- | ---
| Branch?       |  master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

in the process of upgrading from 3.4 to 4.0 we stumbled upon a issue with mongo session handler.

```
[05-Mar-2018 11:12:57 Europe/Vienna] PHP Fatal error:  Uncaught Error: Call to undefined method Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler::createDateTime() in /opt/APP/vendor/symfony/http-foundation/Session/Storage/Handler/MongoDbSessionHandler.php:144
Stack trace:
#0 [internal function]: Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler->updateTimestamp('96d983b59f8aef8...', 'user_obj|O:9:"k...')
#1 [internal function]: session_write_close()
#2 {main}
  thrown in /opt/APP/vendor/symfony/http-foundation/Session/Storage/Handler/MongoDbSessionHandler.php on line 144
```

this PR re-add's the method, that somehow got removed in 4.0 branch, whereas the interface forces to have the implemantation.

Commits
-------

97d9ea8269 fix the handling of timestamp in the MongoDBSessionHandler
2018-03-05 17:01:10 +01:00
Helmut Januschka 97d9ea8269 fix the handling of timestamp in the MongoDBSessionHandler 2018-03-05 17:01:10 +01:00
Javier Eguiluz 21ee76c0ad Made the translation profiler panel more compact 2018-03-05 16:26:36 +01:00
Daniel STANCU 5b4354f46c Readd 'form_label_errors' block to disable errors on form labels 2018-03-05 15:16:24 +02:00
Fabien Potencier 3379310dd6 minor #26396 Improve the documentation of `Finder::exclude()` (mnapoli)
This PR was merged into the 2.7 branch.

Discussion
----------

Improve the documentation of `Finder::exclude()`

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

Tried to do this and this didn't work:

```php
$iterator->in($sourcePath)
    ->exclude($sourcePath.'/foo');
```

I read on http://symfony.com/doc/current/components/finder.html that excluded directories need to be relative:

![capture d ecran 2018-03-04 a 16 10 31](https://user-images.githubusercontent.com/720328/36947055-28e47eda-1fc7-11e8-9475-399a3d853169.png)

Commits
-------

cc3084ed65 Improve the documentation of `Finder::exclude()`
2018-03-04 08:34:45 -08:00
Matthieu Napoli cc3084ed65
Improve the documentation of `Finder::exclude()` 2018-03-04 16:13:29 +01:00
Robin Chalas 0b748fac95 [DI] Skip resource tracking if disabled 2018-03-04 04:54:53 +01:00
Nicolas Grekas cfb243e61a Merge branch '2.8' into 3.4
* 2.8:
  [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
2018-03-02 16:26:15 +01:00
Nicolas Grekas 710a189e83 Merge branch '2.7' into 2.8
* 2.7:
  [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
2018-03-02 16:25:13 +01:00
Nicolas Grekas 79e8545f86 minor #26373 [WebProfilerBundle] fix wrong variable for profiler counting ajax requests (Marin Nicolae)
This PR was squashed before being merged into the 2.7 branch (closes #26373).

Discussion
----------

[WebProfilerBundle] fix wrong variable for profiler counting ajax requests

| Q             | A
| ------------- | ---
| Branch?       |  2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#...

Symfony WebProfiler base js change variable tbodies to tbody for counting Ajax Requests.

Commits
-------

0fb83af [WebProfilerBundle] fix wrong variable for profiler counting ajax requests
2018-03-02 16:24:45 +01:00
Marin Nicolae 0fb83af015 [WebProfilerBundle] fix wrong variable for profiler counting ajax requests 2018-03-02 16:24:40 +01:00
Nicolas Grekas a8dc953279 Merge branch '4.0'
* 4.0:
  [DI] Fix missing "id" normalization when dumping the container
  Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md`
2018-03-02 15:22:00 +01:00
Nicolas Grekas cb06d0f926 Merge branch '3.4' into 4.0
* 3.4:
  [DI] Fix missing "id" normalization when dumping the container
  Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md`
2018-03-02 15:21:47 +01:00
Nicolas Grekas 6ac7b50021 bug #26355 [DI] Fix missing "id" normalization when dumping the container (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix missing "id" normalization when dumping the container

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26306
| License       | MIT
| Doc PR        | -

Commits
-------

4a5e43e [DI] Fix missing "id" normalization when dumping the container
2018-03-02 15:13:11 +01:00
Nicolas Grekas 4a5e43eae8 [DI] Fix missing "id" normalization when dumping the container 2018-03-02 14:51:21 +01:00
Nicolas Grekas 6a98bfa8d7 Revert "feature #24763 [Process] Allow writing portable "prepared" command lines (Simperfit)"
This reverts commit 136408937b, reversing
changes made to e043478ba5.
2018-03-02 13:21:49 +01:00
Nicolas Grekas 8f1a6b5d65 minor #26276 [Doc] Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md` (phansys)
This PR was merged into the 3.4 branch.

Discussion
----------

[Doc] Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md`

|Q            |A     |
|---          |---   |
|Branch       |3.4   |
|Bug fix?     |no    |
|New feature? |no    |
|BC breaks?   |no    |
|Deprecations?|no    |
|Tests pass?  |yes   |
|Fixed tickets|#26269|
|License      |MIT   |
|Doc PR       |n/a   |

Commits
-------

d6e2b81 Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md`
2018-03-02 13:17:15 +01:00
Nicolas Grekas 1f7b9f0fc5 feature #26223 [FrameworkBundle] Add command to delete an item from a cache pool (pierredup)
This PR was squashed before being merged into the 4.1-dev branch (closes #26223).

Discussion
----------

[FrameworkBundle] Add command to delete an item from a cache pool

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | TBD

Currently there is no way to clear a specific item from a cache pool (except programatically), the entire pool needs to be cleared.
Especially during development, when implementing caching, it is useful to delete a specific key to test functionality. Clearing the entire pool, means that everything will need to be cached again, adding unnecessary execution time.

I propose adding a new command, `cache:pool:delete` to delete a specific item from a cache pool

Commits
-------

fd43e81 [FrameworkBundle] Add command to delete an item from a cache pool
2018-03-02 13:13:05 +01:00
Pierre du Plessis fd43e81fd7 [FrameworkBundle] Add command to delete an item from a cache pool 2018-03-02 13:13:00 +01:00
Nicolas Grekas acb5d9f9a1 Merge branch '4.0'
* 4.0:
  [WebProfilerBundle] Fix Debug toolbar breaks app
  Use fill instead of style for svg colors
  bumped Symfony version to 4.0.6
  updated VERSION for 4.0.5
  updated CHANGELOG for 4.0.5
  bumped Symfony version to 3.4.6
  updated VERSION for 3.4.5
  updated CHANGELOG for 3.4.5
  bumped Symfony version to 2.8.36
  updated VERSION for 2.8.35
  updated CHANGELOG for 2.8.35
  [FrameworkBundle] Silence "Failed to remove directory" on cache:clear
  bumped Symfony version to 2.7.43
  updated VERSION for 2.7.42
  update CONTRIBUTORS for 2.7.42
  updated CHANGELOG for 2.7.42
2018-03-02 09:29:06 +01:00
Nicolas Grekas 1c826ca0f3 Merge branch '3.4' into 4.0
* 3.4:
  [WebProfilerBundle] Fix Debug toolbar breaks app
  Use fill instead of style for svg colors
  bumped Symfony version to 3.4.6
  updated VERSION for 3.4.5
  updated CHANGELOG for 3.4.5
  bumped Symfony version to 2.8.36
  updated VERSION for 2.8.35
  updated CHANGELOG for 2.8.35
  [FrameworkBundle] Silence "Failed to remove directory" on cache:clear
  bumped Symfony version to 2.7.43
  updated VERSION for 2.7.42
  update CONTRIBUTORS for 2.7.42
  updated CHANGELOG for 2.7.42
2018-03-02 09:28:17 +01:00
Nicolas Grekas fe4d055bd7 Merge branch '2.8' into 3.4
* 2.8:
  [WebProfilerBundle] Fix Debug toolbar breaks app
  bumped Symfony version to 2.8.36
  updated VERSION for 2.8.35
  updated CHANGELOG for 2.8.35
  bumped Symfony version to 2.7.43
  updated VERSION for 2.7.42
  update CONTRIBUTORS for 2.7.42
  updated CHANGELOG for 2.7.42
2018-03-02 09:27:00 +01:00
Nicolas Grekas aa8254ce2f Merge branch '2.7' into 2.8
* 2.7:
  [WebProfilerBundle] Fix Debug toolbar breaks app
  bumped Symfony version to 2.7.43
  updated VERSION for 2.7.42
  update CONTRIBUTORS for 2.7.42
  updated CHANGELOG for 2.7.42
2018-03-02 09:25:37 +01:00
Nicolas Grekas b2df671912 feature #26341 Autoconfigure service locator tag (apfelbox)
This PR was squashed before being merged into the 4.1-dev branch (closes #26341).

Discussion
----------

Autoconfigure service locator tag

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26187
| License       | MIT
| Doc PR        | —

We will now also autoconfigure the (required) tag `container.service_locator` for all `ServiceLocator`s.

I couldn't find any integration tests for the whole list of autoconfigured core services, so I didn't add any new tests.

Commits
-------

c4b9b42 Autoconfigure service locator tag
2018-03-02 09:24:43 +01:00
Jannik Zschiesche c4b9b4252b Autoconfigure service locator tag 2018-03-02 09:24:40 +01:00
Nicolas Grekas 0c5f8391f9 bug #26368 [WebProfilerBundle] Fix Debug toolbar breaks app (xkobal)
This PR was squashed before being merged into the 2.7 branch (closes #26368).

Discussion
----------

[WebProfilerBundle] Fix Debug toolbar breaks app

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Wrong method is used to count `tbody.rows`

Commits
-------

52f187e [WebProfilerBundle] Fix Debug toolbar breaks app
2018-03-02 09:20:34 +01:00
Xavier HAUSHERR 52f187e86a [WebProfilerBundle] Fix Debug toolbar breaks app 2018-03-02 09:20:32 +01:00
Nicolas Grekas 9980004cb4 bug #26369 Use fill instead of style for svg colors (rpkamp)
This PR was merged into the 3.4 branch.

Discussion
----------

Use fill instead of style for svg colors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT

Using style does not work when a Content Security Policy is in place,
resulting in non-styles (black) images instead of grey.

Symfony 2.7 and 2.8 don't have these images so there is nothing to fix there.

Commits
-------

e296778 Use fill instead of style for svg colors
2018-03-02 09:19:22 +01:00
Remon van de Kamp e29677858f
Use fill instead of style for svg colors
Using style does not work when a Content Security Policy is in place,
resulting in non-styles (black) images instead of grey.
2018-03-02 09:07:37 +01:00
Javier Spagnoletti d6e2b8188c Add entry for `container.dumper.inline_class_loader` param at `UPGRADE-3.4.md` and `UPGRADE-4.0.md` 2018-03-01 21:43:47 -03:00
Fabien Potencier 6628318b29 bug #26358 [FrameworkBundle] Silence "Failed to remove directory" on cache:clear (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Silence "Failed to remove directory" on cache:clear

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #2600
| License       | MIT
| Doc PR        | -

Let's improve the experience of ppl (see old linked issue). This warning is just noise to most.

Commits
-------

3ba624af9f [FrameworkBundle] Silence "Failed to remove directory" on cache:clear
2018-03-01 12:19:29 -08:00
Fabien Potencier 4b13407362 bumped Symfony version to 4.0.6 2018-03-01 12:16:32 -08:00
Fabien Potencier ff68b3a2db
Merge pull request #26363 from fabpot/release-4.0.5
released v4.0.5
2018-03-01 11:48:49 -08:00
Fabien Potencier 173d4aea89 updated VERSION for 4.0.5 2018-03-01 11:48:35 -08:00
Fabien Potencier 4708fc1f2b updated CHANGELOG for 4.0.5 2018-03-01 11:48:25 -08:00
Fabien Potencier b3f807cc5a bumped Symfony version to 3.4.6 2018-03-01 11:47:22 -08:00
Fabien Potencier 8a023e125a
Merge pull request #26362 from fabpot/release-3.4.5
released v3.4.5
2018-03-01 11:24:09 -08:00
Fabien Potencier 1ec5a562b3 updated VERSION for 3.4.5 2018-03-01 11:23:56 -08:00
Fabien Potencier df008e2f56 updated CHANGELOG for 3.4.5 2018-03-01 11:23:47 -08:00
Fabien Potencier 3ff74ada0d bumped Symfony version to 2.8.36 2018-03-01 11:16:54 -08:00
Fabien Potencier 7339c93c82
Merge pull request #26361 from fabpot/release-2.8.35
released v2.8.35
2018-03-01 08:45:46 -08:00
Fabien Potencier fbf0d0cce1 updated VERSION for 2.8.35 2018-03-01 08:45:28 -08:00
Fabien Potencier 586f697610 updated CHANGELOG for 2.8.35 2018-03-01 08:45:24 -08:00
Nicolas Grekas 3ba624af9f [FrameworkBundle] Silence "Failed to remove directory" on cache:clear 2018-03-01 15:51:10 +01:00
Fabien Potencier 31c69ec90d bumped Symfony version to 2.7.43 2018-03-01 06:32:34 -08:00
Nicolas Grekas d1b67a561c fix test 2018-03-01 11:49:02 +01:00
Nicolas Grekas a06f826a21 Merge branch '4.0'
* 4.0:
  [Form][WCAG] Errors sign for people that do not see colors
  [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table
2018-03-01 11:22:02 +01:00