Commit Graph

26553 Commits

Author SHA1 Message Date
Nicolas Grekas
313c8c03de feature #18964 [PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\ (teohhanhui)
This PR was merged into the 3.2-dev branch.

Discussion
----------

[PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes?
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | symfony/symfony-docs#6546

Related to symfony/symfony-standard#969

Commits
-------

d043305 [PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\
2016-06-03 12:59:16 +02:00
Nicolas Grekas
9d79a401a4 minor #18962 [travis] Don't use parallel on HHVM (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[travis] Don't use parallel on HHVM

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Targeting a speedup of the HHVM matrix line especially.

Commits
-------

346149e [travis] Don't use parallel on HHVM
2016-06-03 12:56:46 +02:00
Nicolas Grekas
346149e7c8 [travis] Don't use parallel on HHVM 2016-06-03 12:05:53 +02:00
Teoh Han Hui
d0433054b9
[PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\ 2016-06-03 17:32:43 +08:00
Fabien Potencier
22aa620e80 bug #18954 [3.1][HttpKernel] Fix RequestDataCollector starting the session (romainneutron)
This PR was merged into the 3.1 branch.

Discussion
----------

[3.1][HttpKernel] Fix RequestDataCollector starting the session

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18951
| License       | MIT

The RequestDataCollector starts a non-started session on kernel response. This produces bug #18951
I'm not sure if this is the right fix, let's discuss it.

Commits
-------

ab62dcf [HttpKernel] Fix RequestDataCollector starting the session
2016-06-03 10:45:02 +02:00
Romain Neutron
ab62dcf3f4 [HttpKernel] Fix RequestDataCollector starting the session 2016-06-03 10:33:12 +02:00
Nicolas Grekas
c4149a40fb minor #18947 Run an uptodate version of HHVM on Travis (stof)
This PR was merged into the 2.7 branch.

Discussion
----------

Run an uptodate version of HHVM on Travis

| Q             | A
| ------------- | ---
| Branch?       |2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | n/a

Using the Trusty infrastructure allows running an uptodate version of HHVM rather than running the latest version supporting Precise, which is very old.
It relies on an undocumented feature of the Travis config file, namely the fact that ``matrix.include`` actually allows to overwrite everything from the config file (it is merged with the main config), even though the Travis linter complains about it. I think it is fine to use this and to replace it with an official approach once there is one.

Refs #18922

Commits
-------

e6956c9 Skip some tests on HHVM due to a PHPunit bug
e041da0 Use the Trusty Travis infrastructure for HHVM builds
2016-06-03 10:03:59 +02:00
Nicolas Grekas
553855b931 minor #18960 [appveyor] Ignore STATUS_HEAP_CORRUPTION errors on Windows (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[appveyor] Ignore STATUS_HEAP_CORRUPTION errors on Windows

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As in e.g. https://ci.appveyor.com/project/fabpot/symfony/build/1.0.9382#L1505

Commits
-------

574f4e4 [appveyor] Ignore STATUS_HEAP_CORRUPTION errors on Windows
2016-06-03 10:03:11 +02:00
Nicolas Grekas
574f4e4147 [appveyor] Ignore STATUS_HEAP_CORRUPTION errors on Windows 2016-06-03 09:48:37 +02:00
Fabien Potencier
eced97bf51 minor #18939 [FrameworkBundle] Skip redis cache pools test on failed connection (chalasr)
This PR was squashed before being merged into the 3.1 branch (closes #18939).

Discussion
----------

[FrameworkBundle] Skip redis cache pools test on failed connection

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Actually, running the FrameworkBundle tests suit leads to a failure that says:

> 1) Symfony\Bundle\FrameworkBundle\Tests\Functional\CachePoolsTest::testRedisCachePools
Symfony\Component\Cache\Exception\InvalidArgumentException: Redis connection failed: redis://localhost
[...]
[...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:59
[...]/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php:30

So I propose to catch this specific exception in case of redis is not (locally) supported, in order to be sure that tests stay green.

Commits
-------

0d349dd [FrameworkBundle] Skip redis cache pools test on failed connection
2016-06-03 07:29:17 +02:00
Robin Chalas
0d349dd496 [FrameworkBundle] Skip redis cache pools test on failed connection 2016-06-03 07:29:16 +02:00
Fabien Potencier
60b83dc2fe bug #18949 [3.1][Security] Fix DebugAccessDecisionManager when object is not a scalar (romainneutron)
This PR was merged into the 3.1 branch.

Discussion
----------

[3.1][Security] Fix DebugAccessDecisionManager when object is not a scalar

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT

Commits
-------

ff2d189 [Security] Fix DebugAccessDecisionManager when object is not a scalar
2016-06-03 07:23:02 +02:00
Fabien Potencier
af6ada5df8 bug #18959 [WebProfilerBundle] Fixed forwarded request data in templates (HeahDude)
This PR was merged into the 3.1 branch.

Discussion
----------

[WebProfilerBundle] Fixed forwarded request data in templates

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/silexphp/Silex-WebProfiler/issues/92
| License       | MIT
| Doc PR        | ~

Fixes a bug occurring  when the `FrameworkBundle` is not part of the dependencies (i.e using Silex).

Commits
-------

078c8b6 Fixed forwarded request data in templates
2016-06-03 07:16:26 +02:00
Jules Pietri
078c8b6b8a Fixed forwarded request data in templates 2016-06-03 02:46:43 +02:00
Romain Neutron
ff2d189f34 [Security] Fix DebugAccessDecisionManager when object is not a scalar 2016-06-02 16:45:44 +02:00
Christophe Coevoet
e6956c9bfc Skip some tests on HHVM due to a PHPunit bug 2016-06-02 11:40:24 +02:00
Christophe Coevoet
e041da09e4 Use the Trusty Travis infrastructure for HHVM builds
This allows running an uptodate version of HHVM rather than running the
latest version supporting Precise, which is very old.
2016-06-02 11:40:24 +02:00
Christian Flothmann
bff9c3631d LdapUserProvider: add missing argument type doc 2016-06-01 23:24:55 +02:00
Robin Chalas
05ae01bf02 [Console] Add path argument to dump a specific option in debug:config
Handle failure on undefined path, Add tests

PHPDoc fix

Remove useless assertion
2016-06-01 22:18:34 +02:00
Fabien Potencier
d1b0301c71 bug #18943 [Ldap][Security] The Ldap user provider abstract service now has the correct number of arguments (csarrazi)
This PR was merged into the 3.1 branch.

Discussion
----------

[Ldap][Security] The Ldap user provider abstract service now has the correct number of arguments

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18933
| License       | MIT
| Doc PR        | none

Commits
-------

58996ac Fixed issue with missing argument in the abstract service definition for the ldap user provider
2016-06-01 21:56:09 +02:00
Fabien Potencier
e5ffcb2ada minor #18942 Add 3.1 to PR template branch row and remove 2.3 (chalasr)
This PR was merged into the 2.7 branch.

Discussion
----------

Add 3.1 to PR template branch row and remove 2.3

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

71dcaa1 Add 3.1 to  PR template branch row, remove 2.3
2016-06-01 21:54:39 +02:00
Charles Sarrazin
58996ac0bf Fixed issue with missing argument in the abstract service definition for the ldap user provider 2016-06-01 21:35:13 +02:00
Robin Chalas
71dcaa14c9 Add 3.1 to PR template branch row, remove 2.3 2016-06-01 21:19:49 +02:00
Dword123
c1df9f210e Improve memory efficiency
This avoids concatenating `$message` and `PHP_EOL` (if necessary) as a new value, greatly improving memory efficiency for large `$message`s.
2016-06-01 13:20:21 +02:00
Fabien Potencier
c7f1f7810c bug #18925 [Console] Fix BC break introduced by #18101 (dunglas)
This PR was squashed before being merged into the 3.1 branch (closes #18925).

Discussion
----------

[Console] Fix BC break introduced by #18101

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | https://github.com/symfony/symfony/pull/18101#issuecomment-222736460
| License       | MIT
| Doc PR        | n/a

* [x] Fix tests

Commits
-------

7a5a139 [Console] Fix BC break introduced by #18101
2016-06-01 08:04:30 +02:00
Kévin Dunglas
7a5a139135 [Console] Fix BC break introduced by #18101 2016-06-01 08:04:28 +02:00
Fabien Potencier
44f5283a21 minor #18928 add missing hint for vote() argument type (xabbuh)
This PR was merged into the 3.1 branch.

Discussion
----------

add missing hint for vote() argument type

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This somehow got lost when the `3.0` branch was merged up.

Commits
-------

d14f0bf add missing hint for vote() argument type
2016-06-01 07:48:53 +02:00
Fabien Potencier
a9bce60ce3 minor #18927 document method name changes in Voter class (xabbuh)
This PR was merged into the 2.8 branch.

Discussion
----------

document method name changes in Voter class

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16035
| License       | MIT
| Doc PR        |

Commits
-------

c0b9e99 document method name changes in Voter class
2016-06-01 07:45:39 +02:00
Christian Flothmann
c0b9e9950a document method name changes in Voter class 2016-05-31 21:33:24 +02:00
Christian Flothmann
d14f0bf71f add missing hint for vote() argument type 2016-05-31 21:27:35 +02:00
Nicolas Grekas
8983e83d91 [Cache] Optimize & wire PhpFilesAdapter 2016-05-31 18:28:43 +02:00
Christophe Coevoet
691f19ff34 minor #18914 [#18838] add a test to avoid regressions (xabbuh)
This PR was merged into the 3.1 branch.

Discussion
----------

[#18838] add a test to avoid regressions

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18838
| License       | MIT
| Doc PR        |

Commits
-------

240cf0a [#18838] add a test to avoid regressions
2016-05-30 10:42:44 +02:00
Fabien Potencier
0baa58d4e4 Merge pull request #18916 from fabpot/release-2.3.42
released v2.3.42
2016-05-30 10:41:31 +02:00
Fabien Potencier
7143b2974c updated VERSION for 2.3.42 2016-05-30 10:41:10 +02:00
Fabien Potencier
b4a9d25881 update CONTRIBUTORS for 2.3.42 2016-05-30 10:40:59 +02:00
Fabien Potencier
7d8dc87616 updated CHANGELOG for 2.3.42 2016-05-30 10:40:50 +02:00
Nicolas Grekas
91635a8054 Revert "bug #18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)"
This reverts commit 44f6f89308, reversing
changes made to 57d6053822.
2016-05-30 10:31:06 +02:00
Nicolas Grekas
44f6f89308 bug #18908 [DependencyInjection] force enabling the external XML entity loaders (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] force enabling the external XML entity loaders

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18876
| License       | MIT
| Doc PR        |

Commits
-------

142b1a4 force enabling the external XML entity loaders
2016-05-30 10:25:13 +02:00
Christian Flothmann
240cf0aaa8 [#18838] add a test to avoid regressions 2016-05-30 10:23:04 +02:00
Nicolas Grekas
57d6053822 bug #18893 [DependencyInjection] Skip deep reference check for 'service_container' (RobertMe)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Skip deep reference check for 'service_container'

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The "hasReference" check when dumping the container fails in the case where a service has a method call which includes a reference to a private/inlined service when either that service, or a dependency of it, references the service_container. This because service_container isn't defined while it still tries to check the references of it. So the service_container must be skipped in this case, this shouldn't break anything as the service_container doesn't reference any services, and thus can't reference the service which it is checking for.

Commits
-------

6f36733 [DependencyInjection] Skip deep reference check for 'service_container'
2016-05-30 10:21:17 +02:00
Nicolas Grekas
b3cd2679b8 Partial revert of previous PR 2016-05-30 10:16:24 +02:00
Robert Meijers
6f3673364e [DependencyInjection] Skip deep reference check for 'service_container'
Deep checks on whether a service references another service need to
exclude the 'service_container' service as it doesn't exist. Without this
dumping the container will fail if a service definition references an
inlined service which has a direct or indirect dependency to the
service_container.
2016-05-30 10:16:14 +02:00
Nicolas Grekas
a60c3551b0 bug #18812 Catch \Throwable (fprochazka)
This PR was squashed before being merged into the 2.3 branch (closes #18812).

Discussion
----------

Catch \Throwable

| Q             | A
| ------------- | ---
| Branch?       | 2.3, 2.7, 2.8, 3.0
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | Yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Related symfony/symfony#18765, symfony/symfony#15949

Commits
-------

893cf00 Catch \Throwable
2016-05-30 10:14:44 +02:00
Filip Procházka
893cf00a52 Catch \Throwable 2016-05-30 10:14:41 +02:00
Nicolas Grekas
0cf017e568 bug #18821 [2.3][Form] Removed UTC specification with timestamp (francisbesset)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Form] Removed UTC specification with timestamp

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The function `date_parse()` indicates a warning if a timezone is used with the timestamp: `Double timezone specification`. I removed the UTC specification and this time it's more faster!

Commits
-------

0d14aac Removed UTC specification with timestamp
2016-05-30 10:13:41 +02:00
Nicolas Grekas
c58513457c minor #18854 [Serializer] Add missing @throws annotations (theofidry)
This PR was squashed before being merged into the 2.3 branch (closes #18854).

Discussion
----------

[Serializer] Add missing @throws annotations

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18798
| License       | MIT
| Doc PR        | -

Commits
-------

b73400d [Serializer] Add missing @throws annotations
2016-05-30 10:12:16 +02:00
Théo FIDRY
b73400d707 [Serializer] Add missing @throws annotations 2016-05-30 10:12:14 +02:00
Nicolas Grekas
d645bd5073 bug #18861 Fix for #18843 (inso)
This PR was squashed before being merged into the 2.3 branch (closes #18861).

Discussion
----------

Fix for #18843

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18843
| License       | MIT
| Doc PR        | -

Commits
-------

7d78196 Fix for #18843
2016-05-30 10:10:22 +02:00
Anton Bakai
7d78196d0c Fix for #18843 2016-05-30 10:10:17 +02:00
Fabien Potencier
76e30a9881 bumped Symfony version to 3.1.1 2016-05-30 09:57:32 +02:00