This PR was merged into the 5.2 branch.
Discussion
----------
[Serializer] Drop extra space
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
This extra space prevents phpab to prepare a static autoloader due to a parse error:
```
$ phpab src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
phpab %development% - Copyright (C) 2009 - 2021 by Arne Blankerts and Contributors
Scanning file src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
Could not process file '/home/taffit/Debian/symfony/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php' due to parse errors: Parse error while trying to process class definition (unexpected token "T_DOUBLE_ARROW" in name).
```
Commits
-------
ff05e84553 [Serializer] Drop extra space
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Notifier] [DX] Dsn::getRequiredOption()
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
### Todo
* [x] use the new method in all available bridges and bump composer.json files to `notifer:5.3`
* [x] add tests
This will lead to a much cleaner "communication" between the factory and the transport which option is required and which is optional. This method will also reduce the code duplication in the bridges.
IMHO we should add more of those convenient "helpers" to lower the burden for new bridges.
Commits
-------
3f095bf419 [Notifier] [DX] Dsn::getRequiredOption()
This PR was squashed before being merged into the 5.1 branch.
Discussion
----------
[Notifier] Add tests for SlackOptions
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
Commits
-------
dcaee9970b [Notifier] Add tests for SlackOptions
* 5.2:
fix code style
[Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
stop using void in test files
parse cookie values containing the equal sign
make some time dependent tests more resilient
fix code style
Remove full head content in HTML to text converter
do not break when loading schemas from network paths on Windows
apply the sort callback on the whole search result
* 5.1:
parse cookie values containing the equal sign
make some time dependent tests more resilient
do not break when loading schemas from network paths on Windows
* 4.4:
parse cookie values containing the equal sign
make some time dependent tests more resilient
do not break when loading schemas from network paths on Windows
* 5.1:
[Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
stop using void in test files
This PR was merged into the 4.4 branch.
Discussion
----------
make some time dependent tests more resilient
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
a33850e838 make some time dependent tests more resilient
This PR was merged into the 5.1 branch.
Discussion
----------
stop using void in test files
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
8f9f370f07 stop using void in test files
This PR was merged into the 5.1 branch.
Discussion
----------
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Ref https://github.com/symfony/polyfill/issues/323
In my scenario, I'm doing `Ulid::fromString('0164129e-c96f-eb1a-f011-57cf56e0c559')`. When we reach the modified line, we already know the provided `$ulid` string is an rfc-4122 valid uuid so we don't need to call `fromString` (I guess) + we don't care of the version, we just want the binary content. That fixes the referenced issue in my case because the missing constant is consequently not loaded.
Commits
-------
44392cbc30 [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
This PR was merged into the 5.1 branch.
Discussion
----------
[Uid] Inline UuidV*::TYPE constants
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Ref https://github.com/symfony/polyfill/issues/323
If we hardcode those values in the polyfill, we can surely hardcode them here? In my case, I have tested that `uuid_type` actually returns `3` even if the `\UUID_TYPE_MD5` constant is undefined 🤷♂️
Commits
-------
f0fafec019 [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Console] Handle duplicate negatable options
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Throws an LogicException when adding a "standard" option "--no-foo" along side a negatable "--foo"
Commits
-------
2954c9a238 Handle duplicate negatable options
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Console] Support binary / negatable options
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | Fix#24314
| License | MIT
| Doc PR | TODO
This PR take over #26292 to introduce a new option mode `NEGATABLE` that ease creation of option and their negation (ie. `--foo`, `--no-foo`)
Negated options applies only to flag options (`VALUE_NONE`)
```
./cli.php --foo
var_dump(getOption('foo')); // true
./cli.php --no-foo
var_dump(getOption('foo')); // false
```
Commits
-------
1a9a3c34c9 Implement negatable option
8d455dbd0c [WIP] Implements #24314: Support binary / negatable options, e.g. --foo and --no-foo.
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] do not break when loading schemas from network paths on Windows
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#24090
| License | MIT
| Doc PR |
Commits
-------
acbafe889d do not break when loading schemas from network paths on Windows
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[WebProfilerBundle] Possibility to dynamically set mode
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
Sometimes it is necessary to dynamically decide whether the debug toolbar should be injected or not.
Commits
-------
7c5cf579bb [WebProfilerBundle] Possibility to dynamically set mode
This PR was merged into the 4.4 branch.
Discussion
----------
[Finder] apply the sort callback on the whole search result
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#34879
| License | MIT
| Doc PR |
Commits
-------
126105146f apply the sort callback on the whole search result
