This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBundle] Restore the preview mechanism
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
follow up https://github.com/symfony/symfony/pull/34312
Commits
-------
d3f1121885 [TwigBundle] Restore the preview mechanism
* 3.4:
[HttpFoundation] fix guessing mime-types of files with leading dash
[Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances
Use constant time comparison in UriSigner
This PR was merged into the 5.0-dev branch.
Discussion
----------
Last cleanups before beta
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
61c7c11a32 Last cleanups before beta
This PR was merged into the 4.4 branch.
Discussion
----------
Sync UPGRADE-5.0 before beta
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
a247d319b9 Sync UPGRADE-5.0 before beta
This PR was merged into the 4.4 branch.
Discussion
----------
[ErrorHandler] merge and remove the ErrorRenderer component
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | yes
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This PR supersedes #34288.
Here is what it does:
- Merge the `ErrorRenderer` component into `ErrorHandler`
- Add `ErrorRendererInterface::render(\Throwable $e): FlattenException` and refactor error renderers around it.
- Add `FlattenException::setAsString()` to make the previous possible.
- Add `CliErrorRenderer` to render error on the CLI too. This means `VarDumper` is now a required dependency of `ErrorHandler`. This paves the way to use it also for rendering HTML - the logic there is much more advanced than what `HtmlErrorRenderer` provides and ever should provide.
- Make `BufferingLogger` map its collected logs to `error_log()` if they are not emptied before.
- Remove some classes that are not needed anymore (`ErrorRenderer`, `ErrorRendererPass`, `HtmlErrorRendererInterface`)
- Simplified the logic in `Debug::enable()` - nobody uses its arguments
- Fix a few issues found meanwhile.
With these changes, the component can be used standalone. One is now able to require only it, register it either with either `ErrorHandler::register()` or `Debug::enable()` and profit.
Commits
-------
d1bf1cada4 [ErrorHandler] help finish the PR
6c9157bbc2 [ErrorHandler] merge and remove the ErrorRenderer component
* 4.4:
bumped Symfony version to 4.3.8
updated VERSION for 4.3.7
updated CHANGELOG for 4.3.7
bumped Symfony version to 3.4.35
updated VERSION for 3.4.34
update CONTRIBUTORS for 3.4.34
updated CHANGELOG for 3.4.34
* 4.3:
bumped Symfony version to 4.3.8
updated VERSION for 4.3.7
updated CHANGELOG for 4.3.7
bumped Symfony version to 3.4.35
updated VERSION for 3.4.34
update CONTRIBUTORS for 3.4.34
updated CHANGELOG for 3.4.34
This PR was submitted for the master branch but it was merged into the 4.4 branch instead.
Discussion
----------
[HttpFoundation][Lock] Connection parameter corrected
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Connection parameter incorrectly specified. This variable doesn't exist, the data is in $connection instead.
Commits
-------
27207c3056 [HttpFoundation][Lock] Connection parameter corrected