This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix latest merge from 2.2 in 2.3
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes (Process tests are okay)
| License | MIT
Fix latest merge from 2.2 in 2.3, see #9182
Process tests are okay, an error in HttpKernel seems to occur
Commits
-------
b5e3576 [Process] Fix latest merge from 2.2 in 2.3
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9237).
Discussion
----------
[FrameworkBundle] assets:install command should mirror .dotfiles (.htaccess)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The `assets:install` command currently ignores all *.dotfiles* when mirroring the `Resources\public` folders of bundles. This can lead to issues when *.htaccess* files are required for some public assets (ie.: CORS headers for font files to be served via Cloudfront).
Since the assets being installed are clearly in a folder called `public`, we can safely assume that those files are in fact supposed to be accessible and copy them over with the normal files.
Commits
-------
9c884a0 [FrameworkBundle] assets:install command should mirror .dotfiles (.htaccess)
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9223).
Discussion
----------
[Translator] PoFileDumper - PO headers
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6765 - partially
| License | MIT
| Doc PR |
Po files should not be dumped without a header. It causes a lot of problems, including charset issues.
See #6765 / 1 for more info
Commits
-------
e93bc50 [Translator] PoFileDumper - PO headers
* 2.3:
[Process] Fix#9182 : random failure on pipes tests
Fixed propel guessed relations
[FramworkBundle][HttpKernel] Check event listener services are not abstract
fixed CS
Check for lock existence before unlinking
remove MinCount and MaxCount contraints. It has been replaced by Count constraints.
[FrameworkBundle] fixed path replacement on Windows
Conflicts:
src/Symfony/Bridge/Propel1/Tests/Form/PropelTypeGuesserTest.php
* 2.2:
[Process] Fix#9182 : random failure on pipes tests
Fixed propel guessed relations
[FramworkBundle][HttpKernel] Check event listener services are not abstract
fixed CS
Check for lock existence before unlinking
[FrameworkBundle] fixed path replacement on Windows
Conflicts:
src/Symfony/Component/Process/Process.php
This PR was merged into the 2.2 branch.
Discussion
----------
[Process][2.2] Fix 9182 : random failure on pipes tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9182
| License | MIT
I'm not a big fan of this fix, but - at least - it works.
With this code, finally, Process does not behave the same at all on Windows and Linux.
This patch does not smells very good but it solves the random failing test issue (that produced at runtime too).
Actually, calling `proc_get_status` within the waiting loop introduced the bug.
So this PR reverts to the previous behavior (consider a process running as long as pipes give data). On Windows, this is not the same behavior as we're not using streams but file handles. Whereas the feof of a stream is detected when the other side closes, the feof of a file handle can be reached at any time. So, on Windows, `proc_get_status` is called (checking the feof of the file handle might be positive until the executable outputs something), and we consider a process running as long as the information returned says it's running.
We could think of decouple windows and linux logic in two separated objects, using the interfaces I introduced in #8753. This could bring much more readability and make the code more easy to understand.
Commits
-------
64a0b40 [Process] Fix#9182 : random failure on pipes tests
This PR was merged into the master branch.
Discussion
----------
[Form] fix missing use statement for exception UnexpectedTypeException
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? |
| Fixed tickets |
| License | MIT
| Doc PR |
fix missing use statement for exception `Symfony\Component\Form\Exception\UnexpectedTypeException`
cc @bschussek
Commits
-------
ea91533 [form] fix missing use statement for exception UnexpectedTypeException
This PR was merged into the master branch.
Discussion
----------
[Security\Csrf] Split CsrfTokenGenerator into CsrfTokenManager and TokenGenerator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9210
| License | MIT
| Doc PR | -
This is a follow-up PR of #6554 that splits the CsrfTokenGenerator into two separate classes for generating and managing CSRF tokens. As a consequence, it is now possible to explicitly remove or refresh CSRF tokens if they should be used only once. See #9210 for more information.
Commits
-------
d4bb5f4 [Security\Csrf] Split CsrfTokenGenerator into CsrfTokenManager and TokenGenerator
This PR was merged into the 2.2 branch.
Discussion
----------
[Bridge] [Propel1] Fixed guessed relations
<table>
<tr><th>Q</th><th>A</th></tr>
<tr><td>Bug fix</td><td>yes</td></tr>
<tr><td>Feature addition</td><td>no</td></tr>
<tr><td>Backwards compatibility break</td><td>no</td></tr>
<tr><td>Symfony2 tests pass</td><td>yes</td></tr>
<tr><td>Fixes the following tickets</td><td>N/A</td></tr>
<tr><td>Todo</td><td>N/A</td></tr>
<tr><td>License of the code</td><td>MIT</td></tr>
<tr><td>Documentation PR</td><td>N/A</td></tr>
</table>
The `PropelTypeGuesser` did not match OneToMany relations properly. For example if you have a `Author` class with `Comments` attributes the guesser would guess "Comment" instead of "Comments".
I added some tests to ensure the non regression.
Commits
-------
0b1e95f Fixed propel guessed relations
This PR was squashed before being merged into the master branch (closes#9199).
Discussion
----------
[FrameworkBundle] Adds the possibility to register Commands via the DIC
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | don't now
| Fixed tickets | #8166
| License | MIT
| Doc PR | symfony/symfony-docs#3031
Todo:
* [x] Documentation
* [x] Clean code (add type hinting)
* [x] Add tests
Commits
-------
cabb1fa [FrameworkBundle] Adds the possibility to register Commands via the DIC
This PR was merged into the 2.2 branch.
Discussion
----------
[FramworkBundle] Check event listener services are not abstract
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
6744ead [FramworkBundle][HttpKernel] Check event listener services are not abstract
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9207).
Discussion
----------
[HttpKernel] Check for lock existence before unlinking
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
My logs are filled with a bazillion errors stating "Warning: unlink(/var/www/mysite/app/cache/prod/http_cache/md/cf/47/c693da5dab3eccb65fa36a9b4b07ad0f7cc4.lck): No such file or directory in /var/www/mysite/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/Store.php line 53"
Commits
-------
89cd3b9 Check for lock existence before unlinking
My logs are filled with a bazillion errors stating "Warning: unlink(/var/www/mysite/app/cache/prod/http_cache/md/cf/47/c693da5dab3eccb65fa36a9b4b07ad0f7cc4.lck): No such file or directory in /var/www/mysite/vendor/symfony/symfony/src/Symfony/Component/HttpKernel/HttpCache/Store.php line 53"
This PR was merged into the master branch.
Discussion
----------
[Form] Add a 'submitted' attribute to the form view
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | symfony/symfony-docs#3029
Basically, the use case of this PR is to determine in the view if a form has been validated by the validator. By default, the valid attribute is true and we can't know if the form has been submitted. Now, we can use `form.vars.submitted && form.vars.valid`.
Commits
-------
a386c74 [Form] Add a 'submitted' attribute to the form view
This PR was merged into the master branch.
Discussion
----------
[ExpressionLanguage] replaced the =~ operator by matches (removed the != operator)
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
To be consistent with fabpot/Twig#1209
Commits
-------
4c2d2e2 [ExpressionLanguage] replaced the =~ operator by matches (removed the != operator)
This PR was merged into the master branch.
Discussion
----------
[WIP] [FrameworkBundle] fixed container:debug and router:debug commands
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
#7887 is buggy as hell :(
Commits
-------
fe5961a [FrameworkBundle] moved router:debug and container:debug to use the compact layout
bd16157 [FrameworkBundle] changed JSON descriptors to be more readable on PHP 5.4+
1d210f8 [FrameworkBundle] changed the router:debug to use the shortcut notation for the controller
d997dfa [FrameworkBundle] fixed container:debug and router:debug commands