diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
23,292 Commits 24 Branches 563 Tags 228 MiB
99de3fd49d
Commit Graph

23292 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Fabien Potencier
2dc28eaaf0 bug #16152 Fix URL validator failure with empty string (fabpot, bocharsky-bw) 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix URL validator failure with empty string

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15898
| License       | MIT
| Doc PR        | ~

Fix validator failure if method `__toString` of passed object return an empty string.

Commits
-------

e0910d9 Fix URL validator failure with empty string
0f61859 [Validator] added a failing test
 2015-10-06 19:41:54 +02:00
Nicolas Grekas
72365716c2 Merge branch '2.7' into 2.8 
Conflicts:
	src/Symfony/Component/Security/Http/Tests/RememberMe/PersistentTokenBasedRememberMeServicesTest.php
	src/Symfony/Component/Security/Http/Tests/RememberMe/TokenBasedRememberMeServicesTest.php
	src/Symfony/Component/Security/composer.json
 2015-10-06 19:12:59 +02:00
Victor Bocharsky
e0910d9f49 Fix URL validator failure with empty string 2015-10-06 18:40:02 +02:00
Fabien Potencier
0f61859679 [Validator] added a failing test 2015-10-06 18:38:49 +02:00
Fabien Potencier
a1c7af1fbf feature #16001 [DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService() (nicolas-grekas) 
This PR was merged into the 2.8 branch.

Discussion
----------

[DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The new feature is in the DI component and it enlighten a deprecation from Doctrine that we ignored in FrameworkBundle, that is also fixed in this PR.

See https://github.com/symfony/symfony/pull/16001/files?w=1

Commits
-------

ca69fa3 [DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService()
 2015-10-06 18:29:07 +02:00
Fabien Potencier
f72a7c39b2 feature #16107 [3.0] Various deprecations cleanups (nicolas-grekas) 
This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0] Various deprecations cleanups

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

534a91c [3.0] Various deprecations cleanups
 2015-10-06 18:26:24 +02:00
Fabien Potencier
45a5b005d5 minor #16147 [VarDumper] consistent signature of getDump() in class + trait (xabbuh) 
This PR was merged into the 2.8 branch.

Discussion
----------

[VarDumper] consistent signature of getDump() in class + trait

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16126
| License       | MIT
| Doc PR        |

Commits
-------

48a9e83 consistent signature of getDump() in class + trait
 2015-10-06 18:18:14 +02:00
Fabien Potencier
5aa1233d0b minor #16151 [FrameworkBundle][VarDumper] tweak some deprecation messages (xabbuh) 
This PR was merged into the 2.8 branch.

Discussion
----------

[FrameworkBundle][VarDumper] tweak some deprecation messages

| Q             | A
| ------------- | ---
| Fixed tickets | #16129, #16135
| License       | MIT

I was a bit too slow with reviewing.

Commits
-------

536045f tweak some deprecation messages
 2015-10-06 18:15:19 +02:00
Christian Flothmann
536045f865 tweak some deprecation messages 2015-10-06 17:57:37 +02:00
Fabien Potencier
1c43a4e622 fixed CS 2015-10-06 17:46:46 +02:00
Fabien Potencier
d93e513707 minor #16135 [FrameworkBundle] [Routing] DelegatingLoader: deprecate logger argument (ogizanagi) 
This PR was merged into the 2.8 branch.

Discussion
----------

[FrameworkBundle] [Routing] DelegatingLoader: deprecate logger argument

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related to #16117

Commits
-------

af0eba7 [FrameworkBundle] [Routing] DelegatingLoader: deprecate logger argument
 2015-10-06 17:46:11 +02:00
Fabien Potencier
21e50d59ca feature #14044 [Console] [Helper] [Table] Columns styles (MAXakaWIZARD) 
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #14044).

Discussion
----------

[Console] [Helper] [Table] Columns styles

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR introduces ability to set styles for individual columns in table. For example, we can apply STR_PAD_LEFT for the last column (useful for money, file size etc).

Code:
```php
use Symfony\Component\Finder\Finder;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Helper\TableStyle;

$table = new Table($output);
$table->setHeaders(['#', 'Path', 'Size']);

$style = new TableStyle();
$style->setPadType(STR_PAD_LEFT);

$table->setColumnStyle(2, $style);

$finder = new Finder();
$finder->files()->in("/path/to/dir")->name('*.php')
$counter = 0;
foreach ($finder as $file) {
    $counter++;
    $table->addRow([$counter, $file->getRealPath(), number_format($file->getSize(), 0, '.', ' ')]);
}

$table->render();
```
Output:
```
+---+---------------------+--------+
| # | Path                |   Size |
+---+---------------------+--------+
| 1 | autoload.php        |    183 |
| 2 | ApplicationTest.php | 47 794 |
| 3 | CommandTest.php     | 14 965 |
| 4 | ListCommandTest.php |  2 369 |
+---+---------------------+--------+
```

Commits
-------

668c502 [Console] [Helper] [Table] Add ability to set styles for individual columns
 2015-10-06 17:25:52 +02:00
MAXakaWIZARD
668c502982 [Console] [Helper] [Table] Add ability to set styles for individual columns 2015-10-06 17:25:39 +02:00
ogizanagi
af0eba7d26 [FrameworkBundle] [Routing] DelegatingLoader: deprecate logger argument 2015-10-06 17:24:04 +02:00
Fabien Potencier
07e1d25b6b bug #15121 fixed #15118 [Filesystem] mirroring a symlink copies absolute file path (danepowell) 
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #15121).

Discussion
----------

fixed #15118 [Filesystem] mirroring a symlink copies absolute file path

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15118
| License       | MIT
| Doc PR        |

This reverts the code change in a8b8d33e94 and adjusting the test case accordingly.

Commits
-------

a83d525 fixed #15118 [Filesystem] mirroring a symlink copies absolute file path
 2015-10-06 17:23:29 +02:00
Dane Powell
a83d525b90 fixed #15118 [Filesystem] mirroring a symlink copies absolute file path 2015-10-06 17:23:28 +02:00
Fabien Potencier
2a0f6fbea3 bug #15161 avoid duplicated path with addPrefix (remicollet) 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #15161).

Discussion
----------

avoid duplicated path with addPrefix

 Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | [n/a
| License       | MIT
| Doc PR        | n/a

Having UniversalClassLoader deprecated raise various issues... and ClassLoader doesn't provide the same features... :(

This one avoid duplication of paths for a given prefix, so can improve perf is such case.

Notice: I open this PR against 2.7, first version where UniversalClassLoader is deprecated, but feel free to apply only if 2.8 or 3.0, as you prefer.

Context on how this class is used in various fedora packages, see
http://blog.remirepo.net/post/2015/06/30/PHP-SIG-autoloader

Commits
-------

af420c1 avoid duplicated path with addPrefix
 2015-10-06 17:11:44 +02:00
Remi Collet
af420c120d avoid duplicated path with addPrefix 2015-10-06 17:11:44 +02:00
Fabien Potencier
380e2ba103 minor #16131 [2.7] Fix docblocks about callables (nicolas-grekas) 
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Fix docblocks about callables

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7b12fe9 [2.7] Fix docblocks about callables
 2015-10-06 17:07:22 +02:00
Nicolas Grekas
b362c961f7 Merge branch '2.3' into 2.7 
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
	src/Symfony/Component/Security/Tests/Core/SecurityContextTest.php
 2015-10-06 17:02:37 +02:00
Fabien Potencier
dd385402ec bug #16146 [Security] sync translations and add a test for it (xabbuh) 
This PR was merged into the 2.7 branch.

Discussion
----------

[Security] sync translations and add a test for it

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15955
| License       | MIT
| Doc PR        |

Commits
-------

08333ec [Security] sync translations and add a test for it
 2015-10-06 16:57:43 +02:00
Christian Flothmann
08333ecb11 [Security] sync translations and add a test for it 2015-10-06 16:47:20 +02:00
Fabien Potencier
2539af63ad minor #16145 [FrameworkBundle] Fix deps=low/high tests (nicolas-grekas) 
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fix deps=low/high tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

26ca3dc [FrameworkBundle] Fix deps=low/high tests
 2015-10-06 16:42:38 +02:00
Fabien Potencier
4d57d587c1 minor #14491 [2.3][SECURITY] Add remember me cookie configuration (klaascuvelier) 
This PR was squashed before being merged into the 2.3 branch (closes #14491).

Discussion
----------

[2.3][SECURITY] Add remember me cookie configuration

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14490
| License       | MIT
| Doc PR        |

Commits
-------

e8f0e5a [2.3][SECURITY] Add remember me cookie configuration
 2015-10-06 16:28:56 +02:00
Klaas Cuvelier
e8f0e5afd8 [2.3][SECURITY] Add remember me cookie configuration 2015-10-06 16:28:55 +02:00
Nicolas Grekas
26ca3dc6c2 [FrameworkBundle] Fix deps=low/high tests 2015-10-06 16:14:42 +02:00
Christian Flothmann
48a9e83e4b consistent signature of getDump() in class + trait 2015-10-06 15:57:27 +02:00
Nicolas Grekas
99bf879559 Merge branch '2.3' into 2.7 2015-10-06 14:56:09 +02:00
Nicolas Grekas
2b35f38d06 minor #16141 [FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading (ogizanagi) 
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #16139, #16133
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony/pull/16139#discussion_r41238804.

I think the most efficient solution is to remove translations from `Security/Core` in 2.3 only (should not be propagated to newest branches!) and load both folders if they exist.

Commits
-------

1ed07a0 [FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading
 2015-10-06 14:54:17 +02:00
maxime.steinhausser
1ed07a09d8 [FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading 2015-10-06 14:29:32 +02:00
Nicolas Grekas
8d3bf0348e [Console] Fix merge 2015-10-06 10:54:15 +02:00
Nicolas Grekas
04f1363bfb Merge branch '2.3' into 2.7 2015-10-06 10:50:12 +02:00
Nicolas Grekas
ea10f2415e minor #16139 [FrameworkBundle] Fix translations dir discovery (nicolas-grekas) 
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fix translations dir discovery

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16133
| License       | MIT
| Doc PR        | -

Commits
-------

f37ceef [FrameworkBundle] Fix translations dir discovery
 2015-10-06 10:49:56 +02:00
Nicolas Grekas
f37ceef819 [FrameworkBundle] Fix translations dir discovery 2015-10-06 10:41:18 +02:00
Nicolas Grekas
209047ea79 Merge branch '2.3' into 2.7 
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
	src/Symfony/Bundle/SecurityBundle/composer.json
	src/Symfony/Component/Process/Process.php
 2015-10-06 10:31:51 +02:00
Nicolas Grekas
59d8220724 minor #16138 [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821 (nicolas-grekas) 
This PR was merged into the 2.3 branch.

Discussion
----------

[Security\Core] Fix test failure after sebastianbergmann/phpunit#1821

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16112
| License       | MIT
| Doc PR        | -

See sebastianbergmann/phpunit#1821

Commits
-------

742547c [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821
 2015-10-06 10:21:54 +02:00
Nicolas Grekas
742547c099 [Security\Core] Fix test failure after sebastianbergmann/phpunit#1821 2015-10-06 09:59:00 +02:00
Nicolas Grekas
ca69fa340c [DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService() 2015-10-06 09:36:27 +02:00
Nicolas Grekas
7b12fe982b [2.7] Fix docblocks about callables 2015-10-06 09:34:35 +02:00
Nicolas Grekas
534a91cf54 [3.0] Various deprecations cleanups 2015-10-06 09:31:12 +02:00
Fabien Potencier
1f2a51106f minor #16130 Fix docblocks about callables (nicolas-grekas) 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix docblocks about callables

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

a25beb6 Fix docblocks about callables
 2015-10-06 08:16:33 +02:00
Fabien Potencier
8b15af9864 feature #16125 Replace is_callable checks with type hints (mpajunen, nicolas-grekas) 
This PR was merged into the 3.0-dev branch.

Discussion
----------

Replace is_callable checks with type hints

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |  #14330
| License       | MIT
| Doc PR        | -

Also removes tests checking the exceptions thrown from
the removed is_callable checks.

Commits
-------

7685cdd Add more callable type hints
4e0c6e1 Replace is_callable checks with type hints
 2015-10-06 08:09:31 +02:00
Fabien Potencier
b6ab750e18 minor #16129 [VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster (nicolas-grekas) 
This PR was merged into the 2.8 branch.

Discussion
----------

[VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

02b86b0 [VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster
 2015-10-06 08:07:09 +02:00
Fabien Potencier
fd75cfe076 bug #16133 compatibility with Security component split (xabbuh) 
This PR was merged into the 2.3 branch.

Discussion
----------

compatibility with Security component split

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The FrameworkBundle in version 2.3 can be used with recent versions of
the Security component. However, after the Security component has been
split with Symfony 2.4, translations resources have been moved to the
`symfony/security-core` package. Thus, the changed location must be
taken into account.

Commits
-------

7bc836c compatibility with Security component split
 2015-10-06 08:04:40 +02:00
Nicolas Grekas
02b86b0555 [VarDumper] Move $prev as 1st argument in ThrowingCasterException::__construct, removing $caster 2015-10-06 07:54:52 +02:00
Christian Flothmann
7bc836cc72 compatibility with Security component split 
The FrameworkBundle in version 2.3 can be used with recent versions of
the Security component. However, after the Security component has been
split with Symfony 2.4, translations resources have been moved to the
`symfony/security-core` package. Thus, the changed location must be
taken into account.
 2015-10-05 23:08:59 +02:00
Fabien Potencier
136722c9b0 bug #16123 Command list ordering fix (spdionis, fabpot) 
This PR was merged into the 2.3 branch.

Discussion
----------

Command list ordering fix

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT

Makes sure that global commands are always first.

Commits
-------

2984f8e fixed previous commit
70f2b3e global commands are always first in command list
 2015-10-05 22:39:07 +02:00
Fabien Potencier
416d6eb9dd minor #16132 [SecurityBundle] Remove duplicated require-dev (ogizanagi) 
This PR was merged into the 2.3 branch.

Discussion
----------

[SecurityBundle] Remove duplicated require-dev

| Q             | A
| ------------- | ---
| Fixed tickets | -
| License       | MIT

Commits
-------

1ecbc67 [SecurityBundle] Remove duplicated require-dev
 2015-10-05 21:22:37 +02:00
ogizanagi
1ecbc67238 [SecurityBundle] Remove duplicated require-dev 2015-10-05 19:46:50 +02:00
Nicolas Grekas
a25beb623d Fix docblocks about callables 2015-10-05 19:32:31 +02:00