Commit Graph

4619 Commits

Author SHA1 Message Date
Andrea Ruggiero
9e6baee9f3
Remove full head content in HTML to text converter
When extracting text from HTML part all the content between opening and closing tag should be removed
2021-01-04 22:15:57 +01:00
Christian Flothmann
89fedfa9e9 fix code style 2021-01-04 16:15:05 +01:00
Nicolas Grekas
5ec2a252ee [ProxyManager] fix tests 2021-01-04 12:30:20 +01:00
Fabien Potencier
2c4337ae5b Bump license year 2021-01-01 10:24:35 +01:00
Nicolas Grekas
cd0db690f8 [ProxyManagerBridge] Fix tests 2020-12-28 22:45:17 +01:00
Alexander M. Turek
07c4773d98 CS: Apply ternary_to_null_coalescing fixer 2020-12-27 00:49:32 +01:00
Nicolas Grekas
8b3c1a1edf minor #39614 Add missing @return annotations to fix deprecations on PHP 8 (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

Add missing `@return` annotations to fix deprecations on PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

3ffe5573e9 Add missing `@return` annotations to fix deprecations on PHP 8
2020-12-23 16:21:09 +01:00
Nicolas Grekas
3ffe5573e9 Add missing @return annotations to fix deprecations on PHP 8 2020-12-23 16:11:26 +01:00
Nicolas Grekas
389f5304c7 [ProxyManagerBridge] fix PHP notice, switch to "friendsofphp/proxy-manager-lts" 2020-12-22 17:08:05 +01:00
Nicolas Grekas
698dadccb1 minor #39497 [PhpUnitBridge] [phpunit] Stop using deprecated trait (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] [phpunit] Stop using deprecated trait

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

the `SetUpTearDownTrait` trait has been removed in #39487 this PR remove usage of it in branch 4.4

Commits
-------

55ed00cd3c Stop using deprecated trait
2020-12-14 17:15:46 +01:00
Jérémy Derussé
55ed00cd3c
Stop using deprecated trait 2020-12-14 16:50:10 +01:00
Nicolas Grekas
510623f890 minor #39421 [PhpUnitBridge] Lint files with PHP 5.5 (derrabus)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Lint files with PHP 5.5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

I'd like to make sure that PhpUnitBridge remains compatible with PHP 5.5.

cc @nicolas-grekas @fancyweb

Commits
-------

0bc15ff759 [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 16:00:54 +01:00
Alexander M. Turek
0bc15ff759 [PhpUnitBridge] Lint files with PHP 5.5 2020-12-14 16:00:48 +01:00
Oskar Stark
94f823fd4a Remove void return type from test methods 2020-12-11 13:39:31 +01:00
Jérémy Derussé
a46cff26c6
Fix CS in changelogs 2020-12-10 17:34:26 +01:00
Nicolas Grekas
52a0233905 [PhpUnitBridge] CS fix 2020-12-09 19:44:45 +01:00
Thomas Calvet
fe7abcd1e9 [PhpUnitBridge] Fix PHP 5.5 compatibility 2020-12-09 17:54:32 +01:00
Nicolas Grekas
236400c03a [PhpUnitBridge] Fix CS for PHP 5.5 2020-12-08 18:05:36 +01:00
Nicolas Grekas
ff22d30cb0 Apply "visibility_required" CS rule to constants
php-cs-fixer fix --rules='{"visibility_required": ["property", "method", "const"]}'
2020-12-08 17:59:59 +01:00
Nicolas Grekas
cba70a6547 bug #39226 [PhpUnitBridge] Fix disabling DeprecationErrorHandler from PHPUnit configuration file (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] Fix disabling DeprecationErrorHandler from PHPUnit configuration file

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/38239
| License       | MIT
| Doc PR        | -

The linked issue description is right, the bridge's bootstrap is hit before the env variables from the phpunit.xml file are read and set. So the easiest solution is to read it ourselves in the root script (like we already do for some of them).

Commits
-------

41158b8878 [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file
2020-12-08 12:21:32 +01:00
Wouter de Jong
5134de52f1 Added compatibility with PHPunit 9.5 2020-12-05 16:15:30 +01:00
Thomas Calvet
41158b8878 [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file 2020-11-30 09:16:37 +01:00
Fabien Potencier
1fb80e7cf0 bug #39099 [Form] ignore the pattern attribute for textareas (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] ignore the pattern attribute for textareas

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39066
| License       | MIT
| Doc PR        |

Commits
-------

e7698e7434 ignore the pattern attribute for textareas
2020-11-27 07:20:55 +01:00
Thomas Calvet
dff539434e [PhpUnitBridge] Fix qualification of deprecations triggered by the debug class loader 2020-11-26 18:48:00 +01:00
Alexander M. Turek
1f0a27a732 Merge branch '3.4' into 4.4
* 3.4:
  Minor : Removed typo (extra "the" term)
  [PhpUnitBridge] Fix test fixture file name
2020-11-17 20:45:34 +01:00
Christian Flothmann
e7698e7434 ignore the pattern attribute for textareas 2020-11-17 17:25:11 +01:00
Thomas Calvet
c5a107e4cc [PhpUnitBridge] Fix test fixture file name 2020-11-13 17:28:59 +01:00
Nicolas Grekas
ecf9859609 [ProxyManagerBridge] fix tests 2020-11-12 14:19:35 +01:00
Nicolas Grekas
47041370c0 [ProxyManagerBridge] relax fixture in tests 2020-11-12 13:55:13 +01:00
Christian Flothmann
cdfa9c2d8b Merge branch '3.4' into 4.4
* 3.4:
  failing test for issue 38861
  [DoctrineBridge]  indexBy could reference to association columns
2020-11-09 20:21:10 +01:00
Bart Wach
f9a0e000e9 failing test for issue 38861 2020-11-09 18:46:57 +01:00
Juan Miguel Besada
4c36145664 [DoctrineBridge] indexBy could reference to association columns 2020-11-09 18:41:59 +01:00
Christian Flothmann
784bd0080d also reset id readers 2020-11-09 09:59:19 +01:00
Alexander M. Turek
969da48c98 [DoctrineBridge] Fix DBAL deprecations in middlewares. 2020-11-07 15:21:55 +01:00
Nicolas Grekas
5f77aad6ca [ProxyManagerBridge] replace ProxyManager\Version by feature detection 2020-11-06 15:18:27 +01:00
Nicolas Grekas
6fe261a7ae fix typo 2020-11-03 13:14:11 +01:00
Nicolas Grekas
703497dccf bug #38971 [PhpUnitBridge] fix replaying skipped tests (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix replaying skipped tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while working on https://github.com/symfony/polyfill/pull/310

See also https://3v4l.org/D6Gro for the newly skipped tests in symfony/intl

Commits
-------

849d1b3845 [PhpUnitBridge] fix replaying skipped tests
2020-11-03 12:57:46 +01:00
Nicolas Grekas
849d1b3845 [PhpUnitBridge] fix replaying skipped tests 2020-11-03 12:50:26 +01:00
Nicolas Grekas
ca9ef822cf bug #38921 [PHPUnitBridge] Fixed crash on Windows with PHP 8 (villfa)
This PR was merged into the 4.4 branch.

Discussion
----------

[PHPUnitBridge] Fixed crash on Windows with PHP 8

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

The install command crashed with the message "The filename, directory name, or volume label syntax is incorrect.".
It happens only on Windows with PHP 8.

Probably due to https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L1121-L1123

I have a small repo to show the problem and how it is fixed: https://github.com/villfa/test-phpunit-bridge

Commits
-------

4b958917fd [PHPUnitBridge] Fixed crash on Windows with PHP 8
2020-11-02 16:07:32 +01:00
Alexander M. Turek
43ce6dfe44 Set constant visibility in tests to private where possible. 2020-10-31 23:44:29 +01:00
Fabien Villepinte
4b958917fd [PHPUnitBridge] Fixed crash on Windows with PHP 8
The install command crashed with the message
"The filename, directory name, or volume label syntax is incorrect.".
It happens only on Windows with PHP 8.

Probably due to https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L1121-L1123
2020-10-31 13:49:56 +00:00
Andreas Braun
ecb477952a
Fix wrong check for exporter in ConstraintTrait 2020-10-30 14:45:28 +01:00
Alexander M. Turek
659decf594 Use short array deconstruction syntax. 2020-10-28 21:42:29 +01:00
Grégoire Paris
f0605b8137
Use createMock() rather than createStub()
The CI is not using a recent enough version of PHPUnit for that
2020-10-28 19:29:55 +01:00
Grégoire Paris
ed80bcc82c
Remove dependency on doctrine/reflection
That package is being phased out, and there are good chances that the
classes involved at runtime are completely different from the classes
involved in the test changed in that commit. That test was the only
piece of code I could find still referencing the
Doctrine\Common\Reflection namespace.
2020-10-28 19:09:12 +01:00
Nicolas Grekas
4b36736e91 minor #38838 [ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions" (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions"

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

As highlighted by our CI, `ocramius/proxy-manager` cannot be installed on PHP 7.3 using composer 2 because of broken versioning policies:
![image](https://user-images.githubusercontent.com/243674/97278564-37e73080-183a-11eb-885c-7b3cc07c26af.png)

Fortunately, the package that causes all this mess (`ocramius/package-versions`) has been forked precisely to work around these broken policies.

Requiring this fork allows resolving the dependencies properly.

Commits
-------

8cf60c4ab7 [ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions"
2020-10-27 12:56:04 +01:00
Nicolas Grekas
8cf60c4ab7 [ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions" 2020-10-27 09:50:57 +01:00
Alexander M. Turek
9f322091c8 Bump default PHPUnit version for PHP 8 to 9.4. 2020-10-24 14:35:18 +02:00
Nicolas Grekas
2c4dff8461 fix merge 2020-10-24 13:56:22 +02:00
Nicolas Grekas
77aa17401d Merge branch '3.4' into 4.4
* 3.4:
  Remove branch-version (keep them for contracts only)
  [Serializer] fix decoding float XML attributes starting with 0
  add missing dutch translations
  [Validator] Add missing romanian translations
  do not translate null placeholders or titles
2020-10-24 13:50:19 +02:00