Commit Graph

46515 Commits

Author SHA1 Message Date
Christian Flothmann
93685026b0 drop return type declaration
The configured memory limit can exceed the range that can be represented
by an integer.
2019-11-22 14:14:59 +01:00
Christian Flothmann
0acaa5cfb3 definitions are valid objects 2019-11-22 13:53:53 +01:00
Christian Flothmann
bedad35e59 remove return type declaration from __sleep() 2019-11-22 13:40:21 +01:00
Fabien Potencier
dab6732f39 minor #34475 [Mailer] Add UPGRADE entries about Envelope and MessageEvent (chapa)
This PR was squashed before being merged into the 5.1-dev branch (closes #34475).

Discussion
----------

[Mailer] Add UPGRADE entries about Envelope and MessageEvent

* Class `SmtpEnvelope` has been renamed to `Envelope` in #33562
* A required `$transport` argument has been added to `MessageEvent` in  #32927

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | already up-to-date

Commits
-------

7baa2951f1 [Mailer] Add UPGRADE entries about Envelope and MessageEvent
2019-11-22 08:11:22 +01:00
Mickaël
7baa2951f1 [Mailer] Add UPGRADE entries about Envelope and MessageEvent 2019-11-22 08:11:17 +01:00
Thomas Calvet
59d677182e [FrameworkBundle][ContainerLint] Keep removing compiler passes 2019-11-21 23:20:32 +01:00
Samuel ROZE
bfae515d52 bug #34474 [Messenger] Ignore stamps in in-memory transport (tienvx)
This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Ignore stamps in in-memory transport

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | N/A <!-- required for new features -->

Stamps can be added/removed to/from message during handling. Ignore stamps so that we can ack/reject them correctly.

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

b435b1aab6 [Messenger] Ignore stamps in in-memory transport
2019-11-21 18:00:24 +01:00
Thomas Calvet
dfdcbb401e [TwigBridge] Add row_attr to all form themes 2019-11-21 14:34:54 +01:00
tien.xuan.vo
b435b1aab6 [Messenger] Ignore stamps in in-memory transport 2019-11-21 19:55:17 +07:00
Anto
d4f749a465
[Serializer] Fix MetadataAwareNameConverter usage with string group
fixes 34455
2019-11-21 13:47:16 +01:00
Fabien Potencier
255f557a30 Bump Symfony version to 5.0.1 2019-11-21 09:56:56 +01:00
Fabien Potencier
ea815ba986
Merge pull request #34472 from fabpot/release-5.0.0
released v5.0.0
2019-11-21 09:51:27 +01:00
Fabien Potencier
bac8c50706 Update VERSION for 5.0.0 2019-11-21 09:51:01 +01:00
Fabien Potencier
09220f9fde Update CHANGELOG for 5.0.0 2019-11-21 09:50:28 +01:00
Fabien Potencier
a7fe2b29d2 Bump Symfony version to 4.4.1 2019-11-21 08:13:22 +01:00
Fabien Potencier
625a4dbfda
Merge pull request #34471 from fabpot/release-4.4.0
released v4.4.0
2019-11-21 08:08:41 +01:00
Fabien Potencier
65ec3b47e8 Update VERSION for 4.4.0 2019-11-21 08:08:15 +01:00
Fabien Potencier
90cb32a044 Update CHANGELOG for 4.4.0 2019-11-21 08:07:51 +01:00
Nicolas Grekas
1b4ab81085 Merge branch '5.0'
* 5.0:
  [Routing] fix tests
  [DI] minor cleanup
  [Form] group constraints when calling the validator
  Remove wrong @group legacy annotations
  [DependencyInjection] Fix dumping multiple deprecated aliases
  allow button names to start with uppercase letter
  Allow PHP ^7.2.5
  States that the HttpClient provides a Http Async implementation
  [Routing] Fix ContainerLoader and ObjectLoaderTest
  [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit
  [HttpKernel] Drop deprecated ExceptionListener
  Removed extra whitespace
  [Security] Fix best encoder not wired using migrate_from
2019-11-21 08:02:52 +01:00
Nicolas Grekas
0f8fe5d74b Merge branch '4.4' into 5.0
* 4.4:
  [Routing] fix tests
  [Form] group constraints when calling the validator
  Remove wrong @group legacy annotations
  [DependencyInjection] Fix dumping multiple deprecated aliases
  allow button names to start with uppercase letter
  States that the HttpClient provides a Http Async implementation
2019-11-21 08:02:40 +01:00
Nicolas Grekas
2c1b1bad6e bug #34464 [Form] group constraints when calling the validator (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] group constraints when calling the validator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up of https://github.com/symfony/symfony/pull/34081
Spotted during the workshop at SymfonyCon, while trying to fix deprecation notices on symfony-demo:
the Form component currently passes constraints one by one for validation, effectively preventing the validator from taking care of cross-constraints dependencies.

This PR fixes it.

This will prevent ppl from having to fix things like
> Using the "Symfony\Component\Validator\Constraints\Length" constraint with the "min" option without setting the "allowEmptyString" one is deprecated and defaults to true. In 5.0, it will become optional and default to false.

Commits
-------

d15f77f33e [Form] group constraints when calling the validator
2019-11-21 08:01:17 +01:00
Nicolas Grekas
698cc6bb3b [Routing] fix tests 2019-11-20 14:44:34 +01:00
Nicolas Grekas
c41fa26069 [DI] minor cleanup 2019-11-20 14:33:09 +01:00
Nicolas Grekas
6f110581df Merge branch '4.3' into 4.4
* 4.3:
  [DependencyInjection] Fix dumping multiple deprecated aliases
2019-11-20 14:27:43 +01:00
Nicolas Grekas
1b2651cefd minor #34433 Remove wrong @group legacy annotations (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

Remove wrong @group legacy annotations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

These annotations are still found on branch 5.0.
Does this mean they are wrong? Why don't they make 5.0 fail if not?

Commits
-------

8d84ac34a5 Remove wrong @group legacy annotations
2019-11-20 14:26:58 +01:00
Nicolas Grekas
d15f77f33e [Form] group constraints when calling the validator 2019-11-20 13:58:23 +01:00
Fabien Potencier
9624a444d4 minor #34443 Allow PHP ^7.2.5 (nicolas-grekas)
This PR was merged into the 5.0 branch.

Discussion
----------

Allow PHP ^7.2.5

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34442
| License       | MIT
| Doc PR        | -

Let's what the CI says.

Will need tagging all contracts as v2.0.1 after merge.

Commits
-------

6194c2a96c Allow PHP ^7.2.5
2019-11-20 12:12:35 +01:00
Nicolas Grekas
8d84ac34a5 Remove wrong @group legacy annotations 2019-11-20 11:44:55 +01:00
Fabien Potencier
996d8a708f bug #34451 [DependencyInjection] Fix dumping multiple deprecated aliases (shyim)
This PR was merged into the 4.3 branch.

Discussion
----------

[DependencyInjection] Fix dumping multiple deprecated aliases

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Only the last deprecated alias wins, cause the content will not appended

Commits
-------

60b0dae174 [DependencyInjection] Fix dumping multiple deprecated aliases
2019-11-20 06:36:40 +01:00
Maxime Steinhausser
8d1f32613b [Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls 2019-11-19 17:21:35 +01:00
Soner Sayakci
60b0dae174
[DependencyInjection] Fix dumping multiple deprecated aliases 2019-11-19 16:12:52 +01:00
Nicolas Grekas
12f00e3e15 Merge branch '4.3' into 4.4
* 4.3:
  allow button names to start with uppercase letter
2019-11-19 13:20:06 +01:00
Fabien Potencier
a7c66dbfb3 bug #34448 [Form] allow button names to start with uppercase letter (xabbuh)
This PR was merged into the 4.3 branch.

Discussion
----------

[Form] allow button names to start with uppercase letter

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

d811b0e9b5 allow button names to start with uppercase letter
2019-11-19 10:59:07 +01:00
Christian Flothmann
d811b0e9b5 allow button names to start with uppercase letter 2019-11-19 08:55:12 +01:00
Fabien Potencier
123c84a9dd bug #34434 [Routing] Fix ContainerLoader and ObjectLoaderTest (fancyweb)
This PR was merged into the 5.0 branch.

Discussion
----------

[Routing] Fix ContainerLoader and ObjectLoaderTest

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

0e5db6a033 [Routing] Fix ContainerLoader and ObjectLoaderTest
2019-11-19 06:52:41 +01:00
Fabien Potencier
bf8e444c2b minor #34435 States that the HttpClient provides a Http Async implementation (Taluu)
This PR was merged into the 4.4 branch.

Discussion
----------

States that the HttpClient provides a Http Async implementation

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no (not really)
| New feature?  | no (not really)
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Add in the composer.json of the HttpClient that it now provides an implementation for the `php-http/async-client-implementation` virtual package, as @Nyholm did the implementation on the HttpPlug bridge in #33743.

Commits
-------

8a460cefef States that the HttpClient provides a Http Async implementation
2019-11-19 06:46:23 +01:00
Nicolas Grekas
6194c2a96c Allow PHP ^7.2.5 2019-11-18 18:27:11 +01:00
Baptiste Clavié
8a460cefef
States that the HttpClient provides a Http Async implementation 2019-11-18 13:47:27 +01:00
Thomas Calvet
0e5db6a033 [Routing] Fix ContainerLoader and ObjectLoaderTest 2019-11-18 10:36:08 +01:00
Nicolas Grekas
15f7ea1362 Merge branch '4.4' into 5.0
* 4.4:
  [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit
  Removed extra whitespace
  [Security] Fix best encoder not wired using migrate_from
2019-11-18 08:34:28 +01:00
Nicolas Grekas
4498e7e5e3 minor #34430 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

One less BC break for 5.0

Commits
-------

aab9b43d03 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit
2019-11-18 08:34:05 +01:00
Nicolas Grekas
73300a617a minor #34431 [HttpKernel] Drop deprecated ExceptionListener (chalasr)
This PR was merged into the 5.0 branch.

Discussion
----------

[HttpKernel] Drop deprecated ExceptionListener

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

dede9145dc [HttpKernel] Drop deprecated ExceptionListener
2019-11-18 08:33:31 +01:00
Robin Chalas
aab9b43d03 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit 2019-11-18 00:49:10 +01:00
Robin Chalas
dede9145dc [HttpKernel] Drop deprecated ExceptionListener 2019-11-18 00:44:50 +01:00
Robin Chalas
76d3112d8e bug #34428 [Security] Fix best encoder not wired using migrate_from (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Fix best encoder not wired using migrate_from

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Thanks @wouterj for spotting it.

Commits
-------

4132a60392 [Security] Fix best encoder not wired using migrate_from
2019-11-17 23:59:41 +01:00
Robin Chalas
b4ca84cea6 minor #34429 Removed extra whitespace (GrahamCampbell)
This PR was merged into the 4.4 branch.

Discussion
----------

Removed extra whitespace

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

I was working on upgrading Laravel 7's exception handling to use Symfony's new error handler component, and noticed this minor formatting error.

Commits
-------

754fbe41fb Removed extra whitespace
2019-11-17 23:54:16 +01:00
Graham Campbell
754fbe41fb
Removed extra whitespace 2019-11-17 22:49:13 +00:00
Robin Chalas
4132a60392 [Security] Fix best encoder not wired using migrate_from 2019-11-17 23:41:50 +01:00
Nicolas Grekas
d2649f2f78 minor #34427 Relax requirements for experimental components (nicolas-grekas)
This PR was merged into the 5.1-dev branch.

Discussion
----------

Relax requirements for experimental components

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Reverts #34316 for 5.1 only.

Commits
-------

0c1c4ede48 Relax requirements for experimental components
2019-11-17 22:58:32 +01:00
Nicolas Grekas
a06a0d8a71 Merge branch '5.0'
* 5.0:
  [Finder] Fixed docs
  Fix PR template
  Adjust pull request template for 5.0 branchout
  Update HttpKernel.php
  bumped Symfony version to 4.4.0
  updated VERSION for 4.4.0-RC1
  updated CHANGELOG for 4.4.0-RC1
2019-11-17 22:58:13 +01:00