Commit Graph

40384 Commits

Author SHA1 Message Date
Fabien Potencier
a36f34f0fb Fix CS 2020-08-17 09:48:54 +02:00
Fabien Potencier
524941e36e Merge branch '4.4' into 5.1
* 4.4:
  Fix CS
  Fix CS
  [Validator] Add Polish translation for ISIN constraint
2020-08-17 09:42:30 +02:00
Fabien Potencier
85090fcfb8 Fix CS 2020-08-17 09:39:58 +02:00
Fabien Potencier
c9cdac153f Merge branch '3.4' into 4.4
* 3.4:
  Fix CS
  [Validator] Add Polish translation for ISIN constraint
2020-08-17 09:31:35 +02:00
Fabien Potencier
ba042b1acf Fix CS 2020-08-17 09:27:37 +02:00
Fabien Potencier
78605e1ad9 Merge branch '4.4' into 5.1
* 4.4:
  Fix CS
  [Serializer] Fix configuration of the cache key
  [Messenger] Do not stack retry stamp
  [FrameworkBundle] Add missing mailer transports in xsd
  [ErrorHandler][DebugClassLoader] Add mixed and static return types support
2020-08-17 09:03:44 +02:00
Fabien Potencier
3cdf5c47db Fix CS 2020-08-17 08:12:26 +02:00
Kévin Dunglas
3b034cb343 [Serializer] Fix configuration of the cache key 2020-08-17 08:10:41 +02:00
Fabien Potencier
df3ab767dd bug #36810 [Messenger] Do not stack retry stamp (jderusse)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Messenger] Do not stack retry stamp

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

With the "RecoverableException" or a very high number of retry, the message is currently stacking a lot of stamp, which increase the size of the message sent to queue and (in my case) reach the "maximum size allowed" after 60 retries + php serializer

This PR removes previous stamps before adding the new Delay+RetryStamps.

Commits
-------

ad6f8532c6 [Messenger] Do not stack retry stamp
2020-08-17 08:02:22 +02:00
Jérémy Derussé
ad6f8532c6 [Messenger] Do not stack retry stamp 2020-08-17 08:02:06 +02:00
Przemysław Bogusz
5fa2975b42 [Validator] Add Polish translation for ISIN constraint 2020-08-17 07:25:28 +02:00
Laurent VOULLEMIER
c21df9b50a [FrameworkBundle] Add missing mailer transports in xsd 2020-08-16 23:25:38 +02:00
Fabien Potencier
5f074cdf4e bug #37218 [Lock] MongoDbStore skim non-standard options from uri (kralos)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Lock] MongoDbStore skim non-standard options from uri

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37180
| License       | MIT
| Doc PR        |

Don't allow non-standard connection uri options reach `MongoDB\Client`

Commits
-------

67912faf9f [Lock] MongoDbStore skim non-standard options from uri
2020-08-16 16:54:56 +02:00
Joe Bennett
67912faf9f [Lock] MongoDbStore skim non-standard options from uri 2020-08-16 16:54:50 +02:00
Fabien Potencier
d6b9936f61 bug #37586 [ErrorHandler][DebugClassLoader] Add mixed and static return types support (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler][DebugClassLoader] Add mixed and static return types support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

0533f1f63e [ErrorHandler][DebugClassLoader] Add mixed and static return types support
2020-08-16 16:46:36 +02:00
Fabien Potencier
5ef1679707 Merge branch '4.4' into 5.1
* 4.4:
  [Serializer] Fix variadic support when using type hints
  [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT
2020-08-16 10:27:43 +02:00
Fabien Potencier
803a257b6d Merge branch '3.4' into 4.4
* 3.4:
  [Serializer] Fix variadic support when using type hints
2020-08-16 10:27:11 +02:00
Fabien Potencier
688dbd9dab bug #37845 [Serializer] Fix variadic support when using type hints (fabpot)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix variadic support when using type hints

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

3fffa96928 [Serializer] Fix variadic support when using type hints
2020-08-16 10:23:32 +02:00
Fabien Potencier
3fffa96928 [Serializer] Fix variadic support when using type hints 2020-08-16 10:12:12 +02:00
Maxime Steinhausser
19b341e2b2 [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT 2020-08-14 17:54:02 +02:00
Fabien Potencier
49e047bf85 minor #37833 Added missing router config (dragosprotung)
This PR was merged into the 5.1 branch.

Discussion
----------

Added missing router config

    | Q             | A
    | ------------- | ---
    | Branch?       | 5.1
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | N/A
    | License       | MIT
    | Doc PR        | N/A

Commits
-------

a3bfb7d204 Added missing router config
2020-08-14 12:26:40 +02:00
Thomas Calvet
8bec34dd22 [FrameworkBundle] Remove unused form-resources complex type from XSD file 2020-08-14 11:56:16 +02:00
Dragos Protung
a3bfb7d204
Added missing router config 2020-08-14 11:34:02 +02:00
Fabien Potencier
c777e02b9d Merge branch '4.4' into 5.1
* 4.4:
  use expectWarning() when possible
2020-08-13 16:36:42 +02:00
Fabien Potencier
0bb2a1a918 Merge branch '3.4' into 4.4
* 3.4:
  use expectWarning() when possible
2020-08-13 16:36:30 +02:00
Fabien Potencier
cb92a3c8c1 Merge branch '4.4' into 5.1
* 4.4:
  add validator translation 99 for Italian language
  stop using the deprecated at() PHPUnit matcher
  Fix typehint phpdoc
2020-08-13 16:19:42 +02:00
Fabien Potencier
544d276cba Merge branch '3.4' into 4.4
* 3.4:
  add validator translation 99 for Italian language
  stop using the deprecated at() PHPUnit matcher
  Fix typehint phpdoc
2020-08-13 16:18:44 +02:00
Christian Flothmann
26dd39eb06 use expectWarning() when possible 2020-08-13 16:16:26 +02:00
Fabien Potencier
6972bc232d minor #37808 stop using the deprecated at() PHPUnit matcher (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

stop using the deprecated at() PHPUnit matcher

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37780
| License       | MIT
| Doc PR        |

Commits
-------

850389731c stop using the deprecated at() PHPUnit matcher
2020-08-13 16:08:51 +02:00
Laurent VOULLEMIER
1f66618bb1 Postpone BC layer removal to 6.0.
Since users on 5.0 and 5.1 hasn't have the deprecation, removing the BC layer (and so throwing an exception) in 5.x would be a big BC break.
2020-08-13 10:39:22 +02:00
Fabien Potencier
804b8dd8b5 minor #37820 add validator translation 99 for Italian language (garak)
This PR was merged into the 3.4 branch.

Discussion
----------

add validator translation 99 for Italian language

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | not needed

This is a followup to PR #37730 for Italian language.

Commits
-------

ad4923f706 add validator translation 99 for Italian language
2020-08-13 09:33:49 +02:00
Massimiliano Arione
ad4923f706
add validator translation 99 for Italian language 2020-08-13 09:29:37 +02:00
Fabien Potencier
7241f658b9 bug #37725 [Form] Fix Guess phpdoc return type (franmomu)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fix Guess phpdoc return type

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | -
| License       | MIT
| Doc PR        | -

Since `Guess` is abstract, `static` represents better the return type, so calling `TypeGuess::getBestGuess()` would return `TypeGuess` instead of `Guess`.

Commits
-------

27bb1c499d Fix typehint phpdoc
2020-08-13 09:26:14 +02:00
Fabien Potencier
2b0fdc9857 Merge branch '4.4' into 5.1
* 4.4:
  [Validator] RangeTest: fix expected deprecation
  [Yaml] Fix for #36624; Allow PHP constant as first key in block
  Use PHPUnit 9.3 on php 8.
  fix mapping errors from unmapped forms
  [Validator] Add target guards for Composite nested constraints
2020-08-13 08:24:11 +02:00
Fabien Potencier
a379051c82 Merge branch '3.4' into 4.4
* 3.4:
  [Yaml] Fix for #36624; Allow PHP constant as first key in block
  Use PHPUnit 9.3 on php 8.
  fix mapping errors from unmapped forms
  [Validator] Add target guards for Composite nested constraints
2020-08-13 08:22:32 +02:00
Christian Flothmann
850389731c stop using the deprecated at() PHPUnit matcher 2020-08-12 16:55:37 +02:00
Maxime Steinhausser
33c8c3a63d [Validator] RangeTest: fix expected deprecation 2020-08-12 11:54:23 +02:00
Fabien Potencier
5afac1df4e Fix bad merge 2020-08-12 11:06:24 +02:00
Fabien Potencier
806ef94e98 Merge branch '4.4' into 5.1
* 4.4:
  Fix for issue #37681
  Revert changes to Table->fillCells()
  [Console] Table: support cells with newlines after a cell with colspan >= 2
  Fix redis connect with empty password
  [Validator] Add BC layer for notInRangeMessage when min and max are set
2020-08-12 10:45:47 +02:00
Fabien Potencier
f3753e93d8 bug #36140 [Validator] Add BC layer for notInRangeMessage when min and max are set (l-vo)
This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] Add BC layer for notInRangeMessage when min and max are set

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36133
| License       | MIT
| Doc PR        |

According to #36133, the improvement added in  #32435 may lead to a BC break when the developer pass `min` and `max` options and a custom `minMessage` or `maxMessage`. In this case it's expected to receive a `minMessage`/`maxMessage` in the violation but a `notInRangeMessage` is received instead.

So in the following conditions:
- `min` and `max` options are set
- `minMessage` or `maxMessage` is set

A deprecation is triggered. If a limit is violated and matches to the min/max message passed as option (`minMessage` for `min` violated and `maxMessage` for `max` violated), `minMessage/maxMessage` is used in the violation instead of `notInRangeMessage`.

Commits
-------

092d85c947 [Validator] Add BC layer for notInRangeMessage when min and max are set
2020-08-12 10:39:50 +02:00
Fabien Potencier
92eae57fdb bug #35843 [Validator] Add target guards for Composite nested constraints (ogizanagi)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add target guards for Composite nested constraints

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix https://github.com/symfony/symfony/pull/35815#pullrequestreview-362719298 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

a08ddf7636 [Validator] Add target guards for Composite nested constraints
2020-08-12 10:12:34 +02:00
Fabien Potencier
7e85a6a6c6 bug #37803 Fix for issue #37681 (Rav)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Fix for issue #37681

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37681
| License       | MIT
| Doc PR        |

Allow BOM character and comments before `<!DOCTYPE html>` declaration in DomCrawler while choosing a parser implementation

Commits
-------

9bc249e0b9 Fix for issue #37681
2020-08-12 08:20:48 +02:00
Rav
9bc249e0b9 Fix for issue #37681 2020-08-12 08:20:35 +02:00
Jelle Raaijmakers
17263ca14d Revert changes to Table->fillCells()
These changes were introduced in https://github.com/symfony/symfony/pull/37731
but no longer contributed to the actual fix, which was to perform a
->copyRow().
2020-08-11 19:02:45 +02:00
Thomas Calvet
0533f1f63e [ErrorHandler][DebugClassLoader] Add mixed and static return types support 2020-08-11 14:16:16 +02:00
Fabien Potencier
a77901d6db bug #37744 [Yaml] Fix for #36624; Allow PHP constant as first key in block (jnye)
This PR was squashed before being merged into the 3.4 branch.

Discussion
----------

[Yaml] Fix for #36624; Allow PHP constant as first key in block

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36624
| License       | MIT
| Doc PR        |

When using a PHP constant in the first key of a mapping the parser would throw an exception. However if you used a PHP constant in any other key but the first it was allowed. This fix allows PHP constant as the first key.

I've included a test for this parser error along with the fix.

Commits
-------

46f635c492 [Yaml] Fix for #36624; Allow PHP constant as first key in block
2020-08-11 11:42:46 +02:00
Joshua Nye
46f635c492 [Yaml] Fix for #36624; Allow PHP constant as first key in block 2020-08-11 11:42:40 +02:00
Fabien Potencier
0e9cd90857 bug #37767 [Form] fix mapping errors from unmapped forms (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] fix mapping errors from unmapped forms

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #10519
| License       | MIT
| Doc PR        |

Commits
-------

235920a388 fix mapping errors from unmapped forms
2020-08-11 11:39:48 +02:00
Fabien Potencier
0f92b9a584 bug #37731 [Console] Table: support cells with newlines after a cell with colspan >= 2 (GMTA)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Console] Table: support cells with newlines after a cell with colspan >= 2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

When rendering a table with a cell containing newlines after a cell with
colspan set to at least 2, every line in the cell with newlines except the
first one fails to render.

This case is fixed by calling `->fillCells()` on the unmerged rows and
implementing support for rows that start with a non-zero index for the columns.

While fixing this, I discovered another issue with colspan: if a cell following a
colspanned cell contains enough newlines to make the contents extend further
than the colspanned cell's contents, the cells become misaligned. This is now
also fixed.

Commits
-------

ca11772e3f [Console] Table: support cells with newlines after a cell with colspan >= 2
2020-08-11 09:29:54 +02:00
Jelle Raaijmakers
ca11772e3f [Console] Table: support cells with newlines after a cell with colspan >= 2 2020-08-11 09:29:48 +02:00