Commit Graph

35969 Commits

Author SHA1 Message Date
Nicolas Grekas
0c5f8391f9 bug #26368 [WebProfilerBundle] Fix Debug toolbar breaks app (xkobal)
This PR was squashed before being merged into the 2.7 branch (closes #26368).

Discussion
----------

[WebProfilerBundle] Fix Debug toolbar breaks app

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26364
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Wrong method is used to count `tbody.rows`

Commits
-------

52f187e [WebProfilerBundle] Fix Debug toolbar breaks app
2018-03-02 09:20:34 +01:00
Xavier HAUSHERR
52f187e86a [WebProfilerBundle] Fix Debug toolbar breaks app 2018-03-02 09:20:32 +01:00
Nicolas Grekas
9980004cb4 bug #26369 Use fill instead of style for svg colors (rpkamp)
This PR was merged into the 3.4 branch.

Discussion
----------

Use fill instead of style for svg colors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT

Using style does not work when a Content Security Policy is in place,
resulting in non-styles (black) images instead of grey.

Symfony 2.7 and 2.8 don't have these images so there is nothing to fix there.

Commits
-------

e296778 Use fill instead of style for svg colors
2018-03-02 09:19:22 +01:00
Remon van de Kamp
e29677858f
Use fill instead of style for svg colors
Using style does not work when a Content Security Policy is in place,
resulting in non-styles (black) images instead of grey.
2018-03-02 09:07:37 +01:00
Javier Spagnoletti
d6e2b8188c Add entry for container.dumper.inline_class_loader param at UPGRADE-3.4.md and UPGRADE-4.0.md 2018-03-01 21:43:47 -03:00
Fabien Potencier
6628318b29 bug #26358 [FrameworkBundle] Silence "Failed to remove directory" on cache:clear (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Silence "Failed to remove directory" on cache:clear

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #2600
| License       | MIT
| Doc PR        | -

Let's improve the experience of ppl (see old linked issue). This warning is just noise to most.

Commits
-------

3ba624af9f [FrameworkBundle] Silence "Failed to remove directory" on cache:clear
2018-03-01 12:19:29 -08:00
Fabien Potencier
4b13407362 bumped Symfony version to 4.0.6 2018-03-01 12:16:32 -08:00
Fabien Potencier
ff68b3a2db
Merge pull request #26363 from fabpot/release-4.0.5
released v4.0.5
2018-03-01 11:48:49 -08:00
Fabien Potencier
173d4aea89 updated VERSION for 4.0.5 2018-03-01 11:48:35 -08:00
Fabien Potencier
4708fc1f2b updated CHANGELOG for 4.0.5 2018-03-01 11:48:25 -08:00
Fabien Potencier
b3f807cc5a bumped Symfony version to 3.4.6 2018-03-01 11:47:22 -08:00
Fabien Potencier
8a023e125a
Merge pull request #26362 from fabpot/release-3.4.5
released v3.4.5
2018-03-01 11:24:09 -08:00
Fabien Potencier
1ec5a562b3 updated VERSION for 3.4.5 2018-03-01 11:23:56 -08:00
Fabien Potencier
df008e2f56 updated CHANGELOG for 3.4.5 2018-03-01 11:23:47 -08:00
Fabien Potencier
3ff74ada0d bumped Symfony version to 2.8.36 2018-03-01 11:16:54 -08:00
Fabien Potencier
7339c93c82
Merge pull request #26361 from fabpot/release-2.8.35
released v2.8.35
2018-03-01 08:45:46 -08:00
Fabien Potencier
fbf0d0cce1 updated VERSION for 2.8.35 2018-03-01 08:45:28 -08:00
Fabien Potencier
586f697610 updated CHANGELOG for 2.8.35 2018-03-01 08:45:24 -08:00
Nicolas Grekas
3ba624af9f [FrameworkBundle] Silence "Failed to remove directory" on cache:clear 2018-03-01 15:51:10 +01:00
Fabien Potencier
31c69ec90d bumped Symfony version to 2.7.43 2018-03-01 06:32:34 -08:00
Nicolas Grekas
d1b67a561c fix test 2018-03-01 11:49:02 +01:00
Nicolas Grekas
a06f826a21 Merge branch '4.0'
* 4.0:
  [Form][WCAG] Errors sign for people that do not see colors
  [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table
2018-03-01 11:22:02 +01:00
Nicolas Grekas
39dabcd5ba Merge branch '3.4' into 4.0
* 3.4:
  [Form][WCAG] Errors sign for people that do not see colors
  [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table
2018-03-01 11:21:51 +01:00
Nicolas Grekas
c572e6c570 bug #26327 [Form][WCAG] Errors sign for people that do not see colors (Nyholm)
This PR was squashed before being merged into the 3.4 branch (closes #26327).

Discussion
----------

[Form][WCAG] Errors sign for people that do not see colors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability):

> The form errors is correctly encoded and works great. But visually they may be hard to see for people that do not see colors very well. Try to improve errors with an icon to make it more visual clear that an error has occurred.

![screen shot 2018-02-26 at 17 42 01](https://user-images.githubusercontent.com/1275206/36802282-c81357c6-1cb4-11e8-843c-4592e3d597f9.png)

Commits
-------

3f8cd05 [Form][WCAG] Errors sign for people that do not see colors
2018-03-01 11:20:21 +01:00
Tobias Nyholm
3f8cd05c34 [Form][WCAG] Errors sign for people that do not see colors 2018-03-01 11:20:19 +01:00
Nicolas Grekas
dddef1bd55 minor #26349 Fix typo in test method name (keichinger)
This PR was merged into the 4.1-dev branch.

Discussion
----------

Fix typo in test method name

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This fixes a small typo spotted in #23508 (see 8456f3b32c (r171488418))

Commits
-------

e5734aa Fix typo in test method name
2018-03-01 11:03:32 +01:00
Kai Eichinger
e5734aacc6
Fix typo in test method name
In regards to 8456f3b32c (r171488418)
2018-03-01 10:56:19 +01:00
Nicolas Grekas
bacae4d2d6 bug #26326 [Form][WCAG] Added role="presentation" on tables & removed bootstrap4 table (Nyholm)
This PR was squashed before being merged into the 3.4 branch (closes #26326).

Discussion
----------

[Form][WCAG] Added role="presentation" on tables & removed bootstrap4 table

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability):

> Tables works best for table data, it should not be used for doing layouts. If you really really want to use the label add `role="presentation"`. This will make screen readers to ignore the table structure which will make it easier to navigate. It will also prevent screen readers to read "row 1, column 1".
> But we should consider not using a table here.

Commits
-------

635220a [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table
2018-03-01 09:50:24 +01:00
Tobias Nyholm
635220a657 [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table 2018-03-01 09:50:19 +01:00
Fabien Potencier
1cb920ef3b
Merge pull request #26346 from fabpot/release-2.7.42
released v2.7.42
2018-02-28 14:57:23 -08:00
Fabien Potencier
751196e8f0 updated VERSION for 2.7.42 2018-02-28 14:53:23 -08:00
Fabien Potencier
621d440217 update CONTRIBUTORS for 2.7.42 2018-02-28 14:53:19 -08:00
Fabien Potencier
3000270452 updated CHANGELOG for 2.7.42 2018-02-28 14:53:13 -08:00
Fabien Potencier
97cee3a157 Merge branch '4.0'
* 4.0:
  [Form][WCAG] Add hidden labels on date and time fields
  Pass on previous exception in FatalThrowableError
  [Routing] remove dead code
  [Routing] fix typo
  [Form][WCAG] Fixed HTML errors
  fix merge
  [FrameworkBundle] [Console] add a warning when command is not found
  [WebProfilerBundle] limit ajax request to 100 and remove the last one
2018-02-28 13:50:15 -08:00
Fabien Potencier
96aac17c0d Merge branch '3.4' into 4.0
* 3.4:
  [Form][WCAG] Add hidden labels on date and time fields
  Pass on previous exception in FatalThrowableError
  [Routing] remove dead code
  [Routing] fix typo
  [Form][WCAG] Fixed HTML errors
  fix merge
  [FrameworkBundle] [Console] add a warning when command is not found
  [WebProfilerBundle] limit ajax request to 100 and remove the last one
2018-02-28 13:50:02 -08:00
Fabien Potencier
b7b6bd2605 Merge branch '2.8' into 3.4
* 2.8:
  Pass on previous exception in FatalThrowableError
  [Routing] remove dead code
  [Routing] fix typo
2018-02-28 13:49:22 -08:00
Fabien Potencier
3dd843ba7e Merge branch '2.7' into 2.8
* 2.7:
  Pass on previous exception in FatalThrowableError
  [Routing] remove dead code
  [Routing] fix typo
2018-02-28 13:47:46 -08:00
Fabien Potencier
18beaeedfd bug #26325 [Form][WCAG] Add hidden labels on date and time fields (Nyholm)
This PR was squashed before being merged into the 3.4 branch (closes #26325).

Discussion
----------

[Form][WCAG] Add hidden labels on date and time fields

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability):

> "Guidance texts" (my translation) on DateType and DateTimeType etc are missing. It is great that they are grouped with a "fieldset" but it will be more clear if there was a label on each select. Especially since different countries have different time and date formats. The time form is read like "00 00" and you have no idea if it is seconds, minutes or hours. You may do "guidance texts" visually hidden if you do not want to change the looks of the form. But since "month" is shorten to "Jan" instead of "January" you may want to have clear and visual guidance texts.

Commits
-------

14978e905c [Form][WCAG] Add hidden labels on date and time fields
2018-02-28 13:47:15 -08:00
Tobias Nyholm
14978e905c [Form][WCAG] Add hidden labels on date and time fields 2018-02-28 13:47:10 -08:00
Fabien Potencier
1928fafb9f feature #26330 [FORM] Fix HTML errors. (Nyholm)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[FORM] Fix HTML errors.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

As mentioned in #26328.
Range and color do not support "required" attribute

Commits
-------

f75d8c1985 Fix HTML errors.
2018-02-28 13:42:57 -08:00
Fabien Potencier
4c98001119 feature #26334 [SecurityBundle] Deprecate switch_user.stateless config node (chalasr)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[SecurityBundle] Deprecate switch_user.stateless config node

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/issues/8447

unused since 4.0.

Commits
-------

5781b8f1a1 [SecurityBundle] Deprecate switch_user.stateless config node
2018-02-28 13:40:40 -08:00
Fabien Potencier
40639589bf bug #26338 [Debug] Keep previous errors of Error instances (Philipp91)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #26338).

Discussion
----------

[Debug] Keep previous errors of Error instances

| Q             | A
| ------------- | ---
| Branch?       | 2.7 (I have tested against 4.0, but I guess it applies to all the older versions too)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | ?
| Fixed tickets | --
| License       | MIT

Passing on the previous exception gives developers better debugging information. In particular, if you throw an uncaught `new \Error("Something", 0, new \Exception("Inner exception"))` or sth. like that today, you will not see the "Inner exception" text (which may be more helpful than the outer error) in the HTTP debug response. Converting exceptions into errors this way is a common pattern when an exception raised in a sub-routine cannot reasonably occur for a specific caller situation, so there it becomes an `AssertionError` instead.

Commits
-------

b1b6093f3d Pass on previous exception in FatalThrowableError
2018-02-28 13:02:44 -08:00
Philipp Keck
b1b6093f3d Pass on previous exception in FatalThrowableError 2018-02-28 13:02:44 -08:00
Nicolas Grekas
a5f58f22d7 [Process] fix interpolation of placeholders 2018-02-28 20:33:07 +01:00
Nicolas Grekas
4ae66dc18d [Routing] Handle "_canonical_route" 2018-02-28 12:40:48 +01:00
Frank de Jonge
e32c414b04 [Routing] Implement i18n routing 2018-02-28 12:40:22 +01:00
Nicolas Grekas
a1b241473d feature #26304 [Routing] support scheme requirement without redirectable dumped matcher (Tobion)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Routing] support scheme requirement without redirectable dumped matcher

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

The scheme handling was just redirecting immediately without testing the other routes at all for potential matches. This can cause Problems when you try to have different routes/controllers for the same path but different schemes. See added test.

```
        $coll = new RouteCollection();
        $coll->add('https_route', new Route('/', array(), array(), array(), '', array('https')));
        $coll->add('http_route', new Route('/', array(), array(), array(), '', array('http')));
        $matcher = $this->getUrlMatcher($coll);
        $this->assertEquals(array('_route' => 'http_route'), $matcher->match('/'));
```

Instead of matching the right route, it would redirect immediatly as soon as it hits the first route.
This does not make sense and is not consistent with the other logic. Redirection should only happen when nothing matches. While fixing this I could also remove the limitation

> throw new \LogicException('The "schemes" requirement is only supported for URL matchers that implement RedirectableUrlMatcherInterface.');

If redirection is not possible, the wrong scheme will just not match the route. This is the same as already implemented by UrlMatcher (not RedirecableUrlMatcher). If redirection is supported, it will redirect to the first supported scheme if no other route matches. This makes the implementation similar to redirection for trailing slash and handling not allowed methods.

Also previously, the scheme redirection was done for non-safe verbs which shouldn't happen as well, ref. #25962

Commits
-------

f9b54c5 [Routing] support scheme requirement without redirectable dumped matcher
2018-02-28 12:38:29 +01:00
Tobias Schultze
f9b54c5ccd [Routing] support scheme requirement without redirectable dumped matcher 2018-02-28 12:35:06 +01:00
Nicolas Grekas
2f4b867b50 [Routing] remove dead code 2018-02-28 10:36:59 +01:00
Nicolas Grekas
c794fa821b [Routing] fix typo 2018-02-28 10:29:53 +01:00