Commit Graph

53461 Commits

Author SHA1 Message Date
Nicolas Grekas
0a26f1be0b Merge branch '4.4' into 5.2
* 4.4:
  [HttpKernel] fix transient test
  [FrameworkBundle] Fix freshness checks with boolean parameters on routes
  [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path"
  Add some information about the username in CONTRIBUTORS
2021-02-10 18:26:35 +01:00
Nicolas Grekas
d0135d79fe minor #40147 [HttpKernel] fix transient test (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] fix transient test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

db66fb5838 [HttpKernel] fix transient test
2021-02-10 18:24:59 +01:00
Nicolas Grekas
db66fb5838 [HttpKernel] fix transient test 2021-02-10 18:16:49 +01:00
Nicolas Grekas
17bccca9c6 [Filesystem] remove dirs atomically if possible 2021-02-10 18:13:44 +01:00
Nicolas Grekas
52a999ca3d bug #40135 [FrameworkBundle] Fix freshness checks with boolean parameters on routes (HypeMC)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Fix freshness checks with boolean parameters on routes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40017
| License       | MIT
| Doc PR        | -

Commits
-------

af6db0cfaf [FrameworkBundle] Fix freshness checks with boolean parameters on routes
2021-02-10 17:53:48 +01:00
Nicolas Grekas
f5ddfadcb2 [Filesystem] improve messages on failure 2021-02-10 17:53:17 +01:00
HypeMC
af6db0cfaf [FrameworkBundle] Fix freshness checks with boolean parameters on routes 2021-02-10 16:28:23 +01:00
Nicolas Grekas
c75687fdb1 bug #40138 [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path" (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path"

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Because `annotations.cache` is registered in a quite special way (see #25696), `ResolveHotPathPass` cannot propagate the `container.hot_path` tag to it.

Let's add the tag explicitly since this service is always on the hot path anyway.

Spotted with Blackfire.io as usual.

Commits
-------

e196c1ecb3 [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path"
2021-02-10 12:37:42 +01:00
Christian Flothmann
ec38bab34a bug #40137 [Form] forward the label_html option to expanded choice fields (xabbuh)
This PR was merged into the 5.2 branch.

Discussion
----------

[Form] forward the label_html option to expanded choice fields

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

fbe49cf84d forward the label_html option to expanded choice fields
2021-02-09 15:09:16 +01:00
Christian Flothmann
fbe49cf84d forward the label_html option to expanded choice fields 2021-02-09 09:56:11 +01:00
Nicolas Grekas
e196c1ecb3 [FrameworkBundle] fix registering "annotations.cache" on the "container.hot_path" 2021-02-09 09:55:59 +01:00
Fabien Potencier
5dbc7db04a Add some information about the username in CONTRIBUTORS 2021-02-09 09:21:20 +01:00
Fabien Potencier
386555b8a2 minor #40134 Add some information about the username in CONTRIBUTORS (fabpot)
This PR was merged into the 5.3-dev branch.

Discussion
----------

Add some information about the username in CONTRIBUTORS

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Refs #18644, refs #40111 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Clarify the username in CONTRIBUTORS.

Commits
-------

fb98018754 Add some information about the username in CONTRIBUTORS
2021-02-09 09:19:49 +01:00
Fabien Potencier
fb98018754 Add some information about the username in CONTRIBUTORS 2021-02-09 08:45:33 +01:00
Jérémy Derussé
8fe8b96921
[Messenger] Added RouterContextMiddleware 2021-02-08 23:23:42 +01:00
Nicolas Grekas
20bb3cb3ab Merge branch '5.2' into 5.x
* 5.2:
  merge translation parameters with value configured for parent form
  scan directories for translations sequentially
  Fix kafka tests
  Fix "provide" declarations
  Provide implemented packages of replaced dependencies
  Always autoload string functions on symfony/symfony
2021-02-08 11:24:30 +01:00
Nicolas Grekas
7866a0fbd6 Merge branch '4.4' into 5.2
* 4.4:
  scan directories for translations sequentially
2021-02-08 11:23:22 +01:00
Nicolas Grekas
00e33563c7 bug #40116 [FrameworkBundle][Translator] scan directories for translations sequentially (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][Translator] scan directories for translations sequentially

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40014
| License       | MIT
| Doc PR        |

Commits
-------

8389310983 scan directories for translations sequentially
2021-02-07 19:50:11 +01:00
Nicolas Grekas
6e513fe16c minor #40125 Don't "replace" mailer bridges in "symfony/symfony" (nicolas-grekas)
This PR was merged into the 5.3-dev branch.

Discussion
----------

Don't "replace" mailer bridges in "symfony/symfony"

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

That's not needed, we already don't do it for notifier, messenger and 2 other mailer bridges.
Targetting 5.x to not disrupt existing apps.

Commits
-------

0754aaadf0 Don't "replace" mailer bridges in "symfony/symfony"
2021-02-07 19:45:07 +01:00
Nicolas Grekas
b9af88f9db bug #40124 [Form] merge translation parameters with value configured for parent form (xabbuh)
This PR was merged into the 5.2 branch.

Discussion
----------

[Form] merge translation parameters with value configured for parent form

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39874
| License       | MIT
| Doc PR        |

Commits
-------

3de453c368 merge translation parameters with value configured for parent form
2021-02-07 19:43:45 +01:00
Nicolas Grekas
0754aaadf0 Don't "replace" mailer bridges in "symfony/symfony" 2021-02-07 16:15:59 +01:00
Christian Flothmann
3de453c368 merge translation parameters with value configured for parent form 2021-02-07 15:53:40 +01:00
Christian Flothmann
8389310983 scan directories for translations sequentially 2021-02-07 10:52:31 +01:00
Nicolas Grekas
168e7debb3 bug #40113 [HttpFoundation] Fix FQDN class (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[HttpFoundation] Fix FQDN class

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

99c79c966b Fix FQDN class
2021-02-06 18:31:12 +01:00
Nyholm
d8e36f2940
minor #40118 Fix kafka tests (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

Fix kafka tests

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Fix github-actions tests with kafka.

I'm not sure why (probably a change in github actions), but localhost resolves to ipv6 which is breaks our testing setup

Commits
-------

8d6c64dcde Fix kafka tests
2021-02-06 16:54:55 +01:00
Jérémy Derussé
8d6c64dcde
Fix kafka tests 2021-02-06 15:40:34 +01:00
Jérémy Derussé
99c79c966b
Fix FQDN class 2021-02-06 11:28:18 +01:00
Nicolas Grekas
839c7a1108 minor #40093 Always autoload string functions on symfony/symfony (chalasr)
This PR was merged into the 5.2 branch.

Discussion
----------

Always autoload string functions on symfony/symfony

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Autoloading these functions only in dev make them undefined for projects still using symfony/symfony, which causes troubles when upgrading to 5.2 (e.g. easyadmin uses `u()`).

Commits
-------

b3ca21c4ba Always autoload string functions on symfony/symfony
2021-02-06 09:57:39 +01:00
Nicolas Grekas
6f16e833bd Merge branch '4.4' into 5.2
* 4.4:
  Fix "provide" declarations
2021-02-06 09:56:29 +01:00
Nicolas Grekas
36e5051171 Fix "provide" declarations 2021-02-06 09:54:26 +01:00
Nicolas Grekas
6891550582 Merge branch '4.4' into 5.2
* 4.4:
  Provide implemented packages of replaced dependencies
2021-02-06 09:52:42 +01:00
Nicolas Grekas
f1a7dcafe0 minor #40086 Provide implemented packages of replaced dependencies (simonberger)
This PR was merged into the 4.4 branch.

Discussion
----------

Provide implemented packages of replaced dependencies

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

The meta package symfony/symfony does not provide the virtual packages of the dependencies it replaces.
Composer does not pick it as a candidate to replace those packages if the implement such a package/interface.

See https://github.com/composer/composer/issues/9643, https://github.com/composer/composer/issues/9666

Commits
-------

57d9a818bb Provide implemented packages of replaced dependencies
2021-02-06 09:48:46 +01:00
Simon Berger
57d9a818bb Provide implemented packages of replaced dependencies 2021-02-06 09:48:04 +01:00
Jérémy Derussé
7117e1a798
Use a lazyintertor to close files descriptors when no longer used 2021-02-05 21:09:52 +01:00
Jérémy Derussé
a12db94a06
feature #39978 [DoctrineBridge] Make subscriber and listeners prioritizable (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[DoctrineBridge] Make subscriber and listeners prioritizable

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #28090
| License       | MIT
| Doc PR        | -

handle Doctrine's eventSubscriber and eventListener priority (listener exposed by the eventSubscriber will have the same priority than the eventListener)

Commits
-------

14a613b5e0 Make subscriber and listeners prioritizable
2021-02-05 18:57:17 +01:00
Nicolas Grekas
47da6640f8 Merge branch '5.2' into 5.x
* 5.2:
  Allow psr/cache v3 but on symfony/cache
  [DI] fix tracking of changes to vendor/ dirs
  Remove EOLed 5.1 branch from PR template
  [HttpKernel] [Kernel] Silence deprecations logs writes
  Update PULL_REQUEST_TEMPLATE.md
  fix typo
  [Mailer][Mime] Update inline part names with newly generated ContentId
  Fixed updating catalogue metadata from intl domain
  [HttpFoundation] Setting `REQUEST_TIME_FLOAT` when constructing a Request object
2021-02-05 18:04:25 +01:00
Nicolas Grekas
382b10fc7c Merge branch '4.4' into 5.2
* 4.4:
  Allow psr/cache v3 but on symfony/cache
  [DI] fix tracking of changes to vendor/ dirs
  Remove EOLed 5.1 branch from PR template
  [HttpKernel] [Kernel] Silence deprecations logs writes
  Update PULL_REQUEST_TEMPLATE.md
  [Mailer][Mime] Update inline part names with newly generated ContentId
  Fixed updating catalogue metadata from intl domain
  [HttpFoundation] Setting `REQUEST_TIME_FLOAT` when constructing a Request object
2021-02-05 18:02:58 +01:00
Nicolas Grekas
71ca1f3c71 bug #40104 [HttpKernel] [Kernel] Silence failed deprecations logs writes (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] [Kernel] Silence failed deprecations logs writes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

When `->buildContainer()` throws because the cache directory cannot be created, we still try to write the deprecations logs inside the cache directory. In this case, the final exception is `Warning: file_put_contents(/app/var/cache/dev/App_KernelDevDebugContainerDeprecations.log): failed to open stream: No such file or directory` instead of `Unable to create the "cache" directory (/app/var/cache/dev).`.

Alternative:
```php
try {
    // ...
} catch (\RuntimeException $e)
} finally {
    if (isset($e)) {
        throw $e;
    }

    // ...
}
```

Commits
-------

b7100b6909 [HttpKernel] [Kernel] Silence deprecations logs writes
2021-02-05 17:03:19 +01:00
Nicolas Grekas
0bae2356b1 minor #40106 Allow psr/cache v3 but on symfony/cache (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

Allow psr/cache v3 but on symfony/cache

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Consumers of PSR-6 are compatible with v1|2|3.

Implementations aren't until they add explicit return types, which is not possible without a BC break.

Commits
-------

bf23c44a07 Allow psr/cache v3 but on symfony/cache
2021-02-05 16:56:08 +01:00
Nicolas Grekas
cec91255cd minor #40105 Remove EOLed 5.1 branch from PR template (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

Remove EOLed 5.1 branch from PR template

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

c28ba9a959 Remove EOLed 5.1 branch from PR template
2021-02-05 16:55:30 +01:00
Nicolas Grekas
bf23c44a07 Allow psr/cache v3 but on symfony/cache 2021-02-05 16:46:45 +01:00
Nicolas Grekas
d6219f674f bug #40098 [DependencyInjection] fix tracking of changes to vendor/ dirs (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] fix tracking of changes to vendor/ dirs

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40092
| License       | MIT
| Doc PR        | -

Commits
-------

6867475447 [DI] fix tracking of changes to vendor/ dirs
2021-02-05 16:41:21 +01:00
Nicolas Grekas
6867475447 [DI] fix tracking of changes to vendor/ dirs 2021-02-05 16:35:32 +01:00
Robin Chalas
c28ba9a959 Remove EOLed 5.1 branch from PR template 2021-02-05 15:36:10 +01:00
Thomas Calvet
b7100b6909 [HttpKernel] [Kernel] Silence deprecations logs writes 2021-02-05 14:33:05 +01:00
Jérémy Derussé
14a613b5e0
Make subscriber and listeners prioritizable 2021-02-05 12:48:09 +01:00
Fabien Potencier
c3d8328c61 minor #40101 Update PULL_REQUEST_TEMPLATE.md (noniagriconomie)
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.

Discussion
----------

Update PULL_REQUEST_TEMPLATE.md

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | See https://github.com/symfony/symfony/pull/40097#discussion_r570521793
| License       | MIT
| Doc PR        | Doc introduced in https://github.com/symfony/symfony-docs/pull/14830

ping @OskarStark do you think this can be valuable here? as this file is the entry point of all PRs

Commits
-------

41c7796552 Update PULL_REQUEST_TEMPLATE.md
2021-02-05 09:45:59 +01:00
Antoine Makdessi
41c7796552 Update PULL_REQUEST_TEMPLATE.md 2021-02-05 09:45:51 +01:00
Fabien Potencier
66a1a8b4bb feature #39732 [Routing] don't decode nor double-encode already encoded slashes when generating URLs (nicolas-grekas)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Routing] don't decode nor double-encode already encoded slashes when generating URLs

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | -
| Tickets       | Fix #13017
| License       | MIT
| Doc PR        | -

Replaces https://github.com/symfony/symfony/pull/39339

Commits
-------

eaac18be6f [Routing] don't decode nor double-encode already encoded slashes when generating URLs
2021-02-05 09:40:44 +01:00
Fabien Potencier
2764f3c466 feature #39893 [HttpKernel] Show full URI when route not found (ruudk)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[HttpKernel] Show full URI when route not found

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      |no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

When accessing a route that does not exist, Symfony throws a `NotFoundHttpException` that says `No route found for "POST /path"`.

On some projects this might be good enough to find the root cause, but on projects that have lots of routes on different hosts, it becomes hard to understand how the request was initiated. Was it done over HTTP or HTTPS? What was the hostname? Did the user specify a port?

To make this easier, we now show the full URI of the path, like this: `No route found for "POST https://www.symfony.com/path"`.

Commits
-------

6f5c9ab80b Show full URI when route not found
2021-02-05 09:34:14 +01:00