This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] be smarter when guessing the document root
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12524
| License | MIT
| Doc PR |
Commits
-------
83d768d be smarter when guessing the document root
This PR was merged into the 2.6 branch.
Discussion
----------
[TwigBundle] properly set request attributes in controller test
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
b3db574 properly set request attributes in controller test
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12267).
Discussion
----------
[Form][WebProfiler] Empty form names fix
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
When a Form had no name, the markup was broken in the profiler, making the form tree ugly. This pull request changes the output so that `(no name)` string is displayed when no form name was available.
Before:
![screenshot 2014-10-21 00 06 23](https://cloud.githubusercontent.com/assets/345754/4706329/d596a3ec-5883-11e4-8c67-44a7f357f3e1.png)
After:
![screenshot 2014-10-21 00 08 02](https://cloud.githubusercontent.com/assets/345754/4706359/122674c2-5884-11e4-8237-0177a590f2a0.png)
Commits
-------
6e9642a [Form][WebProfiler] Empty form names fix
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12268).
Discussion
----------
[DX] [Form] [WebProfiler] Added abbrs with type classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
This adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?
Looks like this:
![screenshot 2014-10-21 00 22 09](https://cloud.githubusercontent.com/assets/345754/4706604/32cf2d7a-5886-11e4-9fae-b9bff7a419ac.png)
Commits
-------
0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12147).
Discussion
----------
[TwigBundle] Fix error page preview for custom twig.exception_controller
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12147
| License | MIT
| Doc PR | n/a
The `testErrorPageAction()` always used the `showAction()` of TwigBundle's `ExceptionController`.
You can, however, configure an alternate controller by setting `twig.exception_controller`.
Thus, in order to get a proper preview, we need to forward to this configured controller (which
may be the default one).
This requires us to pass an additional parameter to `ExceptionController::showAction` to be able to
get the *error* page even if configured otherwise in the constructor.
(The other approach would have been to fiddle around with `ExceptionController`'s `debug` flag through a setter when going through the preview action, but that would have been even more messy.)
Commits
-------
2065e00 [TwigBundle] Fix error page preview for custom twig.exception_controller
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#12137).
Discussion
----------
[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12110
| License | MIT
Test and fix of ticket #12110
Commits
-------
76273bf [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
* 2.5:
[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
be smarter when guessing the document root
Azerbaijani locale
Fixed grammar error in docblock
Adjust upgrade file rendering
[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
compare version using PHP_VERSION_ID
[Form] Add doc for FormEvents
don't override internal PHP constants
[Session] Fix parameter names in WriteCheckSessionHandler
Add consistency with request type checking
[FrameworkBundle] Fix server run in case the router script does not exist
Conflicts:
composer.json
src/Symfony/Component/Debug/ErrorHandler.php
src/Symfony/Component/Debug/ExceptionHandler.php
* 2.3:
[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
be smarter when guessing the document root
Azerbaijani locale
Fixed grammar error in docblock
Adjust upgrade file rendering
[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
compare version using PHP_VERSION_ID
[Form] Add doc for FormEvents
don't override internal PHP constants
Conflicts:
UPGRADE-3.0.md
src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
src/Symfony/Component/Debug/ErrorHandler.php
src/Symfony/Component/HttpFoundation/Response.php
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12131).
Discussion
----------
Extract an AbstractEventDispatcherTest from EventDispatcherTest
Allow third party implementations of `EventDispatcherInterface` to reuse the `EventDispatcherTest` unit tests. Also instantly expand test coverage of `ContainerAwareEventDispatcher` by rebasing it onto the new `AbstractEventDispatcherTest`.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
8871368 Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest
This PR was merged into the 2.3 branch.
Discussion
----------
[Bundle][FrameworkBundle] be smarter when guessing the document root
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12524
| License | MIT
| Doc PR |
Commits
-------
e28f5b8 be smarter when guessing the document root
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12296).
Discussion
----------
[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | when relying on this configuration behaviour
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12261
| License | MIT
| Doc PR | —
See symfony/symfony#12261.
I configured a different firewall entry point for one firewall. However, when authentication had to be performed, it still called BasicAuthenticationEntryPoint::start() instead of my service's start(). My service was instantiated, yet never used.
The issue appears to be that the entry point is registered with the firewall's exception listener, but not with the BasicAuthenticationListener. This means that when the BasicAuthenticationListener determines the user has provided wrong credentials, BasicAuthenticationEntryPoint is still used. Only in case of an exception would my entry point service be used.
In my opinion, this is not correct behaviour. Can someone confirm this? Are there currently tests that pertain to the `entry_point` configuration on which I can base a test?
---
Test setup:
```yaml
# security.yml
security:
firewalls:
api:
pattern: ^/api/
http_basic: ~
entry_point: my.service
default:
anonymous: ~
```
Commits
-------
92c8dfb [SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12502).
Discussion
----------
Azerbaijani locale
[Form] [Validator] [Security] Azerbaijani translation added
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Commits
-------
7f7b700 Azerbaijani locale
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12510).
Discussion
----------
Fixed grammar error in docblock
Commits
-------
ba8d937 Fixed grammar error in docblock
This PR was merged into the 2.6 branch.
Discussion
----------
[HttpKernel] fix parse error in DumpDataCollector
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12504
| License | MIT
| Doc PR | -
my bad
Commits
-------
5526dd7 [HttpKernel] fix parse error in DumpDataCollector
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12446).
Discussion
----------
[Twig/DebugBundle] move dump extension registration
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12440
| License | MIT
| Doc PR | -
An alternative fix for #12440
Commits
-------
8cf3d69 [TwigBundle/DebugBundle] move dump extension & cleanups
This PR was merged into the 2.3 branch.
Discussion
----------
compare version using PHP_VERSION_ID
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.
Commits
-------
367ed3c compare version using PHP_VERSION_ID
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12433).
Discussion
----------
[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
Commits
-------
0bd19aa [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.