This PR was merged into the 2.5-dev branch.
Discussion
----------
[OptionsResolver] Allow giving a callback as an allowedValue to OptionsResolver
I recently had to use an option which was an array and could contain some one or multiple values from a list. As it could contain all possible combinations, it was not possible to validate it with a list of allowed values.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | --
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/3437
Commits
-------
07d1d30 Allow giving a callback as an allowedValue to OptionsResolver
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix#9861 : Revert TTY mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9861
| License | MIT
This revert the TTY mode support for the process component
Commits
-------
160b1cf [Process] Fix#9861 : Revert TTY mode
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Update minimal requirement in composer.json
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Tests pass? | yes
| Fixed tickets | #9959
| License | MIT
Minimal requirement for PropertyAccess component needs to be `~2.3` as Form component depends on new method `PropertyAccess::createPropertyAccessor()`.
Commits
-------
88153b3 [Form] Update minimal requirement in composer.json
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9952).
Discussion
----------
[Translator] Fix Empty translations with Qt files
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | no
| License | MIT
| Doc PR |
When you use ts files, QtLinguist, generate empty string for all translations, even if there are not translated yet.
It could be a good idea to generate an entry in the MessageCatalogue only if translation value is not empty.
Commits
-------
1c220be [Translator] Fix Empty translations with Qt files
This PR was merged into the 2.4 branch.
Discussion
----------
[Console] Fixed command name guessing if an alternative is an alias
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9953
| License | MIT
| Doc PR | -
Commits
-------
ade448c [Console] Fixed command name guessing if an alternative is an alias.
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9804).
Discussion
----------
[Form] Update UPGRADE-2.3.md to account for #9388
Added documentation for how to correctly pre-fill a form using the form's `data` option.
The "old" and also wrong way of doing it broke with Symfony 2.3.7 (with https://github.com/symfony/symfony/pull/9388 to be precise) and this short documentation should help others to fix the problem and do it right.
Commits
-------
5e06535 [Form] Update UPGRADE-2.3.md to account for #9388
This PR was squashed before being merged into the 2.3 branch (closes#9948).
Discussion
----------
[WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Profiler page itself is entirely autonomic, but toolbar is not - unfortunately currently it doesn't work in XHTML documents :(.
#9877 backported to `2.3` branch.
Commits
-------
296c4d1 [WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
This PR was merged into the 2.3 branch.
Discussion
----------
Propel1 exception message
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9932
| License | MIT
| Doc PR | none
This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid
Commits
-------
047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
This PR was squashed before being merged into the 2.3 branch (closes#9949).
Discussion
----------
[BrowserKit] Throw exception on invalid cookie expiration timestamp
Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8df535d [BrowserKit] Throw exception on invalid cookie expiration timestamp
Instead correctly use the array of schemes from the Route.
Also adjusted the dumpers to dump the correct data.
I extended the tests to not only test the deprecated behavior, but also
the new schemes-requirement.
* 2.4:
Revert "bug #9601 [Routing] Remove usage of deprecated _scheme requirement (Danez)"
bumped Symfony version to 2.4.2
updated VERSION for 2.4.1
updated CHANGELOG for 2.4.1
bumped Symfony version to 2.3.10
updated VERSION for 2.3.9
update CONTRIBUTORS for 2.3.9
updated CHANGELOG for 2.3.9
Add support SAPI cli-server
Fix hardcoded listenerTag name in error message
[HttpFoundation] Documented public properties.
[Routing] add missing unit tests for Route and RouteCollection classes
Conflicts:
src/Symfony/Component/HttpKernel/DependencyInjection/RegisterListenersPass.php
src/Symfony/Component/HttpKernel/Kernel.php
This PR was merged into the 2.5-dev branch.
Discussion
----------
[FrameworkBundle] Update composer.json to account for #9792
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
In #9792 RegisterListenersPass was moved from HttpKernel to EventDispatcher. Since FrameworkBundle uses that class the dependency needs to be rises to 2.5.
Commits
-------
f1efd16 [FrameworkBundle] Update composer.json to account for #9792
* 2.3:
bumped Symfony version to 2.3.10
updated VERSION for 2.3.9
update CONTRIBUTORS for 2.3.9
updated CHANGELOG for 2.3.9
Add support SAPI cli-server
Fix hardcoded listenerTag name in error message
[HttpFoundation] Documented public properties.
[Routing] add missing unit tests for Route and RouteCollection classes
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
src/Symfony/Component/Routing/Tests/RouteCollectionTest.php
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9938).
Discussion
----------
[Process] Add support SAPI cli-server
As of PHP 5.4.0, the CLI SAPI provides a built-in web server.
```php
PHP_SAPI == 'cli-server'
```
PHP can be used portable without installation on PC. For example, the [assembly](http://windows.php.net/download/) does not require installation in the system on Windows. In this case `PHP_BINARY` contains the path to the PHP executor, and all the other search methods will not return result.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
92d8323 Add support SAPI cli-server
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9940).
Discussion
----------
[EventDispatcher] Fix hardcoded listenerTag name in error message
| Q | A
| ------------- | ---
| Fixed tickets | N/A
| License | MIT
Just as the title say, there was a kernel.event_listener string hardcoded in an error message although everywhere else in this class it is stored in the `$listenerTag` property.
Commits
-------
8c91537 [EventDispatcher] Fix hardcoded listenerTag name in error message
This PR was merged into the 2.5-dev branch.
Discussion
----------
test for class route annotation
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
I mention that AnnotationClassLoaderTest don't test class route annotation functional.
This patch add test for class route annotation
Commits
-------
ac94ddb test for class route annotation
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Documented public properties
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9670
| License | MIT
| Doc PR | -
`$request` and `$query` parameter bags could be hard to get for a newcommer, who's used to `$_POST` and `$_GET` variables. Some people claim naming makes no sense (see #9671).
For consistency I documented all public properties.
Commits
-------
1b79831 [HttpFoundation] Documented public properties.
This PR was merged into the 2.5-dev branch.
Discussion
----------
Removed all codeCoverageIgnore annotations from the code
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
These annotations are artificially bumping the code coverage. Unreached code should be reported in the coverage report, even if we cannot reach 100% coverage for some safeguards IMO.
Thus, some places using them were actually testable (and tested) code.
Commits
-------
4248169 Removed all codeCoverageIgnore annotations from the code
These annotations are artificially bumping the code coverage. Unreached
code should be reported in the coverage report, even if we cannot reach
100% coverage for some safeguards.
Thus, some places using them were actually testable (and tested) code.
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Finder] Added GLOB_BRACE support in Finder::in() method
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9705
| License | MIT
| Doc PR | ~
**before**
```php
$finder->files()->in([
'My/First/Directory',
'My/Second/Directory',
'My/Third/Directory',
]);
```
**after**
```php
$finder->files()->in('My/{First,Second,Third}/Directory');
```
Commits
-------
e2698fc [Finder] Included GLOB_BRACE support in the CHANGELOG.
30814d3 [Finder] Added a test case for the GLOB_BRACE in Finder:in().
da67f5d [Finder] Added GLOB_BRACE support in Finder::in() method
This PR was squashed before being merged into the 2.3 branch (closes#9925).
Discussion
----------
[Routing] add missing unit tests for Route and RouteCollection classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Just add few unit tests in Route and RouteCollection classes to have a full coverage.
Commits
-------
7bbd568 [Routing] add missing unit tests for Route and RouteCollection classes