This PR was merged into the 2.6 branch.
Discussion
----------
Unify the way to provide expression functions for the DI container
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #13012
| License | MIT
| Doc PR | n/a
Function providers registered on the ContainerBuilder are now reused by the PhpDumper when dumping the container instead of forcing to register them again.
I consider it as a bugfix, because the hook introduced in 2.6 is currently unusable.
Commits
-------
8425e4d Unify the way to provide expression functions for the DI container
This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] update debug commands references
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12939
| License | MIT
| Doc PR |
With #11627, both the `ContainerDebugCommand` name and the
`ConfigDebugCommand` name have been moved to the `debug` namespace.
Thus, references should be updated accordingly.
Commits
-------
c0925e4 [FrameworkBundle] Use debug namespace.
5847771 [FrameworkBundle] update debug commands references
With #11627, both the `ContainerDebugCommand` name and the
`ConfigDebugCommand` name have been moved to the `debug` namespace.
Thus, references should be updated accordingly.
The FrameworkBundle doesn't depend on the `symfony/translation`
component and therefore does not enforce a high enough version of this
package. Thus, with `symfony/translation` versions before `2.6`, the
`translator` service does exist, but the `TranslatorBagInterface` is
not present.
Function providers registered on the ContainerBuilder are now reused by
the PhpDumper when dumping the container instead of forcing to register
them again.
Closes#13012
This PR was merged into the 2.3 branch.
Discussion
----------
CS: There should be no empty lines following phpdocs
Commits
-------
143f900 CS: There should be no empty lines following phpdocs
This PR was merged into the 2.6 branch.
Discussion
----------
[DebugBundle] fix link format handling with disabled templating
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13007
| License | MIT
| Doc PR |
Commits
-------
91b4d1d fix link format handling with disabled templating
* 2.6:
[2.6] Test lowest versions of dependencies
Test lowest versions of dependencies
Fix placeholder date format
Test components using their lowest possible deps
This PR was merged into the 2.6 branch.
Discussion
----------
[2.6] Test lowest versions of dependencies
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
a29ffa8 [2.6] Test lowest versions of dependencies
5e6959b Merge remote-tracking branch 'symfony/2.5' into lowest-26
b2e0a80 minor #12998 [2.5] Test components using their lowest possible deps (nicolas-grekas, fabpot)
b1b5cca Test lowest versions of dependencies
88d524e Merge remote-tracking branch 'symfony/2.3' into lowest-25
206ebc7 minor #12542 Test components using their lowest possible deps (nicolas-grekas)
25fef27 Test components using their lowest possible deps
* symfony/2.5:
Test lowest versions of dependencies
Test components using their lowest possible deps
Conflicts:
src/Symfony/Bridge/Twig/composer.json
src/Symfony/Bundle/FrameworkBundle/composer.json
src/Symfony/Bundle/SecurityBundle/composer.json
src/Symfony/Component/EventDispatcher/composer.json
src/Symfony/Component/HttpKernel/composer.json
src/Symfony/Component/Security/composer.json
This PR was merged into the 2.5 branch.
Discussion
----------
[2.5] Test components using their lowest possible deps
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | not yet
| Fixed tickets | -
| License | MIT
| Doc PR | -
Follow up of #12542
Commits
-------
b1b5cca Test lowest versions of dependencies
88d524e Merge remote-tracking branch 'symfony/2.3' into lowest-25
206ebc7 minor #12542 Test components using their lowest possible deps (nicolas-grekas)
25fef27 Test components using their lowest possible deps
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Fix placeholder date format
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12995
| License | MIT
| Doc PR | -
Commits
-------
9a44aa8 Fix placeholder date format
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fix return phpdoc
| Q | A
| ------------- | ---
| Bug fix? | tiny (for IDE autocompletion)
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
What about using `self` or `static` keyword for this?
Commits
-------
9af2d81 Fix return phpdoc
This PR was squashed before being merged into the 2.3 branch (closes#12993).
Discussion
----------
[2.3] Docblocks should not be followed by a blank line
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
There should be no blank line(s) between phpdocs that document properties, interfaces, classes, functions, or traits. This pull request was a test run of a new php-cs-fixer: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/864.
Commits
-------
4e7ba1b [2.3] Docblocks should not be followed by a blank line
This PR was squashed before being merged into the 2.3 branch (closes#12542).
Discussion
----------
Test components using their lowest possible deps
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Once https://github.com/composer/composer/pull/3450 is merged, we'll see if our deps are correct, and ensure that is kept over time by testing each component with its lowest possible deps.
Commits
-------
25fef27 Test components using their lowest possible deps
This PR was merged into the 2.3 branch.
Discussion
----------
[SecurityBundle] remove short array syntax
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The short array syntax was introduced in PHP 5.4 and therefore leads
to failing tests when executed in PHP 5.3 environments.
Commits
-------
697ce4d remove short array syntax
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Avoid missing method when using __invoke on a controller
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
2.6 added support for using `__invoke` on controllers, but the profiler toolbar still expects a method name, leading to:
![image](https://cloud.githubusercontent.com/assets/1784740/5412993/4553c4da-820a-11e4-899c-50ef9f330cdd.png)
This PR changes it to only include the method section/double dots if the method name is included (and the `link` is moved to the class name).
Commits
-------
fb87558 Avoid missing method when using __invoke
This PR was merged into the 2.3 branch.
Discussion
----------
fix session restart on PHP 5.3
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #12562
| License | MIT
| Doc PR | -
this also removes some useless code
Commits
-------
b9d3c92 fix session restart on PHP 5.3
This PR was merged into the 2.7 branch.
Discussion
----------
[DX][Profiler] Show the inherited roles in the web profiler
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12892
| License | MIT
| Doc PR | -
Given the following role hierarchy configuration
````php
security:
role_hierarchy:
ROLE_SUPER_ADMIN: [ROLE_ADMIN, ROLE_ALLOWED_TO_SWITCH]
ROLE_ADMIN: [ROLE_EMPLOYEE]
ROLE_EMPLOYEE: [ROLE_SALES]
````
If you were checking the user roles in the web profiler as an user with the assigned
role `ROLE_ADMIN` you saw only the following output.
![bildschirmfoto 2014-12-08 um 12 31 25](https://cloud.githubusercontent.com/assets/2010989/5338601/26fd4c90-7ed6-11e4-961b-12103ddddf50.png)
This was kind of tricky since pages where you were checking `is_granted('ROLE_EMPLOYEE')`
granted access. Debugging was hard for newcomers to the project if they did not understand
the role hierarchy.
With this adjustment you will see the assigned roles as well as the inherited roles separately as
follows:
![bildschirmfoto 2014-12-08 um 12 23 59](https://cloud.githubusercontent.com/assets/2010989/5338622/5b0ffc58-7ed6-11e4-9863-27c9105897df.png)
Commits
-------
31dc672 Show the inherited roles in the web profiler