This PR was merged into the 4.2-dev branch.
Discussion
----------
[FrameworkBundle] Don't populate fallback cache on warmup
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Since we populate the front PhpArrayCache, there is no need to also populate its fallback pool, since it will never be hit for the warmed up values.
This saves creating a myriad of small cache files and some MB.
Commits
-------
c857ba5ded [FrameworkBundle] Don't populate fallback cache on warmup
This PR was merged into the 2.8 branch.
Discussion
----------
[appveyor] fix bis
| Q | A
| ------------- | ---
| Branch? | 2.8
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Give it another try...
Commits
-------
9d24400b1f [appveyor] fix bis
This PR was merged into the 2.8 branch.
Discussion
----------
[appveyor] minor CI fix
| Q | A
| ------------- | ---
| Branch? | 2.8
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Should fix this message on appveyor:
`fatal: Not a valid object name HEAD^`
Commits
-------
a391331791 [appveyor] minor CI fix
* 4.1:
Use the real image URL for the filesystem tests
[Finder] Update PHPdoc append()
[DI] Fix phpdoc
Fix code examples in PHPDoc
[HttpKernel] Fix inheritdocs
bumped Symfony version to 3.4.16
updated VERSION for 3.4.15
updated CHANGELOG for 3.4.15
* 3.4:
Use the real image URL for the filesystem tests
[Finder] Update PHPdoc append()
[DI] Fix phpdoc
Fix code examples in PHPDoc
[HttpKernel] Fix inheritdocs
bumped Symfony version to 3.4.16
updated VERSION for 3.4.15
updated CHANGELOG for 3.4.15
* 2.8:
Use the real image URL for the filesystem tests
[Finder] Update PHPdoc append()
[DI] Fix phpdoc
Fix code examples in PHPDoc
[HttpKernel] Fix inheritdocs
This PR was merged into the 2.8 branch.
Discussion
----------
[Filesystem] Use the real image URL for tests
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | ?
| Fixed tickets | ø
| License | MIT
| Doc PR | ø
AppVeyor is always failing on this test. Trying with the real HTTPS url of the image to see if it's working or if it's something else.
Commits
-------
886f7390b8 Use the real image URL for the filesystem tests
This PR was merged into the 4.2-dev branch.
Discussion
----------
[Messenger] Ensure the tests and implementation matches the PR #28190
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #28190
| License | MIT
| Doc PR | ø
And we should have master green.
Commits
-------
ba6248546a Ensure the tests and implementation matches the merged #28190 PR
This PR was merged into the 4.1 branch.
Discussion
----------
FrameworkBundle 4.1 == Messenger 4.1
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ø
| License | MIT
| Doc PR | ø
That's the best way to tackle the BC break we've introduced (legitimately) in the consume command in Messenger 4.2.
Commits
-------
aaada7bf55 FrameworkBundle 4.1 == Messenger 4.1
This PR was merged into the 4.1 branch.
Discussion
----------
[FWB][Messenger] Revert "Move commands-specifics to a compiler pass in FWB"
| Q | A
| ------------- | ---
| Branch? | 4.1
| Bug fix? | yes
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ø
| License | MIT
| Doc PR | ø
This reverts #28328.
Commits
-------
fb3f729d64 Revert "Move commands-specifics to a compiler pass in FWB"
* 4.1:
Move commands-specifics to a compiler pass in FWB
bumped Symfony version to 4.1.5
updated VERSION for 4.1.4
updated CHANGELOG for 4.1.4
[travis] disable symfony/flex during phpunit install
This PR was merged into the 4.1 branch.
Discussion
----------
[Messenger][FrameworkBundle] Move commands-specifics to a compiler pass in FWB
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/28271#issuecomment-417333600
| License | MIT
| Doc PR | ø
We very recently [broke the tests](https://github.com/symfony/symfony/pull/28271#issuecomment-417333600) by adding a legitimate BC-break in one of Messenger's command. The failure is on FrameworkBundle (on the 4.1 branch) when using the "latest" dependencies (so messenger on master): the XML configuration does not match anymore the class.
Even though it makes sense to have most the compiler pass in the components, it does not make much sense to have things into them that are very coupled to what we defined in FWB' XML. This pull-request moves what is related to this command to the FWB directly.
Commits
-------
b5415ead46 Move commands-specifics to a compiler pass in FWB
This PR was merged into the 4.2-dev branch.
Discussion
----------
Autoload symfony/contracts from the local repository
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Required to have local changes on Contracts available while working on a PR.
Commits
-------
de6329a7d9 Autoload symfony/contracts from the local repository