This PR was merged into the 2.1 branch.
Commits
-------
b9c37f2 changed sub-requests creation to '::create()'
Discussion
----------
changed sub-requests creation to '::create()'
Added @henrikbjorn suggestion to #7381
* 2.1:
sub-requests are now created with the same class as their parent
[FrameworkBundle] removed BC break
[FrameworkBundle] changed temp kernel name in cache:clear
[DoctrineBridge] Avoids blob values to be logged by doctrine
[Security] use current request attributes to generate redirect url?
[Validator] fix showing wrong max file size for upload errors
[TwigBridge] removed double var initialization (refs #7344)
[2.1][TwigBridge] Fixes Issue #7342 in TwigBridge
[FrameworkBundle] fixed cahe:clear command's warmup
[TwigBridge] now enter/leave scope on Twig_Node_Module
[TwigBridge] fixed fixed scope & trans_default_domain node visitor
[TwigBridge] fixed non probant tests & added new one
[BrowserKit] added ability to ignored malformed set-cookie header
[Translation] removed wriong 'use'
[Translation] added xliff loader/dumper with resname support
[TwigBridge] fixes
Conflicts:
src/Symfony/Bundle/FrameworkBundle/HttpKernel.php
src/Symfony/Component/Security/Http/HttpUtils.php
src/Symfony/Component/Translation/Loader/XliffFileLoader.php
src/Symfony/Component/Translation/Tests/Loader/XliffFileLoaderTest.php
This PR was merged into the 2.1 branch.
Commits
-------
e51432a sub-requests are now created with the same class as their parent
Discussion
----------
[2.1] sub-requests are now created with the same class as their parent
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7185
---------------------------------------------------------------------------
by lsmith77 at 2013-03-14T19:54:13Z
oh .. i thought this was already the case!
---------------------------------------------------------------------------
by gnutix at 2013-03-15T09:57:55Z
Thanks for the PR @jfsimon ! I just override the Request class for a custom getClientIp() method and I sure will need your fix in order for it to work in all scenarios. I'll test your patch in my project as soon as possible.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#7384).
Commits
-------
7dc1e84 fix validator translation
Discussion
----------
fix plural string in persian (fa) translation/ validation component
| Q | A
| ------------- | ---
| Bug fix? | yes (plural fix in persian translation)
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This PR was merged into the 2.2 branch.
Commits
-------
602cdee replace INF to PHP_INT_MAX inside Finder component.
Discussion
----------
[2.2][Finder] fix assets:install issue
I have some bundle with assets, and when i do.
```
app/console assets:install --env=prod
```
I don't have any of my file inside web/bundles, only empty first level directory like "css"
bug issue introduced by 7c66dffa6b
---------------------------------------------------------------------------
by fabpot at 2013-03-13T13:34:10Z
Can you base your patch on the 2.1 branch as the bug is also there? Thanks.
---------------------------------------------------------------------------
by BenoitLeveque at 2013-03-13T14:29:55Z
i didn't reproduce this issue on the latest commit (175cdc0fd0) on 2.1 branch
---------------------------------------------------------------------------
by taylorotwell at 2013-03-13T14:35:28Z
Yeah, it appears the Finder component's recursion is basically broken on the 2.2 branch.
---------------------------------------------------------------------------
by BenoitLeveque at 2013-03-14T13:24:52Z
@fabpot i can't reproduce this issue on the 2.1 branch because you already fix it, see 7241be9b64
This PR was squashed before being merged into the 2.2 branch (closes#7365).
Commits
-------
d9ee869 [HttpKernel] Updated TraceableEventDispatcher.php
Discussion
----------
[HttpKernel] Updated TraceableEventDispatcher.php
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets |
| License | MIT
| Doc PR |
Currently, if no listeners are registered for an dispatched event, the StopwatchEvent "$eventName.'.loading'" is never being stopped.
This PR was merged into the 2.2 branch.
Commits
-------
d7a7434 [Routing] fix url generation for optional parameter having a null value
Discussion
----------
[Routing] fix url generation for optional parameter having a null value
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes|]
| Fixed tickets | [#7316]
| License | MIT
This PR was merged into the 2.1 branch.
Commits
-------
f2ef6bc [FrameworkBundle] removed BC break
cc3a40e [FrameworkBundle] changed temp kernel name in cache:clear
7d87ecd [FrameworkBundle] fixed cahe:clear command's warmup
Discussion
----------
[FrameworkBundle] fixes cahe:clear command's warmup
Solution taken is to replace the last char of the cache directory name to create a temporary cache directory, this way the temporary cache path has the same length than the real one. I tested this on several projects, in dev and prod environments.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6203
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T12:32:25Z
@toloco @gergelypolonkai @ghost-x47 @stewe it would be great if you could test this patch on your projects and report result!
---------------------------------------------------------------------------
by toloco at 2013-03-13T12:41:47Z
Im sorry but have the same...
Notice: unserialize(): Error at offset 155 of 174227 bytes in /home/tolopalmer/Projects/shareandcoach/app/bootstrap.php.cache line 915
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T12:45:04Z
@toloco could you paste the backtrace in a gist? and maybe the concerned file?
---------------------------------------------------------------------------
by stof at 2013-03-13T13:11:47Z
@jfsimon You probably have the same issue with the name of the temporary kernel class
---------------------------------------------------------------------------
by jfsimon at 2013-03-13T13:36:13Z
@stof if you're right, it's a nightmare. It must be possible to write a parser/fixer for serialized objects, don't you think?
---------------------------------------------------------------------------
by toloco at 2013-03-13T14:22:56Z
Here you are the gist with the stack and the bootstrap.php.cache file
https://gist.github.com/toloco/5152581
---------------------------------------------------------------------------
by mpdude at 2013-03-13T20:08:08Z
@jfsimon Writing such a parser is painting yourself in the corner.
Use a temp kernel class name of the same length as a quick fix.
#7230 could bring a solution because we might be able to inject a different ConfigCache factory during the command that intercepts and substitutes Resources before they get written into the meta file. Not sure if that PR has a chance of being picked though.
---------------------------------------------------------------------------
by toloco at 2013-03-14T08:19:58Z
So guys? we are blocked with this problem, can I help you? I can provide more stacks if it's needed
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:05:05Z
@toloco Could you please post the /home/tolopalmer/Projects/shareandcoach/app/cache/dev/appDevUrlMatcher.php.meta file? That's the one that is broken.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:15:20Z
@mpdude you can find its content in the gist https://gist.github.com/toloco/5152581 (1st file, 6th line)
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:24:55Z
@toloco That file should contain a serialized set of Resources, it's not in the Gist.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:33:12Z
@mpdude it's more visible in the raw file: ttps://gist.github.com/toloco/5152581/raw/48a1a823b5c8e6ba03936a52e8dc0d0ff1888f8a/Error+
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:33:27Z
sorry: 48a1a823b5/Error+
---------------------------------------------------------------------------
by toloco at 2013-03-14T10:37:09Z
https://gist.github.com/toloco/5160317 here you are the appDevUrlMatcher.php and meta
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T10:51:46Z
@toloco I applied @mpdude's solution (have a temp kernel class name of the same length than the real one).
Could you test it to see if it fixes your problem?
---------------------------------------------------------------------------
by mpdude at 2013-03-14T10:58:46Z
@jfsimon Thanks!
@toloco If Jean-François' fix does not work, please make sure that the .meta file you posted was the broken one? I was able to unserialize it without problems.
---------------------------------------------------------------------------
by toloco at 2013-03-14T11:02:09Z
Man!!!! you are the fucking boss it works!!
---------------------------------------------------------------------------
by mpdude at 2013-03-14T11:04:30Z
@jfsimon you just made someone happy.
---------------------------------------------------------------------------
by jfsimon at 2013-03-14T11:12:39Z
@toloco @mpdude \o/
This PR was squashed before being merged into the 2.1 branch (closes#7297).
Commits
-------
ef53456 [DoctrineBridge] Avoids blob values to be logged by doctrine
Discussion
----------
[DoctrineBridge] Avoids blob values to be logged by doctrine
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7012
---------------------------------------------------------------------------
by pborreli at 2013-03-07T17:07:23Z
what about clob ?
---------------------------------------------------------------------------
by jfsimon at 2013-03-07T17:10:45Z
@pborreli do you think clob values shouldn't be logged?
---------------------------------------------------------------------------
by pborreli at 2013-03-07T17:26:27Z
well they can have same size than blob
---------------------------------------------------------------------------
by beberlei at 2013-03-07T18:07:15Z
I agree, skipping clobs as well would be WIN :-)
---------------------------------------------------------------------------
by francisbesset at 2013-03-08T08:44:08Z
Where are the tests?
---------------------------------------------------------------------------
by beberlei at 2013-03-08T09:25:20Z
Ah yes, the DbalLogger has a testsuite, can you extend it to show this behavior works?
---------------------------------------------------------------------------
by jfsimon at 2013-03-08T10:28:53Z
@francisbesset @beberlei tests written.
---------------------------------------------------------------------------
by staabm at 2013-03-10T16:00:55Z
May I also ask for text/char fields with a certain amount of chars?
This PR was squashed before being merged into the 2.1 branch (closes#7325).
Commits
-------
6575df6 [Security] use current request attributes to generate redirect url?
Discussion
----------
[Security] use current request attributes to generate redirect url?
Maybe we should consider to use current request attributes to generate the login/logout redirections URL?
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5080
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T08:33:37Z
Can you explain why?
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T09:30:07Z
@Seldaek let say I prefixed all my URLs with a `{domain}` var (`_locale` for instance), I'd like it to be passed to my redirected request. I guess it could lead to side effects, that's why I tagged this PR `RFC`.
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T09:46:33Z
Fair enough. The main issue I see is that you end up with "garbage" query params in the URL. Any params that was needed by the previous page and not needed by the new one ends up as ?foo=bar in the URL. It's usually not harmful, but not very clean either. I'm not sure what it would take to grab all the params that a route can use, and only copy those over.
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T10:12:49Z
@Seldaek indeed, I didn't think about those query parameters... I'll try to fix this in a simple way this afternoon.
---------------------------------------------------------------------------
by jfsimon at 2013-03-11T14:54:31Z
@Seldaek tell me if what you think of this, it may look like a hack (which wont be acceptable).
---------------------------------------------------------------------------
by Seldaek at 2013-03-11T14:59:39Z
Eh I see. I can't say it's the less hacky thing I ever saw, but it might be alright. I don't think I'm the best person to take this call though.. Let's see what @fabpot thinks.
This PR was merged into the 2.1 branch.
Commits
-------
7216cb0 [Validator] fix showing wrong max file size for upload errors
Discussion
----------
[Validator] fix showing wrong max file size for upload errors
this was because the maxSize option wasn't parsed correctly and simple string comparision could lead to wrong results, e.g. 200 > 1000M
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes|]
| Fixed tickets | [#6441,#5551]
| License | MIT
Will apply cleanly to 2.2
This PR was merged into the 2.2 branch.
Commits
-------
4052865 Update time.html.twig
Discussion
----------
[WebprofilerBundle] Update time.html.twig
the "max" variable seems to be unused
This PR was squashed before being merged into the 2.1 branch (closes#7344).
Commits
-------
c423f16 [2.1][TwigBridge] Fixes Issue #7342 in TwigBridge
Discussion
----------
[2.1][TwigBridge] Fixes Issue #7342 in TwigBridge
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7342
| License | MIT
| Doc PR | --
---------------------------------------------------------------------------
by stof at 2013-03-12T13:28:15Z
Can you add a test to avoid regressions ?
---------------------------------------------------------------------------
by benbender at 2013-03-12T13:54:02Z
Done
---------------------------------------------------------------------------
by stevelacey at 2013-03-12T14:40:59Z
Looks good to me?
---------------------------------------------------------------------------
by pborreli at 2013-03-12T16:04:27Z
👍
This PR was merged into the 2.1 branch.
Commits
-------
5ad4bd1 [TwigBridge] now enter/leave scope on Twig_Node_Module
fe4cc24 [TwigBridge] fixed fixed scope & trans_default_domain node visitor
c5e999a [TwigBridge] fixed non probant tests & added new one
Discussion
----------
[TwigBundle] fixes errors with the default domain node visitor & scope
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7281
---------------------------------------------------------------------------
by Julien-Webgenery at 2013-03-12T16:35:58Z
👍
---------------------------------------------------------------------------
by lennerd at 2013-03-12T16:38:40Z
👍
---------------------------------------------------------------------------
by rc2c at 2013-03-12T16:53:04Z
👍
This PR was merged into the 2.1 branch.
Commits
-------
ae0b8ea [Translation] removed wriong 'use'
Discussion
----------
[Translation] removed wrong 'use'
Fixes last comment from #7304 // cc @stof
This PR was squashed before being merged into the 2.1 branch (closes#7304).
Commits
-------
5bc30bb [Translation] added xliff loader/dumper with resname support
Discussion
----------
[Translation] added xliff loader/dumper with resname support
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5940
---------------------------------------------------------------------------
by jfsimon at 2013-03-08T15:49:18Z
@Tobion what do you think of `XliffFileWithResnameDumper` and `XliffFileWithResnameLoader`?
---------------------------------------------------------------------------
by robinduval at 2013-03-08T15:49:58Z
💯 great idea !
---------------------------------------------------------------------------
by lizjulien at 2013-03-08T15:51:45Z
🌟 better.
---------------------------------------------------------------------------
by saro0h at 2013-03-08T15:52:50Z
👍 Can't be worse than the previous one
---------------------------------------------------------------------------
by dxb at 2013-03-08T16:00:32Z
+1
---------------------------------------------------------------------------
by Tobion at 2013-03-08T16:07:59Z
@jfsimon yes the name make sense. It is not possible to add this feature without BC break?
And if not, why not simply add an option/enable method to the existing classes. Having new classes for this seems awkward to me.
---------------------------------------------------------------------------
by jfsimon at 2013-03-08T16:17:44Z
@Tobion I totaly agree with you, but this has been discussed in #5940.
Does the presence of the `resname` attribute in the `trans-unit` tags represent a BC break?
Would opening another PR with this solution be a good idea?
---------------------------------------------------------------------------
by stof at 2013-03-08T17:01:00Z
Your XliffFileWithResnameLoader is able to load all files supported by XliffFileLoader so IMO you don't need to add a new class.
---------------------------------------------------------------------------
by jfsimon at 2013-03-08T18:21:32Z
@stof would the `resname` attribute addition in the dumped XLIFF be considered as a BC break?
---------------------------------------------------------------------------
by jfsimon at 2013-03-09T13:16:32Z
@stof done.
@mvrhov done.
This PR was squashed before being merged into the 2.1 branch (closes#7281).
Commits
-------
e3547c6 [TwigBridge] fixes
Discussion
----------
[TwigBridge] fixes `TranslationDefaultDomainNodeVisitor`
... by adding scope management.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6747
---------------------------------------------------------------------------
by vicb at 2013-03-06T15:14:57Z
Are `open` and `close` good names ? I would prefer `addChild` and `getParent` as there is nothing that is really opened or closed ?
Edit: by looking at the code a second time, I think open & close make sense .
---------------------------------------------------------------------------
by jfsimon at 2013-03-07T13:46:13Z
@vicb I know this is not consistent with the rest of the framework.
I dont think @fabpot will like them.
---------------------------------------------------------------------------
by stof at 2013-03-07T13:53:14Z
what about enter and leave ? It would be consistent with the naming used for scopes in the DI component
---------------------------------------------------------------------------
by vicb at 2013-03-07T13:59:35Z
@stof I like your proposal. My main concern being "leave" (former "close"), @jfsimon could you throw when a scope is used after it has been left ?
---------------------------------------------------------------------------
by jfsimon at 2013-03-07T14:01:56Z
go for enter/leave, but why throwing an exception on using a leaved scope?
---------------------------------------------------------------------------
by vicb at 2013-03-07T14:05:22Z
because if you have a ref to a left scope, you can still use it which is bad
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#7333).
Commits
-------
6992a9e [DependencyInjection] fixed id case when setting a service (also slightly enhanced an error message)
Discussion
----------
[DependencyInjection] fixed id case when setting a service (also slightly enhanced an error message)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#7320).
Commits
-------
7ff2d52 Property accessor custom array object fix
Discussion
----------
Property accessor custom array object fix
Copied `Symfony\Component\Form\Tests\Fixtures\CustomArrayObject` to Fixtures dir, and used it in tests to be able run tests separately from Form component,
This PR was squashed before being merged into the 2.2 branch (closes#7321).
Commits
-------
4f3771d [2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions
Discussion
----------
[2.2][HttpKernel] fixed wrong option name in FragmentHandler::fixOptions
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/7309
---------------------------------------------------------------------------
by Aitboudad at 2013-03-10T11:38:59Z
Hi @fabpot,
can you see why all commits has failed on Travis ?
---------------------------------------------------------------------------
by henrikbjorn at 2013-03-10T11:42:25Z
The test expects the option to be called `renderer` and not `strategy` so you need to change the tests.
---------------------------------------------------------------------------
by Aitboudad at 2013-03-10T12:19:19Z
@henrikbjorn thanks it's ok, but there is still 1 test :( in Symfony\Component\Form\Tests\Extension\Core\Type\TimeTypeTest::testSetDataDifferentTimezones
@bschussek Can you see why :).