This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Fix Container::camelize to convert beginning and ending . and _
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7431
| License | MIT
| Doc PR | n/a
I'm using strtr to make the conversion in order to ensure that the behavior is the same as `Container::get`.
From the test cases I've added, the following were not passing:
Commits
-------
485d53a [DependencyInjection] Fix Container::camelize to convert beginning and ending chars
This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Add exception for service name not dumpable in PHP
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8485#8030
| License | MIT
| Doc PR | n/a
Throws an exception when the DIC is dumped to PHP, before generating invalid PHP.
The regex comes from the PHP doc: http://www.php.net/manual/en/language.oop5.basic.php
Commits
-------
242b318 [DependencyInjection] Add exception for service name not dumpable in PHP
This PR was merged into the 2.2 branch.
Discussion
----------
[Security] fixed issue where x509 authentication clears unrelated tokens
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8226
| License | MIT
| Doc PR | symfony/symfony-docs#2825
| Notes | Replaces PR #8283
TODO:
- [x] Feedback on change to make sure security is not affected
- [x] Fix other authentication listeners (they suffer the same problem)
- [x] Write unit tests for bug and maybe a few listener classes as well
This pull request is the summary of the problem mentioned in the ticket above.
It only fixes the "disappearing token" problem for one authentication provider, not all. If acceptable, the change needs to be applied to all authentication listeners since they always clear all tokens from the security context.
Commits
-------
2317443 [Security] fixed issue where authentication listeners clear unrelated tokens
This commit fixes an issue where authentication listeners clear all security tokens in case of authentication failure.
This behavior makes it impossible to combine certain authentication mechanisms, notably x509 with form-based login.
This PR was merged into the 2.2 branch.
Discussion
----------
[bridge] [propel1] [ModelChoiceList] fix issue #8499 call getPrimaryKey on a non object
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8499
| License | MIT
| Doc PR | no
This fix an issue #8499 introduced by the PR #8223
CC @willdurand @havvg
Commits
-------
2ebb783 fix issue #8499 modelChoiceList call getPrimaryKey on a non object
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8479).
Discussion
----------
[HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8460
| License | MIT
| Doc PR | -
**warning** I did not try to reproduce this bug, so I am not sure it fixes the issue. I just open a PR with the suggested patch. Tests for http foundation are OK. I am not sur it's the best way to fix this issue as I do not understand why symfony reach this code if $_SESSION is not set.
Commits
-------
f5d59fb [HttpFoundation] Fixed NativeSessionStorage:regenerate when does not exists
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8477).
Discussion
----------
Reverts recent change that added type coercion for JSON responses
We shouldn't be coercing primitive in the array provided to setData.
Commits
-------
02e6aef Reverts JSON_NUMERIC_CHECK
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8476).
Discussion
----------
Just a typo
Just a typo in the doc
Commits
-------
fdaf59f Just a Typo
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8465).
Discussion
----------
[Config] Fixed error messages of min/max validation methods
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This PR fixes the error messages of the configuration validation methods `min` and `max`. The error message was "Should be greater/less than: <value>" but should be "Should be greater/less than or equal to <value>".
Commits
-------
3395837 Fixing configuration validation error messages.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8462).
Discussion
----------
[HttpKernel] fixed inline fragment renderer
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8450
| License | MIT
| Doc PR | none
Commits
-------
1554f1f [HttpKernel] fixed inline fragment renderer
This PR was merged into the 2.2 branch.
Discussion
----------
[Console] Show completed percentage, not a rounded value.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This pull request has 2 minor changes:
- 199/200 => 99% instead of 100% (there was no test case and I added one, everything else passes) In the past the value was rounded, the progress bar ended up being 100% for 0.5% of the total execution time. That means 18 seconds on a 1 hour process.
- Fixed the comments to match the inner workings of RedrawFrequency.
First Symfony PR and second overall so hope I just did this the right way.
PR #8419 Rebased for 2.2
Commits
-------
91bb757 ProgressHelper shows percentage complete.
40591b9 Comment fixed: RedrawFrequency is measured in steps.
In the past the value was rounded, the progressbar ended up being 100% for 0.5%
of the total execution time. That means 18 seconds on a 1 hour process.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8420).
Discussion
----------
Update JsonResponse.php
Added JSON_NUMERIC_CHECK flag to fix issues when json response is used in JavaScript apps and especially in AngularJS.
Commits
-------
2b1c973 Update JsonResponse.php
This PR was merged into the 2.2 branch.
Discussion
----------
Passed the config when building the Configuration in ConfigurableExtension
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This passes the config to ``getConfiguration`` instead of passing an empty array in ConfigurableExtension. This makes the class usable for bundle overwriting the ``getConfiguration`` method to use the config instead of using the default logic (which does not need the config).
Commits
-------
a830001 Passed the config when building the Configuration in ConfigurableExtension
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8400).
Discussion
----------
Replace romaji period characters with Japanese style zenkaku period char...
...acters
Found 4 of the Japanese translations inconsistently used romaji style periods. Replaced with zenkaku periods.
Commits
-------
1b3b1a7 Replace romaji period characters with Japanese style zenkaku period characters
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8363).
Discussion
----------
typo first->second
Commits
-------
2d9a84b typo first->second