Nicolas Grekas
b38a717d78
Merge branch '4.4'
...
* 4.4: (28 commits)
fix merge
[SecurityBundle] fix return type declarations
[BrowserKit] fix return type declarations
[PropertyInfo] fix return type declarations
[Bridge/Doctrine] fix return type declarations
[Form] fix return type declarations
[Console] fix return type declarations
[Intl] fix return type declarations
[Templating] fix return type declarations
[DomCrawler] fix return type declarations
[Validator] fix return type declarations
[Process] fix return type declarations
[Workflow] fix return type declarations
[Cache] fix return type declarations
[Serializer] fix return type declarations
[Translation] fix return type declarations
[DI] fix return type declarations
[Config] fix return type declarations
[HttpKernel] Fix return type declarations
[Security] Fix return type declarations
...
2019-08-26 11:05:36 +02:00
Nicolas Grekas
089097046b
Merge branch '4.3' into 4.4
...
* 4.3: (23 commits)
fix merge
[SecurityBundle] fix return type declarations
[BrowserKit] fix return type declarations
[PropertyInfo] fix return type declarations
[Bridge/Doctrine] fix return type declarations
[Form] fix return type declarations
[Console] fix return type declarations
[Intl] fix return type declarations
[Templating] fix return type declarations
[DomCrawler] fix return type declarations
[Validator] fix return type declarations
[Process] fix return type declarations
[Workflow] fix return type declarations
[Cache] fix return type declarations
[Serializer] fix return type declarations
[Translation] fix return type declarations
[DI] fix return type declarations
[Config] fix return type declarations
[HttpKernel] Fix return type declarations
[Security] Fix return type declarations
...
2019-08-26 11:00:56 +02:00
Nicolas Grekas
9e154e7728
fix merge
2019-08-26 10:55:16 +02:00
Nicolas Grekas
74b2802197
Merge branch '3.4' into 4.3
...
* 3.4: (21 commits)
[SecurityBundle] fix return type declarations
[BrowserKit] fix return type declarations
[PropertyInfo] fix return type declarations
[Bridge/Doctrine] fix return type declarations
[Form] fix return type declarations
[Console] fix return type declarations
[Intl] fix return type declarations
[Templating] fix return type declarations
[DomCrawler] fix return type declarations
[Validator] fix return type declarations
[Process] fix return type declarations
[Workflow] fix return type declarations
[Cache] fix return type declarations
[Serializer] fix return type declarations
[Translation] fix return type declarations
[DI] fix return type declarations
[Config] fix return type declarations
[HttpKernel] Fix return type declarations
[Security] Fix return type declarations
[Routing] Fix return type declarations
...
2019-08-26 10:26:39 +02:00
Nicolas Grekas
2ceb453ee5
[SecurityBundle] fix return type declarations
2019-08-26 09:52:58 +02:00
Alexander M. Turek
ca1fad471e
[DI] fix return type declarations
2019-08-26 09:52:58 +02:00
Nicolas Grekas
05fe553666
[HttpKernel] Fix return type declarations
2019-08-26 09:50:50 +02:00
Yonel Ceruto
dc8d470752
feature #33217 [FrameworkBundle][DX] Improving the redirect config when using RedirectController (yceruto)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle][DX] Improving the redirect config when using RedirectController
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/12189
follow-up https://github.com/symfony/symfony/pull/24637
**Before:**
```yaml
# config/routes.yaml
doc_shortcut:
path: /doc
controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::redirectAction
defaults:
route: 'doc_page'
legacy_doc:
path: /legacy/doc
controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController::urlRedirectAction
defaults:
path: 'https://legacy.example.com/doc '
```
**After:**
```yaml
# config/routes.yaml
doc_shortcut:
path: /doc
controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController
defaults:
route: 'doc_page'
legacy_doc:
path: /legacy/doc
controller: Symfony\Bundle\FrameworkBundle\Controller\RedirectController
defaults:
path: 'https://legacy.example.com/doc '
```
See more before/after configs (XML, PHP) in doc PR https://github.com/symfony/symfony-docs/pull/12189
Commits
-------
0ebb469
Improving redirect config when using RedirectController
2019-08-23 17:47:48 -04:00
Yonel Ceruto
0ebb469269
Improving redirect config when using RedirectController
2019-08-23 17:44:26 -04:00
Nicolas Grekas
1bbe5b853e
Merge branch '4.4'
...
* 4.4:
[HttpClient] Added TraceableHttpClient and WebProfiler panel
2019-08-23 19:20:36 +02:00
Jérémy Romey
51640012f1
[HttpClient] Added TraceableHttpClient and WebProfiler panel
...
Co-authored-by: Jérémy Romey <jeremy@free-agent.fr>
Co-authored-by: Timothée Barray <tim@amicalement-web.net>
2019-08-23 19:16:53 +02:00
Nicolas Grekas
9ce1f02501
Merge branch '4.4'
...
* 4.4:
Add more return types after fixing a typo in my script
2019-08-23 14:18:57 +02:00
Nicolas Grekas
65d942010c
Add more return types after fixing a typo in my script
2019-08-23 14:16:45 +02:00
Nicolas Grekas
0fc170a53a
Merge branch '4.4'
...
* 4.4:
Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)"
[Form][PropertyPathMapper] Avoid extra call to get config
[HttpKernel] remove unused fixtures
2019-08-22 18:30:10 +02:00
Nicolas Grekas
ba784bf430
Merge branch '4.3' into 4.4
...
* 4.3:
Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)"
[Form][PropertyPathMapper] Avoid extra call to get config
[HttpKernel] remove unused fixtures
2019-08-22 18:30:04 +02:00
Nicolas Grekas
aeba22c4ad
Merge branch '3.4' into 4.3
...
* 3.4:
Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)"
[Form][PropertyPathMapper] Avoid extra call to get config
2019-08-22 18:29:54 +02:00
Nicolas Grekas
1d7114957b
Revert "bug #31620 [FrameworkBundle] Inform the user when save_path will be ignored (gnat42)"
...
This reverts commit fea98a8473
, reversing
changes made to bd498f2503
.
2019-08-22 18:27:00 +02:00
Nicolas Grekas
d400aeb4f5
Merge branch '4.4'
...
* 4.4:
Add return types to internal & magic methods when possible
fixed CSC
Add Address::fromString
[DomCrawler] Added Crawler::matches(), ::closest(), ::outerHtml()
2019-08-22 15:39:30 +02:00
Nicolas Grekas
962dcfeed0
Add return types to internal & magic methods when possible
2019-08-22 15:18:41 +02:00
Nicolas Grekas
a84a7f0206
Merge branch '4.4'
...
* 4.4:
fix deps=low
[VarExporter] fix support for PHP 7.4
Use PHP 7.4 on deps=low
2019-08-22 10:40:55 +02:00
Nicolas Grekas
1981f06c88
Merge branch '4.3' into 4.4
...
* 4.3:
fix deps=low
[VarExporter] fix support for PHP 7.4
Use PHP 7.4 on deps=low
2019-08-22 10:37:03 +02:00
Nicolas Grekas
0a25ccab8e
fix deps=low
2019-08-22 10:16:11 +02:00
Nicolas Grekas
3979caf6ab
Merge branch '3.4' into 4.3
...
* 3.4:
Use PHP 7.4 on deps=low
2019-08-22 09:51:06 +02:00
Nicolas Grekas
21b87024f0
Use PHP 7.4 on deps=low
2019-08-22 08:53:14 +02:00
Nicolas Grekas
9fb1277c7f
Fix missing return types
2019-08-21 18:09:35 +02:00
Nicolas Grekas
b390ed7d88
Merge branch '4.4'
...
* 4.4:
Fixed tests on the Security and Form components
Add return types to tests and final|internal|private methods
2019-08-21 17:37:45 +02:00
Nicolas Grekas
fc186bb78f
Add return types to tests and final|internal|private methods
2019-08-21 17:14:41 +02:00
Nicolas Grekas
f07faaa757
Merge branch '4.4'
...
* 4.4:
Do not extend the new SF 4.3 ControllerEvent so we can make it final
Backported return type violation bugfixes.
fix deprecated call to setLocale with null
[FrameworkBundle] Fix BrowserKit assertions to make them compatible with Panther
[HttpKernel] deprecate global dir to load resources from
2019-08-21 17:11:23 +02:00
Nicolas Grekas
f499083f78
feature #33258 [HttpKernel] deprecate global dir to load resources from (Tobion)
...
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] deprecate global dir to load resources from
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | #31915 <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR |
Replaces #31958
Here two example deprecations by adding files in the deprecated locations:
```
Overwriting the resource "@AcmeBundle/Resources/config/routing.yaml" with "/vagrant/src/Resources/AcmeBundle/config/routing.yaml" is deprecated since Symfony 4.4 and will be removed in 5.0.
Loading the file "foobar.yaml" from the global resource directory "/vagrant/src" is deprecated since Symfony 4.4 and will be removed in 5.0.
```
Commits
-------
aa82566f76
[HttpKernel] deprecate global dir to load resources from
2019-08-21 17:04:54 +02:00
Alexander M. Turek
f30edcab65
Support for Twig 3.
2019-08-21 14:55:51 +02:00
Kévin Dunglas
2316dc36fb
[FrameworkBundle] Fix BrowserKit assertions to make them compatible with Panther
2019-08-21 14:46:38 +02:00
Fabien Potencier
36a011a0ee
Merge branch '4.4'
...
* 4.4:
Removed calls to Twig\Environment::loadTemplate().
[Intl] make polyfill classes abstract, fix edge case
[Mime] Trim and remove line breaks from NamedAddress name arg
deprecate support for null locales
[TwigBridge] Mark all classes extending twig as @final
[Mime] Remove NamedAddress
[Messenger] remove patch release BC layer of durable and expiring delay
2019-08-21 14:05:09 +02:00
Alexander M. Turek
ea9e375b0b
Removed calls to Twig\Environment::loadTemplate().
2019-08-21 13:24:25 +02:00
Fabien Potencier
eb7d74e6c5
[Mime] Remove NamedAddress
2019-08-21 09:13:01 +02:00
Tobias Schultze
aa82566f76
[HttpKernel] deprecate global dir to load resources from
2019-08-21 00:57:10 +02:00
Nicolas Grekas
6f303b4fed
[5.0] Add return types on internal|final|private methods
2019-08-20 23:44:01 +02:00
Nicolas Grekas
4036357150
Merge branch '4.4'
...
* 4.4:
some backports from master
Add return types to internal|final|private methods
[HttpFoundation] Precalculate session expiry timestamp
2019-08-20 18:53:57 +02:00
Nicolas Grekas
8073b8abfb
some backports from master
2019-08-20 18:35:28 +02:00
Nicolas Grekas
32116184d7
Add return types to internal|final|private methods
2019-08-20 17:32:53 +02:00
Nicolas Grekas
322da9df6c
Merge branch '4.4'
...
* 4.4:
cs fix
Fix inconsistent return points.
[Config] Add handling for ignored keys in ArrayNode::mergeValues.
Fix inconsistent return points.
[Security/Core] UserInterface::getPassword() can return null
cs fix
cs fix
Fix missing exporter in PHPUnit constraint poylfill
added `Process::getLastOutputTime()` method
[Router] Fix TraceableUrlMatcher behaviour with trailing slash
[HttpKernel] Remove outdated docblock comment
Fix handling for session parameters
Revert "bug #33092 [DependencyInjection] Improve an exception message (fabpot)"
2019-08-20 16:46:00 +02:00
Nicolas Grekas
225bf41e3b
Merge branch '4.3' into 4.4
...
* 4.3:
cs fix
Fix inconsistent return points.
[Config] Add handling for ignored keys in ArrayNode::mergeValues.
Fix inconsistent return points.
[Security/Core] UserInterface::getPassword() can return null
[Router] Fix TraceableUrlMatcher behaviour with trailing slash
Revert "bug #33092 [DependencyInjection] Improve an exception message (fabpot)"
2019-08-20 16:44:19 +02:00
Nicolas Grekas
5ec6ff378b
cs fix
2019-08-20 16:41:44 +02:00
Alexander M. Turek
c26c53596e
Fix inconsistent return points.
2019-08-20 16:27:59 +02:00
Nicolas Grekas
aefbc93a07
Merge branch '3.4' into 4.3
...
* 3.4:
Fix inconsistent return points.
[Security/Core] UserInterface::getPassword() can return null
[Router] Fix TraceableUrlMatcher behaviour with trailing slash
2019-08-20 16:07:54 +02:00
Nicolas Grekas
8069b58299
minor #33252 Fix inconsistent return points (derrabus)
...
This PR was merged into the 3.4 branch.
Discussion
----------
Fix inconsistent return points
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17201 in preparation for #33228
| License | MIT
| Doc PR | N/A
Inconsistent return points in methods prevent adding return types. I thought, I'll give it a try and fix them. After this PR, PhpStorm's inspection still finds 39 issues, but as far as I can tell, they're either false positives or fixture code.
Commits
-------
f5b6ee9de1
Fix inconsistent return points.
2019-08-20 15:34:30 +02:00
Alexander M. Turek
f5b6ee9de1
Fix inconsistent return points.
2019-08-20 15:31:17 +02:00
Nicolas Grekas
a2ef397ea3
Merge branch '4.3' into 4.4
...
* 4.3:
cs fix
cs fix
[HttpKernel] Remove outdated docblock comment
Fix handling for session parameters
2019-08-20 14:49:24 +02:00
Nicolas Grekas
2c1f349602
Merge branch '3.4' into 4.3
...
* 3.4:
cs fix
[HttpKernel] Remove outdated docblock comment
2019-08-20 14:49:02 +02:00
Nicolas Grekas
55a484dc20
cs fix
2019-08-20 14:35:37 +02:00
Fabien Potencier
3aceb6d3a2
bug #33232 Fix handling for session parameters (vkhramtsov)
...
This PR was merged into the 4.3 branch.
Discussion
----------
Fix handling for session parameters
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
b8c9e40980
Fix handling for session parameters
2019-08-19 14:41:34 +02:00