This PR was merged into the 2.0 branch.
Commits
-------
22c7a91 [HttpKernel][Translator] Fixed type-hints
Discussion
----------
[HttpKernel][Translator] Fixed type-hints
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
---------------------------------------------------------------------------
by drak at 2012-10-04T15:18:55Z
This PR is ready - the travis build fail is not related to this PR which is just docblock changes.
---------------------------------------------------------------------------
by pborreli at 2012-10-04T15:37:57Z
the travis build fail is indeed not related to your PR but your branch. see https://github.com/drak/symfony/blob/docb/.travis.yml
You should fetch upstream remote, merge, rebase and push again.
---------------------------------------------------------------------------
by drak at 2012-10-04T16:50:28Z
Thanks for the info, but the branch is 100% up to date with `2.0`, the file you quoted is as it is in the main repo: https://github.com/symfony/symfony/blob/2.0/.travis.yml - in any case, it doesnt affect merging this changeset.
This PR was merged into the 2.0 branch.
Commits
-------
6c59fbd [HttpFoundation] Fixed#5611 - Request::splitHttpAcceptHeader incorrect result order.
Discussion
----------
[HttpFoundation] Request::splitHttpAcceptHeader incorrect result order.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: 5611
Makes items with equal q-values return in the original provided order. Fixes tests to reflect this behavior.
---------------------------------------------------------------------------
by kerihenare at 2012-10-02T20:59:11Z
To avoid confusion over the modified language test I have instead created new tests.
This PR was squashed before being merged into the 2.0 branch (closes#5633).
Commits
-------
5c60a65 [2.0][http-foundation] Update phpdoc
c17462f [2.0][http-foundation] Fix response getDate method
Discussion
----------
[2.0][http-foundation] Fix Response::getDate method
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
Reference #5588, #5629
This PR was submitted for the master branch but it was merged into the 2.0 branch instead (closes#5622).
Commits
-------
538f8c7 fixed undefined variable
Discussion
----------
Undefined security http firewall context listener3
Updated minimal patch,
First patch from static code analysis, $value should be $token I guess. please check.
---------------------------------------------------------------------------
by h4ck3rm1k3 at 2012-09-27T18:00:18Z
I have reverted the admin, i could create a new branch if needed. you can just cherrypick e9bb5a8 that would be easier.
---------------------------------------------------------------------------
by h4ck3rm1k3 at 2012-09-27T18:29:36Z
I squashed it down to one commit. thanks for your patience and help.
This PR was submitted on branch master but was merged on branch 2.0 instead (closes#5624).
Commits
-------
05eaebf hasColorSupport does not take an argument
Discussion
----------
hasColorSupport does not take an argument
removed the uneeded argument. trivial patch.
Commits
-------
1402b42 Fixing config normalisation example in docblock
Discussion
----------
Fixing config normalisation example in docblock
Against 2.0 this time
as per @stof's comments in symfony/symfony-docs#1721
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: -
Fixes the following tickets: -
Todo: -
License of the code: MIT
Commits
-------
71d8148 Create CONTRIBUTING.md file for auto-linking in PR's
Discussion
----------
Create CONTRIBUTING.md file for auto-linking in PR's
See: https://github.com/blog/1184-contributing-guidelines
---------------------------------------------------------------------------
by kbond at 2012-09-17T17:35:26Z
@jmikola won the race
---------------------------------------------------------------------------
by stof at 2012-09-17T17:37:35Z
and this should be updated according to the discussion on the dev mailing-list
---------------------------------------------------------------------------
by fabpot at 2012-09-17T17:42:28Z
Instead of duplicating the information, I would just linked to the documentation.
---------------------------------------------------------------------------
by jmikola at 2012-09-17T18:42:29Z
I reduced the file to the "Contributing" block from the readme.
---------------------------------------------------------------------------
by lsmith77 at 2012-09-17T19:36:36Z
+1
Commits
-------
de6658b [Profiler]Use the abstract method to get client IP
Discussion
----------
[Profiler]Use the abstract method to get client IP
---------------------------------------------------------------------------
by armetiz at 2012-09-17T13:37:19Z
This PR is also done for master branch : https://github.com/symfony/symfony/pull/5527
Commits
-------
05f7f78 Fixed the phpdoc in the DependencyInjection component
Discussion
----------
Fixed the phpdoc in the DependencyInjection component
I was sick of having a warning in my IDE each time I used DefinitionDecorator because of an invalid phpdoc in the constructor, so I took some time and fixed it in the whole DI component.
---------------------------------------------------------------------------
by stof at 2012-09-07T23:09:04Z
The travis failure is unrelated. It is all about some intl failures.
---------------------------------------------------------------------------
by eventhorizonpl at 2012-09-07T23:37:04Z
Reviewed-by: Michal Piotrowski <michal@eventhorizon.pl>
---------------------------------------------------------------------------
by pborreli at 2012-09-08T01:42:26Z
👍
Commits
-------
f694615 [Process] fix ProcessTest::testProcessPipes hangs on Windows on branch 2.0
Discussion
----------
[Process] fix ProcessTest::testProcessPipes hangs on Windows on branch 2.0
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5343
Todo: -
License of the code: MIT
Documentation PR:
Marked the test as skipped on Windows, exactly as it is done on master branch (kind of backport)
---------------------------------------------------------------------------
by pborreli at 2012-08-25T20:06:58Z
👍
Commits
-------
9beffff [HttpKernel] KernelTest::testGetRootDir fails on Windows for branch 2.0
Discussion
----------
[HttpKernel] fix KernelTest::testGetRootDir fails on Windows for branch 2.0
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5341
Todo: -
License of the code: MIT
Documentation PR:
replace
$this->assertEquals(DIR, $kernel->getRootDir());
with
$this->assertEquals(DIR, realpath($kernel->getRootDir()));
line 287
---------------------------------------------------------------------------
by pborreli at 2012-08-25T20:23:34Z
👍
Commits
-------
e49afde Update monolog compatibility
832f8dd Add support for Monolog 1.2.0
Discussion
----------
Add support for Monolog 1.2.0
It's BC just in case someone still uses an older monolog version
---------------------------------------------------------------------------
by stloyd at 2012-08-19T07:20:24Z
IMO you should update `composer.json` too.
---------------------------------------------------------------------------
by Seldaek at 2012-08-19T07:36:51Z
1.* is still ok I think. Obviously the latest version is better, and if you update composer will pick the latest, but I don't think we need to force people to upgrade if there is no BC break.
---------------------------------------------------------------------------
by stloyd at 2012-08-19T07:46:31Z
But adding support for version `1.2` without changing `composer.json` which actually is: `>=1.0,<1.2-dev` is useless IMO.
---------------------------------------------------------------------------
by Seldaek at 2012-08-19T07:50:16Z
Where do you see `>=1.0,<1.2-dev`?
---------------------------------------------------------------------------
by stloyd at 2012-08-19T07:55:36Z
Here, in `2.0` branch: https://github.com/symfony/symfony/blob/2.0/composer.json#L21
---------------------------------------------------------------------------
by Seldaek at 2012-08-19T07:58:28Z
Ok fixed.. Everywhere else in the master branch it is required with `1.*` so I didn't get what you meant :)
Commits
-------
1a4a4ee [DependencyInjection] Fixed a frozen constructor of a container with no parameters
2a124bc [DependencyInjection] Added a test for a frozen constructor of a container with no parameters
Discussion
----------
[DependencyInjection] Fix PHP Dumper for a constructor of a frozen container with no parameters
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets:
Todo: -
License of the code: MIT
---------------------------------------------------------------------------
by travisbot at 2012-08-06T16:51:20Z
This pull request [passes](http://travis-ci.org/symfony/symfony/builds/2049206) (merged 1a4a4ee9 into 3d32a0bc).