diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
45,618 Commits 24 Branches 563 Tags 228 MiB
b4c8d51fed
Commit Graph

36988 Commits

Author SHA1 Message Date
Nicolas Grekas
81ba73cb7b bug #33573 [TwigBridge] Add row_attr to all form themes (fancyweb) 
This PR was merged into the 4.3 branch.

Discussion
----------

[TwigBridge] Add row_attr to all form themes

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #33552
| License       | MIT
| Doc PR        | -

The rules I applied:
- Always done on the first HTML tag of the row.
- Current existing row attrs (`class` or `style`) are applied unless they are defined by the `row_attr` override. They can be removed if they are explicitly set to `false`.

Starting from:
```
<div class="form-group">
```

With `row_attr: {foo: "bar"}`:
```
<div foo="bar" class="form-group">
```

With `row_attr: {class: "ccc"}`:
```
<div class="ccc">
```

With `row_attr: {foo: "bar", class: false}`:
```
<div foo="bar">
```

Commits
-------

dfdcbb401e [TwigBridge] Add row_attr to all form themes
 2019-11-28 12:39:15 +01:00
Nicolas Grekas
50db43fc4c bug #34019 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor (Dario Savella) 
This PR was squashed before being merged into the 4.3 branch.

Discussion
----------

[Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

My first pull request...
The following code:
```
$data = <<<EOD
a,b
c,d
EOD;
$encoder = new CsvEncoder([CsvEncoder::NO_HEADERS_KEY=>true]);
var_dump($encoder->decode($data,'csv'));
```
produces:
```
array(2) {
  'a' =>
  string(1) "c"
  'b' =>
  string(1) "d"
}
```
instead of the expected:
```
array(2) {
  [0] =>
  array(2) {
    [0] =>
    string(1) "a"
    [1] =>
    string(1) "b"
  }
  [1] =>
  array(2) {
    [0] =>
    string(1) "c"
    [1] =>
    string(1) "d"
  }
}
```

Commits
-------

a0430f6917 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
 2019-11-28 12:29:50 +01:00
Dario Savella
a0430f6917 [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor 2019-11-28 12:29:45 +01:00
Nicolas Grekas
ab5e7fa706 bug #34083 [Form] Keep preferred_choices order for choice groups (vilius-g) 
This PR was squashed before being merged into the 4.3 branch.

Discussion
----------

[Form] Keep preferred_choices order for choice groups

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Since 4.3 ordering of `preferred_choices` is preserved when displaying form. But this only works for flat options. When the choices are grouped, the preferred groups are in default order.

Now the preferred choice group order is derived by taking the first matching choice from `preferred_choices` and using its position to sort the groups.

Commits
-------

75404e5287 [Form] Keep preferred_choices order for choice groups
 2019-11-28 12:24:09 +01:00
Vilius Grigaliūnas
75404e5287 [Form] Keep preferred_choices order for choice groups 2019-11-28 12:22:21 +01:00
Nicolas Grekas
3688c3aebb Merge branch '3.4' into 4.3 
* 3.4:
  [DI] Missing test on YamlFileLoader
 2019-11-28 12:13:33 +01:00
Nicolas Grekas
84b5db3a44 minor #34675 [DI] Missing test on YamlFileLoader (maxhelias) 
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Missing test on YamlFileLoader

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  |no
| Deprecations? |no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Missing test on YamlFileLoader

Commits
-------

b9d5237f67 [DI] Missing test on YamlFileLoader
 2019-11-28 12:10:43 +01:00
Nicolas Grekas
789c863233 bug #34091 [Debug] work around failing chdir() on Darwin (mary2501) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Debug] work around failing chdir() on Darwin

| Q             | A
| ------------- | ---
| Branch?       |  4.3 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix https://github.com/happybottoms/coverd/issues/15 <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

f40373eb7c [Debug] work around failing chdir() on Darwin
 2019-11-28 11:55:21 +01:00
Maria Grazia Patteri
f40373eb7c [Debug] work around failing chdir() on Darwin 2019-11-28 11:53:46 +01:00
Nicolas Grekas
da459d731f bug #34305 [PhpUnitBridge] Read configuration CLI directive (ro0NL) 
This PR was merged into the 4.3 branch.

Discussion
----------

[PhpUnitBridge] Read configuration CLI directive

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34300
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

22931a0d4a [PhpUnitBridge] Read configuration CLI directive
 2019-11-28 11:35:16 +01:00
Roland Franssen
22931a0d4a [PhpUnitBridge] Read configuration CLI directive 2019-11-28 11:34:19 +01:00
Nicolas Grekas
33731bf287 bug #34490 [Serializer] Fix MetadataAwareNameConverter usage with string group (antograssiot) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Serializer] Fix MetadataAwareNameConverter usage with string group

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34455
| License       | MIT
| Doc PR        |

Allow to use the short syntax for serialization context group like `['groups' => 'user']`

Commits
-------

d4f749a465 [Serializer] Fix MetadataAwareNameConverter usage with string group
 2019-11-28 11:19:20 +01:00
Maxime Helias
b9d5237f67 [DI] Missing test on YamlFileLoader 2019-11-28 11:09:39 +01:00
Nicolas Grekas
53241df2df Revert "minor #34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)" 
This reverts commit 5cacc5dd69, reversing
changes made to f0a6de2736.
 2019-11-28 11:05:51 +01:00
Nicolas Grekas
4375742f2c Merge branch '3.4' into 4.3 
* 3.4:
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Process] add tests for php executable finder if file does not exist
  [Cache] Make sure we get the correct number of values from redis::mget()
 2019-11-28 11:05:26 +01:00
Roy-Orbison
388528da50 Simpler example for Apache basic auth workaround 
Uses a simpler regex and existing back-reference instead of reading header twice.
 2019-11-28 10:37:24 +01:00
Ali Tavafi
069d214210 [Console] Fix trying to access array offset on value of type int 2019-11-28 10:13:48 +01:00
David Buchmann
c6ed0f0208 more robust initialization from request 
Request::getPort is declared as int|string but can actually return null.
 2019-11-28 09:59:10 +01:00
Maxime Steinhausser
9f19ae185d [Config] Remove extra sprintf arg 2019-11-28 09:31:09 +01:00
Nicolas Grekas
ed22c85635 [HttpKernel] fix typo 2019-11-28 09:08:13 +01:00
Nicolas Grekas
396da3726b bug #34669 [HttpClient] turn exception into log when the request has no content-type (nicolas-grekas) 
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] turn exception into log when the request has no content-type

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted while merging a PR with ext-curl disabled:

```
  [Symfony\Component\HttpClient\Exception\TransportException]
  fopen(): Content-type not specified assuming application/x-www-form-urlencoded
```

This is now a log.

Commits
-------

4c671a4487 [HttpClient] turn exception into log when the request has no content-type
 2019-11-28 09:02:16 +01:00
Nicolas Grekas
f9e6f11bea bug #34662 [HttpKernel] Support typehint to deprecated FlattenException in controller (andrew-demb) 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Support typehint to deprecated FlattenException in controller

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34661
| License       | MIT
| Doc PR        |

We should support converting throwable to `FlattenException` with typehint to deprecated class also

Commits
-------

26b4e372dd [HttpKernel] Support typehint to deprecated FlattenException in controller
 2019-11-28 08:56:36 +01:00
Andrii Dembitskyi
26b4e372dd [HttpKernel] Support typehint to deprecated FlattenException in controller 2019-11-28 08:56:28 +01:00
Yonel Ceruto
38493b3e4b Add preview mode support for Html and Serializer error renderers 2019-11-28 08:51:03 +01:00
Nicolas Grekas
ac20382f41 minor #34617 [FWBundle] Remove error_renderer.serializer if the Serializer isn't available (dunglas) 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[FWBundle] Remove error_renderer.serializer if the Serializer isn't available

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

(Should help for https://github.com/hautelook/AliceBundle/pull/485).

Commits
-------

0b4c21b3d2 [FWBundle] Remove error_renderer.serializer if the Serializer isn't available
 2019-11-28 08:41:19 +01:00
Kévin Dunglas
0b4c21b3d2 [FWBundle] Remove error_renderer.serializer if the Serializer isn't available 2019-11-28 08:41:13 +01:00
Sylvain METAYER
d4c34e00ac [VarDumper] notice on potential undefined index 2019-11-28 08:25:37 +01:00
Nicolas Grekas
4c671a4487 [HttpClient] turn exception into log when the request has no content-type 2019-11-27 23:48:43 +01:00
Ahmed
2b62dc3fc5 [Process] add tests for php executable finder if file does not exist 2019-11-27 23:46:56 +01:00
Nicolas Grekas
c79a498299 minor #34653 [FrameworkBundle][Lock] fix interface for definition (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][Lock] fix interface for definition

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34585
| License       | MIT
| Doc PR        |

Commits
-------

e1d1a98a2a fix interface for definition
 2019-11-27 20:03:09 +01:00
Emanuele Panzeri
685c36c3d2 [Cache] Make sure we get the correct number of values from redis::mget() 2019-11-27 19:56:02 +01:00
Christian Flothmann
e1d1a98a2a fix interface for definition 2019-11-27 12:40:37 +01:00
Robin Chalas
cde2538849 Merge branch '4.3' into 4.4 
* 4.3:
  [FWBundle] Remove unused parameter
  [Intl] [Workflow] fixes English grammar typos
  [Filesystem] [Serializer] fixes English grammar typo
  [Messenger] Adding exception to amqp transport in case amqp ext is not installed
  [Monolog Bridge] Fixed accessing static property as non static.
  Improve Symfony description
  Add DateTimeZoneNormalizer into Dependency Injection
  [Messenger] Error when specified default bus is not among the configured
  [Validator] Add Japanese translation
  [Workflow] Apply the same logic of precedence between the apply() and the buildTransitionBlockerList() method
  Remove some unused methods parameters
  Avoid empty \"If-Modified-Since\" header in validation request
  [Security] Fix SwitchUser is broken when the User Provider always returns a valid user
  Fix error message according to the new regex
  compatibility with DoctrineBundle 2
  [Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls
 2019-11-27 00:16:41 +01:00
Fabien Potencier
51d756f65a bug #34621 [Routing] Continue supporting single colon in object route loaders (fancyweb) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Routing] Continue supporting single colon in object route loaders

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/34612
| License       | MIT
| Doc PR        | -

https://github.com/symfony/symfony/pull/32582#discussion_r304824139 was a bad idea. The new `ObjectLoader` class is used directly on 4.4 since we detagged the old service (and the old one). So we need to support the old notation on it. It changes the exception message but it should be alright.

Commits
-------

3c796e120c [Routing] Continue supporting single colon in object route loaders
 2019-11-26 14:01:00 +01:00
Christian Flothmann
4633993cc1 minor #34625 [HttpKernel] reset the kernel cache after each test (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] reset the kernel cache after each test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

5b5927b93b reset the kernel cache after each test
 2019-11-26 12:29:28 +01:00
Nicolas Grekas
59b6cfef4c bug #34554 [HttpClient] Fix early cleanup of pushed HTTP/2 responses (lyrixx) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] Fix early cleanup of pushed HTTP/2 responses

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

0f51da6ec7 [HttpClient] Fix early cleanup of pushed HTTP/2 responses
 2019-11-26 10:41:30 +01:00
Christian Flothmann
5b5927b93b reset the kernel cache after each test 2019-11-26 10:38:45 +01:00
Nicolas Grekas
127ebeee1f bug #34607 [HttpKernel] Ability to define multiple kernel.reset tags (rmikalkenas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Ability to define multiple kernel.reset tags

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34606
| License       | MIT
| Doc PR        |

All info #34606

Commits
-------

6f8dbf1a5f [HttpKernel] Ability to define multiple kernel.reset tags
 2019-11-26 10:37:37 +01:00
Rokas Mikalkėnas
6f8dbf1a5f [HttpKernel] Ability to define multiple kernel.reset tags 2019-11-26 10:37:14 +01:00
Thomas Calvet
3c796e120c [Routing] Continue supporting single colon in object route loaders 2019-11-26 09:26:36 +01:00
Fabien Potencier
74cfa364c0 minor #34616 [FWBundle] Remove unused parameter (dunglas) 
This PR was merged into the 4.3 branch.

Discussion
----------

[FWBundle] Remove unused parameter

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

22a7f40cb8 [FWBundle] Remove unused parameter
 2019-11-26 04:46:36 +01:00
Fabien Potencier
877376a8b3 minor #34603 [Intl] [Workflow] fixes English grammar typos (hhamon) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Intl] [Workflow] fixes English grammar typos

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Also related to #34604

Commits
-------

492e1b5afd [Intl] [Workflow] fixes English grammar typos
 2019-11-26 04:45:55 +01:00
Fabien Potencier
4daa83e8fc Merge branch '3.4' into 4.3 
* 3.4:
  [Filesystem] [Serializer] fixes English grammar typo
  [Monolog Bridge] Fixed accessing static property as non static.
  Improve Symfony description
  [Validator] Add Japanese translation
  Remove some unused methods parameters
  Avoid empty \"If-Modified-Since\" header in validation request
  [Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls
 2019-11-26 04:44:44 +01:00
Kévin Dunglas
22a7f40cb8
[FWBundle] Remove unused parameter 2019-11-25 23:12:50 +01:00
Hugo Hamon
492e1b5afd [Intl] [Workflow] fixes English grammar typos 2019-11-25 17:40:38 +01:00
Hugo Hamon
7524ac2866 [Filesystem] [Serializer] fixes English grammar typo 2019-11-25 17:36:22 +01:00
Hugo Monteiro
fa3f901cf8 mailer: mailchimp bridge is throwing undefined index _id when setting message id in mandrill http transport 2019-11-25 14:55:17 +00:00
Grégoire Pineau
cc400f867e bug #34569 [Workflow] Apply the same logic of precedence between the apply() and the buildTransitionBlockerList() method (lyrixx) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Workflow] Apply the same logic of precedence between the apply() and the buildTransitionBlockerList() method

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34489
| License       | MIT
| Doc PR        |

Commits
-------

2ff3496d62 [Workflow] Apply the same logic of precedence between the apply() and the buildTransitionBlockerList() method
 2019-11-25 15:05:10 +01:00
Grégoire Pineau
0f51da6ec7 [HttpClient] Fix early cleanup of pushed HTTP/2 responses 2019-11-25 13:42:17 +01:00
Christian Flothmann
986cfc6580 skip test on incompatible PHP versions 2019-11-25 11:39:47 +01:00
Nicolas Grekas
be80db3dc8 [HttpKernel] Don't cache "not-fresh" state 2019-11-25 10:10:35 +01:00
Fabien Potencier
350e1100d5 bug #34577 [FrameworkBundle][Cache] Don't deep-merge cache pools configuration (alxndrbauer) 
This PR was squashed before being merged into the 4.4 branch (closes #34577).

Discussion
----------

[FrameworkBundle][Cache] Don't deep-merge cache pools configuration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34488
| License       | MIT

Prevents deep-merge of cache.pools configuration

Commits
-------

a0d6d30c9f [FrameworkBundle][Cache] Don't deep-merge cache pools configuration
 2019-11-25 08:14:59 +01:00
Alexander Bauer
a0d6d30c9f [FrameworkBundle][Cache] Don't deep-merge cache pools configuration 2019-11-25 08:14:53 +01:00
Fabien Potencier
f6c4b67fe3 bug #34515 [DependencyInjection] definitions are valid objects (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] definitions are valid objects

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34480
| License       | MIT
| Doc PR        |

Commits
-------

0acaa5cfb3 definitions are valid objects
 2019-11-25 08:06:53 +01:00
Fabien Potencier
218eb24197 bug #34536 [SecurityBundle] Don't require a user provider for the anonymous listener (chalasr) 
This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] Don't require a user provider for the anonymous listener

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34504
| License       | MIT
| Doc PR        | -

Forgotten when adding the AnonymousFactory in #33503

Commits
-------

0950cfbc65 [SecurityBundle] Don't require a user provider for the anonymous listener
 2019-11-25 07:29:03 +01:00
Christopher Hertel
f15e0e6a43 [Messenger] Adding exception to amqp transport in case amqp ext is not installed 2019-11-25 07:26:43 +01:00
Robin Chalas
0950cfbc65 [SecurityBundle] Don't require a user provider for the anonymous listener 2019-11-24 20:28:56 +01:00
Sander Toonen
aa045d10b9 [Monolog Bridge] Fixed accessing static property as non static. 2019-11-24 19:38:42 +01:00
Fabien Potencier
9623414f8b minor #34574 [FrameworkBundle] fix leftover mentioning "secret:" processor (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix leftover mentioning "secret:" processor

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

f46f3db058 [FrameworkBundle] fix leftover mentioning "secret:" processor
 2019-11-24 19:14:59 +01:00
Fabien Potencier
212931e43c minor #34543 Add missing defaultPriorityMethod field in TaggedIteratorArgument (alexandrunastase) 
This PR was merged into the 4.4 branch.

Discussion
----------

 Add missing defaultPriorityMethod field in TaggedIteratorArgument

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | <!-- prefix each issue number with "Fix #", if any -->
| License       | MIT
| Doc PR        |  <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

#SymfonyHackday

Commits
-------

f5bd421597  Add missing defaultPriorityMethod field in TaggedIteratorArgument
 2019-11-24 19:11:43 +01:00
Nicolas Grekas
f46f3db058 [FrameworkBundle] fix leftover mentioning "secret:" processor 2019-11-24 19:10:25 +01:00
Fabien Potencier
6e60fd0113 bug #34502 [FrameworkBundle][ContainerLint] Keep "removing" compiler passes (fancyweb) 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle][ContainerLint] Keep "removing" compiler passes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/34498
| License       | MIT
| Doc PR        | -

Removing "removing" compiler passes when debug is off (why only in this case btw?) means that the container is never cleaned (the important thing being the "remove unused definitions" pass), leaving it in a "dirty" state. What is the point of testing a container that is different than the one that will be used anyway? 🤔

Making this truely work btw means that 100% of Symfony's declared services must end up valid whether they are used or not and in all combinations possible. I guess that should be the goal but from what I could test in the last hour, that will be a lot of work. However, there are definitely some fixes to do in our services declarations that we can detect thanks to this "bug".

Commits
-------

59d677182e [FrameworkBundle][ContainerLint] Keep removing compiler passes
 2019-11-24 19:08:49 +01:00
Fabien Potencier
0ea13868fa bug #34552 [Dotenv] don't fail when referenced env var does not exist (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Dotenv] don't fail when referenced env var does not exist

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34537
| License       | MIT
| Doc PR        |

Commits
-------

8026609dc9 don't fail when referenced env var does not exist
 2019-11-24 19:05:55 +01:00
jewome62
1a81dd7de8 Add DateTimeZoneNormalizer into Dependency Injection 2019-11-24 19:02:12 +01:00
Fabien Potencier
08489ce99f bug #34547 [Messenger] Error when specified default bus is not among the configured (vudaltsov) 
This PR was squashed before being merged into the 4.3 branch (closes #34547).

Discussion
----------

[Messenger] Error when specified default bus is not among the configured

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

This is a bug fix because the error occurs during the di compilation anyway.

Commits
-------

dd92d2bb10 [Messenger] Error when specified default bus is not among the configured
 2019-11-24 18:55:19 +01:00
Valentin Udaltsov
dd92d2bb10 [Messenger] Error when specified default bus is not among the configured 2019-11-24 18:55:09 +01:00
Issei.M
6cea35a108 [Validator] Add Japanese translation 2019-11-24 18:47:24 +01:00
Fabien Potencier
e757512f8f bug #34513 [Validator] remove return type declaration from __sleep() (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] remove return type declaration from __sleep()

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34478
| License       | MIT
| Doc PR        |

Commits
-------

bedad35e59 remove return type declaration from __sleep()
 2019-11-24 18:43:39 +01:00
Fabien Potencier
df6c635df2 minor #34561 Remove some unused methods parameters (fancyweb) 
This PR was merged into the 3.4 branch.

Discussion
----------

Remove some unused methods parameters

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR removes some useless private method parameters.

Commits
-------

026730e913 Remove some unused methods parameters
 2019-11-24 18:40:20 +01:00
Grégoire Pineau
2ff3496d62 [Workflow] Apply the same logic of precedence between the apply() and the buildTransitionBlockerList() method 2019-11-24 18:22:56 +01:00
Thomas Calvet
026730e913 Remove some unused methods parameters 2019-11-23 21:30:33 +01:00
Christophe Coevoet
7d87ebce2c bug #34385 Avoid empty "If-Modified-Since" header in validation request (mpdude) 
This PR was squashed before being merged into the 3.4 branch (closes #34385).

Discussion
----------

Avoid empty "If-Modified-Since" header in validation request

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Just noticed that when a response has been cached that is `public` and has an `maxAge` but does _not_ provide `Last-Modified`, the validation subrequest will have an empty `If-Modified-Since` header value.

Commits
-------

960faef66f Avoid empty \"If-Modified-Since\" header in validation request
 2019-11-23 16:08:00 +01:00
Matthias Pigulla
960faef66f Avoid empty \"If-Modified-Since\" header in validation request 2019-11-23 16:07:54 +01:00
Christian Flothmann
8026609dc9 don't fail when referenced env var does not exist 2019-11-23 15:53:46 +01:00
Tugdual Saunier
2bf6cd2eea
[Security] Fix SwitchUser is broken when the User Provider always returns a valid user 2019-11-23 15:44:33 +01:00
Alexandru Năstase
f5bd421597
Add missing defaultPriorityMethod field in TaggedIteratorArgument 2019-11-23 11:53:09 +01:00
elementaire
7425d2c69d
Fix error message according to the new regex 
Complete https://github.com/symfony/symfony/pull/34448
 2019-11-22 15:36:52 +01:00
Christian Flothmann
6ff20f0122 compatibility with DoctrineBundle 2 2019-11-22 14:37:01 +01:00
Christian Flothmann
93685026b0 drop return type declaration 
The configured memory limit can exceed the range that can be represented
by an integer.
 2019-11-22 14:14:59 +01:00
Christian Flothmann
0acaa5cfb3 definitions are valid objects 2019-11-22 13:53:53 +01:00
Christian Flothmann
bedad35e59 remove return type declaration from __sleep() 2019-11-22 13:40:21 +01:00
Thomas Calvet
59d677182e [FrameworkBundle][ContainerLint] Keep removing compiler passes 2019-11-21 23:20:32 +01:00
Thomas Calvet
dfdcbb401e [TwigBridge] Add row_attr to all form themes 2019-11-21 14:34:54 +01:00
tien.xuan.vo
b435b1aab6 [Messenger] Ignore stamps in in-memory transport 2019-11-21 19:55:17 +07:00
Anto
d4f749a465
[Serializer] Fix MetadataAwareNameConverter usage with string group 
fixes 34455
 2019-11-21 13:47:16 +01:00
Fabien Potencier
a7fe2b29d2 Bump Symfony version to 4.4.1 2019-11-21 08:13:22 +01:00
Fabien Potencier
65ec3b47e8 Update VERSION for 4.4.0 2019-11-21 08:08:15 +01:00
Nicolas Grekas
2c1b1bad6e bug #34464 [Form] group constraints when calling the validator (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] group constraints when calling the validator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follow up of https://github.com/symfony/symfony/pull/34081
Spotted during the workshop at SymfonyCon, while trying to fix deprecation notices on symfony-demo:
the Form component currently passes constraints one by one for validation, effectively preventing the validator from taking care of cross-constraints dependencies.

This PR fixes it.

This will prevent ppl from having to fix things like
> Using the "Symfony\Component\Validator\Constraints\Length" constraint with the "min" option without setting the "allowEmptyString" one is deprecated and defaults to true. In 5.0, it will become optional and default to false.

Commits
-------

d15f77f33e [Form] group constraints when calling the validator
 2019-11-21 08:01:17 +01:00
Nicolas Grekas
698cc6bb3b [Routing] fix tests 2019-11-20 14:44:34 +01:00
Nicolas Grekas
6f110581df Merge branch '4.3' into 4.4 
* 4.3:
  [DependencyInjection] Fix dumping multiple deprecated aliases
 2019-11-20 14:27:43 +01:00
Nicolas Grekas
d15f77f33e [Form] group constraints when calling the validator 2019-11-20 13:58:23 +01:00
Nicolas Grekas
8d84ac34a5 Remove wrong @group legacy annotations 2019-11-20 11:44:55 +01:00
Maxime Steinhausser
8d1f32613b [Validator] ConstraintValidatorTestCase: add missing return value to mocked validate method calls 2019-11-19 17:21:35 +01:00
Soner Sayakci
60b0dae174
[DependencyInjection] Fix dumping multiple deprecated aliases 2019-11-19 16:12:52 +01:00
Nicolas Grekas
12f00e3e15 Merge branch '4.3' into 4.4 
* 4.3:
  allow button names to start with uppercase letter
 2019-11-19 13:20:06 +01:00
Christian Flothmann
d811b0e9b5 allow button names to start with uppercase letter 2019-11-19 08:55:12 +01:00
Baptiste Clavié
8a460cefef
States that the HttpClient provides a Http Async implementation 2019-11-18 13:47:27 +01:00
Robin Chalas
aab9b43d03 [HttpKernel] Make ErrorListener::onKernelException()'s dispatcher argument explicit 2019-11-18 00:49:10 +01:00
Robin Chalas
76d3112d8e bug #34428 [Security] Fix best encoder not wired using migrate_from (chalasr) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Fix best encoder not wired using migrate_from

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Thanks @wouterj for spotting it.

Commits
-------

4132a60392 [Security] Fix best encoder not wired using migrate_from
 2019-11-17 23:59:41 +01:00
Graham Campbell
754fbe41fb
Removed extra whitespace 2019-11-17 22:49:13 +00:00
Robin Chalas
4132a60392 [Security] Fix best encoder not wired using migrate_from 2019-11-17 23:41:50 +01:00
Nicolas Grekas
80e4ed1a32 Merge branch '4.3' into 4.4 
* 4.3:
  [Finder] Fixed docs
  Fix PR template
  Adjust pull request template for 5.0 branchout
  Update HttpKernel.php
 2019-11-17 22:56:56 +01:00
Nicolas Grekas
90431e78e2 Merge branch '3.4' into 4.3 
* 3.4:
  [Finder] Fixed docs
  Fix PR template
  Adjust pull request template for 5.0 branchout
  Update HttpKernel.php
 2019-11-17 22:56:13 +01:00
Markus Staab
e7d0787a4d [Finder] Fixed docs 2019-11-17 22:55:15 +01:00
Nardberjean
7b7f966711 Update HttpKernel.php 2019-11-17 21:23:00 +01:00
Fabien Potencier
7ed6d35f2c bumped Symfony version to 4.4.0 2019-11-17 15:29:13 +01:00
Fabien Potencier
bef727c673 updated VERSION for 4.4.0-RC1 2019-11-17 15:24:08 +01:00
Nicolas Grekas
0c12b9e31b Merge branch '4.3' into 4.4 
* 4.3:
  [Cache] Disable igbinary on PHP >= 7.4
 2019-11-17 12:01:12 +01:00
Nicolas Grekas
a2c924d772 [Cache] Disable igbinary on PHP >= 7.4 2019-11-17 11:56:39 +01:00
Nicolas Grekas
88cf8a7d48 Merge branch '4.3' into 4.4 
* 4.3:
  [FrameworkBundle] Remove project dir from Translator cache vary scanned directories
  [HttpFoundation] Allow redirecting to URLs that contain a semicolon
  catch exceptions when using PDO directly
  [SecurityBundle] fix failing test
 2019-11-17 11:10:42 +01:00
Nicolas Grekas
d20f544e14 Merge branch '3.4' into 4.3 
* 3.4:
  [HttpFoundation] Allow redirecting to URLs that contain a semicolon
 2019-11-17 11:10:32 +01:00
Fabien Potencier
085c6c069e bug #34347 [Messenger] Perform no deep merging of bus middleware (vudaltsov) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Messenger] Perform no deep merging of bus middleware

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

This change helps in case one needs to configure a bus differently for a custom environment while keeping existing handlers attached by name.

Commits
-------

c264583f28 [Messenger] Perform no deep merging of bus middleware
 2019-11-17 11:09:18 +01:00
Valentin Udaltsov
c264583f28 [Messenger] Perform no deep merging of bus middleware 2019-11-17 11:02:20 +01:00
Fabien Potencier
2b05b71999 feature #34405 [HttpFoundation] Added possibility to configure expiration time in redis session handler (mantulo) 
This PR was squashed before being merged into the 4.4 branch (closes #34405).

Discussion
----------

[HttpFoundation] Added possibility to configure expiration time in redis session handler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |  n/a
| License       | MIT
| Doc PR        | n/a

Add possibility to manually configure expiration time in redis session handler.

Commits
-------

4a9d947b1a [HttpFoundation] Added possibility to configure expiration time in redis session handler
 2019-11-17 11:00:25 +01:00
Vladimir
4a9d947b1a [HttpFoundation] Added possibility to configure expiration time in redis session handler 2019-11-17 11:00:20 +01:00
Fabien Potencier
c1cab2bbc7 bug #34384 [DoctrineBridge] Improve queries parameters display in Profiler (fancyweb) 
This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Improve queries parameters display in Profiler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | https://github.com/symfony/symfony/issues/34234
| License       | MIT
| Doc PR        | -

##  Stringable object:
_The query is runnable._
### Before
<img width="773" alt="Screenshot 2019-11-14 at 21 05 53" src="https://user-images.githubusercontent.com/3658119/68892948-669cf180-0724-11ea-889b-8ce781956fc7.png">

### After
<img width="780" alt="Screenshot 2019-11-14 at 20 56 38" src="https://user-images.githubusercontent.com/3658119/68892978-787e9480-0724-11ea-843b-70a595633192.png">

## Non stringable object:
_Exception, the query is not runnable._
### Before
<img width="783" alt="Screenshot 2019-11-14 at 21 05 31" src="https://user-images.githubusercontent.com/3658119/68892993-80d6cf80-0724-11ea-9961-e32b65f81508.png">

### After
<img width="622" alt="Screenshot 2019-11-14 at 20 57 17" src="https://user-images.githubusercontent.com/3658119/68893007-87fddd80-0724-11ea-98cb-2ef695135673.png">

## Error with an object:
_`ConversionException` or a `\TypeError` when you specify the type when you set the parameter but you provide an invalid value and this value is an object (eg `->setParameter('foo', new \stdClass(), 'date')`), the query is not runnable._
### Before
<img width="775" alt="Screenshot 2019-11-14 at 21 04 45" src="https://user-images.githubusercontent.com/3658119/68893078-a9f76000-0724-11ea-9e9a-bb806ffa0a73.png">

### After
<img width="821" alt="Screenshot 2019-11-14 at 20 59 23" src="https://user-images.githubusercontent.com/3658119/68893098-b24f9b00-0724-11ea-8e9d-7179725b8bc1.png">

## Error with anything else:
_`ConversionException` or a `\TypeError` when you specify the type when you set the parameter but you provide an invalid value and this value is not an object (eg `->setParameter('foo', 'bar', 'date')`), the query is not runnable._
### Before
<img width="809" alt="Screenshot 2019-11-14 at 21 05 10" src="https://user-images.githubusercontent.com/3658119/68893031-93e99f80-0724-11ea-9c23-f8d05f2dbfbb.png">

### After
<img width="832" alt="Screenshot 2019-11-14 at 20 57 54" src="https://user-images.githubusercontent.com/3658119/68893055-9d730780-0724-11ea-8ce1-a7b8946aaf94.png">

The new `runnable` key will be used in `DoctrineBundle` profiler template to hide the `View runnable query` link when the query is not runnable.

Commits
-------

fe15f51d4d [DoctrineBridge] Improve queries parameters display in Profiler
 2019-11-17 10:53:37 +01:00
Thomas Calvet
e75e01dda4 [FrameworkBundle] Remove project dir from Translator cache vary scanned directories 2019-11-17 10:27:11 +01:00
Mark Beech
bd0637ebe4 [HttpFoundation] Allow redirecting to URLs that contain a semicolon 2019-11-17 10:18:38 +01:00
David Prévot
1883af4d4b Drop useless executable bit 2019-11-16 08:59:35 -10:00
Thomas Calvet
fe15f51d4d [DoctrineBridge] Improve queries parameters display in Profiler 2019-11-16 19:56:08 +01:00
Nicolas Grekas
1fbe6157ba bug #34408 [Cache] catch exceptions when using PDO directly (xabbuh) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Cache] catch exceptions when using PDO directly

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony/symfony-docs#12632
| License       | MIT
| Doc PR        |

Commits
-------

5c1f5594f5 catch exceptions when using PDO directly
 2019-11-16 18:08:55 +01:00
Christian Flothmann
5c1f5594f5 catch exceptions when using PDO directly 2019-11-16 17:52:07 +01:00
Nicolas Grekas
eaca085aa4 [SecurityBundle] fix failing test 2019-11-16 16:50:51 +01:00
Nicolas Grekas
4ac626a482 Merge branch '4.3' into 4.4 
* 4.3:
  [HttpFoundation] fix docblock
  Fix MySQL column type definition.
  Link the right file depending on the new version
  [Config] fix id-generation for GlobResource
  [Finder] Allow ssh2 stream wrapper for sftp
  [DI] Use reproducible entropy to generate env placeholders
  [WebProfilerBundle] Require symfony/twig-bundle
  bumped Symfony version to 4.3.9
  updated VERSION for 4.3.8
  updated CHANGELOG for 4.3.8
  bumped Symfony version to 3.4.36
  updated VERSION for 3.4.35
  updated CHANGELOG for 3.4.35
 2019-11-16 16:22:42 +01:00
Nicolas Grekas
769aced459 Merge branch '3.4' into 4.3 
* 3.4:
  Fix MySQL column type definition.
 2019-11-16 16:18:16 +01:00
Nicolas Grekas
4d9b6f1bbd [HttpFoundation] fix docblock 2019-11-16 16:17:02 +01:00
Robin Chalas
585216a8e8 [HttpKernel] Flatten "exception" controller argument if not typed 2019-11-16 13:16:23 +01:00
Jérémie Broutier
51c5f69274 Fix MySQL column type definition. 
Fix wrong MySQL column type definition causing Numeric value out of range exception.

Ref #34409
 2019-11-16 12:41:30 +01:00
Nicolas Grekas
476042d0fb Merge branch '3.4' into 4.3 
* 3.4:
  Link the right file depending on the new version
  [Finder] Allow ssh2 stream wrapper for sftp
  [WebProfilerBundle] Require symfony/twig-bundle
  bumped Symfony version to 3.4.36
  updated VERSION for 3.4.35
  updated CHANGELOG for 3.4.35
 2019-11-16 10:07:40 +01:00
Nicolas Grekas
278dcfb380 bug #34403 [Cache] Redis Tag Aware warn on wrong eviction policy (andrerom) 
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Cache] Redis Tag Aware warn on wrong eviction policy

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| Deprecations? | no
| Tickets       | n.a.
| License       | MIT
| Doc PR        | n.a.

Adds validation to make sure Redis has been setup with the supported eviction policy to avoid surprises when cache suddenly is inconsistent.

This PR replaces #34178, and instead of checking in constructor and throwing it only checks on save, warns about this and refuses to save cache as suggested on the other PR.

TODO:
- [x] ~Adapt test setups for this to set correct eviction policy~ _It already uses default noeviction_

Commits
-------

e77f6de1e8 [Cache] Redis Tag Aware warn on wrong eviction policy
 2019-11-16 09:53:59 +01:00
André R
e77f6de1e8 [Cache] Redis Tag Aware warn on wrong eviction policy 2019-11-16 09:53:52 +01:00
Nicolas Grekas
fda36e84b3 bug #34400 [HttpKernel] collect bundle classes, not paths (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] collect bundle classes, not paths

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34359
| License       | MIT
| Doc PR        | -

Commits
-------

7824d75ac3 [HttpKernel] collect bundle classes, not paths
 2019-11-16 09:51:49 +01:00
Nicolas Grekas
a90de43a8e bug #34398 [Config] fix id-generation for GlobResource (nicolas-grekas) 
This PR was merged into the 4.3 branch.

Discussion
----------

[Config] fix id-generation for GlobResource

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

I never encountered any issues related to this but still, it's a fix.

Commits
-------

6adbfa2ae7 [Config] fix id-generation for GlobResource
 2019-11-16 09:51:12 +01:00
Nicolas Grekas
114a4b86ac bug #34404 [HttpClient] fix HttpClientDataCollector (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix HttpClientDataCollector

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34365
| License       | MIT
| Doc PR        | -

Commits
-------

f51adc53f8 [HttpClient] fix HttpClientDataCollector
 2019-11-16 09:50:26 +01:00
Nicolas Grekas
f51adc53f8 [HttpClient] fix HttpClientDataCollector 2019-11-16 09:45:13 +01:00
Fabien Potencier
1374abd6e8 minor #34399 [HttpKernel] dont check cache freshness more than once per process (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] dont check cache freshness more than once per process

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

While running some functional tests in a loop, I noticed that half the time is spent computing cache freshness. This makes no sense - this mechanism is supposed to run once per process.

Here is the Blackfire comparison:
https://blackfire.io/profiles/compare/a4f2eb44-ae85-440b-ae87-edf43c2b2ef7/graph

![image](https://user-images.githubusercontent.com/243674/68955196-c5667780-07c5-11ea-9a19-f8e765664a8e.png)

Commits
-------

7f9556ce19 [HttpKernel] dont check cache freshness more than once per process
 2019-11-15 18:39:48 +01:00
Nicolas Grekas
7824d75ac3 [HttpKernel] collect bundle classes, not paths 2019-11-15 17:50:43 +01:00
Nicolas Grekas
6adbfa2ae7 [Config] fix id-generation for GlobResource 2019-11-15 16:28:20 +01:00
Nicolas Grekas
7f9556ce19 [HttpKernel] dont check cache freshness more than once per process 2019-11-15 16:26:40 +01:00
Damien Alexandre
e6c9d77b63
[Finder] Allow ssh2 stream wrapper for sftp 
Same fix as #28604 but for the ss2.sftp wrapper.
 2019-11-15 15:28:29 +01:00
Fabien Potencier
ca9a3a41a3 bug #34389 [WebProfilerBundle] add FrameworkBundle requirement (xabbuh) 
This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] add FrameworkBundle requirement

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34379
| License       | MIT
| Doc PR        |

Commits
-------

1752dd9432 add FrameworkBundle requirement
 2019-11-15 12:26:07 +01:00
Nicolas Grekas
b8f8ac947e bug #34358 [Security] always check the token on non-lazy firewalls (nicolas-grekas, lyrixx) 
This PR was merged into the 4.4 branch.

Discussion
----------

 [Security] always check the token on non-lazy firewalls

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34357
| License       | MIT
| Doc PR        |

Commits
-------

2c2632a04c [SecurityBundle] add tests with empty authenticator
797450d6b8 [Security] always check the token on non-lazy firewalls
 2019-11-15 12:06:35 +01:00
Nicolas Grekas
6fd10771d9 bug #34390 [FrameworkBundle] fix wiring of httplug client (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] fix wiring of httplug client

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Closes https://github.com/symfony/recipes/issues/676
| License       | MIT
| Doc PR        | -

Commits
-------

d969d49292 [FrameworkBundle] fix wiring of httplug client
 2019-11-15 12:03:34 +01:00
Nicolas Grekas
d969d49292 [FrameworkBundle] fix wiring of httplug client 2019-11-15 11:02:26 +01:00
Christian Flothmann
1752dd9432 add FrameworkBundle requirement 2019-11-15 10:12:35 +01:00
Grégoire Pineau
2c2632a04c [SecurityBundle] add tests with empty authenticator 2019-11-14 23:51:34 +01:00
Nicolas Grekas
797450d6b8 [Security] always check the token on non-lazy firewalls 2019-11-14 23:50:50 +01:00
Nicolas Grekas
600ae33262 [DI] Use reproducible entropy to generate env placeholders 2019-11-14 21:13:17 +01:00
Thomas Calvet
78dad79fec [WebProfilerBundle] Require symfony/twig-bundle 2019-11-14 16:04:06 +01:00
Maxime Steinhausser
abcf63aaa8 [Mailer] Add UPGRADE entry about the null transport DSN 2019-11-14 15:24:33 +01:00