Commit Graph

26292 Commits

Author SHA1 Message Date
Nicolas Grekas
39df9e4f8b CS fixes 2016-04-17 18:02:30 +02:00
Nicolas Grekas
95afc677b6 bug #18571 [Cache] Minor tweaks (nicolas-grekas)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Cache] Minor tweaks

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/php-cache/integration-tests/pull/51
| License       | MIT
| Doc PR        | -

Commits
-------

9dcbe34 [Cache] Minor tweaks
2016-04-17 16:50:41 +02:00
Nicolas Grekas
9dcbe3403c [Cache] Minor tweaks 2016-04-17 13:51:09 +02:00
Romain Neutron
1a5d4adadd [WebProfilerBunde] Give an absolute url in case the request occured from another domain 2016-04-16 12:12:40 +02:00
Titouan Galopin
4f0b8beea6 [FrameworkBundle] Fallback to default cache system in production for serializer 2016-04-15 22:43:35 +02:00
jhonnyL
313d8b1684 [FrameworkBundle] Better output for user in ContainerDebugCommand 2016-04-15 11:28:00 +00:00
Fabien Potencier
47cb0c3ec1 feature #18020 fix #17993 - Deprecated callable strings (hamza)
This PR was merged into the 3.1-dev branch.

Discussion
----------

fix #17993 - Deprecated callable strings

| Q             | A
| ------------- | ---
| Branch        | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | no
| Fixed tickets | #17993
| License       | MIT
| Doc PR        |

Is this ok ?

- [x] Rebase when  #18057 is merged

Commits
-------

191b495 fix #17993 - Deprecated callable strings
2016-04-15 12:08:13 +02:00
Fabien Potencier
2528ec48cc bug #18280 [Routing] add query param if value is different from default (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[Routing] add query param if value is different from default

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | most likely not
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #10940, #18111, #18035
| License       | MIT
| Doc PR        | -

Commits
-------

1ef2edf [Routing] add query param if value is different from default
2016-04-15 11:53:50 +02:00
Fabien Potencier
cea9d862cc minor #18498 [FrameworkBundle] Use SymfonyStyle in AbstractConfigCommand (JhonnyL)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[FrameworkBundle] Use SymfonyStyle in AbstractConfigCommand

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Before:
![screen shot 2016-04-10 at 18 12 56](https://cloud.githubusercontent.com/assets/1104667/14411548/ab040a32-ff4b-11e5-878d-7e6acb257750.png)
After:
![screen shot 2016-04-10 at 18 11 57](https://cloud.githubusercontent.com/assets/1104667/14411553/be16e022-ff4b-11e5-838e-5fa2ad46133b.png)

Commits
-------

30b44a8 [FrameworkBundle] Use SymfonyStyle in AbstractConfigCommand
2016-04-15 11:33:33 +02:00
Fabien Potencier
529d0fe230 feature #18487 [Cache] Add DoctrineProvider, for using PSR-6 pools in Doctrine Cache (nicolas-grekas)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Cache] Add DoctrineProvider, for using PSR-6 pools in Doctrine Cache

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This would allow cache pool configuration as usual (see #17290) before injecting the resulting doctrine cache provider anywhere such an interface is required.

Commits
-------

5d256dd [Cache] Add DoctrineProvider, for using PSR-6 pools in Doctrine Cache
2016-04-15 11:27:30 +02:00
Fabien Potencier
e4177a716e feature #18544 [FrameworkBundle] Fallback to default cache system in production for validation (tgalopin)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[FrameworkBundle] Fallback to default cache system in production for validation

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | WIP
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR proposes a default fallback to filesystem cache for some services if the APC cache is not enabled in production. In other words, if the following part of `config_prod.yml` file is not uncommented, the filesystem will be used:

``` yaml
#framework:
#    validation:
#        cache: validator.mapping.cache.doctrine.apc
#    serializer:
#        cache: serializer.mapping.cache.doctrine.apc
#
# ... other services
```

Commits
-------

1a65595 [FrameworkBundle] Fallback to default cache system in production for validation
2016-04-15 11:26:35 +02:00
Fabien Potencier
5356dbb7ee bug #18540 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

Replace iconv_*() uses by mb_*(), add mbstring polyfill when required

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18539
| License       | MIT
| Doc PR        | -

Looks like `iconv_*()` functions can be really slow (see #18539).

Commits
-------

27f5f81 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required
2016-04-15 11:20:55 +02:00
Fabien Potencier
8d6670bf80 minor #18529 [HttpKernel] Renamed the argument resolver tag (iltar)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[HttpKernel] Renamed the argument resolver tag

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | not if merged before 3.1
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Changed as discussed several times: https://github.com/symfony/symfony/pull/18510#issuecomment-208778875, https://github.com/symfony/symfony-docs/pull/6422#issuecomment-208453616.

Commits
-------

cd10057 Renamed argument resolver tag, added test
2016-04-15 11:05:59 +02:00
Iltar van der Berg
cd100575d4 Renamed argument resolver tag, added test 2016-04-15 09:47:59 +02:00
hamza
191b4954c0 fix #17993 - Deprecated callable strings
ext
2016-04-15 07:55:48 +02:00
jhonnyL
9f2f858f55 [FrameworkBundle] Remove misleading comment 2016-04-14 20:06:25 +00:00
Fabien Potencier
5f8a196346 Merge branch '2.8' into 3.0
* 2.8:
  [Console] use ANSI escape sequences in ProgressBar overwrite method
  [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
  [DependencyInjection] Remove YAML check in CrossCheckTest
  [Process] Consistently use getProcess() in tests
  [LDAP] Free the search result after a search to free memory
  [DependencyInjection] fix phpDoc
2016-04-14 17:30:28 +02:00
Fabien Potencier
db31b5699d Merge branch '2.7' into 2.8
* 2.7:
  [Console] use ANSI escape sequences in ProgressBar overwrite method
  [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
  [DependencyInjection] Remove YAML check in CrossCheckTest
  [Process] Consistently use getProcess() in tests
  [DependencyInjection] fix phpDoc
2016-04-14 17:22:22 +02:00
Fabien Potencier
44efeaaa27 Merge branch '2.3' into 2.7
* 2.3:
  [DependencyInjection] Remove YAML check in CrossCheckTest
  [DependencyInjection] fix phpDoc
2016-04-14 17:17:41 +02:00
Nicolas Grekas
5d256ddaee [Cache] Add DoctrineProvider, for using PSR-6 pools in Doctrine Cache 2016-04-14 15:55:05 +02:00
Titouan Galopin
1a65595218 [FrameworkBundle] Fallback to default cache system in production for validation 2016-04-14 14:52:43 +02:00
Fabien Potencier
d4799348ff feature #18416 [FrameworkBundle] Calls support for debug:container (JhonnyL)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[FrameworkBundle] Calls support for debug:container

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets |
| License       | MIT
| Doc PR        |

* Show methods to be called after service initialization in `debug:container` command

Commits
-------

b2d1038 [FrameworkBundle] Calls support for debug:container
2016-04-14 13:58:12 +02:00
Fabien Potencier
1ee981fbb8 bug #18436 fix Autowiring tests of #18144 (HeahDude)
This PR was merged into the 3.1-dev branch.

Discussion
----------

fix Autowiring tests of #18144

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| Tests pass?   | yes
| Fixed issue | https://github.com/symfony/symfony/pull/18422#discussion_r58362092
| License       | MIT

Commits
-------

0cbf04a [DI] fix Autowiring tests of #18144
2016-04-14 13:54:39 +02:00
Fabien Potencier
6400b703d4 bug #18496 [Console] use ANSI escape sequences in ProgressBar overwrite method (alekitto)
This PR was squashed before being merged into the 2.7 branch (closes #18496).

Discussion
----------

[Console] use ANSI escape sequences in ProgressBar overwrite method

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | maybe
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16957
| License       | MIT
| Doc PR        |

Rewritten `overwrite` method in ProgressBar class to use ANSI escape sequences to erase lines.
This removes the need to store the last message length as it is not needed to fill the buffer with spaces anymore. As a plus it correctly resets the cursor position while clearing the output

If the output is not decorated the behavior has not been changed.
Could possibly cause a BC break if testing against the decorated emitted output as binary string

Commits
-------

b6cca4c [Console] use ANSI escape sequences in ProgressBar overwrite method
2016-04-14 13:51:22 +02:00
Alessandro Chitolina
b6cca4c020 [Console] use ANSI escape sequences in ProgressBar overwrite method 2016-04-14 13:51:20 +02:00
Christophe Coevoet
6467b24014 minor #18534 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException() (chalasr)
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #18534).

Discussion
----------

[HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18527
| License       | MIT
| Doc PR        | n/a

The `$original` argument has been removed from the method signature in [22f4807](22f4807522).

Commits
-------

00ae320 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
2016-04-14 11:51:33 +02:00
Robin Chalas
00ae320f83 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
Remove unexpected argument from ExceptionListener::logException() method call because the signature has changed in 22f4807
2016-04-14 11:51:32 +02:00
Nicolas Grekas
d2b5cb5f0e minor #18536 Fix the wrong method name given the corresponding interface (joelwurtz)
This PR was merged into the 3.1-dev branch.

Discussion
----------

Fix the wrong method name given the corresponding interface

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17545 Follow up
| License       | MIT
| Doc PR        |

This a follow up of #17545 as i introduce bad methods name in the traits sorry :/

![](http://vomzi.com/wp-content/uploads/2016/02/sorry-gif-847.gif)

Commits
-------

231819e Fix the wrong method name given the corresponding interface
2016-04-14 11:05:59 +02:00
Nicolas Grekas
27f5f81eb3 Replace iconv_*() uses by mb_*(), add mbstring polyfill when required 2016-04-14 10:48:44 +02:00
Joel Wurtz
231819e9ac Fix the wrong method name given the corresponding interface 2016-04-14 00:46:09 +02:00
Fabien Potencier
b803680efe bug #18490 [LDAP] Free the search result after a search to free memory (hiddewie)
This PR was merged into the 2.8 branch.

Discussion
----------

[LDAP] Free the search result after a search to free memory

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7da4453 [LDAP] Free the search result after a search to free memory
2016-04-13 07:10:49 -07:00
Fabien Potencier
8c89a3a0a3 minor #18532 [DependencyInjection] Remove check for YAML class in CrossCheckTest (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] Remove check for YAML class in CrossCheckTest

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    |  no
| Deprecations? |  no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I suppose it's a leftover from when YAML component only was added in suggest.

Commits
-------

af92275 [DependencyInjection] Remove YAML check in CrossCheckTest
2016-04-13 07:04:16 -07:00
Nicolas Grekas
cb0fe14df5 feature #18513 [Process] Turn getIterator() args to flags & add ITER_SKIP_OUT/ERR modes (nicolas-grekas)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Process] Turn getIterator() args to flags & add ITER_SKIP_OUT/ERR modes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8454
| License       | MIT
| Doc PR        | -

Targeted at 3.1

Commits
-------

428f12e [Process] Turn getIterator() args to flags & add ITER_SKIP_OUT/ERR modes
2016-04-13 15:01:25 +02:00
jhonnyL
af922758f4 [DependencyInjection] Remove YAML check in CrossCheckTest 2016-04-13 10:32:03 +00:00
Jules Pietri
0cbf04a77e [DI] fix Autowiring tests of #18144 2016-04-13 08:43:21 +02:00
Nicolas Grekas
428f12e13b [Process] Turn getIterator() args to flags & add ITER_SKIP_OUT/ERR modes 2016-04-12 21:11:33 +02:00
Nicolas Grekas
f1d12a1c07 bug #18485 [Cache] Workaround krakjoe/apcu#170 (nicolas-grekas)
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Cache] Workaround krakjoe/apcu#170

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/krakjoe/apcu/issues/170
| License       | MIT
| Doc PR        | -

Commits
-------

98dce41 [Cache] Workaround krakjoe/apcu#170
2016-04-12 21:07:53 +02:00
Nicolas Grekas
03aa64ad25 minor #18505 [DependencyInjection] fix phpDoc (JhonnyL)
This PR was merged into the 2.3 branch.

Discussion
----------

[DependencyInjection] fix phpDoc

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

* Use inheritdoc where possible
* Remove useless Constructor/__toString

Commits
-------

46ea9cc [DependencyInjection] fix phpDoc
2016-04-12 20:59:35 +02:00
Nicolas Grekas
da357d8424 minor #18519 [Process] Consistently use getProcess() in tests (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Consistently use getProcess() in tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ce13fe7 [Process] Consistently use getProcess() in tests
2016-04-12 20:54:02 +02:00
Christian Flothmann
af9ec74edb Merge branch '3.0'
* 3.0: (24 commits)
  [Filesystem] Better error handling in remove()
  [DependencyInjection] Add coverage for invalid Expression in exportParameters
  [DependencyInjection] Add coverage for all invalid arguments in exportParameters
  anonymous services are always private
  [Form] FormValidator removed code related to removed  option
  [Console] Correct time formatting.
  [WebProfilerBundle] Fixed error from unset twig variable
  Force profiler toolbar svg display
  [DependencyInjection] Resolve aliases before removing abstract services + add tests
  Fix Dom Crawler select option with empty value
  Remove unnecessary option assignment
  fix tests (use non-deprecated options)
  remove unused variable
  mock the proper method
  [PropertyAccess] Fix regression
  [HttpFoundation] Improve phpdoc
  [Logging] Add support for firefox in ChromePhpHandler
  Windows 10 version check in just one line
  Detect CLI color support for Windows 10 build 10586
  [Security] Fixed SwitchUserListener when exiting an impersonication with AnonymousToken
  ...
2016-04-12 20:27:47 +02:00
Christian Flothmann
e72d509012 Merge branch '2.8' into 3.0
* 2.8: (23 commits)
  [Filesystem] Better error handling in remove()
  [DependencyInjection] Add coverage for invalid Expression in exportParameters
  [DependencyInjection] Add coverage for all invalid arguments in exportParameters
  anonymous services are always private
  [Console] Correct time formatting.
  [WebProfilerBundle] Fixed error from unset twig variable
  Force profiler toolbar svg display
  [DependencyInjection] Resolve aliases before removing abstract services + add tests
  Fix Dom Crawler select option with empty value
  Remove unnecessary option assignment
  fix tests (use non-deprecated options)
  remove unused variable
  mock the proper method
  [PropertyAccess] Fix regression
  [HttpFoundation] Improve phpdoc
  [Logging] Add support for firefox in ChromePhpHandler
  Windows 10 version check in just one line
  Detect CLI color support for Windows 10 build 10586
  [Security] Fixed SwitchUserListener when exiting an impersonication with AnonymousToken
  [EventDispatcher] Try first if the event is Stopped
  ...
2016-04-12 20:09:53 +02:00
Christian Flothmann
ed9c94c719 Merge branch '2.7' into 2.8
* 2.7:
  [Filesystem] Better error handling in remove()
  [DependencyInjection] Add coverage for invalid Expression in exportParameters
  [DependencyInjection] Add coverage for all invalid arguments in exportParameters
  anonymous services are always private
  [Console] Correct time formatting.
  [DependencyInjection] Resolve aliases before removing abstract services + add tests
  Fix Dom Crawler select option with empty value
  Remove unnecessary option assignment
  remove unused variable
  mock the proper method
  [PropertyAccess] Fix regression
2016-04-12 20:01:21 +02:00
Nicolas Grekas
689f27b397 bug #18491 [DependencyInjection] anonymous services are always private (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[DependencyInjection] anonymous services are always private

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

0a469a4 anonymous services are always private
2016-04-12 17:22:47 +02:00
Nicolas Grekas
fd693e6997 Merge branch '2.3' into 2.7
* 2.3:
  [Filesystem] Better error handling in remove()
2016-04-12 17:21:00 +02:00
Nicolas Grekas
6401371c7e bug #18515 [Filesystem] Better error handling in remove() (nicolas-grekas)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18515).

Discussion
----------

[Filesystem] Better error handling in remove()

| Q             | A
| ------------- | ---
| Branch?       | master (to be moved on 2.3 when merging)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18512
| License       | MIT
| Doc PR        | -

Commits
-------

b848ddb [Filesystem] Better error handling in remove()
2016-04-12 17:20:10 +02:00
Nicolas Grekas
b848ddb7f0 [Filesystem] Better error handling in remove() 2016-04-12 17:20:10 +02:00
Nicolas Grekas
ce13fe7454 [Process] Consistently use getProcess() in tests 2016-04-12 13:52:58 +02:00
Hidde Wieringa
7da445307c
[LDAP] Free the search result after a search to free memory
Fixed error handling in ldap_search and ldap_free

Added spaces around if

Fixed trailing spaces

Added functional tests for Ldap component

Fixed style errors

Fixed style errors 2

Added slapd to Travis requirements

Added mkdir /tmp/travis to Travis build config

Revert "Added mkdir /tmp/travis to Travis build config"

This reverts commit d7f1884e6dc53602ad8dca6caeabb423445166cc.

Revert "Added slapd to Travis requirements"

This reverts commit 9b212ff5eb9fc2f4d6d54b787e4d307b0e164e21.

Revert "Fixed style errors 2"

This reverts commit cbe0c168d6c9a50dac1ba6593113573f53768be3.

Revert "Fixed style errors"

This reverts commit a2dc110f3df1b9e803447b94d2794eb1a3e8c300.

Revert "Added functional tests for Ldap component"

This reverts commit 33a67230dd25dabdb454381a3cdee95bdaac7f30.
2016-04-12 11:43:13 +02:00
Nicolas Grekas
98dce411e8 [Cache] Workaround krakjoe/apcu#170 2016-04-12 08:30:53 +02:00
JhonnyL
46ea9cc453 [DependencyInjection] fix phpDoc 2016-04-11 16:45:49 +02:00