Commit Graph

14608 Commits

Author SHA1 Message Date
Fabien Potencier
b2d2c12cad merged branch saem/ticket_8228 (PR #8229)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fixed OutOfBoundException when session handler_id is null

[FrameworkBundle] Fixed OutOfBoundException when session handler_id is null

When a null is provided for framework.session.handler_id the FrameworkExtension attempts to set the session storage to null for the 'session.storage.php_bridge' by altering the second argument. According to the session.xml service definition, there is no second argument, and it is in fact the first (read, 0 index) argument that should be changed.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8228
| License       | MIT
| Doc PR        | N/A

Commits
-------

e3561ce [FrameworkBundle] Fixed OutOfBoundException when session handler_id is null
2013-06-08 16:54:12 +02:00
Pierre-Yves LEBECQ
bce6bd2858 [DomCrawler] Fixed a fatal error when setting a value in a malformed field name. 2013-06-08 13:27:47 +02:00
Saem Ghani
e3561ce49c [FrameworkBundle] Fixed OutOfBoundException when session handler_id is null
When a null is provided for framework.session.handler_id the FrameworkExtension attempts to set the session storage to null for the 'session.storage.php_bridge' by altering the second argument. According to the session.xml service definition, there is no second argument, and it is in fact the first (read, 0 index) argument that should be changed.
2013-06-07 15:05:01 -07:00
Bilal Amarni
7ccfe655bd [HttpFoundation] UploadedFile error message 2013-06-06 17:05:59 +02:00
Fabien Potencier
df0a02dc10 merged branch Seldaek/fix-container-opt (PR #8193)
This PR was merged into the 2.3 branch.

Discussion
----------

[DI] Fixes access of aliases shared services

Fixes #8096 and I noticed that the aliases methods weren't really needed anymore so I removed them. I think it's fine since they were protected, but did it in a separate commit in case you just want the bugfix.

Note that while the DI tests pass, I didn't run this patch as part of a real app. I'd appreciate if someone has the time to verify it still works given it's slightly critical code.

Commits
-------

81b122d [DependencyInjection] Add support for aliases of aliases + regression test
d8c0ef7 [DependencyInjection] Rename ContainerBuilder::$aliases to avoid conflicting with the parent class
bb797ee [DependencyInjection] Remove get*Alias*Service methods from compiled containers
379f5e0 [DependencyInjection] Fix aliased access of shared services, fixes #8096
2013-06-05 19:12:01 +02:00
Jordi Boggiano
81b122dd7b [DependencyInjection] Add support for aliases of aliases + regression test 2013-06-05 11:51:05 +02:00
Tobias Schultze
445b2e3dad [Console] fix status code when Exception::getCode returns something like 0.1 2013-06-05 10:14:54 +02:00
Fabien Potencier
ea913e07e5 merged branch GromNaN/templating-var (PR #7951)
This PR was squashed before being merged into the master branch (closes #7951).

Discussion
----------

[Templating] Allows "template" and "parameters" as parameter name (replaces #7908)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | n/a

Allows "template" and "parameters" as parameter name.
**BC break:** These variables were previously declared on every template with respectively the Templating\Storage instance and the array of parameters.

Commits
-------

6e8b918 [Templating] Allows "template" and "parameters" as parameter name (replaces #7908)
2013-06-04 17:16:10 +02:00
Jerome TAMARELLE
6e8b9181ba [Templating] Allows "template" and "parameters" as parameter name (replaces #7908) 2013-06-04 17:16:08 +02:00
Fabien Potencier
5f16e996d5 merged branch alexpods/patch-3 (PR #8003)
This PR was merged into the master branch.

Discussion
----------

[HttpFoundation][NamespacedAttributeBag] Refactoring of resolveKey() method

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Just code enhancement. Low priority.

1) We don't need to call strlen($name) as last argument of substr() function
2) We don't need to call strrpos (or strpos) two times.

Commits
-------

a644516 [HttpFoundation][NamespacedAttributeBag] Refactoring of resolveKey() method
2013-06-04 17:12:29 +02:00
Fabien Potencier
a8929762bc merged branch lyrixx/console-tester-status-code (PR #8023)
This PR was merged into the master branch.

Discussion
----------

[2.4][Console] Added status code to CommandTester and ApplicationTester

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes, but not on travis (segfault)
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Theses classes are already statefull. They contain the input and the
output data. So we can safely add the last status code to the class.

Commits
-------

6526166 [Console] Added status code to CommandTester and ApplicationTester
2013-06-04 17:09:18 +02:00
Fabien Potencier
d8941c19c8 merged branch mpartel/progresshelper-clear (PR #8074)
This PR was merged into the master branch.

Discussion
----------

[Console] Add clear() to ProgressHelper.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#2642

One may want to print something else while the progress bar is running.
The output will be messy if the progress bar is not removed first.

One may also want to remove the progress bar after the work is complete.

Commits
-------

29c71a5 [Console] Add clear() to ProgressHelper.
2013-06-04 17:08:39 +02:00
Fabien Potencier
46b209bc55 merged branch Tobion/monolog-console-integration (PR #8167)
This PR was squashed before being merged into the master branch (closes #8167).

Discussion
----------

[MonologBridge] added integration with the console component

This adds integration with the console component by adding ConsoleHandler and ConsoleFormatter which can be used to show log messages in the console output depending on the verbosity settings.
This PR splits the reusable classes from symfony/MonologBundle#42 into the bridge.
It has been reviewed by @Seldaek

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8033
| License       | MIT
| Doc PR        | will be done when this is used by the MonologBundle

Commits
-------

c0b5996 [MonologBridge] added integration with the console component
2013-06-04 17:05:24 +02:00
Tobias Schultze
c0b59963b3 [MonologBridge] added integration with the console component 2013-06-04 17:05:23 +02:00
Fabien Potencier
b219e0a9c6 merged branch jakzal/2.3-config-tests (PR #8178)
This PR was merged into the 2.3 branch.

Discussion
----------

[Config] Added few tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

804b182 [Config] Added tests for the FileResource and DirectoryResource.
c5dda79 [Config] Fixed @covers annotation which ignored some of the methods from the code coverage.
bf769e0 [Config] Added tests for the ConfigCache.
2013-06-04 17:04:14 +02:00
Fabien Potencier
e1f530eb7a merged branch jakzal/2.3-more-security-tests (PR #8177)
This PR was merged into the 2.3 branch.

Discussion
----------

[Security] Added more tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Continuation of #8136

Commits
-------

5409852 [Security] Added few new test cases for the HttpUtils and improved readability of existing tests.
d6ab77e [Security] Added tests for the SwitchUserListener.
cccd005 [Security] Added tests for the ContextListener.
307bc91 [Security] Added a test to the BasicAuthenticationListener.
314f29a [Security] Removed an unnecessary call to sprintf() and added a test case.
2013-06-04 17:03:43 +02:00
Fabien Potencier
47a0a4c692 merged branch lyrixx/filesystem-docblock (PR #8181)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #8181).

Discussion
----------

[2.4][Filesystem] Fixed doc block on Filesystem::rename

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

891032c [Filesystem] Fixed doc block on Filesystem::rename
2013-06-04 17:02:05 +02:00
Grégoire Pineau
9527001399 Fixed doc block on Filesystem::rename
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -
2013-06-04 17:02:05 +02:00
Fabien Potencier
18f55ffe5e merged branch havvg/hotfix/fix-bundle-command-instantiation (PR #8182)
This PR was merged into the 2.2 branch.

Discussion
----------

[HttpKernel] instantiate valid commands only

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | debatable ..
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This skips the default behavior to instantiate `Command` that cannot simply be instantiated. The respective commands have to be registered by other means.

Commits
-------

afad9c7 instantiate valid commands only
2013-06-04 17:00:11 +02:00
Fabien Potencier
28a900150e merged branch Stelian/2.2 (PR #8183)
This PR was submitted for the 2.2 branch but it was merged into the 2.1 branch instead (closes #8183).

Discussion
----------

Fixed exit code for exceptions with error code 0

Covers https://github.com/symfony/symfony/issues/8180

Commits
-------

48e77f8 Fixed exit code for exceptions with error code 0
2013-06-04 16:58:25 +02:00
Stelian
bbfde62d7c Fixed exit code for exceptions with error code 0 2013-06-04 16:58:25 +02:00
Jordi Boggiano
d8c0ef705c [DependencyInjection] Rename ContainerBuilder::$aliases to avoid conflicting with the parent class 2013-06-04 15:12:01 +02:00
Jordi Boggiano
bb797ee755 [DependencyInjection] Remove get*Alias*Service methods from compiled containers 2013-06-04 14:33:18 +02:00
Jordi Boggiano
379f5e08b4 [DependencyInjection] Fix aliased access of shared services, fixes #8096 2013-06-04 14:33:14 +02:00
Toni Uebernickel
afad9c7894 instantiate valid commands only 2013-06-04 12:08:18 +02:00
Fabien Potencier
8d2cda3395 bumped Symfony version to -DEV 2013-06-03 17:11:57 +02:00
Mark Sonnabaum
28a8443a5f [HttpFoundation] Added Request::getEncodings() method 2013-06-03 09:39:44 -05:00
Fabien Potencier
6da9c5d35b updated VERSION for 2.3.0 2013-06-03 16:13:35 +02:00
Fabien Potencier
38259707ba updated CHANGELOG for 2.3.0 2013-06-03 16:13:02 +02:00
Jakub Zalas
804b1829ef [Config] Added tests for the FileResource and DirectoryResource. 2013-06-03 01:18:25 +01:00
Jakub Zalas
c5dda79778 [Config] Fixed @covers annotation which ignored some of the methods from the code coverage. 2013-06-03 01:05:06 +01:00
Jakub Zalas
bf769e0437 [Config] Added tests for the ConfigCache. 2013-06-03 00:52:04 +01:00
Jakub Zalas
540985275d [Security] Added few new test cases for the HttpUtils and improved readability of existing tests. 2013-06-02 23:50:02 +01:00
Jakub Zalas
d6ab77e7e8 [Security] Added tests for the SwitchUserListener. 2013-06-02 22:56:02 +01:00
Jakub Zalas
cccd0059dc [Security] Added tests for the ContextListener. 2013-06-02 18:27:22 +01:00
Jakub Zalas
307bc91e02 [Security] Added a test to the BasicAuthenticationListener. 2013-06-02 18:27:21 +01:00
Jakub Zalas
314f29a718 [Security] Removed an unnecessary call to sprintf() and added a test case. 2013-06-02 18:27:21 +01:00
Fabien Potencier
6b25213e23 Merge branch '2.2' into 2.3
* 2.2:
  bumped Symfony version to 2.2.3-DEV
  updated VERSION for 2.2.2
  updated CHANGELOG for 2.2.2
  removed CHANGELOG for 2.1
  updated VERSION for 2.1.11
  update CONTRIBUTORS for 2.1.11
  updated CHANGELOG for 2.1.11

Conflicts:
	src/Symfony/Component/HttpKernel/Kernel.php
2013-06-02 18:04:08 +02:00
Fabien Potencier
bc1bf3202d bumped Symfony version to 2.2.3-DEV 2013-06-02 18:01:55 +02:00
Fabien Potencier
34430e8dbf updated VERSION for 2.2.2 2013-06-02 15:03:09 +02:00
Fabien Potencier
b9ca806048 updated CHANGELOG for 2.2.2 2013-06-02 15:02:48 +02:00
Fabien Potencier
93585f6514 removed CHANGELOG for 2.1 2013-06-02 14:54:39 +02:00
Fabien Potencier
57f93b89e8 Merge branch '2.1' into 2.2
* 2.1:
  updated VERSION for 2.1.11
  update CONTRIBUTORS for 2.1.11
  updated CHANGELOG for 2.1.11

Conflicts:
	src/Symfony/Component/HttpKernel/Kernel.php
2013-06-02 14:53:48 +02:00
Fabien Potencier
e029409fc8 updated VERSION for 2.1.11 2013-06-02 14:29:05 +02:00
Fabien Potencier
b2c0861089 update CONTRIBUTORS for 2.1.11 2013-06-02 14:28:43 +02:00
Fabien Potencier
47c4a4f8cd updated CHANGELOG for 2.1.11 2013-06-02 14:28:22 +02:00
Fabien Potencier
f26c2b9deb Merge branch '2.3'
* 2.3:
  ErrorHandler and fixes
  fixed typo in CS translation (closes #8069)
  fix arab translation
  Removed reference to Symfony\Component\Form\Extension\Core\Type\FormType in form.xml
  slovenian validator translations updated
  [FrameworkBundle] set the dispatcher in the console application
  [Console] fix typehint for Application::setDispatcher
  [Finder] Fixed a path in a test.
  [Form] [Validator] Fixed post_max_size = 0 bug (Issue #8065)
2013-06-02 14:05:59 +02:00
Fabien Potencier
7fb9c25f8c Merge branch '2.2' into 2.3
* 2.2:
  fixed typo in CS translation (closes #8069)
  fix arab translation
  [Finder] Fixed a path in a test.
  [Form] [Validator] Fixed post_max_size = 0 bug (Issue #8065)
2013-06-02 14:05:51 +02:00
Fabien Potencier
afe18722d2 Merge branch '2.1' into 2.2
* 2.1:
  fixed typo in CS translation (closes #8069)
  [Form] [Validator] Fixed post_max_size = 0 bug (Issue #8065)

Conflicts:
	src/Symfony/Component/Form/Tests/Extension/Validator/Constraints/FormValidatorTest.php
	src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
2013-06-02 14:05:41 +02:00
Fabien Potencier
49006b42a9 merged branch odi86/check-post-max-size-zero (PR #8149)
This PR was merged into the 2.1 branch.

Discussion
----------

[Form] [Validator] Fixed post_max_size = 0 bug (issue #8065)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8065
| License       | MIT
| Doc PR        |

Commits
-------

2038329 [Form] [Validator] Fixed post_max_size = 0 bug (Issue #8065)
2013-06-02 14:03:10 +02:00