This PR was merged into the 2.0 branch.
Commits
-------
d3f5f3a Added comment
773d818 [FrameworkBundle] Added a check on file mime type for CodeHelper::fileExcerpt()
Discussion
----------
[FrameworkBundle] Added a check on file mime type for CodeHelper::fileExcerpt()
Fixed a bug on `CodeHelper::fileExcerpt()`.
I add a check on the file mime type because I use a phar of phpunit and when a exception throwed in a test, Symfony build a page with the stack trace of the exception.
The phpunit.phar path is in the stack trace and Symfony call `highlight_file()` function on this file path.
`highlight_file()` cannot parse the phar file and warnings are displayed.
This PR add a check on the file mime type.
**This PR can be applied on 2.0, 2.1 and master branches.**
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes (The broken test seems to be unrelated to this change)
Fixes the following tickets: -
License of the code: MIT
This PR was merged into the master branch.
Commits
-------
7511a50 [Validator] Card validation - French translations
Discussion
----------
[Validator] Card validation - French translations
This PR was merged into the master branch.
Commits
-------
008dc8f [Console] tweaked the select() method in the dialog helper to be more consistent with other method in the same class
692b0f4 [Console] added select() method for DialogHelper
Discussion
----------
[Console] Add ability to select values interactively
This is a slightly modified version of #5417
Adds ability to select from value list:
$values = array('One', 'Two', 'Three');
$pick = $this->getHelper('dialog')->select($output, 'Pick a bundle:', $values, 2);
var_dump($pick);
... would give the following CLI output:
Pick a bundle:
0 One
1 Two
2 Three
> 1
1
---------------------------------------------------------------------------
by Seldaek at 2012-12-14T09:07:40Z
Maybe the default value should be shown somehow?
---------------------------------------------------------------------------
by fabpot at 2012-12-14T09:28:42Z
@Seldaek: It's up to you to display it (probably in the question). That's how the other `ask*` methods work.
---------------------------------------------------------------------------
by Tobion at 2012-12-14T09:38:40Z
Would be nice to also add the ability to select multiple values (probably other PR).
So one can select each option individually to toggle it's selection. And one can select multiple with a range like `2-7` (as in the git console with `git add -i`).
---------------------------------------------------------------------------
by fabpot at 2012-12-14T09:45:10Z
@Tobion That's indeed something that should be done in another PR.
This PR was merged into the 2.1 branch.
Commits
-------
f24e3d7 [HttpKernel] Revise MongoDbProfilerStorage::write() return value
78c5273 [Session] Document Mongo|MongoClient argument type instead of "object"
de19a81 [HttpKernel] Support MongoClient and Mongo connection classes
b28af77 [Session] Support MongoClient and Mongo connection classes
20e93bf [Session] Utilize MongoDB::selectCollection()
Discussion
----------
[2.1] Support PHP MongoDB driver 1.3.0+ in profiler/session classes
> Bug fix: yes
> Feature addition: yes
> Backwards compatibility break: no
> Symfony2 tests pass: yes
> Fixes the following tickets: #6130
> License of the code: MIT
I don't believe this is a BC break, but just to confirm: the MongoDbSessionHandler constructor signature changed, as I removed the `Mongo` type hint.
Bug fix entails allowing MongoClient to be used by default if the new driver is available, since the original Mongo class is deprecated. I also removed the assumption about `MongoCollection::update()`'s return value, since it may be a status array now.
---------------------------------------------------------------------------
by jmikola at 2012-12-13T22:04:47Z
Lots of test failures, but they appear to be unrelated.
This PR was merged into the master branch.
Commits
-------
632f57d Corrected typo in catalan translation
Discussion
----------
Corrected typo in catalan translation
This PR was merged into the 2.1 branch.
Commits
-------
a5530c5 [Propel1Bridge] Fix "and => &&" CS in ModelChoiceList
Discussion
----------
[Propel1Bridge] Fix "and => &&" CS in ModelChoiceList
---------------------------------------------------------------------------
by willdurand at 2012-12-13T22:52:45Z
👍
MongoClient defaults its write concern to w=1 (i.e. "safe" writes), which means update() may return an array instead of boolean true. Check for this before returning from write().
This PR was merged into the master branch.
Commits
-------
74a06f8 QtTranslationsLoader class renamed to QtFileLoader.
Discussion
----------
[Translation] QtTranslationsLoader class renamed to QtFileLoader.
QtTranslationsLoader class renamed to QtFileLoader. QtTranslationsLoader is deprecated and will be removed in 2.3.
Fixes#6332.
This PR was merged into the 2.1 branch.
Commits
-------
b20c5ca [Form] Fixed reverse transformation of values in DateTimeToStringTransformer
Discussion
----------
[Form] Fixed reverse transformation of values in DateTimeToStringTransformer
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
The parts not given in the format are reset to the corresponding values of
the UNIX base timestamp. For example, when parsing with the format "Y-m-d",
parsing
"2012-05-18"
now results in the date
"2012-05-18 00:00:00 UTC"
instead of
"2012-05-18 12:58:27 UTC"
as before, where the time part corresponded to the local server time.
Another example: When parsing with the format "H:i:s", parsing
"12:58:27"
now results in
"1970-01-01 12:58:27 UTC"
instead of
"2012-12-13 12:58:27 UTC"
as before, where again the date part corresponded to the local server time.
This behavior is now consistent with DateTimeToArrayTransformer and
DateTimeToLocalizedStringTransformer.
This PR was merged into the master branch.
Commits
-------
2196810 Added QtTranslationsLoader tests.
201818bFixed#5797.
Discussion
----------
[Translation] Fixed#5797.
This should fix issue #5797.
What I did is prevented `Translator` to throw `NotFoundResourceException` if resource is not found and there are fallback locales to process. This happens for locales like `en_GB`, `fr_FR`...
I also tested this fix against real application which uses Validation component without full stack framework and I was able to use `en_GB` locale without any errors only after this fix.