Commit Graph

45338 Commits

Author SHA1 Message Date
Nicolas Grekas
f63976fcbb bug #34331 [TwigBundle] Restore the preview mechanism (yceruto)
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBundle] Restore the preview mechanism

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

follow up https://github.com/symfony/symfony/pull/34312

Commits
-------

d3f1121885 [TwigBundle] Restore the preview mechanism
2019-11-12 14:55:43 +01:00
Yonel Ceruto
d3f1121885 [TwigBundle] Restore the preview mechanism 2019-11-12 08:42:17 -05:00
Nicolas Grekas
3ae3094a18 security #cve-2019-18886 [Security\Core] throw AccessDeniedException when switch user fails (nicolas-grekas)
This PR was merged into the 4.3 branch.
2019-11-12 14:13:43 +01:00
Nicolas Grekas
bcfc282d42 [Security\Core] throw AccessDeniedException when switch user fails 2019-11-12 14:12:56 +01:00
Nicolas Grekas
0b2c3a43bc security #cve-2019-18888 [Mime] fix guessing mime-types of files with leading dash (nicolas-grekas)
This PR was merged into the 4.3 branch.
2019-11-12 14:10:56 +01:00
Nicolas Grekas
77ddabf2e7 [Mime] fix guessing mime-types of files with leading dash 2019-11-12 14:10:02 +01:00
Nicolas Grekas
227e73d164 security #cve-2019-11325 [VarExporter] fix exporting some strings (nicolas-grekas)
This PR was merged into the 4.3 branch.
2019-11-12 14:08:52 +01:00
Nicolas Grekas
2baf53aa7a Merge branch '3.4' into 4.3
* 3.4:
  [HttpFoundation] fix guessing mime-types of files with leading dash
  [Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances
  Use constant time comparison in UriSigner
2019-11-12 14:07:20 +01:00
Nicolas Grekas
4cc37df2fb security #cve-2019-18889 [Cache] forbid serializing AbstractAdapter and TagAwareAdapter instances (nicolas-grekas)
This PR was merged into the 3.4 branch.
2019-11-12 13:50:33 +01:00
Nicolas Grekas
b21025b139 security #cve-2019-18888 [HttpFoundation] fix guessing mime-types of files with leading dash (nicolas-grekas)
This PR was merged into the 3.4 branch.
2019-11-12 13:49:04 +01:00
Nicolas Grekas
010213408e security #cve-2019-18887 [HttpKernel] Use constant time comparison in UriSigner (stof)
This PR was merged into the 3.4 branch.
2019-11-12 13:47:53 +01:00
Nicolas Grekas
92c81b7258 [DI] fix dep 2019-11-12 12:50:59 +01:00
Nicolas Grekas
32c81a5f2e [ErrorHandler] fix return type 2019-11-12 12:21:15 +01:00
Nicolas Grekas
051d4cc073 minor #34328 Sync UPGRADE-5.0 before beta (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

Sync UPGRADE-5.0 before beta

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

a247d319b9 Sync UPGRADE-5.0 before beta
2019-11-12 12:17:17 +01:00
Nicolas Grekas
810e4a136f [ErrorHandler] add missing return types 2019-11-12 12:16:57 +01:00
Thomas Calvet
a247d319b9 Sync UPGRADE-5.0 before beta 2019-11-12 12:06:16 +01:00
Nicolas Grekas
7ec445b130 [HttpKernel] fix deps 2019-11-12 12:00:56 +01:00
Nicolas Grekas
e1ac6e19fb [TwigBundle] fix conflict rule 2019-11-12 11:49:01 +01:00
Nicolas Grekas
a0708cca7f Merge branch '4.3' into 4.4
* 4.3:
  [Workflow] fix lowest dep
2019-11-12 11:13:59 +01:00
Nicolas Grekas
4bc7e9c614 Merge branch '3.4' into 4.3
* 3.4:
  [Workflow] fix lowest dep
2019-11-12 11:07:11 +01:00
Nicolas Grekas
7064ff35f2 [Workflow] fix lowest dep 2019-11-12 11:06:38 +01:00
Nicolas Grekas
36aca86545 Cleanup deps on var-dumper 2019-11-12 11:02:34 +01:00
Nicolas Grekas
a90352263c bug #34326 [HttpKernel] Fix missing import in GetResponseForExceptionEvent (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Fix missing import in GetResponseForExceptionEvent

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

bc46a3a6dd [HttpKernel] Fix missing import in GetResponseForExceptionEvent
2019-11-12 10:29:05 +01:00
Thomas Calvet
bc46a3a6dd [HttpKernel] Fix missing import in GetResponseForExceptionEvent 2019-11-12 10:28:52 +01:00
Fabien Potencier
0b867be27b feature #34312 [ErrorHandler] merge and remove the ErrorRenderer component (nicolas-grekas, yceruto)
This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler] merge and remove the ErrorRenderer component

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This PR supersedes #34288.

Here is what it does:
- Merge the `ErrorRenderer` component into `ErrorHandler`
- Add `ErrorRendererInterface::render(\Throwable $e): FlattenException` and refactor error renderers around it.
- Add `FlattenException::setAsString()` to make the previous possible.
- Add `CliErrorRenderer` to render error on the CLI too. This means `VarDumper` is now a required dependency of `ErrorHandler`. This paves the way to use it also for rendering HTML - the logic there is much more advanced than what `HtmlErrorRenderer` provides and ever should provide.
- Make `BufferingLogger` map its collected logs to `error_log()` if they are not emptied before.
- Remove some classes that are not needed anymore (`ErrorRenderer`, `ErrorRendererPass`, `HtmlErrorRendererInterface`)
- Simplified the logic in `Debug::enable()` - nobody uses its arguments
- Fix a few issues found meanwhile.

With these changes, the component can be used standalone. One is now able to require only it, register it either with either `ErrorHandler::register()` or `Debug::enable()` and profit.

Commits
-------

d1bf1cada4 [ErrorHandler] help finish the PR
6c9157bbc2 [ErrorHandler] merge and remove the ErrorRenderer component
2019-11-12 10:05:23 +01:00
Yonel Ceruto
d1bf1cada4 [ErrorHandler] help finish the PR 2019-11-12 10:04:13 +01:00
Nicolas Grekas
25c166fc10 Merge branch '4.3' into 4.4
* 4.3:
  bumped Symfony version to 4.3.8
  updated VERSION for 4.3.7
  updated CHANGELOG for 4.3.7
  bumped Symfony version to 3.4.35
  updated VERSION for 3.4.34
  update CONTRIBUTORS for 3.4.34
  updated CHANGELOG for 3.4.34
2019-11-12 09:57:06 +01:00
Nicolas Grekas
3461d0eba8 Merge branch '3.4' into 4.3
* 3.4:
  bumped Symfony version to 3.4.35
  updated VERSION for 3.4.34
  update CONTRIBUTORS for 3.4.34
  updated CHANGELOG for 3.4.34
2019-11-12 09:56:22 +01:00
Fabien Potencier
7ddb19c702 bumped Symfony version to 4.3.8 2019-11-11 17:42:32 +01:00
Fabien Potencier
fb4065ac95
Merge pull request #34323 from fabpot/release-4.3.7
released v4.3.7
2019-11-11 17:39:14 +01:00
Fabien Potencier
a2fd583db3 updated VERSION for 4.3.7 2019-11-11 17:38:54 +01:00
Fabien Potencier
e60288d791 updated CHANGELOG for 4.3.7 2019-11-11 17:38:48 +01:00
Fabien Potencier
be987f4926 Merge branch '4.3' into 4.4
* 4.3:
  Removed declare(strict_types=1) in DispatchAfterCurrentBusStamp
2019-11-11 17:28:16 +01:00
Fabien Potencier
a4c4f00e17 bumped Symfony version to 3.4.35 2019-11-11 17:24:44 +01:00
Fabien Potencier
c461582064
Merge pull request #34322 from fabpot/release-3.4.34
released v3.4.34
2019-11-11 17:11:40 +01:00
Fabien Potencier
d7601fa827 updated VERSION for 3.4.34 2019-11-11 17:11:23 +01:00
Fabien Potencier
f888b06f7b update CONTRIBUTORS for 3.4.34 2019-11-11 17:11:18 +01:00
Fabien Potencier
d0f736139e updated CHANGELOG for 3.4.34 2019-11-11 17:11:06 +01:00
Nicolas Grekas
01d9c9dc80 [HttpFoundation] fix typo 2019-11-11 14:11:43 +01:00
Nicolas Grekas
01121770e9 bug #34317 [HttpFoundation][Lock] Connection parameter corrected (wimg)
This PR was submitted for the master branch but it was merged into the 4.4 branch instead.

Discussion
----------

[HttpFoundation][Lock] Connection parameter corrected

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Connection parameter incorrectly specified. This variable doesn't exist, the data is in $connection instead.

Commits
-------

27207c3056 [HttpFoundation][Lock] Connection parameter corrected
2019-11-11 14:09:50 +01:00
wimg
27207c3056 [HttpFoundation][Lock] Connection parameter corrected 2019-11-11 14:09:26 +01:00
Nicolas Grekas
6be5cc75a4 [HttpFoundation] fix guessing mime-types of files with leading dash 2019-11-11 13:53:10 +01:00
Nicolas Grekas
d446d7733a [VarExporter] fix exporting some strings 2019-11-11 13:48:54 +01:00
Nicolas Grekas
6c9157bbc2 [ErrorHandler] merge and remove the ErrorRenderer component 2019-11-10 18:54:30 +01:00
Fabien Potencier
10a349c37d feature #34309 [HttpKernel] make ExceptionEvent able to propagate any throwable (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] make ExceptionEvent able to propagate any throwable

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

An alternative to #34306.

As a reminder, the goal of this series of PRs is to remove the `FatalThrowableError` wrapper that we introduced to seamlessly handle throwables when they were introduced in PHP 7.

From the changelog of `HttpKernel`:
 * Deprecated methods `ExceptionEvent::get/setException()`, use `get/setThrowable()` instead
 * Deprecated class `ExceptionListener`, use `ErrorListener` instead

And the final target: removed `Symfony\Component\ErrorHandler\Exception\ErrorException` (`FatalThrowableError` is already deprecated.)

Commits
-------

6f67f0e0c0 [HttpKernel] make ExceptionEvent able to propagate any throwable
2019-11-10 14:19:52 +01:00
Fabien Potencier
b2b688ca25 minor #34311 [Messenger] Removed strict types in DispatchAfterCurrentBusStamp (vudaltsov)
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Removed strict types in DispatchAfterCurrentBusStamp

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

7b9f752b47 Removed declare(strict_types=1) in DispatchAfterCurrentBusStamp
2019-11-10 13:59:42 +01:00
Valentin Udaltsov
7b9f752b47 Removed declare(strict_types=1) in DispatchAfterCurrentBusStamp 2019-11-10 12:50:21 +03:00
Nicolas Grekas
6f67f0e0c0 [HttpKernel] make ExceptionEvent able to propagate any throwable 2019-11-10 10:37:33 +01:00
Robin Chalas
d5ba53547e minor #34308 [Security] Avoid unnecessary usage of Reflection (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[Security] Avoid unnecessary usage of Reflection

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

2377418443 [Security] Avoid unnecessary usage of Reflection
2019-11-09 23:27:08 +01:00
Robin Chalas
2377418443 [Security] Avoid unnecessary usage of Reflection 2019-11-09 23:08:03 +01:00