This PR was merged into the 2.2 branch.
Discussion
----------
[2.2][TwigBridge] Fix form_enctype bug
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
After a copy/past error in #8675, `{{ form_enctype() }}` was not working because it results in a `Class "Symfony\Bridge\Twig\Node\FormEnctypeNode" not found` error.
This should only be merged in 2.2, as of 2.3 this is moved to the `Symfony\Bridge\Twig\Node\FormEnctypeNode` class
Commits
-------
e0c7d3d Fixed bug introduced in #8675
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8677).
Discussion
----------
[TwigBundle] made the filesystem loader compatible with Twig 2.0
| Q | A
| ------------- | ---
| Bug fix? | yes (for Twig 2.x)
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Without adding the exists() method, the code happens to work by chance,
just because the current implementation of Twig exits() method calls
findTemplate().
But we know that it won't be the case anymore as of Twig 2.0.
Commits
-------
d00548b [TwigBundle] made the filesystem loader compatible with Twig 2.0
Without adding the exists() method, the code happens to work by chance,
just because the current implementation of Twig exits() method calls
findTemplate().
But we know that it won't be the case anymore as of Twig 2.0.
This PR was merged into the 2.2 branch.
Discussion
----------
replaced deprecated Twig features
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
As Symfony depends on Twig 1.11+, removing the usage of deprecated features will allow Symfony 2.2+ to work with Twig 2.0.
Commits
-------
322f880 replaced deprecated Twig features
This PR was merged into the 2.2 branch.
Discussion
----------
Added a missing dev dep for Httpkernel
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8613
| License | MIT
| Doc PR | -
Commits
-------
a741414 [HttpKernel] added a missing dep for dev
This PR was merged into the 2.2 branch.
Discussion
----------
[Form] Removed the "disabled" attribute from the placeholder option in select fields due to problems with the BlackBerry 10 browser
| Q | A
| ------------- | ---
| Bug fix? | yes (together with #8623)
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7678#8478#8526
| License | MIT
| Doc PR | -
Commits
-------
97cbb19 [Form] Removed the "disabled" attribute from the placeholder option in select fields due to problems with the BlackBerry 10 browser
This PR was merged into the 2.2 branch.
Discussion
----------
[Routing] add ability for apache matcher to handle array values
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8567
Commits
-------
c138304 [routing] added ability for apache matcher to handle array values
This PR was merged into the 2.2 branch.
Discussion
----------
[Form] Fix issue with \DateTimeZone::UTC / 'UTC' for PHP < 5.5
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
On PHP 5.4.x and 5.3.x, `setTimeZoneId()` requires the parameter to be a string, but the constant `\DateTimeZone::UTC` is (int) 1024.
See: http://www.php.net/manual/en/intldateformatter.settimezoneid.php
This caused an issue for us when using Date formfields, giving this error:
"DateTimeZone::__construct(): Unknown or bad timezone (1024)"
Commits
-------
5c359a8 Fix issue with \DateTimeZone::UTC / 'UTC' for PHP 5.4
This PR was merged into the 2.2 branch.
Discussion
----------
removed dead code and fixed CS
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
7d58147 removed dead code and fixed CS
This PR was merged into the 2.2 branch.
Discussion
----------
[Validator] Fixed StaticMethodLoader does not try to invoke methods of abstract classes anymore
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8589
| License | MIT
| Doc PR | n/a
Commits
-------
b41cf82 [Validator] fixed StaticMethodLoader trying to invoke methods of abstract classes (closes#8589)
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8581).
Discussion
----------
TimeCollector, Notice, if no events
https://github.com/symfony/symfony/issues/8574
Commits
-------
e9da1c0 return 0 if there is no valid data
This PR was merged into the 2.2 branch.
Discussion
----------
[Tests] Tests on php 5.5 should pass
Because php 5.5 is stable now
Commits
-------
0086ee3 [Tests] Tests on php 5.5 should pass
This PR was merged into the 2.2 branch.
Discussion
----------
[Twig] fixed TwigEngine::exists() method when a template contains a syntax error (closes#8546)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8546
| License | MIT
| Doc PR | n/a
Commits
-------
ae7fa11 [Twig] fixed TwigEngine::exists() method when a template contains a syntax error (closes#88546)
This PR was squashed before being merged into the 2.2 branch (closes#8421).
Discussion
----------
[Validator] fixed ConstraintViolation::$propertyPath incorrect when nested
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8351
| License | MIT
In nested constraints, the property path will be overwritten in the context (as there would be a recursive call to CollectionValidotor when nested). Reason is, in ConstraintValidatorFactory object is loaded from memory if exists and context is initialized with the new context. So, other constraints after the nested constraints PropertyPath would be wrong.
So I think better create a new object for CollectionValidator always.
see this https://gist.github.com/alexkappa/5851274
It shows [name][email] even though the email is not under the name node.
Commits
-------
28e0709 [Validator] fixed ConstraintViolation:: incorrect when nested
This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes#7930).
Discussion
----------
handle Optional and Required constraints from XML or YAML sources correc...
...tly
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7575
| License | MIT
| Doc PR | symfony/symfony-docs#2432
Commits
-------
a93a23a handle Optional and Required constraints from XML or YAML sources correctly
This PR was merged into the 2.2 branch.
Discussion
----------
[Validator] Fixed groups argument misplace for validateValue method from validator class
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Signature of validateValue method in ExecutionContext Class is this.
```
public function validateValue($value, $constraints, $subPath = '', $groups = null)
```
But this was called wrongly in Validator Class.
Commits
-------
d3eb9b7 [Validator] Fixed groups argument misplace for validateValue method from validator class
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8453).
Discussion
----------
added missing comments to WebTestCase
Added comments that are required for autocompletion when extending WebTestCase.
Commits
-------
d056e6b added missing comments to WebTestCase
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8456).
Discussion
----------
[Process] Fixed#8455: PhpExecutableFinder::find() does not always return the correct binary
Since `PHP_BINARY` is the very first approach considered, there is no way to use a workaround like setting the `PHP_PATH`.
Checking `PHP_PATH` could potentially be put before checking `PHP_BINARY`: that would avoid an extra function call (and system call), at the price of a small BC_BREAK, but I think it's better in this case to have a solution that doesn't force people to set the `PHP_PATH` environment variable.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8455
| License | MIT
| Doc PR | none
Commits
-------
35a2fe4 [Process] Fixed#8455: PhpExecutableFinder::find() does not always return the correct binary
This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Fix Container::camelize to convert beginning and ending . and _
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7431
| License | MIT
| Doc PR | n/a
I'm using strtr to make the conversion in order to ensure that the behavior is the same as `Container::get`.
From the test cases I've added, the following were not passing:
Commits
-------
485d53a [DependencyInjection] Fix Container::camelize to convert beginning and ending chars
This PR was merged into the 2.2 branch.
Discussion
----------
[DependencyInjection] Add exception for service name not dumpable in PHP
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8485#8030
| License | MIT
| Doc PR | n/a
Throws an exception when the DIC is dumped to PHP, before generating invalid PHP.
The regex comes from the PHP doc: http://www.php.net/manual/en/language.oop5.basic.php
Commits
-------
242b318 [DependencyInjection] Add exception for service name not dumpable in PHP