Bernhard Schussek
f078554c2a
[Form] Removed StripTagsListenerTest
2011-04-18 14:27:18 +02:00
Bernhard Schussek
57722550de
[Form] Added test for 'email' type and fixed a few bugs
2011-04-18 13:04:18 +02:00
Fabien Potencier
b71f9d2708
[Form] added a unit tests for previous commit
2011-04-18 08:21:18 +02:00
Bernhard Schussek
be5738564f
[Form] Improved regular expression in AbstractType::getName() and added unit tests
2011-04-17 18:01:22 +02:00
Bernhard Schussek
2ea68dfcd2
[Form] Improved test coverage of NumberToLocalizedStringTransformer
2011-04-15 16:25:48 +02:00
Bernhard Schussek
30922d9375
[Form] Fixed: Checkboxes in an expanded choice field never have the 'required' HTML5 attribute. Closes http://trac.symfony-project.org/ticket/9588
2011-04-15 16:10:04 +02:00
Bernhard Schussek
9582221862
[Form] ResizeFormListener::preBind() now handles empty strings. Fixes https://github.com/symfony/symfony/pull/40
2011-04-15 15:43:02 +02:00
Bernhard Schussek
d0c572716a
Merge remote branch 'henrikbjorn/form' into henrik_merge
2011-04-15 15:34:29 +02:00
Bernhard Schussek
bc0efff28d
[Form][FrameworkBundle] Fixed escaping of choice widgets
2011-04-15 15:27:15 +02:00
Henrik Bjørnskov
e687685f98
[Form] change FormView::setVar,getVar,getVars,hasVar to set,get,all,has
...
[Form] Fixed {get,set,has}Var references in templating php
[Form] Added getVars to FormView to ease usage in Twig. Also added some phpdoc and cleaned up the get method by adding a default value
[Form] Fix
[Form] Delete file generated by test
2011-04-15 15:25:37 +02:00
Bernhard Schussek
e787d5dc22
[Form] PropertyPath now can handle elements with special characters
2011-04-15 15:25:19 +02:00
Bernhard Schussek
4f1ae660fa
[Form] Fixed choice labels in expanded choice fields
2011-04-15 15:04:44 +02:00
Bernhard Schussek
41c6ab0ac7
[Form] Field labels can now be passed in the 'label' option
2011-04-15 15:03:10 +02:00
Bernhard Schussek
3d92549382
[FrameworkBundle] Fixed various escaping problems and added test cases for them
2011-04-15 14:38:46 +02:00
Bernhard Schussek
990bef8afb
[Form][FrameworkBundle][TwigBundle] Fixed: CSRF fields are not rendered for nested forms anymore
2011-04-15 14:05:33 +02:00
Bernhard Schussek
8fe21285ba
[Form] Renamed Form::getView() to createView() to clearly indicate that each call returns a new object
2011-04-15 13:52:11 +02:00
Bernhard Schussek
276b23a344
[Form] Moved creation logic of FormView to Form class
2011-04-15 13:41:45 +02:00
Bernhard Schussek
44fa9bbeaa
[Form] Fixed: CSRF token is regenerated if validation fails to avoid stalled tokens. Closes https://github.com/symfony/symfony/pull/415
2011-04-15 12:50:50 +02:00
Bernhard Schussek
c9c8b5c98e
[Form] Improved test coverage of MonthChoiceList and fixed timezone used in it. Fixes https://github.com/symfony/symfony/pull/433
...
Based on dfb93b1bcebf1f34d3a880d00f36acb2bcca0f08:
[FORM] Fixed DateField Month Choices
The month choices were calculated using the current day of the month with
gmmktime rather than the 1st of the month. Additionally, this provides a
UTC timestamp which is passed to the formatter (IntlDateFormatter) which
converts the timestamp using the current timezone. This means that the UTC
timestamp for 1st March was being converted for my timezone (EST) and giving
a date of 28th February, leading to Feb appearing again in the popup form
instead of Mar.
2011-04-15 12:26:07 +02:00
Bernhard Schussek
77bea81ed5
[Form] Improved test coverage of ResizeFormListener. Fixed https://github.com/symfony/symfony/pull/493
2011-04-15 11:06:51 +02:00
Bernhard Schussek
fa457b1cc4
[Form] Renamed 'filter' listeners to 'on' to match naming conventions across the framework
2011-04-15 10:57:32 +02:00
Bernhard Schussek
c6fe6a750d
[Form] Added functional test for the 'size' attribute in the select tags of a time field
2011-04-14 15:29:55 +02:00
Bernhard Schussek
e3db366116
[Form] Passing FormFactory to FormBuilder in its constructor
2011-04-14 15:25:30 +02:00
Bernhard Schussek
72b17cd67c
[Form] Renamed TemplateContext to FormView
2011-04-14 15:02:51 +02:00
Bernhard Schussek
ca6ae09779
[Form] Removed TemplateContext::create()
2011-04-14 14:42:17 +02:00
Bernhard Schussek
4907c7d81d
[Form] Added test coverage for expanded choice fields
2011-04-14 14:18:25 +02:00
Bernhard Schussek
c2dcebf6ea
[FrameworkBundle] Added test coverage for FormHelper and fixed various rendering bugs
2011-04-14 13:37:27 +02:00
Bernhard Schussek
ce5f3073bd
Fixed test suite and names of accessor methods in TemplateContext
2011-04-14 03:52:52 +02:00
Bernhard Schussek
602846f386
[Form] Added tests for table_layout.html.twig
2011-04-14 03:38:19 +02:00
Bernhard Schussek
96f040cec1
[Form] Added extensive test coverage for div_layout.html.twig
2011-04-14 03:15:56 +02:00
Bernhard Schussek
0b0535d30a
[Form] Fixed fatal error in test
2011-04-13 14:01:25 +02:00
Bernhard Schussek
e476231e8a
[Form] Removed invalid tests, cleaned up some tests, added test coverage
2011-04-06 15:58:53 +02:00
Bernhard Schussek
72a41f8c94
[Form] Fixed: Booleans can be used as choice keys now
2011-04-02 18:26:28 +02:00
Bernhard Schussek
a5d0b3aea6
[Form] Changed FormBuilder::set(Client|Norm)Transformer to FormBuilder::prepend(Client|Norm)Transformer and FormBuilder::append(Client|Norm)Transformer to facilitate extension of types
2011-04-02 16:39:19 +02:00
Bernhard Schussek
fc59936740
[Form] Fixed: ThemeRenderer::isChoiceSelected() works correctly for boolean choices
2011-04-02 16:00:46 +02:00
Bernhard Schussek
d3b7c4e8c1
[Form] Moved getLabel(), isChoiceSelected() and isChoiceGroup() from ChoiceListInterface to ThemeRenderer
2011-04-02 14:14:18 +02:00
Bernhard Schussek
94f2baa895
[Form] Fixed BooleanToStringTransformer::reverseTransform() to accept NULL values. Fixes ChoiceTypeTest
2011-04-02 13:00:19 +02:00
Bernhard Schussek
37e8e1270c
[Form][FrameworkBundle][TwigBundle] Renamed view variable 'disabled' to 'read_only' to match with the according FormInterface methods
2011-04-02 12:18:43 +02:00
Bernhard Schussek
35d9b7f800
[Form] Improved test coverage of Form. The emptyValue closure now receives the Form instance to use form data when constructing new objects
2011-04-02 12:00:19 +02:00
Bernhard Schussek
4f39234741
[Form] bind() is ignored if a form is read-only
2011-04-02 11:39:15 +02:00
Bernhard Schussek
ca20aef379
[Form] Improved test coverage of DelegatingValidator and fixed validation group inheritance
2011-04-02 11:35:58 +02:00
Bernhard Schussek
33b0011f86
[Form] Improved test coverage of Form
2011-04-02 11:22:29 +02:00
Bernhard Schussek
c864d7fae1
[Form] Improved test coverage of Form class
2011-03-31 15:23:33 +02:00
Bernhard Schussek
1ef18360fa
[Form] Made name immutable in FormBuilder to avoid synchronization problems with name and property path
2011-03-31 13:48:06 +02:00
Fabien Potencier
59ef0c991c
[Form] fixed two unit tests
2011-03-31 07:36:52 +02:00
Fabien Potencier
c7ccb6643b
[Form] removed unused constructor argument from Type\FieldType (themeFactory and template)
2011-03-31 07:34:04 +02:00
Bernhard Schussek
1fa004ceb2
[Form] Simplified the interface names of the Renderer subnamespace
2011-03-27 23:39:01 +02:00
Bernhard Schussek
cfaa03eeec
[Form] Fixed: empty objects are only created upon binding forms with empty data
2011-03-27 23:07:30 +02:00
Bernhard Schussek
edfae73cd4
[Form] Moved PropertyPath, PropertyPathIterator and VirtualFormAwareIterator to subnamespace Util
2011-03-27 15:37:13 +02:00
Bernhard Schussek
b180319371
[Form] Moved creation of empty data to Form to clean up DataMapperInterface
2011-03-27 15:12:35 +02:00
Bernhard Schussek
6588a47ba7
[Form] Removed FormBuilder::setDataClass(). Use the FieldType option "data_class" instead.
...
The problem was that "data_class" was used in two places: FormBuilder::build() and PropertyPathMapper.
PropertyPathMapper was already constructed during FormType::buildForm(), so any data class changes made to the FormBuilder wouldn't affect the data class of the PropertyPathMapper anymore and so lead to an inconsistent state.
2011-03-27 14:34:48 +02:00
Bernhard Schussek
364b0f5208
[Form] Fixed: FormBuilder::add() accepts FormTypeInterface instances
2011-03-27 14:05:06 +02:00
Bernhard Schussek
dc38eeffe3
[Form] Changed the default value of the 'property_path' option to NULL. Explicitely set it to '' or false to disable mapping for a field/form
2011-03-27 14:02:24 +02:00
Bernhard Schussek
b21929423e
[Form] Completely removed the fields variable in the renderer. The renderer itself supports ArrayAccess and Traversable
2011-03-27 13:48:36 +02:00
Bernhard Schussek
eaff9c641e
[Form] Fixed: the default template is only set on the root renderer and reused by children
2011-03-26 19:39:31 +01:00
Bernhard Schussek
a58cfab37d
[Form] Removed form.type.loader tag and according compiler pass to simplify configuration. Custom types that are not in the DIC can be instantiated manually and passed wherever a type is desired.
2011-03-26 18:48:55 +01:00
Bernhard Schussek
9ff91dc997
Merge remote branch 'beberlei/FormsCollectionPrototype' into beberlei-merge
2011-03-26 18:39:20 +01:00
Bernhard Schussek
fae319e77a
[Form] Renderers are now created explicitely using FormFactory::createRenderer(). This improves performance on requests where a form does not need to be rendered
2011-03-26 16:03:34 +01:00
Bernhard Schussek
8c7a93c90c
[Form] Added FormTypeInterface::buildRendererBottomUp() which is called after children are initialized
2011-03-26 16:03:34 +01:00
Bernhard Schussek
c786fac303
[Form] Sample fix implementation of renderers
2011-03-26 16:03:34 +01:00
Benjamin Eberlei
d87651b6a2
[Form] Add option "prototype" defaulting to true.
2011-03-26 14:52:03 +01:00
Benjamin Eberlei
f882a511a0
[Form] Initialize on iterator access.
2011-03-26 12:28:46 +01:00
Benjamin Eberlei
cd1ce86aee
[Form] Iterator support for ThemeRenderer
2011-03-26 12:25:47 +01:00
Bernhard Schussek
7585dce8dd
[Form] Added options validation to field creation
2011-03-25 15:30:33 +01:00
Bernhard Schussek
6825ea2489
[Form] Improved test coverage of PropertyPathMapper
2011-03-25 11:27:20 +01:00
Bernhard Schussek
e3ac248617
[Form] Errors are mapped to subforms correctly and bubble up again if necessary
2011-03-25 10:53:36 +01:00
Bernhard Schussek
7b412cc762
[Form] Removed FormFactory::addGuessers() and moved guessers to constructor arg instead
2011-03-25 02:26:14 +01:00
Bernhard Schussek
9b1b8cbffa
[Form] Replaced various occurences of 'field' by 'form'
2011-03-25 02:12:01 +01:00
Bernhard Schussek
3c412ffba0
[Form] Moved Form::validateData() to DelegatingValidator::validateFormData()
2011-03-25 01:59:28 +01:00
Bernhard Schussek
770d403a52
[Form] Improved error mapping in DelegatingValidator
2011-03-25 00:57:35 +01:00
Bernhard Schussek
4372bd5dc8
[Form] Fixed: Bubbling errors are caught correctly
2011-03-25 00:18:58 +01:00
Bernhard Schussek
262bdcb21d
[Form] Fixed validation
2011-03-25 00:16:21 +01:00
Bernhard Schussek
ef334dbc4a
Merge remote branch 'beberlei/AttributeSupport' into beberlei-merge
2011-03-24 22:53:39 +01:00
Bernhard Schussek
3f390aa271
[Form] Removed EntityType from DefaultTypeLoader
2011-03-24 22:50:39 +01:00
Benjamin Eberlei
ee96ad0e81
[Form] [DoctrineBridge] Move EntityType and DoctrineTypeLoader into Doctrine Bridge
2011-03-24 22:43:00 +01:00
Benjamin Eberlei
8d6dd2b9af
[Form] Add Arbitrary Attribute Support to Form Rendering.
2011-03-24 22:08:08 +01:00
Benjamin Eberlei
6bcc04905c
[Form] Introduce ArrayTypeLoader, Remove EntityManager and FormFactory interface from DefaultTypeLoader
2011-03-24 20:00:17 +01:00
Bernhard Schussek
2faa47d03b
[Form] Added fallback templates to TwigThemeFactory
2011-03-24 15:11:43 +01:00
Bernhard Schussek
1211d77f49
[Form] Introduced renderer theme factories so that themes can be changed during runtime
2011-03-24 14:27:21 +01:00
Bernhard Schussek
5b41810b6d
Revert "[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'"
...
This reverts commit 1efd680b68
.
2011-03-24 10:55:12 +01:00
Bernhard Schussek
5078a63c74
Revert "[Form] Fixed more naming of themes and theme engines"
...
This reverts commit 1aa34b7240
.
2011-03-24 10:54:47 +01:00
Bernhard Schussek
1aa34b7240
[Form] Fixed more naming of themes and theme engines
2011-03-23 22:51:37 +01:00
Bernhard Schussek
1efd680b68
[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'
2011-03-23 22:34:58 +01:00
Bernhard Schussek
c01419d856
Merge remote branch 'johnwards/renderer_tests' into renderer-tests-merge
2011-03-23 21:13:36 +01:00
Bernhard Schussek
08a09240f6
[Form] Fixed order of input and output timezone to a more natural one
2011-03-23 17:12:04 +01:00
Bernhard Schussek
a880f8d0d1
[Form] Fixed coding conventions
2011-03-23 16:14:53 +01:00
Bernhard Schussek
9e025440ca
Merge remote branch 'johnwards/configuration' into configurable-merge
2011-03-23 16:05:16 +01:00
John Wards
1a014d130e
[Form] Tests for Renderer Plugins
2011-03-22 22:19:51 +00:00
John Wards
2e750f7287
[Form] Coding conventions
2011-03-22 21:02:02 +00:00
John Wards
ef8113c50f
[Form] Base tests for renderers
2011-03-22 20:51:19 +00:00
Bernhard Schussek
ea0e5bb2d6
[Form] Renamed FieldTypeInterface to FormTypeInterface
2011-03-22 12:36:41 +01:00
Bernhard Schussek
270a98e413
[Form] Added support for types that are not registered in the DIC. These are identified by their FQ class name.
2011-03-22 12:33:15 +01:00
John Wards
5a5fdd0529
Merge remote branch 'bernhard/experimental' into configuration
2011-03-22 07:43:47 +00:00
Bernhard Schussek
33692eae4a
[Form] Renamed Form::isTransformationSuccessful() to isSynchronized(). This method now indicates whether the data in the different representations is synchronized. Moved 'invalid' error to DefaultValidator
2011-03-22 02:03:22 +01:00
Bernhard Schussek
16d65f6f16
[Form] Moved previously skipped tests from FormTypeTest to FormTest and fixed them
2011-03-22 01:40:02 +01:00
Bernhard Schussek
577e106361
[Form] Implemented custom mapping of data errors to form fields
2011-03-22 01:15:48 +01:00
John Wards
b4406f254d
[Form] Removing Configurable from DataTransformers
2011-03-21 23:01:10 +00:00
John Wards
27267e8007
[Form] Refactoring tests for new DataTransfomer
2011-03-21 21:46:20 +00:00
Bernhard Schussek
87665bc380
[Form] Decoupled FormBuilder from CSRF protection
2011-03-21 22:41:19 +01:00
Bernhard Schussek
c1abf08d9c
[Form] Implemented error bubbling
2011-03-21 22:13:02 +01:00