Christophe Coevoet
04654cfeb3
Enable the fixer enforcing fully-qualified calls for compiler-optimized functions
2018-07-24 12:05:38 +02:00
Fabien Potencier
d744027357
bug #24606 [HttpFoundation] Fix FileBag issue with associative arrays (enumag)
...
This PR was squashed before being merged into the 2.7 branch (closes #24606 ).
Discussion
----------
[HttpFoundation] Fix FileBag issue with associative arrays
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #24546
| License | MIT
| Doc PR |
Commits
-------
8ea2860996
2017-10-25 18:19:06 -07:00
Jáchym Toušek
8ea2860996
[HttpFoundation] Fix FileBag issue with associative arrays
2017-10-25 18:19:04 -07:00
Nicolas Grekas
0c9edaf336
[DI] minor docblock fixes
2017-10-24 13:40:19 +02:00
Fabien Potencier
166f64efb1
bug #24198 [HttpFoundation] Fix file upload multiple with no files (enumag)
...
This PR was merged into the 2.7 branch.
Discussion
----------
[HttpFoundation] Fix file upload multiple with no files
| Q | A
| ------------- | ---
| Branch? | 2.7
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
```php
<form method="post" enctype="multipart/form-data">
<input type="file" multiple name="img[]">
<input type="submit">
</form>
<?php
$loader = require __DIR__ . '/../app/autoload.php';
if ($_SERVER['REQUEST_METHOD'] === 'POST') {
$request = \Symfony\Component\HttpFoundation\Request::createFromGlobals();
var_export($request->files->all()['img']);
}
```
Expected result when I send the form without any files:
```
array ()
```
Actual result:
```
array ( 0 => NULL, )
```
This causes a problem later when using FileType with multiple option - if no files are sent the form data are `[0 => '']` instead of `[]`.
Of course I need to add a test for this.
Commits
-------
d4f6039dcd
2017-09-30 07:18:14 -07:00
Oskar Stark
5ee9043d8b
removed useless PHPDoc
2017-09-30 07:00:23 -07:00
Jáchym Toušek
d4f6039dcd
[HttpFoundation] Fix file upload multiple with no files
2017-09-14 14:29:10 +02:00
Tyson Andre
12f1239565
Fix minor phpdoc mismatches with the code(detected by phan)
2017-04-29 08:58:46 -07:00
Tobias Schultze
f1c7c657a7
remove api tags from code
2015-09-28 19:11:22 +02:00
Vladimir Reznichenko
4abfabf8da
[2.3] Static Code Analysis for Components
2015-03-21 18:48:06 +01:00
Disquedur
51312d31cc
Remove aligned '=>' and '='
2014-10-26 08:30:58 +01:00
Fabien Potencier
369aebf431
fixed CS
2014-09-22 10:32:35 +02:00
Fabien Potencier
625a4b9650
[HttpFoundation] fixed typo
2014-01-28 16:07:56 +01:00
Fabien Potencier
d100ffaf76
fixed CS
2012-07-09 14:54:20 +02:00
Adrien BRAULT
9a74b851e6
[HttpFoundation] CS and phpdoc fixes
2012-06-25 18:21:41 +02:00
Fabien Potencier
3bdf52a16a
fixed CS
2012-05-18 19:42:42 +02:00
Fabien Potencier
41621e42e9
fixed phpdoc @param alignment
2012-05-15 22:19:31 +02:00
Fabien Potencier
e3421a0b1d
[DoctrineBridge] fixed some CS
2011-12-13 10:22:12 +01:00
Fabien Potencier
8f50592f31
[HttpFoundation] changed \LogicException to \InvalidArgumentException
2011-08-26 08:45:12 +02:00
Fabien Potencier
1c7694ff30
[HttpFoundation] added a missing exception
2011-08-25 10:38:08 +02:00
Fabien Potencier
7dcbcbe69d
[HttpFoundation] tagged public @api
2011-07-20 10:06:02 +02:00
Fabien Potencier
62e4342a86
fixed CS
2011-06-08 12:12:55 +02:00
Victor Berchet
d350e01e33
File & UploadedFile tweaks
2011-04-27 09:10:41 +02:00
Pascal Borreli
8c0beea677
[Phpdoc] Cleaning/fixing
2011-04-23 15:18:47 +00:00
Kris Wallsmith
ab3b8ac364
[HttpFoundation] cleaned up comments and coding standards, added better exception messages when filesystem functions throw errors, added "moved" arg to UploadedFile constructor, added FileNotFoundException to UploadedFile per the parent constructor
2011-03-17 16:07:53 -07:00
Fabien Potencier
8c423edfef
replaced symfony-project.org by symfony.com
2011-03-06 12:40:06 +01:00
Pascal Borreli
f7ab114d36
[HttpFoundation] Fixed missing curly brackets
2011-02-27 18:36:37 +01:00
Kris Wallsmith
c67a9a9643
[HttpFoundation] cleaned up some constructors
2011-02-15 21:51:44 +01:00
Bernhard Schussek
22c12e2c8f
[HttpFoundation] Fixed failing tests introduced in 8dd0c5641a
2011-01-31 15:38:13 +01:00
Bulat Shakirzyanov
14e4b9733d
[HttpFoundation] fixed FileBag to handle sub-requests
2011-01-24 18:22:48 +01:00
Bulat Shakirzyanov
271e757f27
[HttFoundation] extracted FileBag, ServerBag, fixed HeaderBag::add(), updated Request test
2011-01-23 07:40:31 +01:00
