Commit Graph

52951 Commits

Author SHA1 Message Date
Nicolas Grekas
5ec2a252ee [ProxyManager] fix tests 2021-01-04 12:30:20 +01:00
Christian Flothmann
f1ed653eee actually compare the order of entries when any sorting is applied 2021-01-04 12:28:59 +01:00
Fabien Potencier
670da4f2c7 feature #39696 [DoctrineBridge] Deprecate internal test helpers in Test namespace (wouterj)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[DoctrineBridge] Deprecate internal test helpers in Test namespace

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | -
| License       | MIT
| Doc PR        | -

These helper classes are only used internally in the DoctrineBridge and, as far as I can see, only make sense within the test suite of the DoctrineBridge. Having them in `Test` means they are covered by the BC promise, I think we can make our lives more easy by moving them to `Tests`.

Commits
-------

a174e6b4de [DoctrineBridge] Deprecate internal test helpers in Test namespace
2021-01-04 09:15:16 +01:00
Wouter de Jong
a174e6b4de [DoctrineBridge] Deprecate internal test helpers in Test namespace 2021-01-04 09:15:11 +01:00
Fabien Potencier
b76d5608cf bug #39692 [FrameworkBundle] Dump abstract arguments (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Dump abstract arguments

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #24138
| License       | MIT
| Doc PR        | -

This PR fixes n exception thrown when dumping abstract arguments (ie. `./bin/console  debug:containter session.abstract_handler --show-arguments`)

Commits
-------

df769ec84c Dump abstract arguments
2021-01-04 08:57:52 +01:00
Alexander M. Turek
13cfc00c77 Merge branch '5.2' into 5.x
* 5.2:
  remove unneeded sprintf() call
  Fix CS
  Fix config merging in lock
  keep trailing newlines when dumping multi-line strings
  disable error bubbling by default when inherit_data is configured
2021-01-03 23:10:36 +01:00
Alexander M. Turek
a378537a8e Merge branch '5.1' into 5.2
* 5.1:
  remove unneeded sprintf() call
  Fix CS
  Fix config merging in lock
  keep trailing newlines when dumping multi-line strings
  disable error bubbling by default when inherit_data is configured
2021-01-03 23:09:37 +01:00
Alexander M. Turek
3fca96d9de Merge branch '4.4' into 5.1
* 4.4:
  remove unneeded sprintf() call
  Fix CS
  Fix config merging in lock
  keep trailing newlines when dumping multi-line strings
  disable error bubbling by default when inherit_data is configured
2021-01-03 23:00:02 +01:00
Jérémy Derussé
be22c37ea1
Create flock directory 2021-01-03 19:17:49 +01:00
Robin Chalas
e970027682 minor: don't mute call to trigger_deprecation() 2021-01-03 17:04:20 +01:00
Alexander M. Turek
04671ee726 minor #39694 [PropertyAccess] remove unneeded sprintf() call (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyAccess] remove unneeded sprintf() call

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a8252a43b8 remove unneeded sprintf() call
2021-01-03 13:23:32 +01:00
Christian Flothmann
a8252a43b8 remove unneeded sprintf() call 2021-01-03 12:55:43 +01:00
Jérémy Derussé
df769ec84c
Dump abstract arguments 2021-01-03 12:32:13 +01:00
Christian Flothmann
1d0c91629a fix tests to run assertions on returned Crawler instances 2021-01-03 11:13:13 +01:00
Fabien Potencier
a902dd8a1b bug #39683 [Yaml] keep trailing newlines when dumping multi-line strings (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] keep trailing newlines when dumping multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix https://github.com/symfony/symfony/pull/39668#issuecomment-753484545
| License       | MIT
| Doc PR        |

Commits
-------

4c513c24c7 keep trailing newlines when dumping multi-line strings
2021-01-03 09:28:04 +01:00
Fabien Potencier
da07550827 bug #39670 [Form] disable error bubbling by default when inherit_data is configured (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] disable error bubbling by default when inherit_data is configured

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #14441
| License       | MIT
| Doc PR        |

Commits
-------

8679c2ac05 disable error bubbling by default when inherit_data is configured
2021-01-03 09:24:31 +01:00
Fabien Potencier
4bced61887 Fix CS 2021-01-03 09:19:04 +01:00
Fabien Potencier
a0d66d2ecd bug #39686 [Lock] Fix config merging in lock (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Fix config merging in lock

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35920
| License       | MIT
| Doc PR        | -

Commits
-------

6bb2d67cf1 Fix config merging in lock
2021-01-03 09:18:23 +01:00
Fabien Potencier
d2e589c0ec feature #39684 [DomCrawler] deprecate parents() in favor of ancestors() (xabbuh)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[DomCrawler] deprecate parents() in favor of ancestors()

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Fix #26432
| License       | MIT
| Doc PR        |

Commits
-------

8baafa2bc0 deprecate parents() in favor of ancestors()
2021-01-03 09:15:45 +01:00
Fabien Potencier
5e10543cc0 feature #39666 [FrameworkBundle][HttpFoundation] add assertResponseFormatSame() (dunglas)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[FrameworkBundle][HttpFoundation] add assertResponseFormatSame()

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix n/a
| License       | MIT
| Doc PR        | todo

Add a new PHPUnit assertion checking the format of the HTTP request.

Example:

```php
namespace App\Tests;

use ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestCase;
use App\Entity\Book;

class BooksTest extends ApiTestCase
{
    public function testGetCollection(): void
    {
        static::createClient()->request('GET', '/books');
        $this->assertResponseFormatSame('jsonld');
    }
}
```

Commits
-------

8fffa2c6f8 [FrameworkBundle][HttpFoundation] add assertResponseFormatSame()
2021-01-03 09:13:40 +01:00
Kévin Dunglas
8fffa2c6f8 [FrameworkBundle][HttpFoundation] add assertResponseFormatSame() 2021-01-03 09:13:34 +01:00
Jérémy Derussé
6bb2d67cf1
Fix config merging in lock 2021-01-02 23:18:12 +01:00
Robin Chalas
9cb88fe060 feature #39660 [Messenger] Deprecate option prefetch_count (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Messenger] Deprecate option prefetch_count

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yesno
| Tickets       | -
| License       | MIT
| Doc PR        | -

Revert #30671

Commits
-------

5b55097500 Deprecate option prefetch_count
2021-01-02 23:08:41 +01:00
Jérémy Derussé
5b55097500
Deprecate option prefetch_count 2021-01-02 21:28:54 +01:00
Christian Flothmann
8baafa2bc0 deprecate parents() in favor of ancestors() 2021-01-02 17:29:52 +01:00
Christian Flothmann
4c513c24c7 keep trailing newlines when dumping multi-line strings 2021-01-02 17:02:59 +01:00
Alexander M. Turek
b34890a41c Merge branch '5.2' into 5.x
* 5.2:
  fix postgres transport when the retry table is the same
  do not dump extra trailing newlines for multiline blocks
2021-01-02 00:50:33 +01:00
Alexander M. Turek
0633f96941 Merge branch '5.1' into 5.2
* 5.1:
  fix postgres transport when the retry table is the same
  do not dump extra trailing newlines for multiline blocks
2021-01-01 23:54:04 +01:00
Alexander M. Turek
5c2ef6b5cf Merge branch '4.4' into 5.1
* 4.4:
  do not dump extra trailing newlines for multiline blocks
2021-01-01 21:51:20 +01:00
Fabien Potencier
b308458b46 feature #39577 [Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface (derrabus)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | yes
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

`ArrayDenormalizer` currently asks for a full-blown serializer while a simple denormalizer would be enough. I'd like to change this in Symfony 6. This PR prepares the removal of `SerializerAwareInterface` from this class.

Commits
-------

90f6d30b06 [Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface.
2021-01-01 14:15:40 +01:00
Alexander M. Turek
90f6d30b06 [Serializer] Migrate ArrayDenormalizer to DenormalizerAwareInterface. 2021-01-01 12:17:22 +01:00
Fabien Potencier
61aa8fd67c bug #39608 [Messenger] Setup queues once in AMQP (jderusse)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Messenger] Setup queues once in AMQP

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #39605, Fix #38092, Fix #32172
| License       | MIT
| Doc PR        | -

To ease the setup, this PR also merge setup of exchange AND delayExchange.

/cc @Nyholm

Commits
-------

c2e84c610a Setup queues once in AMQP
2021-01-01 10:47:19 +01:00
Fabien Potencier
04c67e61e2 bug #39668 [Yaml] do not dump extra trailing newlines for multiline blocks (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] do not dump extra trailing newlines for multiline blocks

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38310
| License       | MIT
| Doc PR        |

Commits
-------

5fa9592d5e do not dump extra trailing newlines for multiline blocks
2021-01-01 10:44:44 +01:00
Fabien Potencier
e6ba3a5e4b bug #39674 [Messenger] fix postgres transport when the retry table is the same (lyrixx)
This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] fix postgres transport when the retry table is the same

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

---

I noticed messenger do not consume all messages when there is a retry
and when I'm using only one table for everything.

To reproduce, use the following configuration + use PG + throw an
exception in the handler

```yaml
framework:
    messenger:
        failure_transport: failed

        transports:
            async: '%env(MESSENGER_TRANSPORT_DSN)%'
            failed: 'doctrine://default?queue_name=failed'

        routing:
            'App\Message\Foobar': async
```

The real issue is PG does not notify messenger when we `UPDATE` the message.

---

ping @dunglas

Commits
-------

2b4d47163f fix postgres transport when the retry table is the same
2021-01-01 10:40:53 +01:00
Fabien Potencier
0ecf95021c Bump license year 2021-01-01 10:27:30 +01:00
Fabien Potencier
782ed1019f Merge branch '5.2' into 5.x
* 5.2:
  Bump license year
  Bump license year
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  [Notifier] Add missing LICENSE file
  Add reference link
  [Validator] Update Isin message to match the translation files.
  Update README.md
  Add AuthenticationTokenCreatedEvent to be propagated
2021-01-01 10:27:20 +01:00
Fabien Potencier
a459b44829 Bump license year 2021-01-01 10:27:05 +01:00
Fabien Potencier
2a1a4e7067 Merge branch '5.1' into 5.2
* 5.1:
  Bump license year
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Add reference link
  Update README.md
2021-01-01 10:26:45 +01:00
Fabien Potencier
46ea62297b Bump license year 2021-01-01 10:26:30 +01:00
Fabien Potencier
f4ca745086 Merge branch '4.4' into 5.1
* 4.4:
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Update README.md
2021-01-01 10:25:51 +01:00
Fabien Potencier
2c4337ae5b Bump license year 2021-01-01 10:24:35 +01:00
Grégoire Pineau
2b4d47163f fix postgres transport when the retry table is the same 2020-12-31 17:54:38 +01:00
Thomas Calvet
1c652a7649 [FrameworkBundle] Fix UidNormalizer priority 2020-12-31 17:30:56 +01:00
Christian Flothmann
8679c2ac05 disable error bubbling by default when inherit_data is configured 2020-12-31 15:25:34 +01:00
Christian Flothmann
5fa9592d5e do not dump extra trailing newlines for multiline blocks 2020-12-31 11:51:02 +01:00
Grégoire Pineau
29c7bfa7d6 feature #39020 [PropertyInfo] Support multiple types for collection keys & values (Korbeil)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[PropertyInfo] Support multiple types for collection keys & values

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | #38093
| License       | MIT
| Doc PR        | N/A

This PR is here to introduce multiple types for collection keys & values.
Today, we support types as following: `A|B|C` thanks to `getTypes` interface (in extractors) but we do not support union types in collection keys or values, such as `array<A|B|C>`. This PR will allow this.
In a next PR, we'll introduce an Extractor that will parse phpDoc in order to have union types in collection keys or values.

I tried to introduce as few depreciations as possible, we have only 2 of them here:
- `Type::getCollectionKeyType`
- `Type::getCollectionValueType`

Commits
-------

84dd1784cb Support multiple types for collection keys & values
2020-12-31 10:49:36 +01:00
Baptiste Leduc
84dd1784cb
Support multiple types for collection keys & values 2020-12-31 10:27:19 +01:00
Robin Chalas
e1e1defffa feature #39557 [Notifier] [BC BREAK] Final classes (OskarStark)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] [BC BREAK] Final classes

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no, BC BREAK, but experimental <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

733ba619a1 [Notifier] [BC BREAK] Final classes
2020-12-30 23:13:32 +01:00
Nicolas Grekas
841ec99831 bug #39653 [Form] fix passing null $pattern to IntlDateFormatter (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] fix passing null $pattern to IntlDateFormatter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

52360c1e4e [Form] fix passing null $pattern to IntlDateFormatter
2020-12-29 14:57:58 +01:00
Nicolas Grekas
52360c1e4e [Form] fix passing null $pattern to IntlDateFormatter 2020-12-29 14:49:19 +01:00