This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] Allow tabs before comments at the end of a line
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
If a yml file has a tab character before a line ending comment the comment will be included in the parsed value. Yaml spec allows tab or space as whitespace characters so we need to check for tab as well. See included test.
Recently caused an odd and hard to find bug in our project.
See spec:
http://www.yaml.org/spec/1.2/spec.html#s-b-commenthttp://www.yaml.org/spec/1.2/spec.html#s-separate-in-linehttp://www.yaml.org/spec/1.2/spec.html#s-white
This is a new PR replacing https://github.com/symfony/symfony/pull/15747
@fabpot
Commits
-------
d040be7 [Yaml] Allow tabs before comments at the end of a line
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle] Deprecate the security.secure_random service
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Since the SecureRandom class and interface are already deprecated, so should be the service.
Commits
-------
8b55520 [FrameworkBundle] Deprecate the security.secure_random service
This PR was merged into the 2.3 branch.
Discussion
----------
[ci] fix phpunit wrapper
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Our phpunit wrapper doing the root composer up was a mistake as it breaks testing deps=low.
Commits
-------
25fbcc3 [ci] fix phpunit wrapper
This PR was merged into the 2.8 branch.
Discussion
----------
Deprecate the SecureRandom class
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Deprecate the `Symfony\Component\Security\Core\Util\SecureRandom` and encourage the usage of the `random_bytes` function instead
Commits
-------
f02973a Deprecate the SecureRandom class
This PR was merged into the 2.8 branch.
Discussion
----------
[DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService()
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
The new feature is in the DI component and it enlighten a deprecation from Doctrine that we ignored in FrameworkBundle, that is also fixed in this PR.
See https://github.com/symfony/symfony/pull/16001/files?w=1
Commits
-------
ca69fa3 [DI] Warn when a definition relies on a deprecated class in ContainerBuilder::createService()
This PR was merged into the 2.8 branch.
Discussion
----------
[VarDumper] consistent signature of getDump() in class + trait
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16126
| License | MIT
| Doc PR |
Commits
-------
48a9e83 consistent signature of getDump() in class + trait
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle][VarDumper] tweak some deprecation messages
| Q | A
| ------------- | ---
| Fixed tickets | #16129, #16135
| License | MIT
I was a bit too slow with reviewing.
Commits
-------
536045f tweak some deprecation messages
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#15121).
Discussion
----------
fixed#15118 [Filesystem] mirroring a symlink copies absolute file path
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15118
| License | MIT
| Doc PR |
This reverts the code change in a8b8d33e94 and adjusting the test case accordingly.
Commits
-------
a83d525fixed#15118 [Filesystem] mirroring a symlink copies absolute file path
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#15161).
Discussion
----------
avoid duplicated path with addPrefix
Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | [n/a
| License | MIT
| Doc PR | n/a
Having UniversalClassLoader deprecated raise various issues... and ClassLoader doesn't provide the same features... :(
This one avoid duplication of paths for a given prefix, so can improve perf is such case.
Notice: I open this PR against 2.7, first version where UniversalClassLoader is deprecated, but feel free to apply only if 2.8 or 3.0, as you prefer.
Context on how this class is used in various fedora packages, see
http://blog.remirepo.net/post/2015/06/30/PHP-SIG-autoloader
Commits
-------
af420c1 avoid duplicated path with addPrefix
This PR was merged into the 2.7 branch.
Discussion
----------
[2.7] Fix docblocks about callables
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
7b12fe9 [2.7] Fix docblocks about callables
This PR was merged into the 2.7 branch.
Discussion
----------
[Security] sync translations and add a test for it
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15955
| License | MIT
| Doc PR |
Commits
-------
08333ec [Security] sync translations and add a test for it
This PR was squashed before being merged into the 2.3 branch (closes#14491).
Discussion
----------
[2.3][SECURITY] Add remember me cookie configuration
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14490
| License | MIT
| Doc PR |
Commits
-------
e8f0e5a [2.3][SECURITY] Add remember me cookie configuration
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #16139, #16133
| License | MIT
| Doc PR | -
See https://github.com/symfony/symfony/pull/16139#discussion_r41238804.
I think the most efficient solution is to remove translations from `Security/Core` in 2.3 only (should not be propagated to newest branches!) and load both folders if they exist.
Commits
-------
1ed07a0 [FrameworkBundle] [Security] Remove trans from the security/core in 2.3 & dir loading