Commit Graph

33618 Commits

Author SHA1 Message Date
Nicolas Grekas
dca930f579 [DI] Remove colon from env placeholders 2017-10-08 11:22:35 +02:00
Nicolas Grekas
84ce7e6250 minor #24485 [HttpFoundation] Refactoring; (243083df)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[HttpFoundation] Refactoring;

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ---
| License       | MIT
| Doc PR        | ---

Improve performance, clean code;

Commits
-------

79978db Replace function chain to a single call.
2017-10-08 09:35:07 +02:00
243083df
79978dba05 Replace function chain to a single call. 2017-10-08 02:59:09 +04:00
Nicolas Grekas
fe7f26d4f3 [DI] Throw accurate failures when accessing removed services 2017-10-07 23:38:34 +02:00
Nicolas Grekas
e5d0934b87 [DI] Turn private defs to non-public ones before removing passes 2017-10-07 10:21:26 +02:00
Fabien Potencier
a95fe36bfa feature #24467 [Process] drop non-existent working directory support (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Process] drop non-existent working directory support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23708
| License       | MIT
| Doc PR        |

Commits
-------

ade7c90589 drop non-existent working directory support
2017-10-06 09:30:12 -07:00
Christian Flothmann
ade7c90589 drop non-existent working directory support 2017-10-06 18:19:45 +02:00
Fabien Potencier
7ffd22b050 minor #24466 [DependencyInjection] remove unused fixtures file (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[DependencyInjection] remove unused fixtures file

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I was wondering why the conflict markers in the `master` branch (see b6e9471ded/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services31.php (L43-L52)) did not cause any issues. Turned out that this fixtures file was not used anymore (it was only partially removed in #23022).

Commits
-------

3702e5ff37 remove unused fixtures file
2017-10-06 08:53:44 -07:00
Fabien Potencier
b43bdf398d fixed CS 2017-10-06 08:49:22 -07:00
Fabien Potencier
13d75a4adb feature #23499 [Workflow] add guard is_valid() method support (alain-flaus, lyrixx)
This PR was merged into the 3.4 branch.

Discussion
----------

[Workflow] add guard is_valid() method support

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | Yes
| License       | MIT

Workflow guard configuration support expression language like **is_fully_authenticated()**, **has_role()** or **is_granted()**, etc...
I would like to add the support for a new **is_valid()** expression.
Configuration allow to validate subject against specific validation groups to check if a transition can be applied.

In the next configuration exemple, my issue must validate "affectable" validation group to apply "affect" transistion:

```yaml
framework:
    workflows:
        issue:
            marking_store:
                type: single_state
                arguments:
                    - state
            supports: AppBundle\Entity\Issue
            initial_place: created
            places:
                - created
                - affected
                - closed
            transitions:
                affect:
                    guard: "is_valid(subject, ['affectable'])"
                    from: created
                    to:   affected
                close:
                    from: completed
                    to: closed
```

Commits
-------

06d8198714 [Workflow] Added tests for the is_valid() guard expression
9499bc291c [Workflow] Added guard 'is_valid()' method support
2017-10-06 08:47:04 -07:00
Fabien Potencier
3561be7739 bug #24462 [Yaml] parse references on merge keys with objects (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] parse references on merge keys with objects

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23587, #24417
| License       | MIT
| Doc PR        |

Applies necessary changes on the `3.3` branch to make #24417 work with the `PARSE_OBJECT_FOR_MAP` flag.

Commits
-------

ce10f356a3 parse references on merge keys with objects
2017-10-06 08:22:09 -07:00
Christian Flothmann
3702e5ff37 remove unused fixtures file 2017-10-06 17:17:51 +02:00
Fabien Potencier
bfda40706e minor #24463 [Yaml] initialize inline line numbers (xabbuh)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #24463).

Discussion
----------

[Yaml] initialize inline line numbers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Without this change, tests from `InlineTest` cannot be executed
standalone as the parsed line number would never be initialized.

Commits
-------

33d2aa5382 [Yaml] initialize inline line numbers
2017-10-06 08:16:57 -07:00
Christian Flothmann
33d2aa5382 [Yaml] initialize inline line numbers
Without this change, tests from `InlineTest` cannot be executed
standalone as the parsed line number would never be initialized.
2017-10-06 08:16:57 -07:00
Fabien Potencier
b6e9471ded feature #24364 [DependencyInjection][Filesystem][Security][SecurityBundle] remove deprecated features (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DependencyInjection][Filesystem][Security][SecurityBundle] remove deprecated features

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

45dd40cde8 remove deprecated features
2017-10-06 07:38:43 -07:00
Christian Flothmann
45dd40cde8 remove deprecated features 2017-10-06 14:47:08 +02:00
Christian Flothmann
ce10f356a3 parse references on merge keys with objects 2017-10-06 14:26:09 +02:00
Christian Flothmann
0ab92ece1f Merge branch '3.4'
* 3.4: (26 commits)
  bumped Symfony version to 3.3.11
  updated VERSION for 3.3.10
  updated CHANGELOG for 3.3.10
  bumped Symfony version to 2.8.29
  updated VERSION for 2.8.28
  updated CHANGELOG for 2.8.28
  bumped Symfony version to 2.7.36
  updated VERSION for 2.7.35
  update CONTRIBUTORS for 2.7.35
  updated CHANGELOG for 2.7.35
  Added deprecation to cwd not existing Fixes #18249
  [Session] fix MongoDb session handler to gc all expired sessions
  Add changelog for deprecated DbalSessionHandler
  [Security] Look at headers for switch user username parameter
  Updated Test name and exception name to be more accurate
  newline at end of file
  changed exception message
  Ahh, I see.  It actually wants a newline!
  Removed newline
  Created new Exception to throw and modified tests.
  ...
2017-10-06 11:34:09 +02:00
Christian Flothmann
a165f1bc08 Merge branch '3.3' into 3.4
* 3.3: (23 commits)
  bumped Symfony version to 3.3.11
  updated VERSION for 3.3.10
  updated CHANGELOG for 3.3.10
  bumped Symfony version to 2.8.29
  updated VERSION for 2.8.28
  updated CHANGELOG for 2.8.28
  bumped Symfony version to 2.7.36
  updated VERSION for 2.7.35
  update CONTRIBUTORS for 2.7.35
  updated CHANGELOG for 2.7.35
  [Session] fix MongoDb session handler to gc all expired sessions
  Updated Test name and exception name to be more accurate
  newline at end of file
  changed exception message
  Ahh, I see.  It actually wants a newline!
  Removed newline
  Created new Exception to throw and modified tests.
  Created new Exception to throw and modified tests
  Code standard fixes
  Changed automatic token generation to throw an exception instead
  ...
2017-10-06 11:16:43 +02:00
Christian Flothmann
1dfa63feac Merge branch '2.8' into 3.3
* 2.8:
  bumped Symfony version to 2.8.29
  updated VERSION for 2.8.28
  updated CHANGELOG for 2.8.28
2017-10-06 11:15:28 +02:00
Grégoire Pineau
06d8198714 [Workflow] Added tests for the is_valid() guard expression 2017-10-06 10:14:03 +02:00
Alain Flaus
9499bc291c [Workflow] Added guard 'is_valid()' method support 2017-10-06 10:13:24 +02:00
Tobias Nyholm
53d7857092
Use for=ID on radio/checkbox label.
This is required for some screen reader like Jaws
2017-10-05 21:36:40 -04:00
Fabien Potencier
bf0e6f6565 bumped Symfony version to 3.3.11 2017-10-05 17:17:10 -07:00
Fabien Potencier
cfef3b2d50 Merge pull request #24452 from fabpot/release-3.3.10
released v3.3.10
2017-10-05 16:40:32 -07:00
Fabien Potencier
8fc46c7bb3 updated VERSION for 3.3.10 2017-10-05 16:40:19 -07:00
Fabien Potencier
7a1cb838f9 updated CHANGELOG for 3.3.10 2017-10-05 16:39:08 -07:00
Fabien Potencier
81517602fa bumped Symfony version to 2.8.29 2017-10-05 16:35:26 -07:00
Fabien Potencier
074ae55c3e Merge pull request #24451 from fabpot/release-2.8.28
released v2.8.28
2017-10-05 16:24:20 -07:00
Fabien Potencier
ebf0c076fa updated VERSION for 2.8.28 2017-10-05 16:24:02 -07:00
Fabien Potencier
f0b32cfd9d updated CHANGELOG for 2.8.28 2017-10-05 16:23:57 -07:00
Fabien Potencier
307ddb92a4 Merge branch '2.8' into 3.3
* 2.8:
  bumped Symfony version to 2.7.36
  updated VERSION for 2.7.35
  update CONTRIBUTORS for 2.7.35
  updated CHANGELOG for 2.7.35
  [Session] fix MongoDb session handler to gc all expired sessions
2017-10-05 16:10:23 -07:00
Fabien Potencier
fe0b162b56 feature #24441 [Bridge\Doctrine][FrameworkBundle] Remove legacy uses of ContainerAwareInterface (nicolas-grekas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Bridge\Doctrine][FrameworkBundle] Remove legacy uses of ContainerAwareInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related to #24409

Commits
-------

3b1b8cfdf3 [Bridge\Doctrine][FrameworkBundle] Remove legacy uses of ContainerAwareInterface
2017-10-05 16:08:37 -07:00
Fabien Potencier
0c8043a7d6 feature #24388 [Security] Look at headers for switch_user username (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

[Security] Look at headers for switch_user username

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24260
| License       | MIT
| Doc PR        | n/a

Allowing `switch_user.parameter` config node to be a header name.
It's supported by SwitchUserStatelessBundle and I think it makes sense.
Forgotten in #24260 so targets 3.4 but not a blocker.

Commits
-------

3c801951c8 [Security] Look at headers for switch user username parameter
2017-10-05 16:07:43 -07:00
Fabien Potencier
c4282be820 Merge branch '2.7' into 2.8
* 2.7:
  bumped Symfony version to 2.7.36
  updated VERSION for 2.7.35
  update CONTRIBUTORS for 2.7.35
  updated CHANGELOG for 2.7.35
  [Session] fix MongoDb session handler to gc all expired sessions
2017-10-05 16:06:47 -07:00
Fabien Potencier
dd490af864 bumped Symfony version to 2.7.36 2017-10-05 16:05:57 -07:00
Fabien Potencier
0943a1d8f7 Merge pull request #24450 from fabpot/release-2.7.35
released v2.7.35
2017-10-05 15:52:05 -07:00
Fabien Potencier
2c907d5156 updated VERSION for 2.7.35 2017-10-05 15:51:51 -07:00
Fabien Potencier
4d3f3255dd update CONTRIBUTORS for 2.7.35 2017-10-05 15:51:49 -07:00
Fabien Potencier
88f8c6526a updated CHANGELOG for 2.7.35 2017-10-05 15:51:42 -07:00
Fabien Potencier
75daa6a6eb minor #24439 Add changelog for deprecated DbalSessionHandler (Tobion)
This PR was merged into the 3.4 branch.

Discussion
----------

Add changelog for deprecated DbalSessionHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Add missing changelog/upgrade for #24389

Commits
-------

af0aa1e530 Add changelog for deprecated DbalSessionHandler
2017-10-05 15:47:02 -07:00
Fabien Potencier
9568fae01f bug #23906 Added support for guards when advancing workflow from a command (GDIBass)
This PR was merged into the 3.3 branch.

Discussion
----------

Added support for guards when advancing workflow from a command

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23904
| License       | MIT
| Doc PR        | symfony/symfony-docs

Added support for advancing a workflow from the command line when the transition has guards.

Commits
-------

15fd863112 Updated Test name and exception name to be more accurate
fefc20233b newline at end of file
8f2fa6b047 changed exception message
49839e3c28 Ahh, I see.  It actually wants a newline!
2c9d1e2d42 Removed newline
92308b4815 Created new Exception to throw and modified tests.
2ebc71a616 Created new Exception to throw and modified tests
3a8b2eded1 Code standard fixes
22b44e251f Changed automatic token generation to throw an exception instead
8ab59cb1c2 Updated if statement
324c208e12 Code standards update
b044ffb4a2 Added support for guards when advancing workflow from a command
2017-10-05 15:37:15 -07:00
Fabien Potencier
f961aa024f bug #24448 [Session] fix MongoDb session handler to gc all expired sessions (Tobion)
This PR was merged into the 2.7 branch.

Discussion
----------

[Session] fix MongoDb session handler to gc all expired sessions

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

MongoDB session handler `gc` wrongly only deleted one random expired session instead of all of them.
Care when merging to master as this will conflict with #24447

Commits
-------

e6895bfac5 [Session] fix MongoDb session handler to gc all expired sessions
2017-10-05 15:34:50 -07:00
Fabien Potencier
e70abe8ed6 feature #24447 [Session] remove deprecated session handlers (Tobion)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Session] remove deprecated session handlers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | yes
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/8486

Removes deprecated session handler from #24389, #24438 and #24443

Commits
-------

0a7af3fb50 [Session] remove deprecated session handlers
2017-10-05 15:30:57 -07:00
Fabien Potencier
75fe1fc129 feature #24446 [Security] Remove GuardAuthenticatorInterface (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Security] Remove GuardAuthenticatorInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/issues/8485

Removes BC layers for #16835.

Commits
-------

3408152365 [Security][Guard] Remove GuardAuthenticatorInterface
2017-10-05 15:29:17 -07:00
Fabien Potencier
87712e4006 feature #23708 Added deprecation to cwd not existing Fixes #18249 (alexbowers)
This PR was squashed before being merged into the 3.4 branch (closes #23708).

Discussion
----------

Added deprecation to cwd not existing Fixes #18249

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  |no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #18249
| License       | MIT
| Doc PR        | -

Commits
-------

261eae970f Added deprecation to cwd not existing Fixes #18249
2017-10-05 15:24:36 -07:00
Alex Bowers
261eae970f Added deprecation to cwd not existing Fixes #18249 2017-10-05 15:24:30 -07:00
Tobias Schultze
e6895bfac5 [Session] fix MongoDb session handler to gc all expired sessions 2017-10-05 21:04:13 +02:00
Robin Chalas
3408152365 [Security][Guard] Remove GuardAuthenticatorInterface 2017-10-05 20:06:17 +02:00
Tobias Schultze
0a7af3fb50 [Session] remove deprecated session handlers 2017-10-05 20:06:14 +02:00