22286 Commits

All Branches

Search

Author	SHA1	Message	Date
Fabien Potencier	85c10991d3	bug #15411 Fix the handling of null as locale in the stub intl classes (stof) ... This PR was merged into the 2.3 branch. Discussion ---------- Fix the handling of null as locale in the stub intl classes The Intl extension accepts null as locale in formatters and the collator and will use the default locale in such case. Given that the stub implementation considers that the default locale is always 'en', it should be supported here too instead of forcing libraries to pass the default locale explicitly. For instance, ``Twig_Extensions_Extension_Intl`` relies on the fact that ``null`` as locale uses the default one: https://github.com/twigphp/Twig-extensions/pull/94 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony-demo/pull/123 | License | MIT | Doc PR | n/a Commits ------- d6db6ad Fix the handling of null as locale in the stub intl classes	2015-08-01 08:11:19 +02:00
Fabien Potencier	79b5baf42f	minor #15420 Fix doctrine mapping validation type error (luxifer) ... This PR was merged into the 2.3 branch. Discussion ---------- Fix doctrine mapping validation type error | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The error tell to implement the service `doctrine.orm.<em_name>.metadata_driver`, but this extensions check for the existence of the `doctrine.orm.<em_name>_metadata_driver` where `<em_name>` the entity manager name. Commits ------- 2c9b1db Fix doctrine mapping validation type error	2015-08-01 08:04:58 +02:00
Fabien Potencier	9058904d2b	minor #15417 [Debug] cleanup ExceptionHandlerTest (nicolas-grekas) ... This PR was merged into the 2.7 branch. Discussion ---------- [Debug] cleanup ExceptionHandlerTest | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 51bacc6 [Debug] cleanup ExceptionHandlerTest	2015-08-01 07:54:51 +02:00
Fabien Potencier	251314e541	feature #15160 Redesigned the web debug toolbar (javiereguiluz) ... This PR was merged into the 2.8 branch. Discussion ---------- Redesigned the web debug toolbar | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In my opinion, the design of the current Web Debug Toolbar suffers from two problems: it looks outdated and it lacks polishing on some parts. Symfony has always introduced a big update in this toolbar for each big release, so I propose to do the same for Symfony 3. Let's see the new proposed toolbar in action: ----- **This is the default toolbar** (click on the image to enlarge it)  As you can see, if some panel doesn't provide any information, we don't show it (e.g. 0 queries, 0 forms, 0 logs, 0 ajax requests). ----- Let's compare some panels in detail: **Symfony Panel**   **Request Panel**   ----- When needed, more panels are displayed, such as the SQL information: (click on the image to enlarge it)  As you can see, the new toolbar provides more information than the old one and it takes less space. Some of the new panels include more information in the extended info, such as the Doctrine one showing that the second level cache is disabled:   ----- **Errors and warnings** now stand out more clearly because all the panel background is changed. For example, if there are i18n errors: (click on the image to enlarge it)  If the page is loading too slowly: (click on the image to enlarge it)  If Symfony version is deprecated: (click on the image to enlarge it)  ----- HTTP Errors also stand out more clearly: (click on the image to enlarge it)   ----- Some questions that you may be wondering: * **Why use a dark toolbar instead of maintaining the light toolbar?** Because a dark toolbar stands out more from most of the web designs. It's more probable that your applications display a light background than a dark background, so the Symfony Toolbar stands out more if it's designed in dark. * **What about the profiler?** If this proposal is approved I'll also update the design of the profiler to match this new dark and modern look-and-feel. * **What about smaller screens?** This is a proposal, so I haven't finished it. Tweaking the design for smaller screens will be the next step. Anyway, as you can see the new toolbar already takes much less space than the current one, so it won't be hard to adapt it. Commits ------- 5a571b6 Reordered the toolbar elements via service priorities f237ff1 Increased the z-index of .sf-toolbar-info b3ad83d Removed an unused media query b438ee5 Redesigned "abbr" elements 7d92cb8 Restored the old behavior for toolbars with lots of elements 597637e Tweaks and bug fixes 9df0f8b Added some upgrade notes about the new toolbar design 22f6bc5 Removed an useless CSS class and added styles for <hr> 5070861 Added a new profiler_markup_version to improve BC of the new toolbar 2fb3319 Removed an unused import 7ec1cd4 Reverted the feature to display different toolbar versions 084cca6 Minor JavaScript optimizations 972a92e Misc. tweaks and improvements ebb44e4 Added some styles to make old panels look better in the new design 1847285 Pass the toolbar version number from the controller, to ease transition and keep BC a0e03f6 Minor tweaks 002dda5 Fixed toolbar issues when displaying it inside the profiler e94a6a0 Smaller font sizes for smartphones, fixed request status padding issue and make too long panels always be displayed at the leftmost part of browser window 9b585b9 Made the close icon a bit smaller 3ab2e20 fixed all vertical aligning issues and tweaked icons f087ac0 More vertical aligning fixes 9e38a8a Minor CSS tweaks and made font sizes bigger 0dfcb60 Fixed an issue with the Config panel in the Profiler view cd53210 Fixed another z-index issue e28f895 A very high z-index value is required to avoid issues in the profiler view 23dc884 Fixed a potential issue in the request panel 7c35d25 Fixed another insignificant syntax issue e14fb6d Fixed a minor syntax issue 9d89841 Finished the toolbar redesign b25b6dd Finished "dump" panel and other minor tweaks 2bccdd4 Minor CSS fixes c0bee9b Tweaked the Twig panel 77d522a Tweaked the translation panel 041d424 Improved the Security toolbar panel af3dcb2 Minor Ajax tweaks acee052 Finished the Ajax panel redesign fac5391 Lots of minor improvements ef53850 More fixes and tweaks 51a79c9 Reorder toolbar panels 2735346 Fixed a minor markup error that broke the toolbar 64b8f38 A new batch of updates 4eee931 Restored all the code removed by mistake b6f413f First batch of fixes c2fcadc Redesigned the web debug toolbar	2015-07-31 18:40:00 +02:00
Diego Saint Esteben	75c98cba03	Added a way to define the priority of service decoration	2015-07-31 13:03:15 -03:00
Nicolas Grekas	51bacc6d41	[Debug] cleanup ExceptionHandlerTest	2015-07-31 17:18:52 +02:00
Javier Eguiluz	5a571b6eca	Reordered the toolbar elements via service priorities	2015-07-31 17:06:53 +02:00
Fabien Potencier	15d6b8aceb	bumped Symfony version to 2.7.4	2015-07-31 15:51:28 +02:00
Javier Eguiluz	f237ff1913	Increased the z-index of .sf-toolbar-info	2015-07-31 15:42:14 +02:00
Javier Eguiluz	b3ad83da01	Removed an unused media query	2015-07-31 15:37:44 +02:00
Fabien Potencier	a9af4708b4	updated VERSION for 2.7.3	2015-07-31 15:24:45 +02:00
Fabien Potencier	cdda482a3d	updated CHANGELOG for 2.7.3	2015-07-31 15:24:38 +02:00
Fabien Potencier	c7ca0b3629	Merge branch '2.3' into 2.7 ... * 2.3: Fix the return value on error for intl methods returning arrays	2015-07-31 15:24:29 +02:00
Javier Eguiluz	b438ee5482	Redesigned "abbr" elements	2015-07-31 15:19:54 +02:00
Florent Viel	2c9b1db05a	Fix doctrine mapping validation type error ... The error tell to implement the service `doctrine.orm.<em_name>.metadata_driver`, but this extensions check for the existence of the `doctrine.orm.<em_name>_metadata_driver` where `<em_name>` the entity manager name.	2015-07-31 15:18:55 +02:00
Javier Eguiluz	7d92cb8a02	Restored the old behavior for toolbars with lots of elements ... If a toolbar includes lots of elements, some of them may span to a new line, increasing the height of the toolbar	2015-07-31 15:08:06 +02:00
Javier Eguiluz	597637ecea	Tweaks and bug fixes	2015-07-31 13:11:01 +02:00
Javier Eguiluz	9df0f8b4b8	Added some upgrade notes about the new toolbar design	2015-07-31 12:12:25 +02:00
Fabien Potencier	8d025cbc91	fixed typo in translation keys	2015-07-31 08:49:15 +02:00
Christophe Coevoet	7994513e04	Remove skipping of tests based on ICU data version whenever possible ... Many tests being skipped based on the ICU data version don't actually need it. They might be testing code paths not relying on Intl, or not performing assertions on the values depending on the ICU data and so not dependant on the exact ICU version being used.	2015-07-30 18:05:29 +02:00
Fabien Potencier	0fd11d9631	bug #15413 Fix the return value on error for intl methods returning arrays (stof) ... This PR was merged into the 2.3 branch. Discussion ---------- Fix the return value on error for intl methods returning arrays | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When the resource is missing, an empty array should be returned rather than null to respect the interface saying an array is always returned. Commits ------- 801e5e2 Fix the return value on error for intl methods returning arrays	2015-07-30 17:28:54 +02:00
Christophe Coevoet	801e5e2805	Fix the return value on error for intl methods returning arrays ... When the resource is missing, an empty array should be returned rather than null to respect the interface saying an array is always returned.	2015-07-30 16:28:34 +02:00
Javier Eguiluz	22f6bc5003	Removed an useless CSS class and added styles for <hr>	2015-07-30 15:15:53 +02:00
Christophe Coevoet	d6db6ad7f7	Fix the handling of null as locale in the stub intl classes ... The Intl extension accepts null as locale in formatters and the collator and will use the default locale in such case. Given that the stub implementation considers that the default locale is always 'en', it should be supported here too instead of forcing libraries to pass the default locale explicitly.	2015-07-30 14:20:01 +02:00
Javier Eguiluz	5070861326	Added a new profiler_markup_version to improve BC of the new toolbar	2015-07-30 13:21:10 +02:00
Nicolas Grekas	bf8a923199	Merge branch '2.3' into 2.7 ... * 2.3: Fix merge Fix missing _route parameter notice in RouterListener logging case Conflicts: src/Symfony/Component/HttpKernel/EventListener/RouterListener.php	2015-07-30 09:39:20 +02:00
Nicolas Grekas	6b02601e7b	Fix merge	2015-07-30 09:37:09 +02:00
Javier Eguiluz	2fb33191fe	Removed an unused import	2015-07-30 09:30:53 +02:00
Javier Eguiluz	7ec1cd491d	Reverted the feature to display different toolbar versions	2015-07-30 09:29:46 +02:00
Javier Eguiluz	084cca644d	Minor JavaScript optimizations	2015-07-30 09:29:45 +02:00
Javier Eguiluz	972a92e778	Misc. tweaks and improvements	2015-07-30 09:29:45 +02:00
Javier Eguiluz	ebb44e4832	Added some styles to make old panels look better in the new design	2015-07-30 09:29:45 +02:00
Javier Eguiluz	1847285322	Pass the toolbar version number from the controller, to ease transition and keep BC	2015-07-30 09:29:45 +02:00
Javier Eguiluz	a0e03f6b2c	Minor tweaks	2015-07-30 09:29:45 +02:00
Javier Eguiluz	002dda5bd3	Fixed toolbar issues when displaying it inside the profiler	2015-07-30 09:29:45 +02:00
Javier Eguiluz	e94a6a02b1	Smaller font sizes for smartphones, fixed request status padding issue ... and make too long panels always be displayed at the leftmost part of browser window	2015-07-30 09:29:45 +02:00
Javier Eguiluz	9b585b9808	Made the close icon a bit smaller	2015-07-30 09:29:44 +02:00
Javier Eguiluz	3ab2e20913	fixed all vertical aligning issues and tweaked icons	2015-07-30 09:29:44 +02:00
Javier Eguiluz	f087ac0bcd	More vertical aligning fixes	2015-07-30 09:29:44 +02:00
Javier Eguiluz	9e38a8aa96	Minor CSS tweaks and made font sizes bigger	2015-07-30 09:29:44 +02:00
Javier Eguiluz	0dfcb602ef	Fixed an issue with the Config panel in the Profiler view	2015-07-30 09:29:44 +02:00
Javier Eguiluz	cd53210161	Fixed another z-index issue	2015-07-30 09:29:44 +02:00
Javier Eguiluz	e28f895a18	A very high z-index value is required to avoid issues in the profiler view	2015-07-30 09:29:43 +02:00
Javier Eguiluz	23dc884dcf	Fixed a potential issue in the request panel	2015-07-30 09:29:43 +02:00
Javier Eguiluz	7c35d25bae	Fixed another insignificant syntax issue	2015-07-30 09:29:43 +02:00
Javier Eguiluz	e14fb6d5c9	Fixed a minor syntax issue	2015-07-30 09:29:43 +02:00
Javier Eguiluz	9d89841e3a	Finished the toolbar redesign	2015-07-30 09:29:43 +02:00
Javier Eguiluz	b25b6dd608	Finished "dump" panel and other minor tweaks	2015-07-30 09:29:43 +02:00
Javier Eguiluz	2bccdd4a62	Minor CSS fixes	2015-07-30 09:29:43 +02:00
Javier Eguiluz	c0bee9b7e7	Tweaked the Twig panel	2015-07-30 09:29:42 +02:00