Brikou CARRE
e898445b94
removed empty lines/trailing spaces
2011-04-15 21:12:02 +02:00
hidenorigoto
1e78ec395c
[HttpFoundation] fixed wrong method name
2011-04-15 19:04:00 +09:00
Fabien Potencier
5316decd8c
Merge remote branch 'hhamon/shared_maxage_fix'
...
* hhamon/shared_maxage_fix:
[HttpFoundation] force Response to be "public" if setSharedMaxAge() is called.
2011-04-13 23:24:31 +02:00
Fabien Potencier
ea84bb025b
fixed session management in functional tests
2011-04-13 23:11:25 +02:00
Fabien Potencier
e2c9fdf2c7
[HttpFoundation] fixed expiration time for Cookie (PHP wants a Unix timestamp)
2011-04-13 20:12:14 +02:00
Fabien Potencier
66c4bc727c
[HttpFoundation] renamed Cookie::getExpire() to getExpiresTime() to be consistent with the DomCrawler component
2011-04-13 20:10:39 +02:00
Fabien Potencier
84dde4074a
[HttpFoundation] changed default value of Cookie httponly argument to match PHP defaults
2011-04-13 20:07:31 +02:00
hhamon
053d83f557
[HttpFoundation] force Response to be "public" if setSharedMaxAge() is called.
2011-04-13 15:58:48 +02:00
Fabien Potencier
227c87404f
Merge remote branch 'Funsational/master'
...
* Funsational/master:
Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
2011-04-13 14:27:16 +02:00
Johannes Schmitt
1ed73fb6e6
[HttpFoundation] allow to retrieve paths of arbitrary depths
2011-04-05 10:17:31 +02:00
michaelwilliams
46b711c4a8
Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
...
See http://www.php.net/manual/en/function.session-set-save-handler.php#103055 for more details
2011-04-01 18:14:27 -07:00
Fabien Potencier
702e6587ad
Merge remote branch 'pborreli/windows-fix-mimetype'
...
* pborreli/windows-fix-mimetype:
[HttpFoundation][Windows] Fixed filebinary guesser method.
2011-03-30 19:52:56 +02:00
Pascal Borreli
44a6f84855
[HttpFoundation][Windows] Fixed filebinary guesser method.
2011-03-30 17:38:42 +00:00
Fabien Potencier
f77b94074f
[HttpFoundation] replaced the option argument of Session by defaultLocale
2011-03-30 17:26:13 +02:00
Pascal Borreli
dbb18662d7
[HttpFoundation][Windows] Disabled FileBinaryMimeTypeGuesser for Windows OS
2011-03-29 14:32:20 +00:00
Fabien Potencier
a6e6cbbb27
[HttpFoundation] removed the hardcoded ^ and $ from the RequestMatcher
2011-03-23 21:27:04 +01:00
ornicar
7440db7244
[HttpFoundation] Make sure Request::getLanguages always returns an array
2011-03-19 01:34:54 -07:00
Kris Wallsmith
73db141ce6
[HttpFoundation] stripped tags from native error messages in case html_errors is on
2011-03-18 11:11:42 -07:00
Kris Wallsmith
ab3b8ac364
[HttpFoundation] cleaned up comments and coding standards, added better exception messages when filesystem functions throw errors, added "moved" arg to UploadedFile constructor, added FileNotFoundException to UploadedFile per the parent constructor
2011-03-17 16:07:53 -07:00
Fabien Potencier
d5396f64de
[HttpFoundation] fixed a small bug on Windows
2011-03-17 12:28:29 +01:00
Kris Wallsmith
a5d8770a54
[HttpFoundation] fixed ApacheRequest, added tests
2011-03-16 06:13:01 -07:00
Fabien Potencier
bc6ffeef83
[HttpFoundation] fixed flash management
2011-03-11 20:23:17 +01:00
Jordi Boggiano
991b1ed225
[HttpFoundation] UploadedFile::getOriginalName is now overriding getName
2011-03-09 17:26:08 +01:00
Jordi Boggiano
2a5fcdfb1a
[HttpFoundation] Minor optimization
2011-03-09 17:25:36 +01:00
Fabien Potencier
8c423edfef
replaced symfony-project.org by symfony.com
2011-03-06 12:40:06 +01:00
Fabien Potencier
a137d72351
Merge remote branch 'hhamon/cookie_path_fix'
...
* hhamon/cookie_path_fix:
[Security] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpKernel] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[BrowserKit] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-06 10:44:40 +01:00
Fabien Potencier
487cddcfee
Merge remote branch 'DuoSRX/code-coverage'
...
* DuoSRX/code-coverage:
[HttpFoundation] Fixed a typo in response->setLastModified()
[HttpFoundation] Added some more tests on response
[HttpFoundation] Added some tests on Response
[HttpFoundation] Replace a duplicated test with a method in Response
Fixed code coverage generation when resources folder are deeper
2011-03-06 10:44:13 +01:00
Fabien Potencier
51023eea86
[HttpFoundation] fixed CS
2011-03-06 10:39:33 +01:00
Fabien Potencier
c02ebbf2d8
Merge remote branch 'digitalkaoz/httpkernel-datacollector'
...
* digitalkaoz/httpkernel-datacollector:
[HttpKernel] added Tests for DataCollectors
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 10:38:55 +01:00
Xavier Perez
19090d3fb7
[HttpFoundation] Fixed a typo in response->setLastModified()
2011-03-06 00:17:54 +01:00
Robert Schönthal
87e1359ebd
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 00:13:47 +01:00
Xavier Perez
0d56ca5654
[HttpFoundation] Replace a duplicated test with a method in Response
2011-03-05 14:27:35 +01:00
Robert Schönthal
58db452e21
[HttpFoundation] added a check for array keys existence.
2011-03-05 13:30:54 +01:00
Hugo Hamon
ad56bd8e47
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-03 14:50:14 +01:00
Pascal Borreli
ff44b0ff28
[HttpFoundation] Removed remove recurring test
2011-03-01 18:58:07 +01:00
Fabien Potencier
cdf6851eb3
fixed merge
2011-02-27 21:16:13 +01:00
Christophe Coevoet
92bfbf575c
Fixed CS
2011-02-27 20:56:29 +01:00
Pascal Borreli
fc42cc5066
[HttpFoundation] Removed useless else
2011-02-27 18:36:38 +01:00
Pascal Borreli
f7ab114d36
[HttpFoundation] Fixed missing curly brackets
2011-02-27 18:36:37 +01:00
Pascal Borreli
f3b9364eae
[HttpFoundation] Fixed typo
2011-02-26 20:02:06 +01:00
Fabien Potencier
f54cedfe5e
added LICENSE files for the subtree repositories
2011-02-22 18:58:15 +01:00
Kris Wallsmith
a0bae94f88
[HttpFoundation] updated ResponseHeaderBag to compute Cache-Control whenever any of the headers it considers changes
2011-02-21 19:57:05 -08:00
Fabien Potencier
353177d1d6
replaced Response::createRedirect by a new RedirectResponse class
2011-02-21 18:10:53 +01:00
Fabien Potencier
d94acd85f9
remove response as a service
...
The Response is not available in the DIC anymore.
When you need to create a response, create an instance of
Symfony\Component\HttpFoundation\Response instead.
As a side effect, the Controller::createResponse() and Controller::redirect()
methods have been removed and can easily be replaced as follows:
return $this->createResponse('content', 200, array('foo' => 'bar'));
return new Response('content', 200, array('foo' => 'bar'));
return $this->redirect($url);
return Response::createRedirect($url);
2011-02-21 17:36:04 +01:00
Fabien Potencier
bf20238178
fixed a bug in Response content-type auto-detection
...
Without this patch, if you call __toString() on a Response,
the content-type auto-detection would never be trigerred
as __toString() changes the default content-type.
2011-02-21 16:57:25 +01:00
hhamon
f985da5a9c
[HttpFoundation] fix Cache-Control header when forcing the Response to have an Expires header field. The RFC2616 Bis indicates that if the Response has both max-age (or s-maxage) and Expires header field, the Cache-Control maxage wins over Expires. The previous code in ResponseHeaderBag always returned "private, max-age=0, must-revalidate" even if the Expires header field was forced.
...
This commit breaks functional tests in Symfony\Component\HttpKernel\HttpCache\HttpCacheTest.php. I tried to fix functional tests but I didn\'t manage to. For your information, the "try { } catch" block in the HttpKernel\HttpCache::lookup() method seems strange because I suspect line 274 to never leverage any exception...
2011-02-18 12:34:33 +01:00
Kris Wallsmith
c67a9a9643
[HttpFoundation] cleaned up some constructors
2011-02-15 21:51:44 +01:00
Jordi Boggiano
6311960511
[HttpFoundation] Minor clearCookie optimization
2011-02-14 11:15:22 +01:00
hhamon
c2e4ec44a8
[HttpFoundation] fixed phpdoc
2011-02-12 21:51:10 +01:00
Jeremy Mikola
a72145bf5f
[HttpFoundation] Add array type-hint to Session::setAttributes() param
2011-02-10 00:50:07 +01:00