This PR was merged into the 4.4 branch.
Discussion
----------
[Lock] Expand `LockConflictedException` docs
The goal of this is to reduce the chance of bad assumptions about lock acquisition behaviour. Fixes#40969
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40969
| License | MIT
| Doc PR | N/A
The goal of this tweak is to reduce the chance of bad assumptions about lock acquisition behaviour.
As per #40970 with suggested fixes, except now targeting the correct branch.
Commits
-------
2e4335fc70 Expand `LockConflictedException` docs
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Security] Add missing German translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41045
| License | MIT
| Doc PR | N/A
Commits
-------
31bba079c3 [Security] Add missing German translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Add missing Dutch translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41042
| License | MIT
Sorry screwed up my previous branch while rebasing and amending the author name of the commits.
Commits
-------
e30eb8f555 [Security] Add missing Dutch translations
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Security] Update Security Arabic Translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41028
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Related to #41028
Commits
-------
68c10337cc [Security] Update Security Arabic Translations
This PR was merged into the 4.4 branch.
Discussion
----------
Update Romanian Translation based on English
| Q | A
| ------------- | ---
| Branch ? | 4.4
| Bug fix ? | yes
| New feature ? | no
| Deprecations ? | no
| Tickets | Fix#41063
| License | MIT
| Doc PR | NiL
Commits
-------
d2b38fa54a Update Romanian Translation based on English
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Security] Add missing Vietnamese translations
| Q | A
| ------------- | ---
| Branch? | 4.4<!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
3703010b1b add missing vietnamese translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Add missing French translations for logging throttling
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40863 (at least for French)
| License | MIT
| Doc PR | N/A
Note: this PR replaces #40889 as somehow force-push closed the other PR.
Also this one targets 4.4 branch directly :)
Commits
-------
b64efd2848 [Security] Add missing French translations for logging throttling
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] Small phpdoc improvement
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
I have been looking for a way to emulate `$_REQUEST` in Symfony, and I always thought the `get` method is useless for that, because it only looks at some custom routing stuff, GET and whatever BODY might be. Only today I actually looked at the source code and found out that it's actually (almost) doing what I was looking for, i.e. check `$_GET`, and then `$_POST`. So I figured it would be good to be a bit more explicit in the phpdoc (analoguous to the phpdoc for `$request->request`, which says "Request body parameters ($_POST).").
Commits
-------
a53f256b4b Small phpdoc imporvement
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] [Security/Core] fix checking for bcrypt
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Spotted while working on #40920
Because of the logic in the constructor, if bcrypt is used, it's not cast to string.
Commits
-------
f01ea99254 [Security/Core] fix checking for bcrypt
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] DataPart: remove confusing fix-me comment
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I don't think this comment is correct? There is an exception thrown [below](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mime/Part/DataPart.php#L60).
Commits
-------
72493c6acf [Mime] DataPart: remove confusing fix-me comment
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[CI] Make sure to restore default locale
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | F
| License | MIT
| Doc PR |
Whenever we have a test that do `\Locale::setDefault()` we must make sure to restore it to the original value.
Commits
-------
a5afe47ccf [CI] Make sure to restore default locale
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] make fabbot happy
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
9826c05928 make fabbot happy
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] Allow tabs as separators between tokens
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40507
| License | MIT
| Doc PR | None
As described in #40507, the Yaml spec allows tabs as whitespace characters between tokens. However, the Yaml parser crashes on this as it only expects spaces after the colon. https://yaml.org/spec/1.2/spec.html#id2778241
While I'm not a huge fan of it personally, it's an issue when a different linter tells us that a given YAML file with content that we have little control over has valid syntax in an unrelated check, and then our app crashes because it cannot be parsed after all.
Commits
-------
9a130ae93e Fix issue 40507: Tabs as separators between tokens
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Cache] phpredis: Added full TLS support for RedisCluster
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | n/a
This Pr bridges the gap for full TLS support when using phpredis driver implementation of TLS.
Adds the 'ssl' options array for cache configuration when using RedisCluster
https://www.php.net/manual/en/context.ssl.php
Switches directed node commands from using individual \Redis connections to using the recommended implementation from the phpredis documentation:
https://github.com/phpredis/phpredis/blob/develop/cluster.markdown#directed-node-commands
This pr will enable compatibility with Amazon ElastiCache redis cluster mode using In Transit encryption (TLS) using the phpredis driver, Supports tagging & binary data types.
Commits
-------
a1e0408d08 [Cache] phpredis: Added full TLS support for RedisCluster
This PR was submitted for the 5.x branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[Console] added phpdocs to InputOption constants
| Q | A
| ------------- | ---
| Branch? | 5.x for features / 4.4 or 5.2 for bug fixes <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | n/a <!-- required for new features -->
This PR adds phpdocs to the `InputOption` constants. The docs itself were copied over from the docs on https://symfony.com/doc/current/console/input.html#using-command-options.
Over and over again people (including myself) confuse the different available constants.
having the meaning carried with the implementation should help to use the one which actually fits the use-case.
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
9f124f6278 [Console] : added phpdocs to InputOption constants
