Commits
-------
8d50c16 few optimisations for XliffFileLoader and XmlFileLoader
Discussion
----------
few optimisations for XliffFileLoader and XmlFileLoader
- file_put_contents + file_get_contents -> copy
- use stripos insteed preg_match
- removed useless `$tmpfiles` in XliffFileLoader
Commits
-------
3a7e038 [FrameworkBundle] sanitize target arg in asset:install command
Discussion
----------
[FrameworkBundle] sanitize target arg in asset:install command
`php app/console assets:install web/`
(removed tailing /)
before
`Installing assets for Symfony\Bundle\FrameworkBundle into web//bundles/framework`
after
`Installing assets for Symfony\Bundle\FrameworkBundle into web/bundles/framework`
Commits
-------
bbb68b7 Added RSS HTTP request format
Discussion
----------
Added RSS HTTP request format
Hi,
We have added RSS HTTP request format to `initializeFormats()` function in HttpFoundation Request class, to enable specifying `_format: rss` in routing files.
We couldn't find a reason for not having the rss format specified, and even the [cookbook refers](http://symfony.com/doc/2.0/book/routing.html#advanced-routing-example) to using of `_format: rss` .
Thanks,
Bait.sk
Commits
-------
df3bde4 [FrameworkBundle] Updated German validator translation
Discussion
----------
[FrameworkBundle] Updated German validator translation
Updated german translation to include trans-id 41, which was added in #2065.
Commits
-------
ca6299d [FrameworkBundle] Fixed a typo in the translation file per @PeymanHR
Discussion
----------
[FrameworkBundle] Fixed a typo in the translation file per @PeymanHR
Closes#2082
Commits
-------
d19f1d7 [Doctrine] Fix UniqueEntityValidator reporting a false positive by ignoring multiple query results
Discussion
----------
[Doctrine] Fix UniqueEntityValidator reporting a false positive by ignoring multiple query results
An entity should only be considered unique if its search criteria returns no matches or a single, identical entity. Multiple results indicates that conflicting entities exist.
Note: the DoctrineMongoDBBundle's unique validator checks identifier values if the object strict-equality check is false. This may be a worthwhile improvement, as it would prevent reporting a validation error for an enttiy which is going to overwrite its conflicting counter-part in the database.
---------------------------------------------------------------------------
by jmikola at 2011/09/01 14:23:27 -0700
This is the Doctrine bridge equivalent for my fix to DoctrineMongoDBBundle: https://github.com/symfony/DoctrineMongoDBBundle/pull/42
---------------------------------------------------------------------------
by fabpot at 2011/09/02 00:13:52 -0700
As this is a bug fix, can you base your PR on the symfony/2.0 branch? Thanks.
* EvanK-patch-1:
Per the [documentation][1], the `NotBlank` constraint should be using the `empty` language construct, otherwise it will not trigger on, for example, a boolean false from an unchecked checkbox field.
An entity should only be considered unique if its search criteria returns no matches or a single, identical entity. Multiple results indicates that conflicting entities exist.
Commits
-------
e991c59 [Console] Improved checks for InputArgument and InputOption constructor's $mode parameter.
Discussion
----------
Check that $mode is not below 1 to actually look if any of the flags are
Check that $mode is not below 1 to actually look if any of the flags are set.
I'm not sure if 0 must be allowed or not.
---------------------------------------------------------------------------
by fabpot at 2011/08/31 08:59:41 -0700
Can you squash your commit before I merge? Thanks.
---------------------------------------------------------------------------
by ktomk at 2011/08/31 15:25:05 -0700
Squashed and polished.
Commits
-------
6bd1749 Fixed a bug when multiple expanded choices would render unchecked because of the Form Framework's strict type checking.
Discussion
----------
[DoctrineBridge] Entities to array transformer
Fixed a bug when multiple expanded choices would render unchecked because of the Form Framework's strict type checking.
---------------------------------------------------------------------------
by fabpot at 2011/08/31 09:01:47 -0700
Looks good to me. Can you squash your commits before I merge? Thanks.
Commits
-------
0224a34 Fixes typo on ACL Doctrine cache.
Discussion
----------
[2.0] Impossible to use ACL provider cache
Using ACL provider cache is impossible. It's due to a typo in the configuration file (an undescore in place of a dot). My PR fixes this. Maybe add some tests to validate the ACL cache feature?
Check that $mode in InputArgument::__construct() is not below 1 to actually look if any of the flags are set.
Check that $mode in InputOption::__construct() is not below 1 to actually look if any of the flags are set.
Check for the correct parameter type, as in InputOption (integer).
InputArgumentTest: Added test for negative integer $mode parameter input in constructor.
InputOptionTest: Added test for negative integer $mode parameter input in constructor.
Commits
-------
f448029 [HttpKernel] Tweaked SQLite to speed up SqliteProfilerStorage
Discussion
----------
[HttpKernel] Tweaked SQLite to speed up SqliteProfilerStorage
See: http://stackoverflow.com/questions/6108602/avoiding-locked-sqlite-database-timeouts-with-php-pdo
This is the PR rebased for symfony/2.0 (the old PR was #1864)
---
Hi,
Here is a PR as discussed in issue #1856.
It solves a "fatal error" in the `SqliteProfilerStorage`.
I tested it all day long for real and it works fine.
Regards,
William
Commits
-------
eb8f3cb added uniqueEntity message translation (fr)
df9f223 added missing french translations
f4c133e removed trailing dot to make it consistent with other validator messages
Discussion
----------
[Translation] Unique Entity message
I've added the translation of uniqueEntity validation message, I've used ``trans-unit id="41"`` which seems to be unused
Commits
-------
2cfa22c Fix Method ContainerAwareEventDispatcher::hasListeners
Discussion
----------
Fix Method ContainerAwareEventDispatcher::hasListeners
Related to #1903.
This is the squashed on 2.0 branch version of the PR #1903
---
Fix Method ContainerAwareEventDispatcher::hasListeners
Fix the fact that Method ContainerAwareEventDispatcher::hasListeners return false if my service is not lazyLoaded
---------------------------------------------------------------------------
by cedriclombardot at 2011/08/31 01:40:45 -0700
@stof it's fixed
