Commit Graph

34266 Commits

Author SHA1 Message Date
Fabien Potencier
15ed486ea1 bug #24822 [DI] Fix "almost-circular" dependencies handling (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix "almost-circular" dependencies handling

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19362, #24775
| License       | MIT
| Doc PR        | -

In a situation like the following one, we used to trigger a circular reference exception. But this was a false positive, as the reference is resolvable without hitting the circle. Fixing this exception could be considered as a new feature (because no existing config needs it, since it fails). But for 3.4, this should be considered a bug fix, as reported in #24775: not handling this situation now means creating broken service trees.

``` php
$containerBuilder = new ContainerBuilder();

$container->register('foo', FooCircular::class)->setPublic(true)
   ->addArgument(new Reference('bar'));

$container->register('bar', BarCircular::class)
    ->addMethodCall('addFoobar', array(new Reference('foobar')));

$container->register('foobar', FoobarCircular::class)
    ->addArgument(new Reference('foo'));

$foo = $containerBuilder->get('foo');
```

Commits
-------

beb4df712c [DI] Fix "almost-circular" dependencies handling
2017-11-05 07:38:28 -08:00
Fabien Potencier
3671e08346 bug #24821 symfony/form auto-enables symfony/validator, even when not present (weaverryan)
This PR was merged into the 3.4 branch.

Discussion
----------

symfony/form auto-enables symfony/validator, even when not present

| Q             | A
| ------------- | ---
| Branch?       | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | not needed

In #24303, we allowed form to be used without the validator component. But, there is a small problem with the logic: the validation system is set to enabled, even if it is not present. If you install form but NOT validator, you see the error:

> Validation support cannot be enabled as the Validator component is not installed.

Assuming the form system really is usable without validation, this should be an easy merge.

Commits
-------

03c0254296 Only enabling validation if it is present
2017-11-05 07:35:58 -08:00
Fabien Potencier
dc25f9ab88 bug #24824 [FrameworkBundle][Config] fix: do not add resource checkers for no-debug (dmaicher)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle][Config] fix: do not add resource checkers for no-debug

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24808
| License       | MIT
| Doc PR        | -

As mentioned within #24808 replacing the `ConfigCachePass` here 537c496dfe...a442e378e1 (diff-687bdbb38a4dc672ca2a79f23e764892L127) with a tagged iterator argument resulted in resource checkers being added even if debug=false.

This resulted in a performance drop as on every request all the checkers have been checked.

This restores the previous behavior and does not add any checkers if debug=false.

Commits
-------

645f712190 [FrameworkBundle][Config] fix: do not add resource checkers for debug=false
2017-11-05 07:34:11 -08:00
Nicolas Grekas
9bc9474ff0 Merge branch '2.7' into 2.8
* 2.7:
  [Intl] Make intl-data tests pass and save language aliases again
  Remove useless docblocks
2017-11-05 16:25:56 +01:00
Maxime Steinhausser
d1b343c015 [Serializer] Fix extra attributes when no group specified 2017-11-05 16:20:19 +01:00
Nicolas Grekas
5a3db6781c bug #24814 [Intl] Make intl-data tests pass and save language aliases again (jakzal)
This PR was squashed before being merged into the 2.7 branch (closes #24814).

Discussion
----------

[Intl] Make intl-data tests pass and save language aliases again

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Due to changes in ICU 5.5 aliases were not being saved since that version.

Commits
-------

661a4b6 [Intl] Make intl-data tests pass and save language aliases again
2017-11-05 16:10:08 +01:00
Jakub Zalas
661a4b60d0 [Intl] Make intl-data tests pass and save language aliases again 2017-11-05 16:10:05 +01:00
Nicolas Grekas
49806e05fa minor #24724 Remove useless docblocks (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

Remove useless docblocks

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

2443511 Remove useless docblocks
2017-11-05 16:05:07 +01:00
Gabriel Ostrolucký
40780835c7
Drop support for PHPUnit 4
You can no longer mock Symfony > 4.0 components, because they now use nullable type hints. PHPUnit 4 requires 2.* for phpunit-mock-objects, which don't support that. For example, it's no longer possible to mock ContainerBuilder with PHPUnit 4. This will save time debugging this issue for bundles still using PHPUnit 4. I have discovered this problem when patching KnpPaginatorBundle for Syfmfony 4.0.
2017-11-05 15:55:41 +01:00
David Maicher
645f712190 [FrameworkBundle][Config] fix: do not add resource checkers for debug=false 2017-11-05 14:56:21 +01:00
Nicolas Grekas
beb4df712c [DI] Fix "almost-circular" dependencies handling 2017-11-05 13:06:25 +01:00
Robin Chalas
0c2d77cb33 minor #24823 [Console] Fix CommandTester::setInputs() docblock (ogizanagi)
This PR was merged into the 3.3 branch.

Discussion
----------

[Console] Fix CommandTester::setInputs() docblock

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

44f6e6d [Console] Fix CommandTester::setInputs() docblock
2017-11-05 12:35:01 +01:00
Maxime Steinhausser
44f6e6db2c [Console] Fix CommandTester::setInputs() docblock 2017-11-05 12:28:12 +01:00
Ryan Weaver
03c0254296 Only enabling validation if it is present 2017-11-04 17:11:56 -04:00
Maxime Steinhausser
daf1bc20c7 minor #24725 [PropertyInfo] Remove useless docblocks (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PropertyInfo] Remove useless docblocks

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

b58c31f2aa [PropertyInfo] Remove useless docblocks
2017-11-04 14:35:47 +01:00
Gabriel Ostrolucký
5810983e30 Fix displaying errors for bootstrap 4 2017-11-04 14:34:38 +01:00
Maxime Steinhausser
d483410086 minor #24726 [FrameworkBundle] Fix docblocks (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Fix docblocks

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

3ebf6ac45b [FrameworkBundle] Fix docblocks
2017-11-04 14:34:20 +01:00
Fabien Potencier
f422db8192 bug #24810 [Serializer] readd default argument value (xabbuh)
This PR was merged into the 3.3 branch.

Discussion
----------

[Serializer] readd default argument value

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/24649#discussion_r148789150
| License       | MIT
| Doc PR        |

Commits
-------

740abbe9ec [Serializer] readd default argument value
2017-11-03 07:22:13 -07:00
Fabien Potencier
e973c247c8 bug #24809 [Config] Fix dump of config references for deprecated nodes (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

[Config] Fix dump of config references for deprecated nodes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

```yaml
# before
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)

#after
trusted_proxies:      [] # Deprecated (The "framework.trusted_proxies" configuration key has been deprecated in Symfony 3.3. Use the Request::setTrustedProxies() method in your front controller instead.)
```

Commits
-------

188eb34a71 Fix reference dump for deprecated nodes
2017-11-03 07:14:19 -07:00
Christian Flothmann
740abbe9ec [Serializer] readd default argument value 2017-11-03 15:12:43 +01:00
Fabien Potencier
107881f08a bug #24796 [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass (lyrixx)
This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

25e0117152 [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass
2017-11-03 07:09:54 -07:00
Robin Chalas
188eb34a71 Fix reference dump for deprecated nodes 2017-11-03 11:37:20 +01:00
Grégoire Pineau
25e0117152 [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass 2017-11-03 11:03:57 +01:00
Fabien Potencier
2e3df94f3a bug #24774 [HttpKernel] Let the storage manage the session starts (sroze)
This PR was squashed before being merged into the 3.4 branch (closes #24774).

Discussion
----------

[HttpKernel] Let the storage manage the session starts

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24730
| License       | MIT
| Doc PR        | ø

HttpKernel's request collector should not really care if the session has started or not, be let the storage decide. Without the session, it is not possible to track the redirected pages.

I don't think the consideration of "we should not start the session if not needed by the user's code" applies here as if this is running, that is very likely that the user is running the dev environment anyway.

Commits
-------

95d0b7235f [HttpKernel] Let the storage manage the session starts
2017-11-01 20:21:13 -07:00
Samuel ROZE
95d0b7235f [HttpKernel] Let the storage manage the session starts 2017-11-01 20:21:07 -07:00
Nicolas Grekas
3bc7b3a54f bug #24735 [VarDumper] fix trailling comma when dumping an exception (Simperfit)
This PR was merged into the 3.3 branch.

Discussion
----------

[VarDumper] fix trailling comma when dumping an exception

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yesish
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24581
| License       | MIT
| Doc PR        |  O

This PR is fixing a behaviour when a exception got every single line with a comma.

Commits
-------

fc3fe7f [VarDumper] fix trailling comma when dumping an exception
2017-11-01 18:57:21 +01:00
Valentin
d56632a45f FormInterface::getPropertyPath(): PropertyPathInterface|null 2017-11-01 12:36:38 +03:00
Amrouche Hamza
fc3fe7f42e
[VarDumper] fix trailling comma when dumping an exception 2017-11-01 08:04:17 +01:00
Fabien Potencier
782dc947dc bug #24770 [Validator] Fix TraceableValidator is reset on data collector instantiation (ogizanagi)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fix TraceableValidator is reset on data collector instantiation

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Calling reset from the constructor is wrong in this case as it'll reset the `TraceableValidator`, which means you'll never get collected data on the first request as the collector is instantiated after (on kernel response).

Another option would be to tag the `debug.validator` service with `kernel.reset` and remove the reset call from the collector.

Commits
-------

f5855fb039 [Validator] Fix TraceableValidator is reset on data collector instantiation
2017-10-31 10:50:48 -07:00
Maxime Steinhausser
f5855fb039 [Validator] Fix TraceableValidator is reset on data collector instantiation 2017-10-31 17:02:06 +01:00
Fabien Potencier
a522e04255 Merge branch '3.4'
* 3.4:
  removed extra whitespace
  Removes \n or space when / are empty
  [HttpFoundation] add Early Hints in Reponse to fix test
  bumped Symfony version to 3.4.0
  updated VERSION for 3.4.0-BETA2
  updated CHANGELOG for 3.4.0-BETA2
  Throwing exception if redis and predis unavailable
2017-10-31 08:19:56 -07:00
Fabien Potencier
5c46e393c7 Merge branch '3.3' into 3.4
* 3.3:
  removed extra whitespace
  Removes \n or space when / are empty
  [HttpFoundation] add Early Hints in Reponse to fix test
  Throwing exception if redis and predis unavailable
2017-10-31 08:19:40 -07:00
Fabien Potencier
3b54b3dfbc Merge branch '2.8' into 3.3
* 2.8:
  [HttpFoundation] add Early Hints in Reponse to fix test
2017-10-31 08:19:30 -07:00
Fabien Potencier
f334fb5d83 Merge branch '2.7' into 2.8
* 2.7:
  [HttpFoundation] add Early Hints in Reponse to fix test
2017-10-31 08:19:21 -07:00
Fabien Potencier
b833be7921 minor #24766 [FrameworkBundle] Drop serializer.cache option (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[FrameworkBundle] Drop serializer.cache option

| Q             | A
| ------------- | ---
| Branch?       | 4.0
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

BC layer has been removed already but not the option, probably a bad merge.

Commits
-------

85f09a40f1 [FrameworkBundle] Drop serializer.cache option
2017-10-31 08:18:46 -07:00
Fabien Potencier
151e5e87af bug #24764 [HttpFoundation] add Early Hints to Reponse to fix test (Simperfit)
This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] add Early Hints to Reponse to fix test

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | not needed

This line seems to be needed in order to fix the tests, maybe it has been forgot in merge ?

Commits
-------

71ad77aed3 [HttpFoundation] add Early Hints in Reponse to fix test
2017-10-31 08:14:03 -07:00
Fabien Potencier
30f3b91cad removed extra whitespace 2017-10-31 08:12:41 -07:00
Fabien Potencier
cb6c394d7f bug #24759 Removes \n or space when $context/$extra are empty (kirkmadera)
This PR was squashed before being merged into the 3.3 branch (closes #24759).

Discussion
----------

Removes \n or space when $context/$extra are empty

Simple log messages cause extra spaces or newlines when using the default format and $context or $extra are empty, resulting in output like this:

```
23:24:41 DEBUG     [test] debug

23:24:41 INFO      [test] info

23:24:41 NOTICE    [test] notice

23:24:41 WARNING   [test] warning

23:24:41 ERROR     [test] error

```

This makes reviewing command history difficult.

In the instance where $context or $extra is empty, it should not get appended with a space or newline.

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT

Commits
-------

0d8edaec79 Removes \n or space when / are empty
2017-10-31 08:11:30 -07:00
Kirk Madera
0d8edaec79 Removes \n or space when / are empty 2017-10-31 08:11:27 -07:00
Amrouche Hamza
71ad77aed3
[HttpFoundation] add Early Hints in Reponse to fix test 2017-10-31 14:48:52 +01:00
Robin Chalas
85f09a40f1 [FrameworkBundle] Drop serializer.cache option 2017-10-31 10:23:34 +01:00
Fabien Potencier
a32b130f10 bumped Symfony version to 4.0.0 2017-10-30 16:00:15 -07:00
Fabien Potencier
6423afb1dc
Merge pull request #24762 from fabpot/release-4.0.0-BETA2
released v4.0.0-BETA2
2017-10-30 15:54:08 -07:00
Fabien Potencier
cfdf415b51 updated VERSION for 4.0.0-BETA2 2017-10-30 15:53:48 -07:00
Fabien Potencier
4f86b02e54 updated CHANGELOG for 4.0.0-BETA2 2017-10-30 15:53:39 -07:00
Fabien Potencier
996f6ef3cb bumped Symfony version to 3.4.0 2017-10-30 15:52:56 -07:00
Fabien Potencier
837878f169
Merge pull request #24761 from fabpot/release-3.4.0-BETA2
released v3.4.0-BETA2
2017-10-30 15:31:30 -07:00
Fabien Potencier
33e9a13cac updated VERSION for 3.4.0-BETA2 2017-10-30 15:31:12 -07:00
Fabien Potencier
8d72fd9159 updated CHANGELOG for 3.4.0-BETA2 2017-10-30 15:30:58 -07:00
Fabien Potencier
1595afe4aa Merge branch '3.4'
* 3.4:
  fixed tests
2017-10-30 14:30:05 -07:00