Commit Graph

34325 Commits

Author SHA1 Message Date
Nicolas Grekas
3c4d168ca9 [FrameworkBundle] Ignore failures when removing the old cache dir 2017-11-21 11:54:42 +01:00
Nicolas Grekas
1193c26ce9 Merge branch '3.4'
* 3.4:
  [HttpFoundation] Fix bad merge in NativeSessionStorage
  Bump phpunit-bridge requirement to 3.4|4.0
  [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)
  [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
  Add a "link" script to ease debugging Flex apps
  [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
2017-11-21 10:59:36 +01:00
Nicolas Grekas
2c2044b34f Merge branch '3.3' into 3.4
* 3.3:
  [HttpFoundation] Fix bad merge in NativeSessionStorage
  Bump phpunit-bridge requirement to 3.4|4.0
  [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)
  [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
  Add a "link" script to ease debugging Flex apps
  [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
2017-11-21 10:59:09 +01:00
Nicolas Grekas
1a1079d7c4 Merge branch '2.8' into 3.3
* 2.8:
  [HttpFoundation] Fix bad merge in NativeSessionStorage
  Bump phpunit-bridge requirement to 3.4|4.0
  [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)
  [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
  Add a "link" script to ease debugging Flex apps
  [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
2017-11-21 10:58:54 +01:00
Nicolas Grekas
8603bf1081 Merge branch '2.7' into 2.8
* 2.7:
  Bump phpunit-bridge requirement to 3.4|4.0
  [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
  Add a "link" script to ease debugging Flex apps
  [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
2017-11-21 10:57:39 +01:00
Nicolas Grekas
efd9a5ae08 minor #25041 [Form] Rename FormConfigBuilder::$nativeRequestProcessor private variable to ::$nativeRequestHandler (issei-m)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`

| Q             | A
| ------------- | ---
| Branch?       |2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | Not confirmed, but the changes are completely minor
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I guess the term "processor" had been used until [this PR comes](https://github.com/symfony/symfony/pull/7732), but hadn't been renamed properly at the time.
And I think "handler" sounds more relevant to me anyway.

Commits
-------

a35d4f8 [Form] Rename `FormConfigBuilder::$nativeRequestProcessor` private variable to `::$nativeRequestHandler`
2017-11-21 10:54:12 +01:00
Nicolas Grekas
57a9e5ed72 minor #25058 Bump phpunit-bridge requirement to 3.4|4.0 (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

Bump phpunit-bridge requirement to 3.4|4.0

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The bridge 4.0 is already used because of the way simple-phpunit works.
This just make it more explicit and will be required when #25056 will be merged.

Commits
-------

1c1a540 Bump phpunit-bridge requirement to 3.4|4.0
2017-11-21 10:47:16 +01:00
Nicolas Grekas
58d12e88b4 [HttpFoundation] Fix bad merge in NativeSessionStorage 2017-11-21 10:41:52 +01:00
Nicolas Grekas
1c1a540d2f Bump phpunit-bridge requirement to 3.4|4.0 2017-11-21 10:30:35 +01:00
Nicolas Grekas
01ff6eb46b Merge branch '3.4'
* 3.4:
  [Debug] Fix undefined variable $lightTrace
  [Bridge/PhpUnit] fix installation path
2017-11-21 10:27:49 +01:00
Nicolas Grekas
7be944a787 bug #25072 [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false) (joky)
This PR was merged into the 2.8 branch.

Discussion
----------

[Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25050
| License       | MIT
| Doc PR        | -

Commits
-------

5ddb121 [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false)
2017-11-21 10:22:33 +01:00
Guillaume Aveline
5ddb121723 [Bridge/PhpUnit] Remove trailing "\n" from ClockMock::microtime(false) 2017-11-21 10:19:30 +01:00
Nicolas Grekas
79a64d3bd5 bug #25069 [Debug] Fix undefined variable $lightTrace (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Fix undefined variable $lightTrace

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As reported in #25066

Commits
-------

21b2343 [Debug] Fix undefined variable $lightTrace
2017-11-21 10:08:30 +01:00
Nicolas Grekas
21b23431ba [Debug] Fix undefined variable $lightTrace 2017-11-21 10:01:46 +01:00
Nicolas Grekas
30325e0783 minor #25068 [Bridge/PhpUnit] fix installation path (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Bridge/PhpUnit] fix installation path

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25067
| License       | MIT
| Doc PR        | -

Fixes yesterdays's work on the bridge, tricky one...

Commits
-------

bd4fe8d [Bridge/PhpUnit] fix installation path
2017-11-21 09:58:25 +01:00
Nicolas Grekas
bd4fe8d86f [Bridge/PhpUnit] fix installation path 2017-11-21 09:49:35 +01:00
Issei.M
a35d4f88b3 [Form] Rename FormConfigBuilder::$nativeRequestProcessor private variable to ::$nativeRequestHandler 2017-11-21 10:08:49 +09:00
Nicolas Grekas
e04b4f4a1b Merge branch '3.4'
* 3.4:
  [Bridge/PhpUnit] move .phpunit/ out of phpunit-bridge/
2017-11-20 23:32:13 +01:00
Nicolas Grekas
b40c84dcf8 [Bridge/PhpUnit] move .phpunit/ out of phpunit-bridge/ 2017-11-20 23:31:51 +01:00
Nicolas Grekas
20716d96ca Merge branch '3.4'
* 3.4:
  [Security] remove remaining FQCN service ids
2017-11-20 22:37:30 +01:00
Nicolas Grekas
92f77f287c fix merge 2017-11-20 22:31:52 +01:00
Nicolas Grekas
abe3c96253 minor #24746 Add a link script to ease debugging Flex apps (dunglas)
This PR was merged into the 2.7 branch.

Discussion
----------

Add a link script to ease debugging Flex apps

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24708
| License       | MIT
| Doc PR        | n/a

(Reopened because of mishandling in the previous PR)

It's painful to debug and patch Flex apps because `symfony/symfony` isn't installed by default (only components are) but PRs must be opened against the monolithic repository.

This tiny tool, inspired by `npm link`, scan the `vendor/` directory of the project, and replace `symfony/` dependencies by symlinks to the local clone of the `symfony/symfony` repositories.

Usage:

```
git clone git@github.com:symfony/symfony.git
cd symfony
./link /path/to/the/project
```

Commits
-------

381f5d1 Add a "link" script to ease debugging Flex apps
2017-11-20 22:26:00 +01:00
Robin Chalas
f89253607b fix merge 2017-11-20 22:21:09 +01:00
Kévin Dunglas
381f5d1bc5
Add a "link" script to ease debugging Flex apps 2017-11-20 22:18:44 +01:00
Nicolas Grekas
21eb340324 [Security] remove remaining FQCN service ids 2017-11-20 22:16:05 +01:00
Nicolas Grekas
5b6c1b3132 Merge branch '3.4'
* 3.4:
  [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone
  [DI] Analyze setter-circular deps more precisely
  fixing that PropertyNormalizer supports parent properties
  [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener
  [TwigBundle][FrameworkBundle] Remove the internals from debug autowiring
  [DI] Skip hot_path tag for deprecated services as their class might also be
  [Cache] Memcached options should ignore "lazy"
  [FrameworkBundle] Dont create empty bundles directory
2017-11-20 22:12:12 +01:00
Nicolas Grekas
961981577d bug #25053 [Serializer] Fixing PropertyNormalizer supports parent properties (Christopher Hertel)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fixing PropertyNormalizer supports parent properties

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

With 5ecafc5e25 support for parent properties was added to 3.4, but supports method was not updated for child classes without properties.

Commits
-------

a879e4f fixing that PropertyNormalizer supports parent properties
2017-11-20 21:50:55 +01:00
Nicolas Grekas
e222d85aa9 bug #25055 [DI] Analyze setter-circular deps more precisely (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Analyze setter-circular deps more precisely

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24950
| License       | MIT
| Doc PR        | -

This PR reverts the effect of #24828 and #24822 on fixtures, except for the new behavior these PRs introduced, which was mostly fine, but missed a few cases.
This PR now uses the reference graph to precisely decide which services need circular dependency care, and does not touch the other ones.

Commits
-------

9cc4a21 [DI] Analyze setter-circular deps more precisely
2017-11-20 21:49:21 +01:00
Nicolas Grekas
17fba0c208 feature #25056 [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Right now, the bridge is installed at least twice: in vendor/ of the tested package, and in phpunit's clone.
By forcing the vendor one to be used for the phpunit clone also, we sync the version of the code, so that things become more manageable and easier to debug.

Applies also to our own CI.

Commits
-------

038c671 [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone
2017-11-20 21:47:24 +01:00
Nicolas Grekas
038c671c33 [Bridge/PhpUnit] Sync the bridge version installed in vendor/ and in phpunit clone 2017-11-20 20:24:15 +01:00
Nicolas Grekas
a135690130 bug #25048 Allow EnumNode name to be null (MatTheCat)
This PR was squashed before being merged into the 4.0-dev branch (closes #25048).

Discussion
----------

Allow EnumNode name to be null

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25046
| License       | MIT

Commits
-------

57d0636 Allow EnumNode name to be null
2017-11-20 19:23:00 +01:00
Mathieu Lechat
57d0636299 Allow EnumNode name to be null 2017-11-20 19:22:57 +01:00
Nicolas Grekas
9ccefdef0d minor #25011 [TwigBundle][FrameworkBundle] Remove the internals from debug autowiring (Simperfit)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBundle][FrameworkBundle] Remove the internals from debug autowiring

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24986
| License       | MIT
| Doc PR        |

#SymfonyConHackday2017
@nicolas-grekas @weaverryan @fabpot @stof It should be OK to review and to merge.

Commits
-------

491839b [TwigBundle][FrameworkBundle] Remove the internals from debug autowiring
2017-11-20 19:14:44 +01:00
Nicolas Grekas
e3efa2fec7 bug #25045 [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] Don't trigger auto-picking notice if provider is set per listener

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24980
| License       | MIT
| Doc PR        | n/a

Commits
-------

19e891a [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener
2017-11-20 19:04:24 +01:00
Nicolas Grekas
f1b7921390 minor #25040 [Form] Add phpdoc to RequestHandlerInterface::isFileUpload() method (issei-m)
This PR was squashed before being merged into the 2.7 branch (closes #25040).

Discussion
----------

[Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | Not confirmed, but the changes are completely minor
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

faf5470 [Form] Add phpdoc to `RequestHandlerInterface::isFileUpload()` method
2017-11-20 18:59:32 +01:00
Issei.M
faf5470fd5 [Form] Add phpdoc to RequestHandlerInterface::isFileUpload() method 2017-11-20 18:59:30 +01:00
Nicolas Grekas
9cc4a213c9 [DI] Analyze setter-circular deps more precisely 2017-11-20 18:46:17 +01:00
Christopher Hertel
a879e4f34b fixing that PropertyNormalizer supports parent properties 2017-11-20 17:26:54 +01:00
Robin Chalas
7bb7b0d89f minor #25047 fix outdated provider handling comment (xabbuh)
This PR was merged into the 4.0-dev branch.

Discussion
----------

fix outdated provider handling comment

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

cd39213 fix outdated provider handling comment
2017-11-20 12:43:19 +01:00
Robin Chalas
19e891a9e5 [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener 2017-11-20 12:33:01 +01:00
Christian Flothmann
cd39213dfc fix outdated provider handling comment 2017-11-20 12:02:43 +01:00
Amrouche Hamza
491839b7c2
[TwigBundle][FrameworkBundle] Remove the internals from debug autowiring 2017-11-20 10:25:08 +01:00
Christian Flothmann
dd26c80aa9 substitute aliases in inline mappings 2017-11-20 10:04:28 +01:00
Fabien Potencier
1b6597d19c bug #25033 [FrameworkBundle] Dont create empty bundles directory by default (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Dont create empty bundles directory by default

| Q             | A
| ------------- | ---
| Branch?       | 3.4 / 4.1?
| Bug fix?      | yes?
| New feature?  | no
| BC breaks?    | no?
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

we still run `assets:install` by default, which in bundle-less apps gives this annoying empty public/bundles dir and some useless cli output, all the time. This fixes it.

Commits
-------

f8e7478583 [FrameworkBundle] Dont create empty bundles directory
2017-11-20 08:23:16 +01:00
Michał Strzelecki
675a3fe7f6 added ability for substitute aliases when mapping in YAML is on single line 2017-11-20 08:20:36 +01:00
Fabien Potencier
57b26b6b92 bug #25037 [DI] Skip hot_path tag for deprecated services as their class might also be (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Skip hot_path tag for deprecated services as their class might also be

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24959
| License       | MIT
| Doc PR        | -

Commits
-------

1775bba68f [DI] Skip hot_path tag for deprecated services as their class might also be
2017-11-20 08:19:24 +01:00
Nicolas Grekas
1775bba68f [DI] Skip hot_path tag for deprecated services as their class might also be 2017-11-19 23:04:27 +01:00
Nicolas Grekas
219d71054f bug #25038 [Cache] Memcached options should ignore "lazy" (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Memcached options should ignore "lazy"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25036
| License       | MIT
| Doc PR        | -

Commits
-------

de5f41d [Cache] Memcached options should ignore "lazy"
2017-11-19 22:24:23 +01:00
Nicolas Grekas
e970c6ca79 Merge branch '3.4'
* 3.4:
  [WebServerBundle] fix test
2017-11-19 22:23:04 +01:00
Nicolas Grekas
8d7b9593fe [WebServerBundle] fix test 2017-11-19 22:22:53 +01:00