This PR was merged into the 5.3-dev branch.
Discussion
----------
Fix CS in changelogs
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
the last one :)
Commits
-------
fb22eece5e Fix CS in changelogs
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Messenger] Added more descriptive exception message when handling of a message failed
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no (more of a patch thing)
| New feature? | no
| Deprecations? | no
| License | MIT
I use Symfony Messenger extensively and I run into the `HandlerFailedException` from time to time. What bothers me is that the exception doesn't carry the name of the message that failed right there in the exception message.
Here is an example from Sentry:
As you can see I get the error message, but I have to look through all my messages (in different bundles etc) to find the sinner.
This PR adds the message name directly to the exception message.
Commits
-------
d985ca9a6e [Messenger] Added more descriptive exception message when handling of a message failed
This PR was merged into the 5.2 branch.
Discussion
----------
Fix CS in Changelogs in 5.2
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
25a8a0a81b Fix CS in Changelogs in 5.2
This PR was merged into the 5.1 branch.
Discussion
----------
[Notifier] Streamline README files
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | --
| License | MIT
| Doc PR | --
This should be considered a bug fix as it does not touches any PHP file.
I will continue the work for `5.2` branch after the merge
Commits
-------
dfddc899ce [Notifier] Streamline README files
This PR was merged into the 4.4 branch.
Discussion
----------
Fix licence
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Backport of #39435 for 4.4 (the file has been renamed and the git history trapped me)
Commits
-------
6d7893cdaa Fix licence
This PR was merged into the 4.4 branch.
Discussion
----------
Fix CS in link binary
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I missed this file. Sorry :(
Commits
-------
7f6c90ceec Fix CS in link binary
This PR was merged into the 5.1 branch.
Discussion
----------
Fix CS in Changelogs in 5.1
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
4557e4d55d Fix CS in Changelogs
This PR was squashed before being merged into the 5.1 branch.
Discussion
----------
[Notifier] [Free Mobile] Rename method to match other bridges
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
All other bridges use `create*` instead of `init*`
Commits
-------
f53ae7c40a [Notifier] [Free Mobile] Rename method to match other bridges
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] fix setting "read_timeout" when using Redis
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Being inspired by #39431
Commits
-------
7acca31e66 [Cache] fix setting "read_timeout" when using Redis
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Cache] Bugfix provide the correct host and port when throwing the exception
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
The message before was including the result of the `getMasterAddrByName` call of which ended with:
```
Failed to retrieve master information from master name "mymaster" and address ":0".
```
Commits
-------
276bbb5e85 [Cache] Bugfix provide the correct host and port when throwing the exception
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Cache] Make use of `read_timeout` in `\RedisSentinel` and `\Redis`
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39429
| License | MIT
This is a bugfix for #39363 a feature introduced in 5.x
As described in issue #39429, `\RedisSentinel` accepts an optional read timeout value during construction.
`read_timeout` is already part of the connection options, this PR just make use of it.
Commits
-------
14e36a22d6 [Cache] Make use of `read_timeout` in `\RedisSentinel` and `\Redis`
This PR was merged into the 4.4 branch.
Discussion
----------
Fix CS in changelogs - 4.4
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I'm note sure it worth applying this patch on lower versions...
Commits
-------
a46cff26c6 Fix CS in changelogs
Both classes have an optional argument `$readTimeout` that can be set during
initialization for `\RedisSentinel` and during `connect`/`pconnect`
respectively.
* 5.1:
[Notifier] [Twilio] Fix tests
[Cache] Prevent notice on case matching metadata trick
[Notifier][Slack] Remove :void from test methods
[Notifier] Remove @internal annotation from notifier transports
[Notifier][Twilio] Add tests
[Notifier][Free Mobile] Tests
[DI] The default index method wasn't used if the "index_by" attribute is missing
This PR was merged into the 5.2 branch.
Discussion
----------
[Serializer][Validator] Mention annotation loaders handle PHP8 attributes
| Q | A
| ------------- | ---
| Branch? | 5.2 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
Just a small note for the ones reading docblocks first and expecting to find a PhpAttributeLoader or whatever: the annotation loaders handle both doctrine annotations & PHP 8 attributes.
The route loader already mentions this.
Commits
-------
3cbe758df3 [Serializer][Validator] Mention annotation loaders handle PHP8 attributes
This PR was merged into the 5.2 branch.
Discussion
----------
[HttpClient] Fix content swallowed by AsyncClient initializer
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I'm not sure if it should be fixed in RetryableHttpClient or AsycClient.
The issue is: when the Strategy needs the body to take a decision BUT decide to NOT retry the request, the content is "lost"
In fact, when the first chunk is yield, the AsyncResponse's initializer is stopped, and nothing consume the remaining chunks. Moreover, because the `passthru` were disabled before yielding the first chunk in RetryableHttpClient, the callback is never called again to yield the remaining content.
Commits
-------
d324271691 Fix content swallowed by AsyncClient initializer
This PR was squashed before being merged into the 5.1 branch.
Discussion
----------
[Notifier] [Twilio] Fix tests
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | ---
| License | MIT
| Doc PR | ---
PR based on https://github.com/symfony/symfony/pull/39404#issuecomment-742449997 from @derrabus
Lowest build was failing, so I bumped `symfony/notifier` to `5.1`, should be all 💚 now! 🙏
Commits
-------
f7f5f869cf [Notifier] [Twilio] Fix tests
This PR was submitted for the 5.1 branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Cache] Prevent notice on case matching metadata trick
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
On saving an array of one element with a int key of strlen 10
it matches the first conditions of the trick used to save metadata.
> Notice: Trying to access array offset on value of type int
Casting it to string fixes it.
Commits
-------
a91ac74906 [Cache] Prevent notice on case matching metadata trick
On saving an array of one element with a int key of strlen 10
it matches the first conditions of the trick used to save metadata.
> Notice: Trying to access array offset on value of type int
Casting it to string fixes it.
