Commit Graph

30867 Commits

Author SHA1 Message Date
Alexander M. Turek
ef461b6f8e minor #39455 [Notifier] Rework/streamline bridges (5.1) (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] Rework/streamline bridges (5.1)

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

This PR

* add missing tests
* pull up scheme check (check scheme first and then for required options)

Commits
-------

856e191687 [Notifier] Rework/streamline bridges (5.1)
2020-12-14 23:20:55 +01:00
Oskar Stark
856e191687 [Notifier] Rework/streamline bridges (5.1) 2020-12-14 23:20:24 +01:00
Jérémy Derussé
2fb9fa3dac
Merge branch '4.4' into 5.1
* 4.4:
  [Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used
  Stop using deprecated trait
  [PhpUnitBridge] Lint files with PHP 5.5
2020-12-14 21:31:08 +01:00
Oskar Stark
a40d1375f9
[Mailer] [Amazon] Ensure "ext-simplexml" is loaded if SesApiTransport is used 2020-12-14 21:27:17 +01:00
Nicolas Grekas
bae2782cdb Merge branch '4.4' into 5.1
* 4.4:
  Fix EncoderInterface::encode() return type
  [Lock] Prevent store exception break combined store
2020-12-14 11:55:48 +01:00
Nicolas Grekas
c052542e65 minor #39451 [Serializer] Fix EncoderInterface::encode() return type (jeroennoten)
This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] Fix EncoderInterface::encode() return type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N.A.
| License       | MIT
| Doc PR        | N.A.

I might have missed something (in that case, please let me know), but I believe that `EncoderInterface::encode()` will and should always return a `string`. This makes more sense because `DecoderInterface::decode()` only accepts a string as input.

Commits
-------

ae6f054cc1 Fix EncoderInterface::encode() return type
2020-12-14 11:44:27 +01:00
Jeroen Noten
ae6f054cc1 Fix EncoderInterface::encode() return type 2020-12-14 11:44:14 +01:00
Nicolas Grekas
43ab20e4f2 bug #39476 [Lock] Prevent store exception break combined store (dzubchik)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Lock] Prevent store exception break combined store

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #39470 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Handle exception to preserve expected behavior - one or multiple stores could be unreachable in a moment and combined store will handle this according to strategy.

Commits
-------

0daff35bae [Lock] Prevent store exception break combined store
2020-12-14 11:21:44 +01:00
Dmytro Dzubenko
0daff35bae [Lock] Prevent store exception break combined store 2020-12-14 11:21:37 +01:00
Pierre du Plessis
14c3614ac4 Remove check for unsupported PHP version 2020-12-14 12:10:03 +02:00
Oskar Stark
45b3a3062c [Notifier] Rename test method names
To stay consistent
2020-12-14 10:19:36 +01:00
Fabien Potencier
9d73e7caf0 Merge branch '4.4' into 5.1
* 4.4:
  Fix tests
2020-12-14 08:03:02 +01:00
Jérémy Derussé
d651fb539c
Fix tests 2020-12-13 23:21:11 +01:00
Jérémy Derussé
fe40ddb013
Fix applyVersion tests 2020-12-13 19:27:25 +01:00
Fabien Potencier
7c7366a82a bug #39456 [Notifier] [Free Mobile] Fix wrong scheme in mapping (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] [Free Mobile] Fix wrong scheme in mapping

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

The scheme is `freemobile`, not `free-mobile`

For reference:
134af39538/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransportFactory.php (L41-L43)

Commits
-------

6eae1951ee [Notifier][Free Mobile] Fix wrong scheme in mapping
2020-12-12 09:30:23 +01:00
Alexander M. Turek
7d846d3e82 Merge branch '4.4' into 5.1
* 4.4:
  Use more explicit variable name
  Fix wrong comment about SES region
  [Mailer] [Sendgrid] Use $scheme variable to stay consistent
  [Mailer] [Amazon] Fix @param annotation
  [Mailer] Rename testsuites
  Remove void return type from test methods
2020-12-12 00:11:02 +01:00
Nicolas Grekas
8f6c52a19a minor #39467 Fix wrong comment about SES region (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

Fix wrong comment about SES region

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This list is wrong (or maybe no more exact). And maintain such list does not make sens in code.

https://docs.aws.amazon.com/general/latest/gr/ses.html

Commits
-------

759774750e Fix wrong comment about SES region
2020-12-11 16:21:07 +01:00
Nicolas Grekas
8d6794f6b6 minor #39459 Remove void return type from test methods (OskarStark)
This PR was merged into the 4.4 branch.

Discussion
----------

Remove void return type from test methods

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

cc @nicolas-grekas

Commits
-------

94f823fd4a Remove void return type from test methods
2020-12-11 16:19:13 +01:00
Nicolas Grekas
38b2968549 minor #39460 Remove void return type from test methods (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

Remove void return type from test methods

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

This PR follows #39459

cc @nicolas-grekas

Commits
-------

6e6c3ba1a0 Remove void return type from test methods
2020-12-11 16:16:17 +01:00
Jérémy Derussé
759774750e
Fix wrong comment about SES region 2020-12-11 15:43:01 +01:00
Maxime Steinhausser
278688deeb minor #39465 [Mailer] [Sendgrid] Use $scheme variable to stay consistent (OskarStark)
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] [Sendgrid] Use $scheme variable to stay consistent

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Its used like this in all other mailer bridges

Commits
-------

1a40d7c75a [Mailer] [Sendgrid] Use $scheme variable to stay consistent
2020-12-11 15:13:33 +01:00
Maxime Steinhausser
7f49e15f40 minor #39464 [Mailer] [Amazon] Fix @param annotation (OskarStark)
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] [Amazon] Fix @param annotation

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

514881c708 [Mailer] [Amazon] Fix @param annotation
2020-12-11 15:11:17 +01:00
Oskar Stark
6eae1951ee [Notifier][Free Mobile] Fix wrong scheme in mapping 2020-12-11 14:41:25 +01:00
Oskar Stark
1a40d7c75a [Mailer] [Sendgrid] Use $scheme variable to stay consistent 2020-12-11 14:18:32 +01:00
Oskar Stark
514881c708 [Mailer] [Amazon] Fix @param annotation 2020-12-11 14:09:19 +01:00
Oskar Stark
9ebfa6034a [Mailer] Rename testsuites
to stay consistent with other bridges
2020-12-11 13:58:29 +01:00
Oskar Stark
6e6c3ba1a0 Remove void return type from test methods 2020-12-11 13:47:35 +01:00
Oskar Stark
94f823fd4a Remove void return type from test methods 2020-12-11 13:39:31 +01:00
Oskar Stark
616df0c6a3 [Notifier] Remove void return type from test methods 2020-12-11 11:27:22 +01:00
javer
594ce465ce [PropertyInfo][Serializer] Fixed extracting ignored properties 2020-12-10 23:52:33 +01:00
Alexander M. Turek
59d32c1e72 minor #39383 [Notifier] Streamline README files (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] Streamline README files

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | --
| License       | MIT
| Doc PR        | --

This should be considered a bug fix as it does not touches any PHP file.

I will continue the work for `5.2` branch after the merge

Commits
-------

dfddc899ce [Notifier] Streamline README files
2020-12-10 19:54:36 +01:00
Robin Chalas
4ad158e519 minor #39437 Fix licence (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

Fix licence

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Backport of #39435 for 4.4 (the file has been renamed and the git history trapped me)

Commits
-------

6d7893cdaa Fix licence
2020-12-10 19:19:49 +01:00
Jérémy Derussé
6d7893cdaa
Fix licence 2020-12-10 19:10:51 +01:00
Nicolas Grekas
eb1a490261 minor #39435 Fix CS in Changelogs in 5.1 (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

Fix CS in Changelogs in 5.1

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

4557e4d55d Fix CS in Changelogs
2020-12-10 18:59:56 +01:00
Nicolas Grekas
4e7d0c16cd Merge branch '4.4' into 5.1
* 4.4:
  [Cache] remove no-op
2020-12-10 18:56:50 +01:00
Nicolas Grekas
0bc3deeebd [Cache] remove no-op 2020-12-10 18:56:42 +01:00
Jérémy Derussé
4557e4d55d
Fix CS in Changelogs 2020-12-10 18:56:13 +01:00
Oskar Stark
46d5fb1f30 [Notifier][Sinch] Add tests 2020-12-10 18:52:05 +01:00
Nicolas Grekas
185ba9cc9a minor #39404 [Notifier] [Nexmo] Add tests (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] [Nexmo] Add tests

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Commits
-------

8e566ef84d [Notifier] [Nexmo] Add tests
2020-12-10 18:50:52 +01:00
Oskar Stark
8e566ef84d [Notifier] [Nexmo] Add tests 2020-12-10 18:50:45 +01:00
Oskar Stark
0c3fe30513 [Notifier][OvhCloud] Add tests 2020-12-10 18:49:11 +01:00
Nicolas Grekas
ec23ebeec9 minor #39426 [Notifier] [Free Mobile] Rename method to match other bridges (OskarStark)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Notifier] [Free Mobile] Rename method to match other bridges

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

All other bridges use `create*` instead of `init*`

Commits
-------

f53ae7c40a [Notifier] [Free Mobile] Rename method to match other bridges
2020-12-10 18:45:24 +01:00
Oskar Stark
f53ae7c40a [Notifier] [Free Mobile] Rename method to match other bridges 2020-12-10 18:45:17 +01:00
Nicolas Grekas
bec247dbc7 Merge branch '4.4' into 5.1
* 4.4:
  [Cache] fix setting "read_timeout" when using Redis
  Fix CS in changelogs
2020-12-10 18:44:54 +01:00
Nicolas Grekas
9186d149df bug #39433 [Cache] fix setting "read_timeout" when using Redis (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] fix setting "read_timeout" when using Redis

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Being inspired by #39431

Commits
-------

7acca31e66 [Cache] fix setting "read_timeout" when using Redis
2020-12-10 18:39:37 +01:00
Nicolas Grekas
7acca31e66 [Cache] fix setting "read_timeout" when using Redis 2020-12-10 17:45:19 +01:00
Jérémy Derussé
a46cff26c6
Fix CS in changelogs 2020-12-10 17:34:26 +01:00
Alexander M. Turek
651bd12d75 Merge branch '4.4' into 5.1
* 4.4:
  [Cache] Prevent notice on case matching metadata trick
  [DI] The default index method wasn't used if the "index_by" attribute is missing
2020-12-10 14:41:20 +01:00
Oskar Stark
f7f5f869cf [Notifier] [Twilio] Fix tests 2020-12-10 13:14:12 +01:00
Oskar Stark
dfddc899ce [Notifier] Streamline README files 2020-12-10 08:54:19 +01:00