* 2.3:
updated VERSION for 2.2.11
update CONTRIBUTORS for 2.2.11
updated CHANGELOG for 2.2.11
Fixed typo in phpdoc
Handled the scenario when no entity manager is passed with closure query builder.
[HttpKernel] made a small optimization to Bundle initialization
minor optimalization at bundle initialization
[EventDispatcher] tweaked README
removed observer pattern, in favour of mediator
[DoctrineBridge] normalized class names in the ORM type guesser
Fix `extract` method to avoid recalculating count() for each iteration.
[Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
use the correct class name to retrieve mapped class' metadata and repository
[WebProfilerBundle] Fixed js escaping in time.html.twig
Conflicts:
src/Symfony/Component/Debug/ErrorHandler.php
* 2.2:
updated VERSION for 2.2.11
update CONTRIBUTORS for 2.2.11
updated CHANGELOG for 2.2.11
[HttpKernel] made a small optimization to Bundle initialization
minor optimalization at bundle initialization
[EventDispatcher] tweaked README
removed observer pattern, in favour of mediator
[DoctrineBridge] normalized class names in the ORM type guesser
Fix `extract` method to avoid recalculating count() for each iteration.
use the correct class name to retrieve mapped class' metadata and repository
[WebProfilerBundle] Fixed js escaping in time.html.twig
Conflicts:
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/time.html.twig
src/Symfony/Component/HttpKernel/Kernel.php
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#9683).
Discussion
----------
[MonologBridge] updated Composer suggested packages
Commits
-------
1faf588 [MonologBridge] updated Composer suggested packages
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#9675).
Discussion
----------
Fixed typo in phpdoc
Commits
-------
350d5ea Fixed typo in phpdoc
This PR was merged into the 2.4 branch.
Discussion
----------
Fixed BC break in csrf protection
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9429
| License | MIT
| Doc PR | n/a
Commits
-------
d00954a Default form.csrf_protection.enabled to csrf_protection.enabled
This PR was merged into the 2.3 branch.
Discussion
----------
[Bridge/Doctrine] ORMQueryBuilderLoader - handled the scenario when no entity manager is passed with closure query builder
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
a534b55 Handled the scenario when no entity manager is passed with closure query builder.
This PR was merged into the 2.2 branch.
Discussion
----------
[HttpKernel] minor optimalization at bundle initialization
fast check to avoid six array method calls
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [|no]
| Tests pass? | [yes]
| Fixed tickets | #9657
| License | MIT
| Doc PR |
That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN
Commits
-------
3330c40 [HttpKernel] made a small optimization to Bundle initialization
4ba6c0b minor optimalization at bundle initialization
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#9662).
Discussion
----------
[FrameworkBundle] Enabled csrf_protection by default if form.csrf_protection is enabled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9429
| License | MIT
| Doc PR | -
This PR enables the CSRF protection services automatically if CSRF protection for forms is enabled. In this case, the CSRF protection services cannot be disabled anymore manually (the same as with the validation services).
Commits
-------
b5e5c71 [FrameworkBundle] Enabled csrf_protection by default if form.csrf_protection is enabled
This PR was merged into the 2.2 branch.
Discussion
----------
Removed observer pattern, in favour of mediator
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | *
| Fixed tickets | #9344
I don't think this is the best tool to implement the observer pattern.
I just have copied the sentence from:
https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst
but maybe could be improved with something like:
"Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern"
[edit-1]
I think this could be modified also here:
https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig
Commits
-------
ab3e231 [EventDispatcher] tweaked README
b9ad62e removed observer pattern, in favour of mediator
This PR was merged into the 2.2 branch.
Discussion
----------
[DoctrineBridge] normalized class names in the ORM type guesser
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5837
| License | MIT
| Doc PR | n/a
Commits
-------
a1b9c2e [DoctrineBridge] normalized class names in the ORM type guesser
This PR was merged into the 2.2 branch.
Discussion
----------
use the correct class name to retrieve mapped class' metadata and reposi...
...tory
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9646
| License | MIT
| Doc PR |
The validation context isn't necessarily the entity being validated. In case that you added the Unique Entity constraint inside your custom type via the ``constraints`` option the validation context will be the ``Form`` class itself. Thus, not the validation context should be used to get the class metadata and the repository of the validated entity, but the entity itself should be used.
Commits
-------
cd4df11 use the correct class name to retrieve mapped class' metadata and repository
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9651).
Discussion
----------
Fix `extract` method to avoid recalculating count() for each iteration.
This PR was submitted on the symfony/DomCrawler read-only repository and moved automatically to the main Symfony repository (closessymfony/DomCrawler#16).
Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
Since this count will never change during the method execution, this change make the code a bit more efficient.
Commits
-------
9ababf4 Fix `extract` method to avoid recalculating count() for each iteration.
Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
Since this count will never change during the method execution, this change make the code a bit more efficient.
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
This is a follow-up for #9641 where I try to restore the previous code behavior as much as possible.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
d7a4cfb [Debug] ensured that a fatal PHP error is actually fatal after being handled by our error handler
This PR was merged into the 2.2 branch.
Discussion
----------
[WebProfilerBundle] Fixed js escaping in time.html.twig
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
For some event names I received the JavaScript error: ```Uncaught SyntaxError: Unexpected token ILLEGAL```
Commits
-------
4828350 [WebProfilerBundle] Fixed js escaping in time.html.twig
* 2.4:
[Debug] fixed unit tests
Avoid notice from being *eaten* by fatal error.
Teardown used wrong property
Modified guessDefaultEscapingStrategy to not escape txt templates
Fix DateType for 32bits computers.
Fixed the registration of validation.xml file when the form is disabled
fixed lexing expression ending with spaces
Fixes#9633, Removed dependency to Symfony\Bundle\FrameworkBundle\Tests\TestCase
[Validator] Replaced inexistent interface.
[HttpKernel] Fix profiler event-listener usage outside request stack context
When getting the session's id, check if the session is not closed
Fix undefined offset when formatting namespace suggestions
Adjusting CacheClear Warmup method to namespaced kernels
* 2.3:
[Debug] fixed unit tests
Avoid notice from being *eaten* by fatal error.
Teardown used wrong property
Modified guessDefaultEscapingStrategy to not escape txt templates
Fix DateType for 32bits computers.
Fixed the registration of validation.xml file when the form is disabled
Fixes#9633, Removed dependency to Symfony\Bundle\FrameworkBundle\Tests\TestCase
[Validator] Replaced inexistent interface.
When getting the session's id, check if the session is not closed
Adjusting CacheClear Warmup method to namespaced kernels
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
* 2.2:
Teardown used wrong property
Modified guessDefaultEscapingStrategy to not escape txt templates
Fix DateType for 32bits computers.
Fixed the registration of validation.xml file when the form is disabled
When getting the session's id, check if the session is not closed
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] Avoid notice from being "eaten" by fatal error.
Workaround for https://bugs.php.net/bug.php?id=54275. Follow-up to PR #9428 and #9449.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8703
| License | MIT
| Doc PR | n/a
Commits
-------
872d584 [Debug] fixed unit tests
2d6c2aa Avoid notice from being *eaten* by fatal error.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9640).
Discussion
----------
Fixed wrong property in test teardown
This PR was submitted on the symfony/EventDispatcher read-only repository and moved automatically to the main Symfony repository (closessymfony/EventDispatcher#2).
Commits
-------
5330603 Teardown used wrong property
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#9639).
Discussion
----------
Modified guessDefaultEscapingStrategy to not escape txt templates
This PR was submitted on the symfony/TwigBundle read-only repository and moved automatically to the main Symfony repository (closessymfony/TwigBundle#2).
Useful for plaintext emails.
Commits
-------
6affe94 Modified guessDefaultEscapingStrategy to not escape txt templates
This PR was squashed before being merged into the 2.2 branch (closes#9314).
Discussion
----------
[Form] Fix DateType for 32bits computers.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5227,#5554
| License | MIT
| Doc PR | -
Fix an issue due to 32bits machines, date can be only between 1902-2037.
Simply not add date if false. Can be good to add this to 2.3 and master too.
Commits
-------
b80fb43 [Form] Fix DateType for 32bits computers.
This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes#9443).
Discussion
----------
[FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
cfa5aa5 [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
This PR was merged into the 2.2 branch.
Discussion
----------
[HttpFoundation] Do not return an empty session id if the session was closed
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7936
| License | MIT
| Doc PR | ~
A regression from the bug fix#9246 was introduced due to an incomplete fix ;
As the `started` flag on the NativeSessionStorage was not `true` anymore when saving the session, the session id was always empty when saving it, and thus when sending the `PHPSESSID` cookie.
The previous PR I made (#9530) was another approach to solve this regression, but this one should keep the fix made by @tecbot on #9246, and finish it with another verification. I may miss another place where `started` is used, but I don't really see which other conditions depending on this property should be altered...
**Note : this is #9611 rebased on 2.2**
This should be mergeable.
Commits
-------
5b9a727 When getting the session's id, check if the session is not closed
This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes#9621).
Discussion
----------
[ExpressionLanguage] fixed lexing expression ending with spaces
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9606, #9615
| License | MIT
| Doc PR |
Alternative fix for #9615
Commits
-------
d8f61c4 [ExpressionLanguage] fixed lexing expression ending with spaces
