Commit Graph

10630 Commits

Author SHA1 Message Date
Fabien Potencier 7680101c5e merged branch stof/unique_validator_error_mapping (PR #4868)
Commits
-------

ac78755 [DoctrineBridge] Added an option to choose the subpath for the violation

Discussion
----------

[DoctrineBridge] Added an option to choose the subpath for the violation

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3866
Todo: -

By default, the UniqueEntityValidator maps the violation on the first
field of the UniqueEntity constraint. The new option allows to control
this behavior if a better mapping is suited.
2012-07-12 07:05:33 +02:00
Christian Raue 20ae6931fa added missing dot 2012-07-12 03:11:01 +03:00
Christophe Coevoet ac7875569a [DoctrineBridge] Added an option to choose the subpath for the violation
By default, the UniqueEntityValidator maps the violation on the first
field of the UniqueEntity constraint. The new option allows to control
this behavior if a better mapping is suited.
2012-07-12 00:19:02 +02:00
Brikou CARRE f748885476 fixed swiftmailer requirement in composer file 2012-07-12 00:10:01 +02:00
Fabien Potencier 485c3d975e bumped Symfony version to 2.0.17-DEV 2012-07-11 20:25:42 +02:00
Fabien Potencier d4b40fb24b merged branch asm89/fix-security-default-authentication-handlers-config (PR #4864)
Commits
-------

f59b052 [Security] Fix the default authentication handlers config definition

Discussion
----------

[Security] Fix the default authentication handlers config definition

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/asm89/symfony.png?branch=fix-security-default-authentication-handlers-config)](http://travis-ci.org/asm89/symfony)
License of the code: MIT

Options should be a collection, when you use the default handler definition as a parent you will get an error that the argument of the constructor is a string and not an array, because for your own service the extension of the security bundle will not replace the arguments.
2012-07-11 20:22:30 +02:00
Fabien Potencier e49dfaf08b Merge branch '2.0'
* 2.0:
  updated VERSION for 2.0.16
  update CONTRIBUTORS for 2.0.16
  updated CHANGELOG for 2.0.16
  [Console] fixed wrong phpdoc (closes #4394)
2012-07-11 20:21:28 +02:00
Alexander f59b0528f6 [Security] Fix the default authentication handlers config definition 2012-07-11 20:12:59 +02:00
Fabien Potencier 11ae9c9740 updated VERSION for 2.0.16 2012-07-11 19:51:30 +02:00
Fabien Potencier 6e14d67cb2 update CONTRIBUTORS for 2.0.16 2012-07-11 19:50:55 +02:00
Fabien Potencier 0341492ed5 updated CHANGELOG for 2.0.16 2012-07-11 19:48:12 +02:00
Bernhard Schussek a92f80b815 [Validator] Added Length constraint and deprecated MinLength and MaxLength 2012-07-11 19:48:02 +02:00
Bernhard Schussek 83a3f75b2d [Validator] Deprecated the constraints Min and Max in favor of Range 2012-07-11 19:48:02 +02:00
Bernhard Schussek 0cdacee5be [Validator] Removed MinCount and MaxCount and replaced them by the constraint Count 2012-07-11 19:47:53 +02:00
Fabien Potencier d04949f05e merged branch bschussek/issue3428 (PR #4862)
Commits
-------

1fe3996 [Validator] Improved error messages displayed when the Valid constraint is misused

Discussion
----------

[Validator] Improved error messages displayed when the Valid constraint is misused

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #3428
Todo: -
2012-07-11 19:02:28 +02:00
Bernhard Schussek 741c147ce5 [Validator] Renamed deprecated Size constraint to Range 2012-07-11 18:38:44 +02:00
Bernhard Schussek 1fe39962fd [Validator] Improved error messages displayed when the Valid constraint is misused 2012-07-11 18:23:09 +02:00
Fabien Potencier 83c058fbf1 merged branch bschussek/issue4852 (PR #4860)
Commits
-------

c919b81 [Form] Fixed TransformationFailedExceptions to be caught in the model transformers
f06203a [Form] Improved ValidatorTypeGuesser to interpret the constraints True and False

Discussion
----------

[Form] Fixed TransformationFailedExceptions thrown by model transformers to be caught by the form

Bug fix: yes
Feature addition: (yes)
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4852
Todo: -
2012-07-11 16:53:31 +02:00
Bernhard Schussek c919b81ca9 [Form] Fixed TransformationFailedExceptions to be caught in the model transformers 2012-07-11 16:50:44 +02:00
Bernhard Schussek f06203a640 [Form] Improved ValidatorTypeGuesser to interpret the constraints True and False 2012-07-11 16:46:06 +02:00
Fabien Potencier c3b79f1f15 merged branch bschussek/size_deprecation (PR #4851)
Commits
-------

0be602d [Validator] Deprecated the Size constraint
d661837 [Validator] Reverted the changes done to the Size constraint in 3a5e84f4a7
d84b689 [Validator] Added the constraints MinCount and MaxCount
1a732e4 [Validator] Removed the Range constraint as it duplicates functionality given in Min and Max

Discussion
----------

[Validator] Deprecated the Size constraint in favor of MinCount and MaxCount

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This PR cleans up with the current ambiguity between

* Min
* Max
* MinLength
* MaxLength
* Range
* Size

in the following ways:

* The Range constraint was removed again as it can be completely replaced by Min and Max.
* The Size constraint was reverted to it's 2.0 feature set and deprecated.
* The constraints MinCount and MaxCount were added to make up for the functionality that was added to Size.
2012-07-11 15:50:35 +02:00
Bernhard Schussek 0be602deef [Validator] Deprecated the Size constraint 2012-07-11 15:48:36 +02:00
Fabien Potencier d92a90f13e merged branch asm89/validator-docblock (PR #4856)
Commits
-------

d0e7543 [Validator] Fix docblocks

Discussion
----------

[Validator] Fix docblocks
2012-07-11 15:02:57 +02:00
Alexander d0e7543613 [Validator] Fix docblocks 2012-07-11 15:00:23 +02:00
Fabien Potencier a7e2c5f7df [Process] remade ProcessBuilder::setTimeout fluent 2012-07-11 14:45:17 +02:00
Fabien Potencier b72ca7c6c6 merged branch bschussek/issue4242 (PR #4848)
Commits
-------

b7aae48 [Locale] Fixed error resetting in StubIntlDateFormatter::parse()

Discussion
----------

[Locale] Fixed error resetting in StubIntlDateFormatter::parse()

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4242
Todo: -

---------------------------------------------------------------------------

by bschussek at 2012-07-11T08:00:15Z

ping @eriksencosta, @igorw - is this solved as intended?

---------------------------------------------------------------------------

by eriksencosta at 2012-07-11T11:20:24Z

Yes, thanks!
2012-07-11 14:22:56 +02:00
Fabien Potencier f83401abd9 [Process] fixed setting the timeout to null 2012-07-11 14:21:05 +02:00
Bernhard Schussek d661837ec0 [Validator] Reverted the changes done to the Size constraint in 3a5e84f4a7 2012-07-11 11:43:13 +02:00
Bernhard Schussek d84b689529 [Validator] Added the constraints MinCount and MaxCount 2012-07-11 11:43:13 +02:00
Bernhard Schussek 1a732e4983 [Validator] Removed the Range constraint as it duplicates functionality given in Min and Max 2012-07-11 11:43:13 +02:00
Fabien Potencier 09d71ca927 merged branch bschussek/issue4615 (PR #4850)
Commits
-------

92abf5a [Form] Enabled error bubbling from the parts of a date/time field to the main field

Discussion
----------

[Form] Enabled error bubbling from the parts of a date/time field to the main field

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #4615
Todo: -
2012-07-11 10:37:29 +02:00
Bernhard Schussek 92abf5aace [Form] Enabled error bubbling from the parts of a date/time field to the main field 2012-07-11 10:34:15 +02:00
Bernhard Schussek b7aae48a74 [Locale] Fixed error resetting in StubIntlDateFormatter::parse() 2012-07-11 09:56:07 +02:00
Fabien Potencier f3547d4ff1 merged branch bschussek/testfix (PR #4847)
Commits
-------

7a76dba [Form] Renamed the options "data_timezone" and "user_timezone"
655d645 [Form] Fixed tests failing on systems with timezones other than +01:00

Discussion
----------

[Form] Fixed tests and renamed the options "data_timezone" and "user_timezone"

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

The option names were renamed for better consistency with the terms "model data" or "model format" and "view data" or "view format".
2012-07-11 09:47:34 +02:00
Bernhard Schussek 7a76dbad20 [Form] Renamed the options "data_timezone" and "user_timezone" 2012-07-11 09:44:09 +02:00
Fabien Potencier 50109ebcc2 [Process] re-added the possibility to set the Process timeout to null (to disable it) (closes #4843) 2012-07-11 09:39:53 +02:00
Fabien Potencier 5da1bc6a4f added missing listener priority changes in the UPGRADE file (refs #2680) 2012-07-11 09:36:00 +02:00
Bernhard Schussek 655d645568 [Form] Fixed tests failing on systems with timezones other than +01:00 2012-07-11 09:34:01 +02:00
Fabien Potencier 75dfc8fe97 merged branch bschussek/issue3162 (PR #4839)
Commits
-------

ded6c03 [Form] DateTimeType now handles RFC 3339 dates as provided by HTML5
7e8b622 [Form] Added the option "format" to DateTimeType
9eeb200 [Form] Changed the default format of DateType to "yyyy-MM-dd" to support HTML 5 out of the box
d621a76 [Form] Improved DateTimeType code

Discussion
----------

[Form] Changed DateType and DateTimeType to support HTML5 by default

Bug fix: no
Feature addition: yes
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: #2849, #3162
Todo: -

This PR changes DateType and DateTimeType to support HTML5 by default when setting the option "widget" to "single_text".

Also, the option "format" was added to DateTimeType.

---------------------------------------------------------------------------

by stof at 2012-07-10T15:38:44Z

This loos OK to me

---------------------------------------------------------------------------

by MDrollette at 2012-07-10T16:36:26Z

@stof typo: "looks" #meta-stoffed
2012-07-11 09:09:08 +02:00
Bernhard Schussek ded6c0305c [Form] DateTimeType now handles RFC 3339 dates as provided by HTML5 2012-07-11 09:06:31 +02:00
Fabien Potencier a94d41d97b merged branch jonathaningram/override_kernel_name (PR #4846)
Commits
-------

02e0a8f Allow Kernel::$name to be overridden by subclasses

Discussion
----------

Allow Kernel::$name to be overridden by subclasses

Because the name of the kernel is calculated in the constructor,
any child class that had overriden the kernel name, will be
ignored.

By setting the kernel name in the child class, we can avoid having
to execute the regex to calculate the name upon every construction
of a Kernel.

A test (and a kernel fixture) is added to prove that the override
works correctly.

Note: the Kernel API has not been touched, so there should be no
issues with BC.

What do you think?
2012-07-11 08:25:20 +02:00
Fabien Potencier bfda8a3c29 merged branch aharonp/master (PR #4842)
Commits
-------

6def8d1 Refactored Filesystem::makePathRelative function to correctly handle more use-cases

Discussion
----------

Refactored the makePathRelative function

The function was failing in a number of different use cases because the function was incorrectly using a character offset comparison to determine where the common path stops.

I've fixed this by splitting up the paths into their individual directories and then comparing the directory names.

If the paths match then the function will return `./` and not an empty string. This is for consistency sake, to ensure all returned paths end with `/`.
2012-07-11 08:24:17 +02:00
Jonathan Ingram 02e0a8f232 Allow Kernel::$name to be overridden by subclasses
Because the name of the kernel is calculated in the constructor,
any child class that had overriden the kernel name, will be
ignored.

By setting the kernel name in the child class, we can avoid having
to execute the regex to calculate the name upon every construction
of a Kernel.

A test (and a kernel fixture) is added to prove that the override
works correctly.

Note: the Kernel API has not been touched, so there should be no
issues with BC.
2012-07-11 16:13:02 +10:00
Aharon Perkel 6def8d1dd1 Refactored Filesystem::makePathRelative function to correctly handle more use-cases 2012-07-11 01:22:37 +03:00
Fabien Potencier 064ad6255c [HttpFoundation] allow _method to be set in the query string (closes #4202) 2012-07-10 22:17:24 +02:00
Fabien Potencier 9a2c61780b [ClassLoader] fixed order of interfaces in generated class collection caches (closes #4841) 2012-07-10 20:28:16 +02:00
Bernhard Schussek 7e8b622802 [Form] Added the option "format" to DateTimeType 2012-07-10 17:23:19 +02:00
Fabien Potencier e83c1a590a [HttpKernel] tweaked a phpdoc 2012-07-10 16:40:07 +02:00
Fabien Potencier 97b2256b69 merged branch rdohms/enumNode-bug (PR #4838)
Commits
-------

1b08cd1 `values()` function did not return the object, this breaking the fluent interface.

Discussion
----------

[Config][EnumNode] Fluent Interface is broken

`values()` function did not return the object, this breaking the fluent interface.

Added a `return $this` so that usage of this node works as expected:

    ->enumNode('foo')->values(array('a', 'b'))->end()

---------------------------------------------------------------------------

by fabpot at 2012-07-10T14:21:25Z

Can you reopen a PR for the 2.0 branch instead? Thanks.

---------------------------------------------------------------------------

by rdohms at 2012-07-10T14:25:05Z

@fabpot yeah.

---------------------------------------------------------------------------

by rdohms at 2012-07-10T14:27:42Z

@fabpot Actually, sorry, this node is not in 2.0 it was introduced in 2.1 last month.
2012-07-10 16:28:28 +02:00
Rafael Dohms 1b08cd1058 `values()` function did not return the object, this breaking the fluent interface.
Added a `return $this` so that usage of this node works as expected:
    ->enumNode('foo')->values(array('a', 'b'))->end()
2012-07-10 16:14:17 +02:00