This PR was merged into the 2.5 branch.
Discussion
----------
[Console] Remove dialog helper usage
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Because the dialog helper is deprecated, we should use question helper instead.
Commits
-------
844aa54 Remove dialog usage
This PR was merged into the 2.3 branch.
Discussion
----------
[ClassLoader] define constant only if it wasn't defined before
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
388229b define constant only if it wasn't defined before
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#12644).
Discussion
----------
Fix incorrect spanish translation
SymfonyCon Madrid 2014 Hackday
Commits
-------
28b07ba Fix incorrect spanish translation
This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] removed unneeded check
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
It is already checked in the `isEnabled()` method of the parent
`ServerCommand` class if the current PHP build is HHVM and the
`server:start` command is never enabled then. Thus, it's not needed
to check for HHVM on every command execution.
This was pointed out by @stof in #12489 for the `server:run` command.
Commits
-------
ce2adfa removed unneeded check
* 2.5:
[Debug] fix error message on double exception
Fix initialized() with aliased services
Rename Symfony2 to Symfony
compare version using PHP_VERSION_ID
backport #12489
remove an unneeded check
This PR was merged into the 2.5 branch.
Discussion
----------
compare version using PHP_VERSION_ID
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This continues the work started in #12497 on the `2.3` branch.
Commits
-------
d2f846b compare version using PHP_VERSION_ID
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#12553).
Discussion
----------
[Debug] fix error message on double exception
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
1ed7606 [Debug] fix error message on double exception
This PR was merged into the 2.5 branch.
Discussion
----------
remove an unneeded check
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? |no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
It is already checked in the `isEnabled()` method if the current PHP
build is HHVM and the `server:run` command is never enabled then.
Thus, it's not needed to check for HHVM on every command execution.
Commits
-------
2035fea remove an unneeded check
This PR was merged into the 2.3 branch.
Discussion
----------
Rename Symfony2 to Symfony
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Replaces #12563
Commits
-------
0a76b7e Rename Symfony2 to Symfony
This PR was merged into the 2.6 branch.
Discussion
----------
[Translation] [2.6] Upgrade information for LoggingTranslator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
When upgrading a Symfony 2.5 project to the 2.6 branch, I noticed that the `@translator` service was changed. In the affected project, we've had a service that depends on the `@translator` service and uses a type hint to ensure that a `Translator` instance is passed to the constructor. With the introduction of the `LoggingTranslator` class (PR #10887), this type hint now fails.
I have added a small note to ` UPGRADE-2.6.md` in case more people stumble across this changed behavior.
Commits
-------
cd55a81 Upgrade information for the Translation component regarding the new LoggingTranslator class.
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12437).
Discussion
----------
[2.6] [Validator] make DateTime objects represented as strings in the violation message
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
Commits
-------
b753218 [Validator] make DateTime objects represented as strings in the violation message.
This PR was merged into the 2.6 branch.
Discussion
----------
[Security][Http] fix data type in docblock
| Q | A
| ------------- | ---
| Fixed tickets | #12564
| License | MIT
Commits
-------
1c6f5a1 fix data type in docblock
This PR was squashed before being merged into the 2.6 branch (closes#12584).
Discussion
----------
[RFC] [DebugBundle] [HttpKernel] Avoid using container as dependency for DumpListener
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Usage of the `container` service as dependency avoid using the listener outside of a Symfony project.
I don't know if the lazy loading of the dumper service is really required. We should only use the `DebugBundle` in `dev` environment.
If it break performance, maybe we can consider using the `lazy="true"` parameter in services definition.
I currently working on a Silex [`DebugServiceProvider`](https://github.com/jeromemacias/Silex-Debug) which use the `DebugBundle` to avoid duplicating the dump profiler view (like it's done by the `WebProfilerServiceProvider`).
Those modifications are required by the provider to be usable.
Commits
-------
680fe7a [RFC] [DebugBundle] [HttpKernel] Avoid using container as dependency for DumpListener
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Remove usage of app.request in search bar template
This PR removes the last usage of the global Twig variable `app.request` in Symfony.
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
d3451fc [WebProfilerBundle] Remove usage of app.request in search bar template
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12570).
Discussion
----------
Fix initialized() with aliased services
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12569
| License | MIT
| Doc PR |
Commits
-------
a18b6d1 Fix initialized() with aliased services
It is already checked in the `isEnabled()` method of the parent
`ServerCommand` class if the current PHP build is HHVM and the
`server:start` command is never enabled then. Thus, it's not needed
to check for HHVM on every command execution.
This was pointed out by @stof in #12489 for the `server:run` command.
It is already checked in the `isEnabled()` method if the current PHP
build is HHVM and the `server:run` command is never enabled then.
Thus, it's not needed to check for HHVM on every command execution.
