Commit Graph

39159 Commits

Author SHA1 Message Date
Christian Flothmann
f72c6a5ad4 a colon followed by spaces exclusively separates mapping keys and values 2021-01-11 15:27:16 +01:00
Fabien Potencier
6c8d5808a6 Use ::class keyword when possible 2021-01-11 09:57:50 +01:00
Fabien Potencier
c79e61f1f2 minor #39775 [WIP] Use ::class keyword when possible (fabpot)
This PR was merged into the 4.4 branch.

Discussion
----------

[WIP] Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

036a36cb14 Use ::class keyword when possible
2021-01-11 07:02:33 +01:00
Fabien Potencier
036a36cb14 Use ::class keyword when possible 2021-01-10 17:45:22 +01:00
Fabien Potencier
cfab37fecf minor #39773 Improve composer.json descriptions (fabpot)
This PR was merged into the 4.4 branch.

Discussion
----------

Improve composer.json descriptions

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Refs #39768 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

611a2dfaf3 Improve composer.json descriptions
2021-01-10 17:26:45 +01:00
Fabien Potencier
611a2dfaf3 Improve composer.json descriptions 2021-01-10 17:25:35 +01:00
Fabien Potencier
220cedf58c minor #39762 [Form] Update AbstractType.php (DonCallisto)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Update AbstractType.php

Switched from parent type hard-coded FQCN to `::class` keyword.

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

ff13967545 Switched from parent type hard-coded FQCN to `::class` keyword.
2021-01-10 13:19:09 +01:00
Christian Flothmann
0028efe8f8 quote all dumped unicode spaces 2021-01-09 13:36:37 +01:00
Samuele Lilli
ff13967545 Switched from parent type hard-coded FQCN to ::class keyword. 2021-01-08 13:59:24 +01:00
Nicolas Grekas
3ee310f20a bug #39747 [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

`CheckTypeDeclarationsPass` currently explodes if it encounters one of following the new builtin types of PHP 8:

* `false` (can only appear as part of a union)
* `mixed` (we don't need to check anything)

In either case, the pass will try to call a method `is_false()`/`is_mixed()` and fail.

This PR should fix both cases.

Commits
-------

f16230be5d [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
2021-01-07 15:35:02 +01:00
Nicolas Grekas
d223a5ed40 bug #39738 [VarDumper] fix mutating $GLOBALS while cloning it (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] fix mutating $GLOBALS while cloning it

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39679
| License       | MIT
| Doc PR        | -

Also preparing for https://wiki.php.net/rfc/restrict_globals_usage

Commits
-------

384b0adf38 [VarDumper] fix mutating $GLOBALS while cloning it
2021-01-07 14:07:47 +01:00
Alexander M. Turek
f16230be5d [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass 2021-01-07 03:15:41 +01:00
Alexander M. Turek
185454367a [DependencyInjection] Fix InvalidParameterTypeException for function parameters 2021-01-07 02:09:26 +01:00
Nicolas Grekas
384b0adf38 [VarDumper] fix mutating $GLOBALS while cloning it 2021-01-06 15:16:24 +01:00
Nicolas Grekas
9b719ab13d minor #39720 make some time dependent tests more resilient (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

make some time dependent tests more resilient

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a33850e838 make some time dependent tests more resilient
2021-01-05 19:32:49 +01:00
Christian Flothmann
29d2da572e parse cookie values containing the equal sign 2021-01-05 15:30:54 +01:00
Christian Flothmann
a33850e838 make some time dependent tests more resilient 2021-01-05 10:09:27 +01:00
Fabien Potencier
e1b81d513e bug #39716 [DependencyInjection] do not break when loading schemas from network paths on Windows (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] do not break when loading schemas from network paths on Windows

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #24090
| License       | MIT
| Doc PR        |

Commits
-------

acbafe889d do not break when loading schemas from network paths on Windows
2021-01-05 07:35:25 +01:00
Fabien Potencier
1dead9a518 bug #39703 [Finder] apply the sort callback on the whole search result (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] apply the sort callback on the whole search result

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34879
| License       | MIT
| Doc PR        |

Commits
-------

126105146f apply the sort callback on the whole search result
2021-01-05 07:04:52 +01:00
Andrea Ruggiero
9e6baee9f3
Remove full head content in HTML to text converter
When extracting text from HTML part all the content between opening and closing tag should be removed
2021-01-04 22:15:57 +01:00
Christian Flothmann
acbafe889d do not break when loading schemas from network paths on Windows 2021-01-04 20:26:31 +01:00
Nicolas Grekas
426bf9640a minor #39691 [DomCrawler] fix tests to run assertions on returned Crawler instances (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[DomCrawler] fix tests to run assertions on returned Crawler instances

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

1d0c91629a fix tests to run assertions on returned Crawler instances
2021-01-04 18:30:04 +01:00
Nicolas Grekas
e8d5d29c30 bug #39708 [WebProfilerBundle] take query and request parameters into account when matching routes (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] take query and request parameters into account when matching routes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #25206
| License       | MIT
| Doc PR        |

Commits
-------

28b6051f53 take query and request parameters into account when matching routes
2021-01-04 18:14:21 +01:00
Nicolas Grekas
c9ae215e9f minor #39707 [Validator] mistake (gbere)
This PR was merged into the 4.4 branch.

Discussion
----------

[Validator] mistake

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT

Commits
-------

caa59fae81 mistake
2021-01-04 18:13:08 +01:00
Nicolas Grekas
bb5d52c42d minor #39710 fix code style (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

fix code style

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

89fedfa9e9 fix code style
2021-01-04 18:09:16 +01:00
Nicolas Grekas
09e51d6b42 Cleanup CI scripts 2021-01-04 17:51:14 +01:00
Christian Flothmann
89fedfa9e9 fix code style 2021-01-04 16:15:05 +01:00
Christian Flothmann
689e3039fc fix code style 2021-01-04 15:27:21 +01:00
Christian Flothmann
126105146f apply the sort callback on the whole search result 2021-01-04 15:07:41 +01:00
Christian Flothmann
28b6051f53 take query and request parameters into account when matching routes 2021-01-04 14:59:34 +01:00
Gerard Berengué
caa59fae81
mistake 2021-01-04 14:29:17 +01:00
Fabien Potencier
0304f754b3 minor #39705 [ProxyManager] fix tests (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[ProxyManager] fix tests

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

5ec2a252ee [ProxyManager] fix tests
2021-01-04 13:05:33 +01:00
Fabien Potencier
135a9b20af minor #39704 [Finder] actually compare the order of entries when any sorting is applied (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Finder] actually compare the order of entries when any sorting is applied

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Without this change the tests where still passing if the sorting didn't work as expected. There are three more tests that sort by file times. I do not really know how to make them more stable though.

Commits
-------

f1ed653eee actually compare the order of entries when any sorting is applied
2021-01-04 13:04:05 +01:00
Christian Flothmann
28a956baa9 harden test to not depend on the actual time 2021-01-04 12:47:44 +01:00
Nicolas Grekas
5ec2a252ee [ProxyManager] fix tests 2021-01-04 12:30:20 +01:00
Christian Flothmann
f1ed653eee actually compare the order of entries when any sorting is applied 2021-01-04 12:28:59 +01:00
Alexander M. Turek
04671ee726 minor #39694 [PropertyAccess] remove unneeded sprintf() call (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[PropertyAccess] remove unneeded sprintf() call

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

a8252a43b8 remove unneeded sprintf() call
2021-01-03 13:23:32 +01:00
Christian Flothmann
a8252a43b8 remove unneeded sprintf() call 2021-01-03 12:55:43 +01:00
Christian Flothmann
1d0c91629a fix tests to run assertions on returned Crawler instances 2021-01-03 11:13:13 +01:00
Fabien Potencier
a902dd8a1b bug #39683 [Yaml] keep trailing newlines when dumping multi-line strings (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] keep trailing newlines when dumping multi-line strings

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix https://github.com/symfony/symfony/pull/39668#issuecomment-753484545
| License       | MIT
| Doc PR        |

Commits
-------

4c513c24c7 keep trailing newlines when dumping multi-line strings
2021-01-03 09:28:04 +01:00
Fabien Potencier
da07550827 bug #39670 [Form] disable error bubbling by default when inherit_data is configured (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] disable error bubbling by default when inherit_data is configured

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #14441
| License       | MIT
| Doc PR        |

Commits
-------

8679c2ac05 disable error bubbling by default when inherit_data is configured
2021-01-03 09:24:31 +01:00
Fabien Potencier
4bced61887 Fix CS 2021-01-03 09:19:04 +01:00
Fabien Potencier
a0d66d2ecd bug #39686 [Lock] Fix config merging in lock (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[Lock] Fix config merging in lock

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35920
| License       | MIT
| Doc PR        | -

Commits
-------

6bb2d67cf1 Fix config merging in lock
2021-01-03 09:18:23 +01:00
Jérémy Derussé
6bb2d67cf1
Fix config merging in lock 2021-01-02 23:18:12 +01:00
Christian Flothmann
4c513c24c7 keep trailing newlines when dumping multi-line strings 2021-01-02 17:02:59 +01:00
Fabien Potencier
04c67e61e2 bug #39668 [Yaml] do not dump extra trailing newlines for multiline blocks (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] do not dump extra trailing newlines for multiline blocks

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38310
| License       | MIT
| Doc PR        |

Commits
-------

5fa9592d5e do not dump extra trailing newlines for multiline blocks
2021-01-01 10:44:44 +01:00
Fabien Potencier
2c4337ae5b Bump license year 2021-01-01 10:24:35 +01:00
Christian Flothmann
8679c2ac05 disable error bubbling by default when inherit_data is configured 2020-12-31 15:25:34 +01:00
Christian Flothmann
5fa9592d5e do not dump extra trailing newlines for multiline blocks 2020-12-31 11:51:02 +01:00
Nicolas Grekas
52360c1e4e [Form] fix passing null $pattern to IntlDateFormatter 2020-12-29 14:49:19 +01:00