This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12437).
Discussion
----------
[2.6] [Validator] make DateTime objects represented as strings in the violation message
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
Commits
-------
b753218 [Validator] make DateTime objects represented as strings in the violation message.
This PR was merged into the 2.6 branch.
Discussion
----------
[Security][Http] fix data type in docblock
| Q | A
| ------------- | ---
| Fixed tickets | #12564
| License | MIT
Commits
-------
1c6f5a1 fix data type in docblock
This PR was squashed before being merged into the 2.6 branch (closes#12584).
Discussion
----------
[RFC] [DebugBundle] [HttpKernel] Avoid using container as dependency for DumpListener
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Usage of the `container` service as dependency avoid using the listener outside of a Symfony project.
I don't know if the lazy loading of the dumper service is really required. We should only use the `DebugBundle` in `dev` environment.
If it break performance, maybe we can consider using the `lazy="true"` parameter in services definition.
I currently working on a Silex [`DebugServiceProvider`](https://github.com/jeromemacias/Silex-Debug) which use the `DebugBundle` to avoid duplicating the dump profiler view (like it's done by the `WebProfilerServiceProvider`).
Those modifications are required by the provider to be usable.
Commits
-------
680fe7a [RFC] [DebugBundle] [HttpKernel] Avoid using container as dependency for DumpListener
This PR was merged into the 2.6 branch.
Discussion
----------
[WebProfilerBundle] Remove usage of app.request in search bar template
This PR removes the last usage of the global Twig variable `app.request` in Symfony.
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
d3451fc [WebProfilerBundle] Remove usage of app.request in search bar template
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12570).
Discussion
----------
Fix initialized() with aliased services
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12569
| License | MIT
| Doc PR |
Commits
-------
a18b6d1 Fix initialized() with aliased services
It is already checked in the `isEnabled()` method of the parent
`ServerCommand` class if the current PHP build is HHVM and the
`server:start` command is never enabled then. Thus, it's not needed
to check for HHVM on every command execution.
This was pointed out by @stof in #12489 for the `server:run` command.
It is already checked in the `isEnabled()` method if the current PHP
build is HHVM and the `server:run` command is never enabled then.
Thus, it's not needed to check for HHVM on every command execution.
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12439).
Discussion
----------
Remove block submit_widget
submit_widget parent block already renders button_widget_block. btn is already added by button_widget_block. I propose to remove this block as it adds btn twice and has no other use.
Commits
-------
9a08b77 Remove block submit_widget
* 2.5:
reformat code as suggested by @fabpot
Fix typo
Make `\Request::get` more performant.
[Form][WebProfiler] Empty form names fix
[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
bumped Symfony version to 2.5.8
updated VERSION for 2.5.7
update CONTRIBUTORS for 2.5.7
updated CHANGELOG for 2.5.7
bumped Symfony version to 2.3.23
fixed typo
updated VERSION for 2.3.22
update CONTRIBUTORS for 2.3.22
updated CHANGELOG for 2.3.22
Conflicts:
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig
src/Symfony/Component/HttpKernel/Kernel.php
* 2.3:
reformat code as suggested by @fabpot
Fix typo
Make `\Request::get` more performant.
[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
bumped Symfony version to 2.3.23
fixed typo
updated VERSION for 2.3.22
update CONTRIBUTORS for 2.3.22
updated CHANGELOG for 2.3.22
Conflicts:
src/Symfony/Component/HttpKernel/Kernel.php
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#12537).
Discussion
----------
[HttpFoundation] Make Request::get() more performant
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This finishes the work started by @KorvinSzanto in #12369.
Commits
-------
3039935 reformat code as suggested by @fabpot
ad64223 Fix typo
4162713 Make `\Request::get` more performant.
This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] be smarter when guessing the document root
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12524
| License | MIT
| Doc PR |
Commits
-------
83d768d be smarter when guessing the document root
This PR was merged into the 2.6 branch.
Discussion
----------
[TwigBundle] properly set request attributes in controller test
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
b3db574 properly set request attributes in controller test
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12267).
Discussion
----------
[Form][WebProfiler] Empty form names fix
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
When a Form had no name, the markup was broken in the profiler, making the form tree ugly. This pull request changes the output so that `(no name)` string is displayed when no form name was available.
Before:
![screenshot 2014-10-21 00 06 23](https://cloud.githubusercontent.com/assets/345754/4706329/d596a3ec-5883-11e4-8c67-44a7f357f3e1.png)
After:
![screenshot 2014-10-21 00 08 02](https://cloud.githubusercontent.com/assets/345754/4706359/122674c2-5884-11e4-8237-0177a590f2a0.png)
Commits
-------
6e9642a [Form][WebProfiler] Empty form names fix
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12268).
Discussion
----------
[DX] [Form] [WebProfiler] Added abbrs with type classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
This adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?
Looks like this:
![screenshot 2014-10-21 00 22 09](https://cloud.githubusercontent.com/assets/345754/4706604/32cf2d7a-5886-11e4-9fae-b9bff7a419ac.png)
Commits
-------
0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12147).
Discussion
----------
[TwigBundle] Fix error page preview for custom twig.exception_controller
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12147
| License | MIT
| Doc PR | n/a
The `testErrorPageAction()` always used the `showAction()` of TwigBundle's `ExceptionController`.
You can, however, configure an alternate controller by setting `twig.exception_controller`.
Thus, in order to get a proper preview, we need to forward to this configured controller (which
may be the default one).
This requires us to pass an additional parameter to `ExceptionController::showAction` to be able to
get the *error* page even if configured otherwise in the constructor.
(The other approach would have been to fiddle around with `ExceptionController`'s `debug` flag through a setter when going through the preview action, but that would have been even more messy.)
Commits
-------
2065e00 [TwigBundle] Fix error page preview for custom twig.exception_controller
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#12137).
Discussion
----------
[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12110
| License | MIT
Test and fix of ticket #12110
Commits
-------
76273bf [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data