This PR was merged into the 2.2 branch.
Discussion
----------
[Finder] Fixed a path in a test
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Test case was introduced in 45b68e02bd.
It's probably better to be explicit rather than to rely on a path position in the array. Position in 2.1 was different than in the other branches.
Commits
-------
127f3bd [Finder] Fixed a path in a test.
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] renamed ConsoleForExceptionEvent into ConsoleExceptionEvent
I wondered about the name and now I figured the problem was already raised in the PR: https://github.com/symfony/symfony/pull/7466#discussion-diff-3503539
So I think it should be fixed for LTS.
BC break: yes
test pass: yes
Commits
-------
554ab9f [Console] renamed ConsoleForExceptionEvent into ConsoleExceptionEvent
* 2.2:
Fix several instances of doubled words
[Finder] Fix iteration fails with non-rewindable streams
[Finder] Fix unexpected duplicate sub path related AppendIterator issue
Added type of return value in VoterInterface.
Fixed two bugs in HttpCache
Conflicts:
src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php
* 2.1:
Fix several instances of doubled words
[Finder] Fix iteration fails with non-rewindable streams
[Finder] Fix unexpected duplicate sub path related AppendIterator issue
Added type of return value in VoterInterface.
Fixed two bugs in HttpCache
Conflicts:
src/Symfony/Component/Finder/Tests/FinderTest.php
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][FrameworkBundle] removed HttpFoundation classes from HttpKernel cache
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | [#8126]
| License | MIT
Since #7322, class redeclaration errors will occur in non-debug mode when using HttpCache, because the map isn't adaptative, and HttpCache might need HttpFoundation classes even before booting the Kernel. I suggest moving them to the bootstrap instead.
Commits
-------
c8e5503 [FrameworkBundle] removed HttpFoundation classes from HttpKernel cache
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Validator] Added missing slovak translations
This commit sholud be also merged to master.
Commits
-------
af2cd98 Added missing slovak translations
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] Fixed the check if an interface exists.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
re #8136
Commits
-------
fd151fd [Security] Fixed the check if an interface exists.
This PR was merged into the 2.1 branch.
Discussion
----------
Fix several instances of doubled words
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
One correction to an exception; the rest in docblocks.
Commits
-------
52fed7b Fix several instances of doubled words
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Add namespace support back in to list command
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | Couldn't spot this issue in the list
| License | MIT
| Doc PR | NA
Added a test to prevent this happening again.
Commits
-------
79a842a [Console] Add namespace support back in to list command
This PR was squashed before being merged into the 2.1 branch (closes
Discussion
----------
[Finder] Fix iteration fails with non-rewindable streams
<table>
<tr>
<th>Q</th><th>A</th>
</tr>
<tr>
<td>Bug fix?</td><td>yes</td>
</tr>
<tr>
<td>New feature?</td><td>no</td>
</tr>
<tr>
<td>BC breaks?</td><td>no</td>
</tr>
<tr>
<td>Deprecations?</td><td>no</td>
</tr>
<tr>
<td>Tests pass?</td><td>yes</td>
</tr>
<tr>
<td>Fixed tickets</td><td>#3585, #7834</td>
</tr>
<tr>
<td>License?</td><td>MIT</td>
</tr>
</table>
- [x] Add a good detection of non seekable stream
- [x] Add some unit tests
But the iteration under ftp stream still not work properly. Edit: need
tests for that.
Commits
-------
169c0b9 [Finder] Fix iteration fails with non-rewindable streams
This PR was squashed before being merged into the 2.1 branch (closes#8127).
Discussion
----------
[Finder] Fix unexpected duplicate sub path related AppendIterator issue
Bug fix: yes
New feature: no
BC breaks: no
Deprecations: no
Tests pass: yes
Fixes: https://github.com/symfony/symfony/pull/4993#issuecomment-8515845
Todo: -
License of the code: MIT
> @dg: I am afraid it is not working, see this example http://davidgrudl.com/tmp/appenditerator-finder.zip.
Commits
-------
45b68e0 [Finder] Fix unexpected duplicate sub path related AppendIterator issue
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] [2.3] removed old option
Looks like a leftover from @c8afa886cd7c9598e5fbda661e93210a7786739b
Commits
-------
a8f4501 [Form] [2.3] removed old option
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfiler] remove deprecated verbose option
test pass: yes
bc break: no
Commits
-------
8a4b91b [WebProfiler] remove deprecated verbose option
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] removed deprecated method from cache:clear command
bc break: no
test pass: yes
Commits
-------
024bd9e [FrameworkBundle] removed deprecated method from cache:clear command
This PR was merged into the 2.3 branch.
Discussion
----------
[ClassLoader] tiny refactoring
test pass: yes
bc break: no
Commits
-------
6394a5b [ClassLoader] tiny refactoring
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] Added tests
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
8d5f39f [Security] Added tests for the DefaultLogoutSuccessHandler.
30fe940 [Security] Added tests for the DefaultAuthenticationSuccessHandler.
12d9b0a [Security] Added tests for the DefaultAuthenticationFailureHandler.
3129bee [Security] Added tests for the remember me ReponseListener.
573bf07 [Security] Added tests for the SessionAuthenticationStrategy.
9d3397d [Security] Added tests for the AccessMap.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8040).
Discussion
----------
[Monolog] fix logger in regards to DebugLoggerInterface
Commits
-------
438f75c [Monolog] fix logger in regards to DebugLoggerInterface
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#8117).
Discussion
----------
[Security] Added type of return value in VoterInterface.
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Simple addition of the return type for the `supportsClass` method, as per the `supportsAttribute` method doc in the interface.
Commits
-------
c176d1e [Security] Added type of return value in VoterInterface.
This PR was submitted for the 2.0 branch but it was merged into the 2.1 branch instead (closes#8098).
Discussion
----------
[HttpKernel] Fixed two bugs in HttpCache
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8097
| License | MIT
| Doc PR |
1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
header
I discovered that the HttpCache::handle method calls Response::prepare
after calling Response::isModified. Response::isModified removes the
Content-Type header as it should, but Response::handle adds in the
default Content-Type header when none is set. If the default
Content-Type is not the correct Content-Type, then the Content-Type in
the cache gets clobered. I solved this problem by moving the
Response::isModified call after the Response::prepare call. I updated
the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
Content-Type header was not being sent for 304 responses.
2. Failure to invalidate cached entities referred to by the Location
header
I discovered that the Store::invalidate method was looking for Location
and Content-Location headers to invalidate, but it was looking in the
request headers instead of the response headers. Because the
Store::invalidate method doesn't take a response, I decided it was
better to move this logic to the HttpCache::invalidate method instead.
I updated the testInvalidatesCachedResponsesOnPost test to verify that
Location headers are getting invalidated correctly.
Commits
-------
a4251bd [HttpKernel] Fixed two bugs in HttpCache
1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
header
I discovered that the HttpCache::handle method calls Response::prepare
after calling Response::isModified. Response::isModified removes the
Content-Type header as it should, but Response::handle adds in the
default Content-Type header when none is set. If the default
Content-Type is not the correct Content-Type, then the Content-Type in
the cache gets clobered. I solved this problem by moving the
Response::isModified call after the Response::prepare call. I updated
the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
Content-Type header was not being sent for 304 responses.
2. Failure to invalidate cached entities referred to by the Location
header
I discovered that the Store::invalidate method was looking for Location
and Content-Location headers to invalidate, but it was looking in the
request headers instead of the response headers. Because the
Store::invalidate method doesn't take a response, I decided it was
better to move this logic to the HttpCache::invalidate method instead.
I updated the testInvalidatesCachedResponsesOnPost test to verify that
Location headers are getting invalidated correctly.
This PR was merged into the 2.3 branch.
Discussion
----------
[SecurityBundle] Added missing files for phpunit
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes and no (BC Break in RequestMatcher, symfony/http-foundation: 2.2.x)
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
11497f3 [SecurityBundle] Added missing files for phpunit
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Added Router tests and fixed an exception message
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
e61ba7d [Routing] Added Router tests and fixed an exception message.
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfilerBundle] Fixed composer.json
Commits
-------
d4f5389 [WebProfilerBundle] Fixed composer.json
Tobias Schultze
Fabien Potencier
Jakub Zalas
Stefan Oderbolz
John Bafford
Andrej Hudec
Bilal Amarni
alquerci
Rich Sage
Tim Anido
Jason Desrosiers
Martin Hasoň