Code enhancement. $bundlesDir variable doesnt't need any bundle information for initialization. So it must be placed out of the loop to not process unnecessary operations.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7857).
Discussion
----------
[HttpCache] remove validation related headers when needed
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [yes]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | [#6977]
| License | MIT
Fixes#6977 by removing validation related headers when there is at least one embedded response.
I've added an embedded response counter because the current check was wrong I think, it was checking count($this->ttls) which isn't updated for validateable responses.
And for the BC break, looking at the interface PHPDoc description, it supposes add() method should only be applied on esi responses and update() takes the master one at the end, what do you think?
Commits
-------
bb80139 [HttpCache] remove validation related headers when needed
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7886).
Discussion
----------
[HttpKernel][Profile] Fixes#7883
Commits
-------
0172fc1 [HttpKernel][Profile] use while loop for iterating
This PR was merged into the 2.1 branch.
Discussion
----------
[Filesystem] copy() is not working when open_basedir is set
More details: https://bugs.php.net/bug.php?id=64634
Commits
-------
10dea94 [Filesystem] copy() is not working when open_basedir is set
* 2.2:
Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
[Translation] fixed a unit test
Conflicts:
src/Symfony/Component/HttpFoundation/Request.php
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#7871).
Discussion
----------
Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
[HttpFoundation] fixed something
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7870
| License | MIT
| Doc PR |
Ensure that the getPort() method returns port 443 as default when
X-FORWARDED-PROTO is set to https. Currently it would return port 80
if X-FORWARDED-PROTO was set to https and X-FORWARDED-PORT was not
set by the trusted proxy.
Commits
-------
8554af3 Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
This PR was merged into the master branch.
Discussion
----------
[2.3] [Validator] added comparison constraints and validators
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
They work on a class level and you specify a list of properties. Included are the standard GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual and Equal. e.g.:
```php
<?php
/**
* @assert:GreaterThan({"diedDate", "bornDate"})
* @assert:LessThanOrEqual({"bornDate", "firstSchoolDayDate", "diedDate"})
*/
class Person
{
private $bornDate;
private $firstSchoolDayDate;
private $diedDate;
}
```
I think it would also be useful if they worked on a property level rather than just class. I'm not sure what the default option should be though. e.g. is there a reliable way to determine what's a raw value and what's a property name:
```php
<?php
/** @assert:GreaterThan(80) */
private $iq;
/** @assert:LessThan('dateDied') */
private $bornDate;
/** @assert:LessThanOrEqual('C') */
private $grade;
/** @assert:GreaterThanOrEqual({50, 'ageStartedSchool'}) */
private $age;
```
Commits
-------
0bffdff [Validator] Added comparison validators.
This PR was merged into the master branch.
Discussion
----------
[PropertyAccess] Made naming consistent with Form and Validator
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
8817e70 [PropertyAccess] Made naming consistent with Form and Validator
This PR was merged into the master branch.
Discussion
----------
[Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7873
| License | MIT
| Doc PR | -
Commits
-------
441222e [Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added
This PR was merged into the master branch.
Discussion
----------
[Process] Add unit tests for #7865
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | |no
| Tests pass? | yes when 2.1 will be merged in master
| License | MIT
This PR adds test for #7865. It's currently failing, but will pass once 2.1 will be merged in master.
Commits
-------
421c354 [Process] Add unit tests for #7865
* 2.2:
[BrowserKit] fixed BC break done recently
[Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
[Console] find command even if its name is a namespace too (closes#7860)
Rename misprint property (from warmer to finder)
Reset all catalogues when adding resource to fallback locale (#7715, #7819)
Added reloading of fallback catalogues when calling addResource() (#7715)
Re-added context information to log list
Add This field is missing RU translation
Conflicts:
src/Symfony/Component/Console/Tests/ApplicationTest.php
* 2.1:
[BrowserKit] fixed BC break done recently
[Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
Rename misprint property (from warmer to finder)
Add This field is missing RU translation
Conflicts:
src/Symfony/Component/Process/Process.php
src/Symfony/Component/Validator/Resources/translations/validators.ru.xlf
This PR was merged into the 2.1 branch.
Discussion
----------
[BrowserKit] fixed BC break done recently
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This PR tries to avoid a BC break that was introduced recently in the management of cookies (see #7738).
see fabpot/Silex#684
Commits
-------
25b8b84 [BrowserKit] fixed BC break done recently
This PR was merged into the master branch.
Discussion
----------
Fix http-kernel dep in symfony/security
The current constraint will not match 2.3.x-dev and cause edge cases
where either:
* composer falls back to symfony/symfony because it cannot find a match
* composer installs 2.2 versions of http-kernel and http-foundation
Commits
-------
01016be Fix http-kernel dep in symfony/security
This PR was merged into the 2.1 branch.
Discussion
----------
[Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5594
| License | MIT
When a process is signaled, an exception is thrown saying `The process has been signaled with signal "0".`. This is wrong because "0" is not a signal.
This is actually a bug in `Process` because we retrieve the `stopsig` property of the process status whereas we should retrieve the `termsig`.
`stopsig` should be retrieved in case the process has been stopped, and `termsig` when it has been signaled, see [PHP documentation](http://www.php.net/manual/en/function.proc-get-status.php).
Commits
-------
8757ad4 [Process] Fix#5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
This PR was merged into the master branch.
Discussion
----------
Added missing information to the UPGRADE-3.0 file and sorted its sections
Commits
-------
7e7e4c0 Added missing information to the UPGRADE-3.0 file and sorted its sections
This PR was merged into the master branch.
Discussion
----------
Place hasArgument() check at the beginning of getArgument() method
If input definition doesn't have specified argument, then unnecessary operations will be executed ($arguments = is_int($name) ? array_values($this->arguments) : $this->arguments;)
Commits
-------
992c218 Place hasArgument() check at the beginning of getArgument() method
This PR was merged into the master branch.
Discussion
----------
[Validator] Rename issn constraint message option.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Rename issn constraint message option to be consistent with all constraints having a single message option as suggested by @stof at a4abfb9550 (L0R23)
Commits
-------
57c724a [Validator] Rename issn constraint message option to be consistent with all constraints having a single message option
The current constraint will not match 2.3.x-dev and cause edge cases
where either:
* composer falls back to symfony/symfony because it cannot find a match
* composer installs 2.2 versions of http-kernel and http-foundation
This PR was merged into the 2.2 branch.
Discussion
----------
[Console] is not ambiguous anymore if it has a perfect match command name (closes#7860)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes, locally
| Fixed tickets | #7860
| License | MIT
| Doc PR | no
Commits
-------
be34917 [Console] find command even if its name is a namespace too (closes#7860)
If input definition doesn't have specified argument, then unnecessary operations will be executed ($arguments = is_int($name) ? array_values($this->arguments) : $this->arguments;)