This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
`CheckTypeDeclarationsPass` currently explodes if it encounters one of following the new builtin types of PHP 8:
* `false` (can only appear as part of a union)
* `mixed` (we don't need to check anything)
In either case, the pass will try to call a method `is_false()`/`is_mixed()` and fail.
This PR should fix both cases.
Commits
-------
f16230be5d [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
This PR was submitted for the 5.x branch but it was merged into the 5.1 branch instead.
Discussion
----------
[FrameworkBundle] Rename parameter of magic method configureContainer
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
Default application Kernel has `configureContainer` method defined with `$container` as first parameter. PhpStorm inspection said:
```
Parameter's name changed during inheritance
Parameter's name changed from 'c' to 'container'
```
Commits
-------
e4598c2b4f Rename parameter of @method configureContainer
Default application Kernel has `configureContainer` method defined with `$container` as first parameter. PhpStorm inspection said:
```
Parameter's name changed during inheritance
Parameter's name changed from 'c' to 'container'
```
This PR was merged into the 4.4 branch.
Discussion
----------
[VarDumper] fix mutating $GLOBALS while cloning it
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39679
| License | MIT
| Doc PR | -
Also preparing for https://wiki.php.net/rfc/restrict_globals_usage
Commits
-------
384b0adf38 [VarDumper] fix mutating $GLOBALS while cloning it
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Fix InvalidParameterTypeException for function parameters
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39737
| License | MIT
| Doc PR | N/A
Commits
-------
185454367a [DependencyInjection] Fix InvalidParameterTypeException for function parameters
This PR was merged into the 5.3-dev branch.
Discussion
----------
[Notifier] Add missing space in changelog (5.3)
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
Add missing space
Commits
-------
3f1989d97b [Notifier] Add missing space in changelog (5.3)
This PR was merged into the 4.4 branch.
Discussion
----------
Fix CI: Use full path to binaries in dockerized steps
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
~4 hours ago Github automatically adds the `PATH` env variable into docker steps.
Which is an issue for the openldap, because the image stores the binaries in a vendor-prefixed folder.
This PR use full path to binaries instead of relying on PATH
Commits
-------
9a3fc5a967 Fix bitnami env PATH
This PR was merged into the 5.2 branch.
Discussion
----------
[Serializer] Drop extra space
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
This extra space prevents phpab to prepare a static autoloader due to a parse error:
```
$ phpab src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
phpab %development% - Copyright (C) 2009 - 2021 by Arne Blankerts and Contributors
Scanning file src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
Could not process file '/home/taffit/Debian/symfony/src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php' due to parse errors: Parse error while trying to process class definition (unexpected token "T_DOUBLE_ARROW" in name).
```
Commits
-------
ff05e84553 [Serializer] Drop extra space
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[Notifier] [DX] Dsn::getRequiredOption()
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
### Todo
* [x] use the new method in all available bridges and bump composer.json files to `notifer:5.3`
* [x] add tests
This will lead to a much cleaner "communication" between the factory and the transport which option is required and which is optional. This method will also reduce the code duplication in the bridges.
IMHO we should add more of those convenient "helpers" to lower the burden for new bridges.
Commits
-------
3f095bf419 [Notifier] [DX] Dsn::getRequiredOption()
This PR was squashed before being merged into the 5.1 branch.
Discussion
----------
[Notifier] Add tests for SlackOptions
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | ---
| License | MIT
| Doc PR | ---
Commits
-------
dcaee9970b [Notifier] Add tests for SlackOptions
* 5.2:
fix code style
[Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
stop using void in test files
parse cookie values containing the equal sign
make some time dependent tests more resilient
fix code style
Remove full head content in HTML to text converter
do not break when loading schemas from network paths on Windows
apply the sort callback on the whole search result
* 5.1:
parse cookie values containing the equal sign
make some time dependent tests more resilient
do not break when loading schemas from network paths on Windows
* 4.4:
parse cookie values containing the equal sign
make some time dependent tests more resilient
do not break when loading schemas from network paths on Windows
* 5.1:
[Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
stop using void in test files
This PR was merged into the 4.4 branch.
Discussion
----------
make some time dependent tests more resilient
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
a33850e838 make some time dependent tests more resilient
This PR was merged into the 5.1 branch.
Discussion
----------
stop using void in test files
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
8f9f370f07 stop using void in test files
This PR was merged into the 5.1 branch.
Discussion
----------
[Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Ref https://github.com/symfony/polyfill/issues/323
In my scenario, I'm doing `Ulid::fromString('0164129e-c96f-eb1a-f011-57cf56e0c559')`. When we reach the modified line, we already know the provided `$ulid` string is an rfc-4122 valid uuid so we don't need to call `fromString` (I guess) + we don't care of the version, we just want the binary content. That fixes the referenced issue in my case because the missing constant is consequently not loaded.
Commits
-------
44392cbc30 [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
This PR was merged into the 5.1 branch.
Discussion
----------
[Uid] Inline UuidV*::TYPE constants
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Ref https://github.com/symfony/polyfill/issues/323
If we hardcode those values in the polyfill, we can surely hardcode them here? In my case, I have tested that `uuid_type` actually returns `3` even if the `\UUID_TYPE_MD5` constant is undefined 🤷♂️
Commits
-------
f0fafec019 [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants